Browse Source

expand,unexpand: drop broken test, add FIXME comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Denys Vlasenko 4 years ago
parent
commit
92549250f3

+ 2 - 0
coreutils/expand.c

@@ -63,6 +63,8 @@ enum {
 	OPT_ALL         = 1 << 2,
 };
 
+//FIXME: does not work properly with input containing NULs
+
 #if ENABLE_EXPAND
 static void expand(FILE *file, unsigned tab_size, unsigned opt)
 {

+ 0 - 20
testsuite/expand/expand-works-like-GNU

@@ -1,20 +0,0 @@
-# FEATURE: CONFIG_UNEXPAND
-
-rm -f foo bar
-$ECHO -e "\ty" | expand -t 3 ../../busybox > foo
-$ECHO -e "\ty" | busybox unexpand -t 3 ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi
-rm -f foo bar
-$ECHO -e "\ty\tx" | expand -it 3 ../../busybox > foo
-$ECHO -e "\ty\tx" | busybox unexpand -it 3 ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi

+ 0 - 56
testsuite/unexpand/unexpand-works-like-GNU

@@ -1,56 +0,0 @@
-# coreutils 8.25 often says "input line is too long"
-# on ELF executables. In this case, do not run the test:
-unexpand ../../busybox >/dev/null || exit 0
-
-rm -f foo bar
-echo "       y" | unexpand ../../busybox > foo
-echo "       y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi
-rm -f foo bar
-echo "        y" | unexpand ../../busybox > foo
-echo "        y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi
-echo "       y       y" | unexpand ../../busybox > foo
-echo "       y       y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi
-rm -f foo bar
-echo "        y        y" | unexpand ../../busybox > foo
-echo "        y        y" | busybox unexpand ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi
-echo "       y       y" | unexpand -a ../../busybox > foo
-echo "       y       y" | busybox unexpand -a ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi
-rm -f foo bar
-echo "        y        y" | unexpand -a ../../busybox > foo
-echo "        y        y" | busybox unexpand -a ../../busybox > bar
-set +e
-test ! -f foo -a -f bar
-if [ $? = 0 ] ; then
-	set -e
-	diff -q foo bar
-fi