3
0

ifenslave.c 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617
  1. /* Mode: C;
  2. *
  3. * Mini ifenslave implementation for busybox
  4. * Copyright (C) 2005 by Marc Leeman <marc.leeman@barco.com>
  5. *
  6. * ifenslave.c: Configure network interfaces for parallel routing.
  7. *
  8. * This program controls the Linux implementation of running multiple
  9. * network interfaces in parallel.
  10. *
  11. * Author: Donald Becker <becker@cesdis.gsfc.nasa.gov>
  12. * Copyright 1994-1996 Donald Becker
  13. *
  14. * This program is free software; you can redistribute it
  15. * and/or modify it under the terms of the GNU General Public
  16. * License as published by the Free Software Foundation.
  17. *
  18. * The author may be reached as becker@CESDIS.gsfc.nasa.gov, or C/O
  19. * Center of Excellence in Space Data and Information Sciences
  20. * Code 930.5, Goddard Space Flight Center, Greenbelt MD 20771
  21. *
  22. * Changes :
  23. * - 2000/10/02 Willy Tarreau <willy at meta-x.org> :
  24. * - few fixes. Master's MAC address is now correctly taken from
  25. * the first device when not previously set ;
  26. * - detach support : call BOND_RELEASE to detach an enslaved interface.
  27. * - give a mini-howto from command-line help : # ifenslave -h
  28. *
  29. * - 2001/02/16 Chad N. Tindel <ctindel at ieee dot org> :
  30. * - Master is now brought down before setting the MAC address. In
  31. * the 2.4 kernel you can't change the MAC address while the device is
  32. * up because you get EBUSY.
  33. *
  34. * - 2001/09/13 Takao Indoh <indou dot takao at jp dot fujitsu dot com>
  35. * - Added the ability to change the active interface on a mode 1 bond
  36. * at runtime.
  37. *
  38. * - 2001/10/23 Chad N. Tindel <ctindel at ieee dot org> :
  39. * - No longer set the MAC address of the master. The bond device will
  40. * take care of this itself
  41. * - Try the SIOC*** versions of the bonding ioctls before using the
  42. * old versions
  43. * - 2002/02/18 Erik Habbinga <erik_habbinga @ hp dot com> :
  44. * - ifr2.ifr_flags was not initialized in the hwaddr_notset case,
  45. * SIOCGIFFLAGS now called before hwaddr_notset test
  46. *
  47. * - 2002/10/31 Tony Cureington <tony.cureington * hp_com> :
  48. * - If the master does not have a hardware address when the first slave
  49. * is enslaved, the master is assigned the hardware address of that
  50. * slave - there is a comment in bonding.c stating "ifenslave takes
  51. * care of this now." This corrects the problem of slaves having
  52. * different hardware addresses in active-backup mode when
  53. * multiple interfaces are specified on a single ifenslave command
  54. * (ifenslave bond0 eth0 eth1).
  55. *
  56. * - 2003/03/18 - Tsippy Mendelson <tsippy.mendelson at intel dot com> and
  57. * Shmulik Hen <shmulik.hen at intel dot com>
  58. * - Moved setting the slave's mac address and openning it, from
  59. * the application to the driver. This enables support of modes
  60. * that need to use the unique mac address of each slave.
  61. * The driver also takes care of closing the slave and restoring its
  62. * original mac address upon release.
  63. * In addition, block possibility of enslaving before the master is up.
  64. * This prevents putting the system in an undefined state.
  65. *
  66. * - 2003/05/01 - Amir Noam <amir.noam at intel dot com>
  67. * - Added ABI version control to restore compatibility between
  68. * new/old ifenslave and new/old bonding.
  69. * - Prevent adding an adapter that is already a slave.
  70. * Fixes the problem of stalling the transmission and leaving
  71. * the slave in a down state.
  72. *
  73. * - 2003/05/01 - Shmulik Hen <shmulik.hen at intel dot com>
  74. * - Prevent enslaving if the bond device is down.
  75. * Fixes the problem of leaving the system in unstable state and
  76. * halting when trying to remove the module.
  77. * - Close socket on all abnormal exists.
  78. * - Add versioning scheme that follows that of the bonding driver.
  79. * current version is 1.0.0 as a base line.
  80. *
  81. * - 2003/05/22 - Jay Vosburgh <fubar at us dot ibm dot com>
  82. * - ifenslave -c was broken; it's now fixed
  83. * - Fixed problem with routes vanishing from master during enslave
  84. * processing.
  85. *
  86. * - 2003/05/27 - Amir Noam <amir.noam at intel dot com>
  87. * - Fix backward compatibility issues:
  88. * For drivers not using ABI versions, slave was set down while
  89. * it should be left up before enslaving.
  90. * Also, master was not set down and the default set_mac_address()
  91. * would fail and generate an error message in the system log.
  92. * - For opt_c: slave should not be set to the master's setting
  93. * while it is running. It was already set during enslave. To
  94. * simplify things, it is now handeled separately.
  95. *
  96. * - 2003/12/01 - Shmulik Hen <shmulik.hen at intel dot com>
  97. * - Code cleanup and style changes
  98. * set version to 1.1.0
  99. */
  100. //usage:#define ifenslave_trivial_usage
  101. //usage: "[-cdf] MASTER_IFACE SLAVE_IFACE..."
  102. //usage:#define ifenslave_full_usage "\n\n"
  103. //usage: "Configure network interfaces for parallel routing\n"
  104. //usage: "\n -c,--change-active Change active slave"
  105. //usage: "\n -d,--detach Remove slave interface from bonding device"
  106. //usage: "\n -f,--force Force, even if interface is not Ethernet"
  107. /* //usage: "\n -r,--receive-slave Create a receive-only slave" */
  108. //usage:
  109. //usage:#define ifenslave_example_usage
  110. //usage: "To create a bond device, simply follow these three steps:\n"
  111. //usage: "- ensure that the required drivers are properly loaded:\n"
  112. //usage: " # modprobe bonding ; modprobe <3c59x|eepro100|pcnet32|tulip|...>\n"
  113. //usage: "- assign an IP address to the bond device:\n"
  114. //usage: " # ifconfig bond0 <addr> netmask <mask> broadcast <bcast>\n"
  115. //usage: "- attach all the interfaces you need to the bond device:\n"
  116. //usage: " # ifenslave bond0 eth0 eth1 eth2\n"
  117. //usage: " If bond0 didn't have a MAC address, it will take eth0's. Then, all\n"
  118. //usage: " interfaces attached AFTER this assignment will get the same MAC addr.\n\n"
  119. //usage: " To detach a dead interface without setting the bond device down:\n"
  120. //usage: " # ifenslave -d bond0 eth1\n\n"
  121. //usage: " To set the bond device down and automatically release all the slaves:\n"
  122. //usage: " # ifconfig bond0 down\n\n"
  123. //usage: " To change active slave:\n"
  124. //usage: " # ifenslave -c bond0 eth0\n"
  125. #include "libbb.h"
  126. /* #include <net/if.h> - no. linux/if_bonding.h pulls in linux/if.h */
  127. #include <linux/if.h>
  128. //#include <net/if_arp.h> - not needed?
  129. #include <linux/if_bonding.h>
  130. #include <linux/sockios.h>
  131. #include "fix_u32.h" /* hack, so we may include kernel's ethtool.h */
  132. #include <linux/ethtool.h>
  133. #ifndef BOND_ABI_VERSION
  134. # define BOND_ABI_VERSION 2
  135. #endif
  136. #ifndef IFNAMSIZ
  137. # define IFNAMSIZ 16
  138. #endif
  139. struct dev_data {
  140. struct ifreq mtu, flags, hwaddr;
  141. };
  142. enum { skfd = 3 }; /* AF_INET socket for ioctl() calls. */
  143. struct globals {
  144. unsigned abi_ver; /* userland - kernel ABI version */
  145. smallint hwaddr_set; /* Master's hwaddr is set */
  146. struct dev_data master;
  147. struct dev_data slave;
  148. };
  149. #define G (*ptr_to_globals)
  150. #define abi_ver (G.abi_ver )
  151. #define hwaddr_set (G.hwaddr_set)
  152. #define master (G.master )
  153. #define slave (G.slave )
  154. #define INIT_G() do { \
  155. SET_PTR_TO_GLOBALS(xzalloc(sizeof(G))); \
  156. } while (0)
  157. /* NOINLINEs are placed where it results in smaller code (gcc 4.3.1) */
  158. static int ioctl_on_skfd(unsigned request, struct ifreq *ifr)
  159. {
  160. return ioctl(skfd, request, ifr);
  161. }
  162. static int set_ifrname_and_do_ioctl(unsigned request, struct ifreq *ifr, const char *ifname)
  163. {
  164. strncpy_IFNAMSIZ(ifr->ifr_name, ifname);
  165. return ioctl_on_skfd(request, ifr);
  166. }
  167. static int get_if_settings(char *ifname, struct dev_data *dd)
  168. {
  169. int res;
  170. res = set_ifrname_and_do_ioctl(SIOCGIFMTU, &dd->mtu, ifname);
  171. res |= set_ifrname_and_do_ioctl(SIOCGIFFLAGS, &dd->flags, ifname);
  172. res |= set_ifrname_and_do_ioctl(SIOCGIFHWADDR, &dd->hwaddr, ifname);
  173. return res;
  174. }
  175. static int get_slave_flags(char *slave_ifname)
  176. {
  177. return set_ifrname_and_do_ioctl(SIOCGIFFLAGS, &slave.flags, slave_ifname);
  178. }
  179. static int set_hwaddr(char *ifname, struct sockaddr *hwaddr)
  180. {
  181. struct ifreq ifr;
  182. memcpy(&(ifr.ifr_hwaddr), hwaddr, sizeof(*hwaddr));
  183. return set_ifrname_and_do_ioctl(SIOCSIFHWADDR, &ifr, ifname);
  184. }
  185. static int set_mtu(char *ifname, int mtu)
  186. {
  187. struct ifreq ifr;
  188. ifr.ifr_mtu = mtu;
  189. return set_ifrname_and_do_ioctl(SIOCSIFMTU, &ifr, ifname);
  190. }
  191. static int set_if_flags(char *ifname, int flags)
  192. {
  193. struct ifreq ifr;
  194. ifr.ifr_flags = flags;
  195. return set_ifrname_and_do_ioctl(SIOCSIFFLAGS, &ifr, ifname);
  196. }
  197. static int set_if_up(char *ifname, int flags)
  198. {
  199. int res = set_if_flags(ifname, flags | IFF_UP);
  200. if (res)
  201. bb_perror_msg("%s: can't up", ifname);
  202. return res;
  203. }
  204. static int set_if_down(char *ifname, int flags)
  205. {
  206. int res = set_if_flags(ifname, flags & ~IFF_UP);
  207. if (res)
  208. bb_perror_msg("%s: can't down", ifname);
  209. return res;
  210. }
  211. static int clear_if_addr(char *ifname)
  212. {
  213. struct ifreq ifr;
  214. ifr.ifr_addr.sa_family = AF_INET;
  215. memset(ifr.ifr_addr.sa_data, 0, sizeof(ifr.ifr_addr.sa_data));
  216. return set_ifrname_and_do_ioctl(SIOCSIFADDR, &ifr, ifname);
  217. }
  218. static int set_if_addr(char *master_ifname, char *slave_ifname)
  219. {
  220. #if (SIOCGIFADDR | SIOCSIFADDR \
  221. | SIOCGIFDSTADDR | SIOCSIFDSTADDR \
  222. | SIOCGIFBRDADDR | SIOCSIFBRDADDR \
  223. | SIOCGIFNETMASK | SIOCSIFNETMASK) <= 0xffff
  224. #define INT uint16_t
  225. #else
  226. #define INT int
  227. #endif
  228. static const struct {
  229. INT g_ioctl;
  230. INT s_ioctl;
  231. } ifra[] = {
  232. { SIOCGIFADDR, SIOCSIFADDR },
  233. { SIOCGIFDSTADDR, SIOCSIFDSTADDR },
  234. { SIOCGIFBRDADDR, SIOCSIFBRDADDR },
  235. { SIOCGIFNETMASK, SIOCSIFNETMASK },
  236. };
  237. struct ifreq ifr;
  238. int res;
  239. unsigned i;
  240. for (i = 0; i < ARRAY_SIZE(ifra); i++) {
  241. res = set_ifrname_and_do_ioctl(ifra[i].g_ioctl, &ifr, master_ifname);
  242. if (res < 0) {
  243. ifr.ifr_addr.sa_family = AF_INET;
  244. memset(ifr.ifr_addr.sa_data, 0,
  245. sizeof(ifr.ifr_addr.sa_data));
  246. }
  247. res = set_ifrname_and_do_ioctl(ifra[i].s_ioctl, &ifr, slave_ifname);
  248. if (res < 0)
  249. return res;
  250. }
  251. return 0;
  252. }
  253. static void change_active(char *master_ifname, char *slave_ifname)
  254. {
  255. struct ifreq ifr;
  256. if (!(slave.flags.ifr_flags & IFF_SLAVE)) {
  257. bb_error_msg_and_die("%s is not a slave", slave_ifname);
  258. }
  259. strncpy_IFNAMSIZ(ifr.ifr_slave, slave_ifname);
  260. if (set_ifrname_and_do_ioctl(SIOCBONDCHANGEACTIVE, &ifr, master_ifname)
  261. && ioctl_on_skfd(BOND_CHANGE_ACTIVE_OLD, &ifr)
  262. ) {
  263. bb_perror_msg_and_die(
  264. "master %s, slave %s: can't "
  265. "change active",
  266. master_ifname, slave_ifname);
  267. }
  268. }
  269. static NOINLINE int enslave(char *master_ifname, char *slave_ifname)
  270. {
  271. struct ifreq ifr;
  272. int res;
  273. if (slave.flags.ifr_flags & IFF_SLAVE) {
  274. bb_error_msg(
  275. "%s is already a slave",
  276. slave_ifname);
  277. return 1;
  278. }
  279. res = set_if_down(slave_ifname, slave.flags.ifr_flags);
  280. if (res)
  281. return res;
  282. if (abi_ver < 2) {
  283. /* Older bonding versions would panic if the slave has no IP
  284. * address, so get the IP setting from the master.
  285. */
  286. res = set_if_addr(master_ifname, slave_ifname);
  287. if (res) {
  288. bb_perror_msg("%s: can't set address", slave_ifname);
  289. return res;
  290. }
  291. } else {
  292. res = clear_if_addr(slave_ifname);
  293. if (res) {
  294. bb_perror_msg("%s: can't clear address", slave_ifname);
  295. return res;
  296. }
  297. }
  298. if (master.mtu.ifr_mtu != slave.mtu.ifr_mtu) {
  299. res = set_mtu(slave_ifname, master.mtu.ifr_mtu);
  300. if (res) {
  301. bb_perror_msg("%s: can't set MTU", slave_ifname);
  302. return res;
  303. }
  304. }
  305. if (hwaddr_set) {
  306. /* Master already has an hwaddr
  307. * so set it's hwaddr to the slave
  308. */
  309. if (abi_ver < 1) {
  310. /* The driver is using an old ABI, so
  311. * the application sets the slave's
  312. * hwaddr
  313. */
  314. if (set_hwaddr(slave_ifname, &(master.hwaddr.ifr_hwaddr))) {
  315. bb_perror_msg("%s: can't set hw address",
  316. slave_ifname);
  317. goto undo_mtu;
  318. }
  319. /* For old ABI the application needs to bring the
  320. * slave back up
  321. */
  322. if (set_if_up(slave_ifname, slave.flags.ifr_flags))
  323. goto undo_slave_mac;
  324. }
  325. /* The driver is using a new ABI,
  326. * so the driver takes care of setting
  327. * the slave's hwaddr and bringing
  328. * it up again
  329. */
  330. } else {
  331. /* No hwaddr for master yet, so
  332. * set the slave's hwaddr to it
  333. */
  334. if (abi_ver < 1) {
  335. /* For old ABI, the master needs to be
  336. * down before setting it's hwaddr
  337. */
  338. if (set_if_down(master_ifname, master.flags.ifr_flags))
  339. goto undo_mtu;
  340. }
  341. if (set_hwaddr(master_ifname, &(slave.hwaddr.ifr_hwaddr))) {
  342. bb_error_msg("%s: can't set hw address",
  343. master_ifname);
  344. goto undo_mtu;
  345. }
  346. if (abi_ver < 1) {
  347. /* For old ABI, bring the master
  348. * back up
  349. */
  350. if (set_if_up(master_ifname, master.flags.ifr_flags))
  351. goto undo_master_mac;
  352. }
  353. hwaddr_set = 1;
  354. }
  355. /* Do the real thing */
  356. strncpy_IFNAMSIZ(ifr.ifr_slave, slave_ifname);
  357. if (set_ifrname_and_do_ioctl(SIOCBONDENSLAVE, &ifr, master_ifname)
  358. && ioctl_on_skfd(BOND_ENSLAVE_OLD, &ifr)
  359. ) {
  360. goto undo_master_mac;
  361. }
  362. return 0;
  363. /* rollback (best effort) */
  364. undo_master_mac:
  365. set_hwaddr(master_ifname, &(master.hwaddr.ifr_hwaddr));
  366. hwaddr_set = 0;
  367. goto undo_mtu;
  368. undo_slave_mac:
  369. set_hwaddr(slave_ifname, &(slave.hwaddr.ifr_hwaddr));
  370. undo_mtu:
  371. set_mtu(slave_ifname, slave.mtu.ifr_mtu);
  372. return 1;
  373. }
  374. static int release(char *master_ifname, char *slave_ifname)
  375. {
  376. struct ifreq ifr;
  377. int res = 0;
  378. if (!(slave.flags.ifr_flags & IFF_SLAVE)) {
  379. bb_error_msg("%s is not a slave", slave_ifname);
  380. return 1;
  381. }
  382. strncpy_IFNAMSIZ(ifr.ifr_slave, slave_ifname);
  383. if (set_ifrname_and_do_ioctl(SIOCBONDRELEASE, &ifr, master_ifname) < 0
  384. && ioctl_on_skfd(BOND_RELEASE_OLD, &ifr) < 0
  385. ) {
  386. return 1;
  387. }
  388. if (abi_ver < 1) {
  389. /* The driver is using an old ABI, so we'll set the interface
  390. * down to avoid any conflicts due to same MAC/IP
  391. */
  392. res = set_if_down(slave_ifname, slave.flags.ifr_flags);
  393. }
  394. /* set to default mtu */
  395. set_mtu(slave_ifname, 1500);
  396. return res;
  397. }
  398. static NOINLINE void get_drv_info(char *master_ifname)
  399. {
  400. struct ifreq ifr;
  401. struct ethtool_drvinfo info;
  402. memset(&ifr, 0, sizeof(ifr));
  403. ifr.ifr_data = (caddr_t)&info;
  404. info.cmd = ETHTOOL_GDRVINFO;
  405. /* both fields are 32 bytes long (long enough) */
  406. strcpy(info.driver, "ifenslave");
  407. strcpy(info.fw_version, utoa(BOND_ABI_VERSION));
  408. if (set_ifrname_and_do_ioctl(SIOCETHTOOL, &ifr, master_ifname) < 0) {
  409. if (errno == EOPNOTSUPP)
  410. return;
  411. bb_perror_msg_and_die("%s: SIOCETHTOOL error", master_ifname);
  412. }
  413. abi_ver = bb_strtou(info.fw_version, NULL, 0);
  414. if (errno)
  415. bb_error_msg_and_die("%s: SIOCETHTOOL error", master_ifname);
  416. }
  417. int ifenslave_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
  418. int ifenslave_main(int argc UNUSED_PARAM, char **argv)
  419. {
  420. char *master_ifname, *slave_ifname;
  421. int rv;
  422. int res;
  423. unsigned opt;
  424. enum {
  425. OPT_c = (1 << 0),
  426. OPT_d = (1 << 1),
  427. OPT_f = (1 << 2),
  428. };
  429. #if ENABLE_LONG_OPTS
  430. static const char ifenslave_longopts[] ALIGN1 =
  431. "change-active\0" No_argument "c"
  432. "detach\0" No_argument "d"
  433. "force\0" No_argument "f"
  434. /* "all-interfaces\0" No_argument "a" */
  435. ;
  436. applet_long_options = ifenslave_longopts;
  437. #endif
  438. INIT_G();
  439. opt = getopt32(argv, "cdfa");
  440. argv += optind;
  441. if (opt & (opt-1)) /* Only one option can be given */
  442. bb_show_usage();
  443. master_ifname = *argv++;
  444. /* No interface names - show all interfaces. */
  445. if (!master_ifname) {
  446. display_interfaces(NULL);
  447. return EXIT_SUCCESS;
  448. }
  449. /* Open a basic socket */
  450. xmove_fd(xsocket(AF_INET, SOCK_DGRAM, 0), skfd);
  451. /* Exchange abi version with bonding module */
  452. get_drv_info(master_ifname);
  453. slave_ifname = *argv++;
  454. if (!slave_ifname) {
  455. if (opt & (OPT_d|OPT_c)) {
  456. /* --change or --detach, and no slaves given -
  457. * show all interfaces. */
  458. display_interfaces(slave_ifname /* == NULL */);
  459. return 2; /* why 2? */
  460. }
  461. /* A single arg means show the
  462. * configuration for this interface
  463. */
  464. display_interfaces(master_ifname);
  465. return EXIT_SUCCESS;
  466. }
  467. if (get_if_settings(master_ifname, &master)) {
  468. /* Probably a good reason not to go on */
  469. bb_perror_msg_and_die("%s: can't get settings", master_ifname);
  470. }
  471. /* Check if master is indeed a master;
  472. * if not then fail any operation
  473. */
  474. if (!(master.flags.ifr_flags & IFF_MASTER))
  475. bb_error_msg_and_die("%s is not a master", master_ifname);
  476. /* Check if master is up; if not then fail any operation */
  477. if (!(master.flags.ifr_flags & IFF_UP))
  478. bb_error_msg_and_die("%s is not up", master_ifname);
  479. #ifdef WHY_BOTHER
  480. /* Neither -c[hange] nor -d[etach] -> it's "enslave" then;
  481. * and -f[orce] is not there too. Check that it's ethernet. */
  482. if (!(opt & (OPT_d|OPT_c|OPT_f))) {
  483. /* The family '1' is ARPHRD_ETHER for ethernet. */
  484. if (master.hwaddr.ifr_hwaddr.sa_family != 1) {
  485. bb_error_msg_and_die(
  486. "%s is not ethernet-like (-f overrides)",
  487. master_ifname);
  488. }
  489. }
  490. #endif
  491. /* Accepts only one slave */
  492. if (opt & OPT_c) {
  493. /* Change active slave */
  494. if (get_slave_flags(slave_ifname)) {
  495. bb_perror_msg_and_die(
  496. "%s: can't get flags", slave_ifname);
  497. }
  498. change_active(master_ifname, slave_ifname);
  499. return EXIT_SUCCESS;
  500. }
  501. /* Accepts multiple slaves */
  502. res = 0;
  503. do {
  504. if (opt & OPT_d) {
  505. /* Detach a slave interface from the master */
  506. rv = get_slave_flags(slave_ifname);
  507. if (rv) {
  508. /* Can't work with this slave, */
  509. /* remember the error and skip it */
  510. bb_perror_msg(
  511. "skipping %s: can't get %s",
  512. slave_ifname, "flags");
  513. res = rv;
  514. continue;
  515. }
  516. rv = release(master_ifname, slave_ifname);
  517. if (rv) {
  518. bb_perror_msg("can't release %s from %s",
  519. slave_ifname, master_ifname);
  520. res = rv;
  521. }
  522. } else {
  523. /* Attach a slave interface to the master */
  524. rv = get_if_settings(slave_ifname, &slave);
  525. if (rv) {
  526. /* Can't work with this slave, */
  527. /* remember the error and skip it */
  528. bb_perror_msg(
  529. "skipping %s: can't get %s",
  530. slave_ifname, "settings");
  531. res = rv;
  532. continue;
  533. }
  534. rv = enslave(master_ifname, slave_ifname);
  535. if (rv) {
  536. bb_perror_msg("can't enslave %s to %s",
  537. slave_ifname, master_ifname);
  538. res = rv;
  539. }
  540. }
  541. } while ((slave_ifname = *argv++) != NULL);
  542. if (ENABLE_FEATURE_CLEAN_UP) {
  543. close(skfd);
  544. }
  545. return res;
  546. }