Browse Source

travis: disable the libssh build

It can't run on focal and causes warnings on bionic. Since the focal
failure started rather suddenly a while ago, we can suspect it might be
temporary.

Added "bring back the build" to the TODO document.

Fixes #7011
Closes #7012
Daniel Stenberg 3 years ago
parent
commit
f71d3e01ec
2 changed files with 24 additions and 29 deletions
  1. 19 19
      .travis.yml
  2. 5 10
      docs/TODO

+ 19 - 19
.travis.yml

@@ -63,25 +63,25 @@ jobs:
         - libssh2-1-dev
         - libbrotli-dev
         - libzstd-dev
-  - env:
-    - T=normal C="--with-openssl --with-libssh"
-    # Avoid bionic, its pre-release libssh version triggers deprecation warnings.
-    dist: focal
-    addons:
-      apt:
-        <<: *common_apt
-        packages:
-        - cmake
-        - valgrind
-        - libev-dev
-        - libc-ares-dev
-        - g++-8
-        - stunnel4
-        - libidn2-dev
-        - gnutls-bin
-        # The above list is common_packages minus impacket.
-        - libssh-dev
-        - ninja-build
+#  - env:
+#    - T=normal C="--with-openssl --with-libssh"
+#    # Avoid bionic, its pre-release libssh version triggers deprecation warnings.
+#    dist: focal
+#    addons:
+#      apt:
+#        <<: *common_apt
+#        packages:
+#        - cmake
+#        - valgrind
+#        - libev-dev
+#        - libc-ares-dev
+#        - g++-8
+#        - stunnel4
+#        - libidn2-dev
+#        - gnutls-bin
+#        # The above list is common_packages minus impacket.
+#        - libssh-dev
+#        - ninja-build
   - env:
     - T=normal C="--enable-ares --with-openssl"
     - OVERRIDE_CC="CC=gcc-8" OVERRIDE_CXX="CXX=g++-8"

+ 5 - 10
docs/TODO

@@ -181,7 +181,7 @@
  20.6 Use the RFC6265 test suite
  20.7 Support LD_PRELOAD on macOS
  20.8 Run web-platform-tests url tests
- 20.9 Use "random" ports for the test servers
+ 20.9 Bring back libssh tests on Travis
 
 ==============================================================================
 
@@ -1263,13 +1263,8 @@
 
  See https://github.com/curl/curl/issues/4477
 
-20.9 Use "random" ports for the test servers
+20.9 Bring back libssh tests on Travis
 
- Instead of insisting and using fixed port numbers for the tests (even though
- they can be changed with a switch), consider letting each server pick a
- random available one at start-up, store that info in a file and let the test
- suite use that.
-
- We could then remove the "check that it is our server that's running"-check
- and we would immediately detect when we write tests wrongly to use hard-coded
- port numbers.
+ In https://github.com/curl/curl/pull/7012 we remove the libssh builds and
+ tests from Travis CI due to them not working. This should be remedied and
+ libssh builds be brought back.