Browse Source

lua/uloop: fd_add: use absolute indices for arguments

Instead of having to adjust the index repeatedly as the stack is
manipulated, use absolute addressing for the function arguments, so they
stay the same throughout the call.  Zero functional change, just
subjectively easier to follow variables.

Signed-off-by: Karl Palsson <karlp@etactica.com>
Karl Palsson 3 years ago
parent
commit
53b9a2123f
1 changed files with 5 additions and 6 deletions
  1. 5 6
      lua/uloop.c

+ 5 - 6
lua/uloop.c

@@ -233,24 +233,23 @@ static int ul_ufd_add(lua_State *L)
 	int ref;
 	int fd_ref;
 
-	flags = luaL_checkinteger(L, -1);
+	flags = luaL_checkinteger(L, 3);
 	if (!flags) {
 		lua_pushstring(L, "flags cannot be zero");
 		lua_error(L);
 	}
-	lua_pop(L, 1);
 
-	luaL_checktype(L, -1, LUA_TFUNCTION);
+	luaL_checktype(L, 2, LUA_TFUNCTION);
 
-	fd = get_sock_fd(L, -2);
+	fd = get_sock_fd(L, 1);
 
 	lua_getglobal(L, "__uloop_cb");
-	lua_pushvalue(L, -2);
+	lua_pushvalue(L, 2);
 	ref = luaL_ref(L, -2);
 	lua_pop(L, 1);
 
 	lua_getglobal(L, "__uloop_fds");
-	lua_pushvalue(L, -3);
+	lua_pushvalue(L, 1);
 	fd_ref = luaL_ref(L, -2);
 	lua_pop(L, 1);