Browse Source

opkg: Fix -Wformat-overflow warning

A null pointer is being passed to printf. This can lead to problems.

Fixes warning:

error: '%s' directive argument is null [-Werror=format-overflow=]
   41 |    opkg_message(l, "%s: "fmt, __FUNCTION__, ##args); \
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: in expansion of macro 'opkg_msg'
   45 |  opkg_msg(l, fmt": %s.\n", ##args, strerror(errno))
      |  ^~~~~~~~
note: in expansion of macro 'opkg_perror'
  247 |   opkg_perror(ERROR, "Failed to create temporary directory '%s'",

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Rosen Penev 4 years ago
parent
commit
80d161eb5b
1 changed files with 1 additions and 2 deletions
  1. 1 2
      libopkg/opkg_install.c

+ 1 - 2
libopkg/opkg_install.c

@@ -244,8 +244,7 @@ static int unpack_pkg_control_files(pkg_t * pkg)
 
 	tmp_unpack_dir = mkdtemp(tmp_unpack_dir);
 	if (tmp_unpack_dir == NULL) {
-		opkg_perror(ERROR, "Failed to create temporary directory '%s'",
-			    tmp_unpack_dir);
+		opkg_perror(ERROR, "Failed to create temporary directory");
 		return -1;
 	}