Browse Source

uxc: fix potential NULL-pointer dereference

Check for NULL returned by strrchr() and return error in that case.
It should not be reachable as the string should always contain a '/'
character, but follow best practices anyway.

Coverity CID: 1500356 Dereference null return value
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Daniel Golle 2 years ago
parent
commit
5c5e63f89a
1 changed files with 3 additions and 0 deletions
  1. 3 0
      uxc.c

+ 3 - 0
uxc.c

@@ -1032,6 +1032,9 @@ static int uxc_set(char *name, char *path, signed char autostart, char *pidfile,
 			char *t1, *t2;
 			t1 = strdup(cfname);
 			t2 = strrchr(t1, '/');
+			if (!t2)
+				return -EINVAL;
+
 			*t2 = '\0';
 
 			if (asprintf(&t2, "%s/settings", t1) == -1)