Browse Source

cli: drop redundant uci_add_delta_path() call for -P

savedir is always present in the list of delta paths. It's guaranteed by
1. uci_alloc_context() which sets defaults
2. uci_set_savedir() which allows changing savedir

Calling uci_add_delta_path() with ctx->savedir argument seems to always
return UCI_ERR_DUPLICATE.

Fixes: 2b4872345ab2b ("make use of the history path feature in the cli")
Cc: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Rafał Miłecki 1 year ago
parent
commit
5de3871898
1 changed files with 0 additions and 1 deletions
  1. 0 1
      cli.c

+ 0 - 1
cli.c

@@ -748,7 +748,6 @@ int main(int argc, char **argv)
 				uci_add_delta_path(ctx, optarg);
 				break;
 			case 'P':
-				uci_add_delta_path(ctx, ctx->savedir);
 				uci_set_savedir(ctx, optarg);
 				flags |= CLI_FLAG_NOCOMMIT;
 				break;