Home Explore Help
Register Sign In
OWEALs
/
wolfssl
mirror of https://github.com/wolfSSL/wolfssl.git
2
0
Fork 0
Files Issues 8 Wiki
Browse Source

Fix for PQC enabled handshake

When PQC Kyber support is enabled, incoming KeyShare messages are tested
regarding the named group is a PQC Kyber group (pure or hybrid). The
boundaries of this test are way too loose (large gap between the pure
ones and the hybrid ones). This could result in failing handshakes in
case a client uses GREASE (Generate Random Extensions And Sustain
Extensibility), as there group numbers in the large gap are used.

The fix is just to make sure that the PQC test uses the two small
boundaries of the PQC named groups.

The lower bound for the hybrid groups has also been updated to reflect
the current OQS definition.

Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
Tobias Frauenschläger 1 month ago
parent
6500444b26
commit
403fcc5a4b
2 changed files with 3 additions and 2 deletions
Split View Show Diff Stats
  1. 2 1
      wolfssl/internal.h
  2. 1 1
      wolfssl/ssl.h

+ 2 - 1
wolfssl/internal.h
View File 

@@ -1850,7 +1850,8 @@ enum Misc {
 
     (MIN_FFHDE_GROUP <= (group) && (group) <= MAX_FFHDE_GROUP)
 
 #ifdef HAVE_PQC
 
 #define WOLFSSL_NAMED_GROUP_IS_PQC(group) \
 
-    (WOLFSSL_PQC_MIN <= (group) && (group) <= WOLFSSL_PQC_MAX)
 
+    ((WOLFSSL_PQC_SIMPLE_MIN <= (group) && (group) <= WOLFSSL_PQC_SIMPLE_MAX) || \
 
+     (WOLFSSL_PQC_HYBRID_MIN <= (group) && (group) <= WOLFSSL_PQC_HYBRID_MAX))
 
 #else
 
 #define WOLFSSL_NAMED_GROUP_IS_PQC(group)    ((void)(group), 0)
 
 #endif /* HAVE_PQC */

+ 1 - 1
wolfssl/ssl.h
View File 

@@ -4004,7 +4004,7 @@ enum {
 
     WOLFSSL_KYBER_LEVEL5          = 573, /* KYBER_1024 */
 
     WOLFSSL_PQC_SIMPLE_MAX        = 573,
 
 
-    WOLFSSL_PQC_HYBRID_MIN        = 12052,
 
+    WOLFSSL_PQC_HYBRID_MIN        = 12090,
 
     WOLFSSL_P256_KYBER_LEVEL1     = 12090,
 
     WOLFSSL_P384_KYBER_LEVEL3     = 12092,
 
     WOLFSSL_P521_KYBER_LEVEL5     = 12093,