Bladeren bron

Allow `==` when null checking (#24593)

fusagiko / takayamaki 1 jaar geleden
bovenliggende
commit
c1a7e38d2b
3 gewijzigde bestanden met toevoegingen van 1 en 5 verwijderingen
  1. 1 1
      .eslintrc.js
  2. 0 3
      app/javascript/mastodon/components/short_number.jsx
  3. 0 1
      app/javascript/mastodon/utils/numbers.js

+ 1 - 1
.eslintrc.js

@@ -71,7 +71,7 @@ module.exports = {
     'comma-style': ['warn', 'last'],
     'consistent-return': 'error',
     'dot-notation': 'error',
-    eqeqeq: 'error',
+    eqeqeq: ['error', 'always', { 'null': 'ignore' }],
     indent: ['warn', 2],
     'jsx-quotes': ['error', 'prefer-single'],
     'no-case-declarations': 'off',

+ 0 - 3
app/javascript/mastodon/components/short_number.jsx

@@ -32,17 +32,14 @@ function ShortNumber({ value, renderer, children }) {
   const shortNumber = toShortNumber(value);
   const [, division] = shortNumber;
 
-  // eslint-disable-next-line eqeqeq
   if (children != null && renderer != null) {
     console.warn('Both renderer prop and renderer as a child provided. This is a mistake and you really should fix that. Only renderer passed as a child will be used.');
   }
 
-  // eslint-disable-next-line eqeqeq
   const customRenderer = children != null ? children : renderer;
 
   const displayNumber = <ShortNumberCounter value={shortNumber} />;
 
-  // eslint-disable-next-line eqeqeq
   return customRenderer != null
     ? customRenderer(displayNumber, pluralReady(value, division))
     : displayNumber;

+ 0 - 1
app/javascript/mastodon/utils/numbers.js

@@ -60,7 +60,6 @@ export function toShortNumber(sourceNumber) {
  * // => 1790
  */
 export function pluralReady(sourceNumber, division) {
-  // eslint-disable-next-line eqeqeq
   if (division == null || division < DECIMAL_UNITS.HUNDRED) {
     return sourceNumber;
   }