123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202 |
- # frozen_string_literal: true
- require 'rails_helper'
- describe FetchOEmbedService, type: :service do
- subject { described_class.new }
- before do
- stub_request(:get, "https://host.test/provider.json").to_return(status: 404)
- stub_request(:get, "https://host.test/provider.xml").to_return(status: 404)
- stub_request(:get, "https://host.test/empty_provider.json").to_return(status: 200)
- end
- describe 'discover_provider' do
- context 'when status code is 200 and MIME type is text/html' do
- context 'when OEmbed endpoint contains URL as parameter' do
- before do
- stub_request(:get, 'https://www.youtube.com/watch?v=IPSbNdBmWKE').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_youtube.html'),
- )
- stub_request(:get, 'https://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DIPSbNdBmWKE').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_json_empty.html')
- )
- end
- it 'returns new OEmbed::Provider for JSON provider' do
- subject.call('https://www.youtube.com/watch?v=IPSbNdBmWKE')
- expect(subject.endpoint_url).to eq 'https://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DIPSbNdBmWKE'
- expect(subject.format).to eq :json
- end
- it 'stores URL template' do
- subject.call('https://www.youtube.com/watch?v=IPSbNdBmWKE')
- expect(Rails.cache.read('oembed_endpoint:www.youtube.com')[:endpoint]).to eq 'https://www.youtube.com/oembed?format=json&url={url}'
- end
- end
- context 'Both of JSON and XML provider are discoverable' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_json_xml.html')
- )
- end
- it 'returns new OEmbed::Provider for JSON provider if :format option is set to :json' do
- subject.call('https://host.test/oembed.html', format: :json)
- expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
- expect(subject.format).to eq :json
- end
- it 'returns new OEmbed::Provider for XML provider if :format option is set to :xml' do
- subject.call('https://host.test/oembed.html', format: :xml)
- expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
- expect(subject.format).to eq :xml
- end
- it 'does not cache OEmbed endpoint' do
- subject.call('https://host.test/oembed.html', format: :xml)
- expect(Rails.cache.exist?('oembed_endpoint:host.test')).to eq false
- end
- end
- context 'JSON provider is discoverable while XML provider is not' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_json.html')
- )
- end
- it 'returns new OEmbed::Provider for JSON provider' do
- subject.call('https://host.test/oembed.html')
- expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
- expect(subject.format).to eq :json
- end
- it 'does not cache OEmbed endpoint' do
- subject.call('https://host.test/oembed.html')
- expect(Rails.cache.exist?('oembed_endpoint:host.test')).to eq false
- end
- end
- context 'XML provider is discoverable while JSON provider is not' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_xml.html')
- )
- end
- it 'returns new OEmbed::Provider for XML provider' do
- subject.call('https://host.test/oembed.html')
- expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
- expect(subject.format).to eq :xml
- end
- it 'does not cache OEmbed endpoint' do
- subject.call('https://host.test/oembed.html')
- expect(Rails.cache.exist?('oembed_endpoint:host.test')).to eq false
- end
- end
- context 'Invalid XML provider is discoverable while JSON provider is not' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_invalid_xml.html')
- )
- end
- it 'returns nil' do
- expect(subject.call('https://host.test/oembed.html')).to be_nil
- end
- end
- context 'Neither of JSON and XML provider is discoverable' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_undiscoverable.html')
- )
- end
- it 'returns nil' do
- expect(subject.call('https://host.test/oembed.html')).to be_nil
- end
- end
- context 'Empty JSON provider is discoverable' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_json_empty.html')
- )
- end
- it 'returns new OEmbed::Provider for JSON provider' do
- subject.call('https://host.test/oembed.html')
- expect(subject.endpoint_url).to eq 'https://host.test/empty_provider.json'
- expect(subject.format).to eq :json
- end
- end
- end
- context 'when endpoint is cached' do
- before do
- stub_request(:get, 'http://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=dqwpQarrDwk').to_return(
- status: 200,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_json_empty.html')
- )
- end
- it 'returns new provider without fetching original URL first' do
- subject.call('https://www.youtube.com/watch?v=dqwpQarrDwk', cached_endpoint: { endpoint: 'http://www.youtube.com/oembed?format=json&url={url}', format: :json })
- expect(a_request(:get, 'https://www.youtube.com/watch?v=dqwpQarrDwk')).to_not have_been_made
- expect(subject.endpoint_url).to eq 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk'
- expect(subject.format).to eq :json
- expect(a_request(:get, 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk')).to have_been_made
- end
- end
- context 'when status code is not 200' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 400,
- headers: { 'Content-Type': 'text/html' },
- body: request_fixture('oembed_xml.html')
- )
- end
- it 'returns nil' do
- expect(subject.call('https://host.test/oembed.html')).to be_nil
- end
- end
- context 'when MIME type is not text/html' do
- before do
- stub_request(:get, 'https://host.test/oembed.html').to_return(
- status: 200,
- body: request_fixture('oembed_xml.html')
- )
- end
- it 'returns nil' do
- expect(subject.call('https://host.test/oembed.html')).to be_nil
- end
- end
- end
- end
|