瀏覽代碼

Adjust acceptance tests to changes in link share menu behaviour

Now the link share menu is not automatically opened after a link share
is created, so waiting until it was opened failed in iShareTheLinkFor.

Note that the steps that interact with the link share menu take care
themselves of showing the menu if needed, so there is no need to
explicitly show it despite the change. Also, the waiting in
iShareTheLinkFor was introduced when the link share menu was changed
to automatically open after creating a link share, as that caused some
issues with the steps that opened the menu by themselves (fec8d12fc5).
Due to all this, now that the link share menu is again not automatically
opened the wait can be simply removed.

Signed-off-by: Greta Doci <gretadoci@gmail.com>
Greta Doci 4 年之前
父節點
當前提交
1993984769
共有 1 個文件被更改,包括 0 次插入8 次删除
  1. 0 8
      tests/acceptance/features/bootstrap/FilesAppSharingContext.php

+ 0 - 8
tests/acceptance/features/bootstrap/FilesAppSharingContext.php

@@ -249,14 +249,6 @@ class FilesAppSharingContext implements Context, ActorAwareInterface {
 		$this->actor->find(FileListContext::shareActionForFile(FilesAppContext::currentSectionMainView(), $fileName), 10)->click();
 
 		$this->actor->find(self::shareLinkAddNewButton(), 5)->click();
-
-		// Wait until the menu was opened after the share creation to continue.
-		if (!WaitFor::elementToBeEventuallyShown(
-				$this->actor,
-				self::shareLinkMenu(),
-				$timeout = 5 * $this->actor->getFindTimeoutMultiplier())) {
-			PHPUnit_Framework_Assert::fail("The share link menu is not open yet after $timeout seconds");
-		}
 	}
 
 	/**