fix(systemtags): Add one unittest for to test tags parsing after the dependency was updated

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

apps/systemtags/src/utils.spec.ts

@@ -0,0 +1,105 @@
+/**
+ * @copyright 2023 Ferdinand Thiessen <opensource@fthiessen.de>
+ *
+ * @author Ferdinand Thiessen <opensource@fthiessen.de>
+ *
+ * @license AGPL-3.0-or-later
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+import type { DAVResultResponseProps } from 'webdav'
+import type { ServerTag, Tag } from './types.js'
+
+import { describe, it, expect } from '@jest/globals'
+import { formatTag, parseIdFromLocation, parseTags } from './utils'
+
+describe('systemtags - utils', () => {
+	describe('parseTags', () => {
+		it('renames properties', () => {
+			const tags = parseTags([{
+				props: {
+					displayname: 'display-name',
+					resourcetype: {
+						collection: false,
+					},
+					'user-visible': true,
+					'user-assignable': true,
+					'can-assign': true,
+				} as DAVResultResponseProps,
+			}])
+
+			expect(tags).toEqual([
+				{
+					displayname: 'display-name',
+					resourcetype: {
+						collection: false,
+					},
+					userVisible: true,
+					userAssignable: true,
+					canAssign: true,
+				},
+			])
+		})
+	})
+
+	describe('parseIdFromLocation', () => {
+		it('works with simple url', () => {
+			const url = 'http://some.domain/remote.php/dav/3'
+			expect(parseIdFromLocation(url)).toEqual(3)
+		})
+		it('works with trailing slash', () => {
+			const url = 'http://some.domain/remote.php/dav/3/'
+			expect(parseIdFromLocation(url)).toEqual(3)
+		})
+		it('works with query', () => {
+			const url = 'http://some.domain/remote.php/dav/3?some-value'
+			expect(parseIdFromLocation(url)).toEqual(3)
+		})
+	})
+
+	describe('formatTag', () => {
+		it('handles tags', () => {
+			const tag: Tag = {
+				canAssign: true,
+				displayName: 'DisplayName',
+				userAssignable: true,
+				userVisible: true,
+			}
+
+			expect(formatTag(tag)).toEqual({
+				canAssign: true,
+				name: 'DisplayName',
+				userAssignable: true,
+				userVisible: true,
+			})
+		})
+		it('handles server tags', () => {
+			const tag: ServerTag = {
+				canAssign: true,
+				name: 'DisplayName',
+				userAssignable: true,
+				userVisible: true,
+			}
+
+			expect(formatTag(tag)).toEqual({
+				canAssign: true,
+				name: 'DisplayName',
+				userAssignable: true,
+				userVisible: true,
+			})
+		})
+	})
+})

apps/systemtags/src/utils.ts

@@ -22,19 +22,20 @@
 
 import camelCase from 'camelcase'
 
-import type { FileStat } from 'webdav'
+import type { DAVResultResponseProps } from 'webdav'
 
 import type { ServerTag, Tag, TagWithId } from './types.js'
 
-export const parseTags = (tags: Required<FileStat>[]): TagWithId[] => {
+export const parseTags = (tags: { props: DAVResultResponseProps }[]): TagWithId[] => {
 	return tags.map(({ props }) => Object.fromEntries(
 		Object.entries(props)
-			.map(([key, value]) => [camelCase(key), value])
+			.map(([key, value]) => [camelCase(key), value]),
 	)) as TagWithId[]
 }
 
 /**
  * Parse id from `Content-Location` header
+ * @param url URL to parse
  */
 export const parseIdFromLocation = (url: string): number => {
 	const queryPos = url.indexOf('?')

dist/icons.css

@@ -19,8 +19,8 @@
   --original-icon-category-auth-white: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxnIGZpbGw9Im5vbmUiIHN0cm9rZT0iI2ZmZmZmZiI+PGNpcmNsZSBjeD0iNSIgY3k9IjEwIiByPSIzIiBzdHJva2Utd2lkdGg9IjIiIGZpbGw9IiNmZmZmZmYiLz48cGF0aCBkPSJtNy43IDcuOCA1LjgtNS44IiBzdHJva2Utd2lkdGg9IjIiIGZpbGw9IiNmZmZmZmYiLz48cGF0aCBkPSJtMTEuNSAzLjUgMi41IDIuNSIgc3Ryb2tlLXdpZHRoPSIxLjUiIGZpbGw9IiNmZmZmZmYiLz48cGF0aCBkPSJtOS4zIDUgMi41IDIuNSIgc3Ryb2tlLXdpZHRoPSIxLjUiIGZpbGw9IiNmZmZmZmYiLz48L2c+PC9zdmc+Cg==);
   --original-icon-category-customization-dark: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im0xMS4yMjYgMWMtMi4wMzYgMC4wMy0zLjggMS42NC0zLjggMy43NSAwIDIuMDMgMS42MiAzLjc1IDMuOCAzLjc1IDIuMjUgMCAzLjctMi4wNzYgMy43LTMuNjEgMC0wLjEyLTAuMTMtMC4xMS0wLjIzLTAuMDU0bC0yLjM4NCAxLjM1LTEuNjQtMC45di0xLjg3M2wyLjQ4My0xLjQzYzAuMDk3LTAuMDQ5IDAuMTk5LTAuMTIzIDAuMTQ1LTAuMjIzLTAuMzgtMC42Ni0xLjQxLTAuNzYtMi4wNzQtMC43NnptLTQuMTcgNS40LTYgNi4yMjNjLTAuMDggMC4wNzg1LTAuMDcgMC4yIDAgMC4yNzVsMi4xNjUgMi4wNGMwLjA4IDAuMDggMC4yMSAwLjA4IDAuMjggMGw1Ljk2OS02LjEzOGMwLjA5LTAuMSAwLjA2LTAuMjctMC4wNy0wLjMyLTEtMC40MS0xLjY1LTEuMTMtMi0yLjAxNS0wLjA5LTAuMjI1LTAuMjUtMC4xNjUtMC4zNDYtMC4wNjV6IiBmaWxsPSIjMDAwMDAwIi8+PC9zdmc+Cg==);
   --original-icon-category-customization-white: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im0xMS4yMjYgMWMtMi4wMzYgMC4wMy0zLjggMS42NC0zLjggMy43NSAwIDIuMDMgMS42MiAzLjc1IDMuOCAzLjc1IDIuMjUgMCAzLjctMi4wNzYgMy43LTMuNjEgMC0wLjEyLTAuMTMtMC4xMS0wLjIzLTAuMDU0bC0yLjM4NCAxLjM1LTEuNjQtMC45di0xLjg3M2wyLjQ4My0xLjQzYzAuMDk3LTAuMDQ5IDAuMTk5LTAuMTIzIDAuMTQ1LTAuMjIzLTAuMzgtMC42Ni0xLjQxLTAuNzYtMi4wNzQtMC43NnptLTQuMTcgNS40LTYgNi4yMjNjLTAuMDggMC4wNzg1LTAuMDcgMC4yIDAgMC4yNzVsMi4xNjUgMi4wNGMwLjA4IDAuMDggMC4yMSAwLjA4IDAuMjggMGw1Ljk2OS02LjEzOGMwLjA5LTAuMSAwLjA2LTAuMjctMC4wNy0wLjMyLTEtMC40MS0xLjY1LTEuMTMtMi0yLjAxNS0wLjA5LTAuMjI1LTAuMjUtMC4xNjUtMC4zNDYtMC4wNjV6IiBmaWxsPSIjZmZmZmZmIi8+PC9zdmc+Cg==);
-  --original-icon-category-dashboard-dark: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld2JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im03LjkwNjIgMWE3IDcgMCAwIDAtNi45MDYyIDcgNyA3IDAgMCAwIDcgNyA3IDcgMCAwIDAgNy03IDcgNyAwIDAgMC03LTcgNyA3IDAgMCAwLTAuMDkzNzUgMHptMC4wOTM3NSAyLjY5OTJhNC4zIDQuMyAwIDAgMSA0LjMwMDggNC4zMDA4IDQuMyA0LjMgMCAwIDEtNC4zMDA4IDQuMzAwOCA0LjMgNC4zIDAgMCAxLTQuMzAwOC00LjMwMDggNC4zIDQuMyAwIDAgMSA0LjMwMDgtNC4zMDA4eiIgc3Ryb2tlLWRhc2hvZmZzZXQ9IjEwIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiIHN0cm9rZS13aWR0aD0iLjUiIHN0eWxlPSJwYWludC1vcmRlcjptYXJrZXJzIHN0cm9rZSBmaWxsIi8+PC9zdmc+Cg==);
-  --original-icon-category-dashboard-white: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld2JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im03LjkwNjIgMWE3IDcgMCAwIDAtNi45MDYyIDcgNyA3IDAgMCAwIDcgNyA3IDcgMCAwIDAgNy03IDcgNyAwIDAgMC03LTcgNyA3IDAgMCAwLTAuMDkzNzUgMHptMC4wOTM3NSAyLjY5OTJhNC4zIDQuMyAwIDAgMSA0LjMwMDggNC4zMDA4IDQuMyA0LjMgMCAwIDEtNC4zMDA4IDQuMzAwOCA0LjMgNC4zIDAgMCAxLTQuMzAwOC00LjMwMDggNC4zIDQuMyAwIDAgMSA0LjMwMDgtNC4zMDA4eiIgc3Ryb2tlLWRhc2hvZmZzZXQ9IjEwIiBzdHJva2UtbGluZWNhcD0icm91bmQiIHN0cm9rZS1saW5lam9pbj0icm91bmQiIHN0cm9rZS13aWR0aD0iLjUiIHN0eWxlPSJwYWludC1vcmRlcjptYXJrZXJzIHN0cm9rZSBmaWxsIi8+PC9zdmc+Cg==);
+  --original-icon-category-dashboard-dark: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld2JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im03LjkwNjIgMWE3IDcgMCAwIDAtNi45MDYyIDcgNyA3IDAgMCAwIDcgNyA3IDcgMCAwIDAgNy03IDcgNyAwIDAgMC03LTcgNyA3IDAgMCAwLTAuMDkzNzUgMHptMC4wOTM3NSAyLjY5OTJhNC4zIDQuMyAwIDAgMSA0LjMwMDggNC4zMDA4IDQuMyA0LjMgMCAwIDEtNC4zMDA4IDQuMzAwOCA0LjMgNC4zIDAgMCAxLTQuMzAwOC00LjMwMDggNC4zIDQuMyAwIDAgMSA0LjMwMDgtNC4zMDA4eiIgZmlsbD0iIzAwMDAwMCIvPjwvc3ZnPgo=);
+  --original-icon-category-dashboard-white: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld2JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im03LjkwNjIgMWE3IDcgMCAwIDAtNi45MDYyIDcgNyA3IDAgMCAwIDcgNyA3IDcgMCAwIDAgNy03IDcgNyAwIDAgMC03LTcgNyA3IDAgMCAwLTAuMDkzNzUgMHptMC4wOTM3NSAyLjY5OTJhNC4zIDQuMyAwIDAgMSA0LjMwMDggNC4zMDA4IDQuMyA0LjMgMCAwIDEtNC4zMDA4IDQuMzAwOCA0LjMgNC4zIDAgMCAxLTQuMzAwOC00LjMwMDggNC4zIDQuMyAwIDAgMSA0LjMwMDgtNC4zMDA4eiIgZmlsbD0iI2ZmZmZmZiIvPjwvc3ZnPgo=);
   --original-icon-category-files-dark: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im0xLjUgMmMtMC4yNSAwLTAuNSAwLjI1LTAuNSAwLjV2MTFjMCAwLjI2IDAuMjQgMC41IDAuNSAwLjVoMTNjMC4yNiAwIDAuNS0wLjI0MSAwLjUtMC41di05YzAtMC4yNS0wLjI1LTAuNS0wLjUtMC41aC02LjVsLTItMnoiIGZpbGw9IiMwMDAwMDAiLz48L3N2Zz4K);
   --original-icon-category-files-white: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im0xLjUgMmMtMC4yNSAwLTAuNSAwLjI1LTAuNSAwLjV2MTFjMCAwLjI2IDAuMjQgMC41IDAuNSAwLjVoMTNjMC4yNiAwIDAuNS0wLjI0MSAwLjUtMC41di05YzAtMC4yNS0wLjI1LTAuNS0wLjUtMC41aC02LjVsLTItMnoiIGZpbGw9IiNmZmZmZmYiLz48L3N2Zz4K);
   --original-icon-category-games-dark: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTYiIGhlaWdodD0iMTYiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDE2IDE2IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPjxwYXRoIGQ9Im04IDFjLTEuMSAwLTIgMC45LTIgMiAwIDAuNzE0IDAuMzggMS4zNyAxIDEuNzN2NC4yN2MwIDEuMzU0IDIgMS4zNTQgMiAwdi00LjI3YzAuNi0wLjM1NyAxLTEuMDIgMS0xLjczIDAtMS4xLTAuOS0yLTItMnptLTQuNSA1LjljLTAuMjc3IDAtMC40MjQgMC4yMzQtMC41IDAuNS0wLjY1NyAxLjY4NS0xLjQgMy40My0yIDUuMXYyYzAgMC4yNzcgMC4yMjMgMC41IDAuNSAwLjVoMTNjMC4yNzcgMCAwLjUtMC4yMjMgMC41LTAuNXYtMmwtMi01LjFjLTAuMDgtMC4yNjYtMC4yMjMtMC41LTAuNS0wLjVoLTIuNXYyLjFjMC4wMzggMi43MDUtNC4wNCAyLjctNCAwdi0yLjFoLTIuNXptMC41IDMuMWMwLjgzIDAgMS41IDAuNDkgMS41IDFzLTAuNjcgMS0xLjUgMS0xLjUtMC40OS0xLjUtMSAwLjY3LTEgMS41LTF6bTggMGMwLjgzIDAgMS41IDAuNDkgMS41IDFzLTAuNjcgMS0xLjUgMS0xLjUtMC40OS0xLjUtMSAwLjY3LTEgMS41LTF6IiBmaWxsPSIjMDAwMDAwIi8+PC9zdmc+Cg==);

jest.config.ts

@@ -28,6 +28,7 @@ const ignorePatterns = [
 	'@mdi/svg',
 	'@nextcloud/vue',
 	'ansi-regex',
+	'camelcase',
 	'char-regex',
 	'hot-patcher',
 	'is-svg',