Bladeren bron

Fix tests

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Morris Jobke 5 jaren geleden
bovenliggende
commit
7c6c3d0d76

+ 5 - 1
settings/Controller/CheckSetupController.php

@@ -525,6 +525,10 @@ Raw output
 		return $this->config->getSystemValue('mail_smtpmode', 'php') === 'php';
 	}
 
+	protected function hasOpcacheLoaded(): bool {
+		return extension_loaded('opcache');
+	}
+
 	/**
 	 * @return DataResponse
 	 */
@@ -553,7 +557,7 @@ Raw output
 				'hasPassedCodeIntegrityCheck' => $this->checker->hasPassedCheck(),
 				'codeIntegrityCheckerDocumentation' => $this->urlGenerator->linkToDocs('admin-code-integrity'),
 				'isOpcacheProperlySetup' => $this->isOpcacheProperlySetup(),
-				'hasOpcacheLoaded' => extension_loaded("opcache"),
+				'hasOpcacheLoaded' => $this->hasOpcacheLoaded(),
 				'phpOpcacheDocumentation' => $this->urlGenerator->linkToDocs('admin-php-opcache'),
 				'isSettimelimitAvailable' => $this->isSettimelimitAvailable(),
 				'hasFreeTypeSupport' => $this->hasFreeTypeSupport(),

+ 6 - 0
tests/Settings/Controller/CheckSetupControllerTest.php

@@ -134,6 +134,7 @@ class CheckSetupControllerTest extends TestCase {
 				'hasMissingIndexes',
 				'isSqliteUsed',
 				'isPhpMailerUsed',
+				'hasOpcacheLoaded',
 			])->getMock();
 	}
 
@@ -395,6 +396,10 @@ class CheckSetupControllerTest extends TestCase {
 			->expects($this->once())
 			->method('hasFileinfoInstalled')
 			->willReturn(true);
+		$this->checkSetupController
+			->expects($this->once())
+			->method('hasOpcacheLoaded')
+			->willReturn(true);
 		$this->checkSetupController
 			->expects($this->once())
 			->method('hasWorkingFileLocking')
@@ -451,6 +456,7 @@ class CheckSetupControllerTest extends TestCase {
 				'hasPassedCodeIntegrityCheck' => true,
 				'codeIntegrityCheckerDocumentation' => 'http://docs.example.org/server/go.php?to=admin-code-integrity',
 				'isOpcacheProperlySetup' => false,
+				'hasOpcacheLoaded' => true,
 				'phpOpcacheDocumentation' => 'http://docs.example.org/server/go.php?to=admin-php-opcache',
 				'isSettimelimitAvailable' => true,
 				'hasFreeTypeSupport' => false,