12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567 |
- <?php
- /**
- * @author Roeland Jago Douma <rullzer@owncloud.com>
- *
- * @copyright Copyright (c) 2015, ownCloud, Inc.
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
- */
- namespace Test\Share20;
- use OC\Files\Mount\MoveableMount;
- use OC\HintException;
- use OCP\Files\File;
- use OCP\Files\Folder;
- use OCP\Files\IRootFolder;
- use OCP\Files\Mount\IMountPoint;
- use OCP\Files\Node;
- use OCP\Files\Storage;
- use OCP\IGroup;
- use OCP\IUser;
- use OCP\IUserManager;
- use OCP\Share\Exceptions\ShareNotFound;
- use OCP\Share\IProviderFactory;
- use OCP\Share\IShare;
- use OC\Share20\Manager;
- use OC\Share20\Exception;
- use OC\Share20\Share;
- use OCP\IL10N;
- use OCP\ILogger;
- use OCP\IConfig;
- use OCP\Share\IShareProvider;
- use OCP\Security\ISecureRandom;
- use OCP\Security\IHasher;
- use OCP\Files\Mount\IMountManager;
- use OCP\IGroupManager;
- use Symfony\Component\EventDispatcher\EventDispatcher;
- use Symfony\Component\EventDispatcher\GenericEvent;
- /**
- * Class ManagerTest
- *
- * @package Test\Share20
- * @group DB
- */
- class ManagerTest extends \Test\TestCase {
- /** @var Manager */
- protected $manager;
- /** @var ILogger */
- protected $logger;
- /** @var IConfig */
- protected $config;
- /** @var ISecureRandom */
- protected $secureRandom;
- /** @var IHasher */
- protected $hasher;
- /** @var IShareProvider | \PHPUnit_Framework_MockObject_MockObject */
- protected $defaultProvider;
- /** @var IMountManager */
- protected $mountManager;
- /** @var IGroupManager */
- protected $groupManager;
- /** @var IL10N */
- protected $l;
- /** @var DummyFactory */
- protected $factory;
- /** @var IUserManager */
- protected $userManager;
- /** @var IRootFolder | \PHPUnit_Framework_MockObject_MockObject */
- protected $rootFolder;
- /** @var EventDispatcher | \PHPUnit_Framework_MockObject_MockObject */
- protected $eventDispatcher;
- public function setUp() {
- $this->logger = $this->createMock(ILogger::class);
- $this->config = $this->createMock(IConfig::class);
- $this->secureRandom = $this->createMock(ISecureRandom::class);
- $this->hasher = $this->createMock(IHasher::class);
- $this->mountManager = $this->createMock(IMountManager::class);
- $this->groupManager = $this->createMock(IGroupManager::class);
- $this->userManager = $this->createMock(IUserManager::class);
- $this->rootFolder = $this->createMock(IRootFolder::class);
- $this->eventDispatcher = $this->createMock(EventDispatcher::class);
- $this->l = $this->createMock(IL10N::class);
- $this->l->method('t')
- ->will($this->returnCallback(function($text, $parameters = []) {
- return vsprintf($text, $parameters);
- }));
- $this->factory = new DummyFactory(\OC::$server);
- $this->manager = new Manager(
- $this->logger,
- $this->config,
- $this->secureRandom,
- $this->hasher,
- $this->mountManager,
- $this->groupManager,
- $this->l,
- $this->factory,
- $this->userManager,
- $this->rootFolder,
- $this->eventDispatcher
- );
- $this->defaultProvider = $this->getMockBuilder('\OC\Share20\DefaultShareProvider')
- ->disableOriginalConstructor()
- ->getMock();
- $this->defaultProvider->method('identifier')->willReturn('default');
- $this->factory->setProvider($this->defaultProvider);
- }
- /**
- * @return \PHPUnit_Framework_MockObject_MockBuilder
- */
- private function createManagerMock() {
- return $this->getMockBuilder('\OC\Share20\Manager')
- ->setConstructorArgs([
- $this->logger,
- $this->config,
- $this->secureRandom,
- $this->hasher,
- $this->mountManager,
- $this->groupManager,
- $this->l,
- $this->factory,
- $this->userManager,
- $this->rootFolder,
- $this->eventDispatcher
- ]);
- }
- /**
- * @expectedException \InvalidArgumentException
- */
- public function testDeleteNoShareId() {
- $share = $this->manager->newShare();
- $this->manager->deleteShare($share);
- }
- public function dataTestDelete() {
- $user = $this->createMock(IUser::class);
- $user->method('getUID')->willReturn('sharedWithUser');
- $group = $this->createMock(IGroup::class);
- $group->method('getGID')->willReturn('sharedWithGroup');
- return [
- [\OCP\Share::SHARE_TYPE_USER, 'sharedWithUser'],
- [\OCP\Share::SHARE_TYPE_GROUP, 'sharedWithGroup'],
- [\OCP\Share::SHARE_TYPE_LINK, ''],
- [\OCP\Share::SHARE_TYPE_REMOTE, 'foo@bar.com'],
- ];
- }
- /**
- * @dataProvider dataTestDelete
- */
- public function testDelete($shareType, $sharedWith) {
- $manager = $this->createManagerMock()
- ->setMethods(['getShareById', 'deleteChildren'])
- ->getMock();
- $path = $this->createMock(File::class);
- $path->method('getId')->willReturn(1);
- $share = $this->manager->newShare();
- $share->setId(42)
- ->setProviderId('prov')
- ->setShareType($shareType)
- ->setSharedWith($sharedWith)
- ->setSharedBy('sharedBy')
- ->setNode($path)
- ->setTarget('myTarget');
- $manager->expects($this->once())->method('deleteChildren')->with($share);
- $this->defaultProvider
- ->expects($this->once())
- ->method('delete')
- ->with($share);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['pre', 'post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'pre_unshare', $hookListner, 'pre');
- \OCP\Util::connectHook('OCP\Share', 'post_unshare', $hookListner, 'post');
- $hookListnerExpectsPre = [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => $shareType,
- 'shareWith' => $sharedWith,
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget',
- ];
- $hookListnerExpectsPost = [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => $shareType,
- 'shareWith' => $sharedWith,
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget',
- 'deletedShares' => [
- [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => $shareType,
- 'shareWith' => $sharedWith,
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget',
- ],
- ],
- ];
- $hookListner
- ->expects($this->exactly(1))
- ->method('pre')
- ->with($hookListnerExpectsPre);
- $hookListner
- ->expects($this->exactly(1))
- ->method('post')
- ->with($hookListnerExpectsPost);
- $manager->deleteShare($share);
- }
- public function testDeleteLazyShare() {
- $manager = $this->createManagerMock()
- ->setMethods(['getShareById', 'deleteChildren'])
- ->getMock();
- $share = $this->manager->newShare();
- $share->setId(42)
- ->setProviderId('prov')
- ->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('sharedWith')
- ->setSharedBy('sharedBy')
- ->setShareOwner('shareOwner')
- ->setTarget('myTarget')
- ->setNodeId(1)
- ->setNodeType('file');
- $this->rootFolder->expects($this->never())->method($this->anything());
- $manager->expects($this->once())->method('deleteChildren')->with($share);
- $this->defaultProvider
- ->expects($this->once())
- ->method('delete')
- ->with($share);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['pre', 'post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'pre_unshare', $hookListner, 'pre');
- \OCP\Util::connectHook('OCP\Share', 'post_unshare', $hookListner, 'post');
- $hookListnerExpectsPre = [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'sharedWith',
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget',
- ];
- $hookListnerExpectsPost = [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'sharedWith',
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget',
- 'deletedShares' => [
- [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'sharedWith',
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget',
- ],
- ],
- ];
- $hookListner
- ->expects($this->exactly(1))
- ->method('pre')
- ->with($hookListnerExpectsPre);
- $hookListner
- ->expects($this->exactly(1))
- ->method('post')
- ->with($hookListnerExpectsPost);
- $manager->deleteShare($share);
- }
- public function testDeleteNested() {
- $manager = $this->createManagerMock()
- ->setMethods(['getShareById'])
- ->getMock();
- $path = $this->createMock(File::class);
- $path->method('getId')->willReturn(1);
- $share1 = $this->manager->newShare();
- $share1->setId(42)
- ->setProviderId('prov')
- ->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('sharedWith1')
- ->setSharedBy('sharedBy1')
- ->setNode($path)
- ->setTarget('myTarget1');
- $share2 = $this->manager->newShare();
- $share2->setId(43)
- ->setProviderId('prov')
- ->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setSharedWith('sharedWith2')
- ->setSharedBy('sharedBy2')
- ->setNode($path)
- ->setTarget('myTarget2')
- ->setParent(42);
- $share3 = $this->manager->newShare();
- $share3->setId(44)
- ->setProviderId('prov')
- ->setShareType(\OCP\Share::SHARE_TYPE_LINK)
- ->setSharedBy('sharedBy3')
- ->setNode($path)
- ->setTarget('myTarget3')
- ->setParent(43);
- $this->defaultProvider
- ->method('getChildren')
- ->will($this->returnValueMap([
- [$share1, [$share2]],
- [$share2, [$share3]],
- [$share3, []],
- ]));
- $this->defaultProvider
- ->method('delete')
- ->withConsecutive($share3, $share2, $share1);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['pre', 'post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'pre_unshare', $hookListner, 'pre');
- \OCP\Util::connectHook('OCP\Share', 'post_unshare', $hookListner, 'post');
- $hookListnerExpectsPre = [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'sharedWith1',
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy1',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget1',
- ];
- $hookListnerExpectsPost = [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'sharedWith1',
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy1',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget1',
- 'deletedShares' => [
- [
- 'id' => 44,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_LINK,
- 'shareWith' => '',
- 'itemparent' => 43,
- 'uidOwner' => 'sharedBy3',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget3',
- ],
- [
- 'id' => 43,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_GROUP,
- 'shareWith' => 'sharedWith2',
- 'itemparent' => 42,
- 'uidOwner' => 'sharedBy2',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget2',
- ],
- [
- 'id' => 42,
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'sharedWith1',
- 'itemparent' => null,
- 'uidOwner' => 'sharedBy1',
- 'fileSource' => 1,
- 'fileTarget' => 'myTarget1',
- ],
- ],
- ];
- $hookListner
- ->expects($this->exactly(1))
- ->method('pre')
- ->with($hookListnerExpectsPre);
- $hookListner
- ->expects($this->exactly(1))
- ->method('post')
- ->with($hookListnerExpectsPost);
- $manager->deleteShare($share1);
- }
- public function testDeleteChildren() {
- $manager = $this->createManagerMock()
- ->setMethods(['deleteShare'])
- ->getMock();
- $share = $this->createMock(IShare::class);
- $share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
- $child1 = $this->createMock(IShare::class);
- $child1->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
- $child2 = $this->createMock(IShare::class);
- $child2->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
- $child3 = $this->createMock(IShare::class);
- $child3->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
- $shares = [
- $child1,
- $child2,
- $child3,
- ];
- $this->defaultProvider
- ->expects($this->exactly(4))
- ->method('getChildren')
- ->will($this->returnCallback(function($_share) use ($share, $shares) {
- if ($_share === $share) {
- return $shares;
- }
- return [];
- }));
- $this->defaultProvider
- ->expects($this->exactly(3))
- ->method('delete')
- ->withConsecutive($child1, $child2, $child3);
- $result = $this->invokePrivate($manager, 'deleteChildren', [$share]);
- $this->assertSame($shares, $result);
- }
- public function testGetShareById() {
- $share = $this->createMock(IShare::class);
- $this->defaultProvider
- ->expects($this->once())
- ->method('getShareById')
- ->with(42)
- ->willReturn($share);
- $this->assertEquals($share, $this->manager->getShareById('default:42'));
- }
- /**
- * @expectedException \OCP\Share\Exceptions\ShareNotFound
- */
- public function testGetExpiredShareById() {
- $manager = $this->createManagerMock()
- ->setMethods(['deleteShare'])
- ->getMock();
- $date = new \DateTime();
- $date->setTime(0,0,0);
- $share = $this->manager->newShare();
- $share->setExpirationDate($date)
- ->setShareType(\OCP\Share::SHARE_TYPE_LINK);
- $this->defaultProvider->expects($this->once())
- ->method('getShareById')
- ->with('42')
- ->willReturn($share);
- $manager->expects($this->once())
- ->method('deleteShare')
- ->with($share);
- $manager->getShareById('default:42');
- }
- /**
- * @expectedException InvalidArgumentException
- * @expectedExceptionMessage Passwords are enforced for link shares
- */
- public function testVerifyPasswordNullButEnforced() {
- $this->config->method('getAppValue')->will($this->returnValueMap([
- ['core', 'shareapi_enforce_links_password', 'no', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'verifyPassword', [null]);
- }
- public function testVerifyPasswordNull() {
- $this->config->method('getAppValue')->will($this->returnValueMap([
- ['core', 'shareapi_enforce_links_password', 'no', 'no'],
- ]));
- $result = $this->invokePrivate($this->manager, 'verifyPassword', [null]);
- $this->assertNull($result);
- }
- public function testVerifyPasswordHook() {
- $this->config->method('getAppValue')->will($this->returnValueMap([
- ['core', 'shareapi_enforce_links_password', 'no', 'no'],
- ]));
- $this->eventDispatcher->expects($this->once())->method('dispatch')
- ->willReturnCallback(function($eventName, GenericEvent $event) {
- $this->assertSame('OCP\PasswordPolicy::validate', $eventName);
- $this->assertSame('password', $event->getSubject());
- }
- );
- $result = $this->invokePrivate($this->manager, 'verifyPassword', ['password']);
- $this->assertNull($result);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage password not accepted
- */
- public function testVerifyPasswordHookFails() {
- $this->config->method('getAppValue')->will($this->returnValueMap([
- ['core', 'shareapi_enforce_links_password', 'no', 'no'],
- ]));
- $this->eventDispatcher->expects($this->once())->method('dispatch')
- ->willReturnCallback(function($eventName, GenericEvent $event) {
- $this->assertSame('OCP\PasswordPolicy::validate', $eventName);
- $this->assertSame('password', $event->getSubject());
- throw new HintException('message', 'password not accepted');
- }
- );
- $this->invokePrivate($this->manager, 'verifyPassword', ['password']);
- }
- public function createShare($id, $type, $path, $sharedWith, $sharedBy, $shareOwner,
- $permissions, $expireDate = null, $password = null) {
- $share = $this->createMock(IShare::class);
- $share->method('getShareType')->willReturn($type);
- $share->method('getSharedWith')->willReturn($sharedWith);
- $share->method('getSharedBy')->willReturn($sharedBy);
- $share->method('getShareOwner')->willReturn($shareOwner);
- $share->method('getNode')->willReturn($path);
- $share->method('getPermissions')->willReturn($permissions);
- $share->method('getExpirationDate')->willReturn($expireDate);
- $share->method('getPassword')->willReturn($password);
- return $share;
- }
- public function dataGeneralChecks() {
- $user0 = 'user0';
- $user2 = 'user1';
- $group0 = 'group0';
- $file = $this->createMock(File::class);
- $node = $this->createMock(Node::class);
- $data = [
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, null, $user0, $user0, 31, null, null), 'SharedWith is not a valid user', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, $group0, $user0, $user0, 31, null, null), 'SharedWith is not a valid user', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'SharedWith is not a valid user', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, null, $user0, $user0, 31, null, null), 'SharedWith is not a valid group', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, $user2, $user0, $user0, 31, null, null), 'SharedWith is not a valid group', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'SharedWith is not a valid group', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, $user2, $user0, $user0, 31, null, null), 'SharedWith should be empty', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, $group0, $user0, $user0, 31, null, null), 'SharedWith should be empty', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, 'foo@bar.com', $user0, $user0, 31, null, null), 'SharedWith should be empty', true],
- [$this->createShare(null, -1, $file, null, $user0, $user0, 31, null, null), 'unkown share type', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, $user2, null, $user0, 31, null, null), 'SharedBy should be set', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, $group0, null, $user0, 31, null, null), 'SharedBy should be set', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, null, null, $user0, 31, null, null), 'SharedBy should be set', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, $user0, $user0, $user0, 31, null, null), 'Can\'t share with yourself', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, null, $user2, $user0, $user0, 31, null, null), 'Path should be set', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, null, $group0, $user0, $user0, 31, null, null), 'Path should be set', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, null, null, $user0, $user0, 31, null, null), 'Path should be set', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $node, $user2, $user0, $user0, 31, null, null), 'Path should be either a file or a folder', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $node, $group0, $user0, $user0, 31, null, null), 'Path should be either a file or a folder', true],
- [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $node, null, $user0, $user0, 31, null, null), 'Path should be either a file or a folder', true],
- ];
- $nonShareAble = $this->createMock(Folder::class);
- $nonShareAble->method('isShareable')->willReturn(false);
- $nonShareAble->method('getPath')->willReturn('path');
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $nonShareAble, $user2, $user0, $user0, 31, null, null), 'You are not allowed to share path', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $nonShareAble, $group0, $user0, $user0, 31, null, null), 'You are not allowed to share path', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $nonShareAble, null, $user0, $user0, 31, null, null), 'You are not allowed to share path', true];
- $limitedPermssions = $this->createMock(File::class);
- $limitedPermssions->method('isShareable')->willReturn(true);
- $limitedPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
- $limitedPermssions->method('getPath')->willReturn('path');
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $limitedPermssions, $user2, $user0, $user0, null, null, null), 'A share requires permissions', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $limitedPermssions, $group0, $user0, $user0, null, null, null), 'A share requires permissions', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $limitedPermssions, null, $user0, $user0, null, null, null), 'A share requires permissions', true];
- $mount = $this->createMock(MoveableMount::class);
- $limitedPermssions->method('getMountPoint')->willReturn($mount);
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $limitedPermssions, $user2, $user0, $user0, 31, null, null), 'Cannot increase permissions of path', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $limitedPermssions, $group0, $user0, $user0, 17, null, null), 'Cannot increase permissions of path', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $limitedPermssions, null, $user0, $user0, 3, null, null), 'Cannot increase permissions of path', true];
- $nonMoveableMountPermssions = $this->createMock(Folder::class);
- $nonMoveableMountPermssions->method('isShareable')->willReturn(true);
- $nonMoveableMountPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
- $nonMoveableMountPermssions->method('getPath')->willReturn('path');
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $nonMoveableMountPermssions, $user2, $user0, $user0, 11, null, null), 'Cannot increase permissions of path', false];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $nonMoveableMountPermssions, $group0, $user0, $user0, 11, null, null), 'Cannot increase permissions of path', false];
- $rootFolder = $this->createMock(Folder::class);
- $rootFolder->method('isShareable')->willReturn(true);
- $rootFolder->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
- $rootFolder->method('getPath')->willReturn('myrootfolder');
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $rootFolder, $user2, $user0, $user0, 30, null, null), 'You can\'t share your root folder', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $rootFolder, $group0, $user0, $user0, 2, null, null), 'You can\'t share your root folder', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $rootFolder, null, $user0, $user0, 16, null, null), 'You can\'t share your root folder', true];
- $allPermssions = $this->createMock(Folder::class);
- $allPermssions->method('isShareable')->willReturn(true);
- $allPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $allPermssions, $user2, $user0, $user0, 30, null, null), 'Shares need at least read permissions', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 2, null, null), 'Shares need at least read permissions', true];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $allPermssions, $user2, $user0, $user0, 31, null, null), null, false];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $allPermssions, $group0, $user0, $user0, 3, null, null), null, false];
- $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $allPermssions, null, $user0, $user0, 17, null, null), null, false];
- return $data;
- }
- /**
- * @dataProvider dataGeneralChecks
- *
- * @param $share
- * @param $exceptionMessage
- */
- public function testGeneralChecks($share, $exceptionMessage, $exception) {
- $thrown = null;
- $this->userManager->method('userExists')->will($this->returnValueMap([
- ['user0', true],
- ['user1', true],
- ]));
- $this->groupManager->method('groupExists')->will($this->returnValueMap([
- ['group0', true],
- ]));
- $userFolder = $this->createMock(Folder::class);
- $userFolder->method('getPath')->willReturn('myrootfolder');
- $this->rootFolder->method('getUserFolder')->willReturn($userFolder);
- try {
- $this->invokePrivate($this->manager, 'generalCreateChecks', [$share]);
- $thrown = false;
- } catch (\OCP\Share\Exceptions\GenericShareException $e) {
- $this->assertEquals($exceptionMessage, $e->getHint());
- $thrown = true;
- } catch(\InvalidArgumentException $e) {
- $this->assertEquals($exceptionMessage, $e->getMessage());
- $thrown = true;
- }
- $this->assertSame($exception, $thrown);
- }
- /**
- * @expectedException \InvalidArgumentException
- * @expectedExceptionMessage You can't share your root folder
- */
- public function testGeneralCheckShareRoot() {
- $thrown = null;
- $this->userManager->method('userExists')->will($this->returnValueMap([
- ['user0', true],
- ['user1', true],
- ]));
- $userFolder = $this->createMock(Folder::class);
- $userFolder->method('isSubNode')->with($userFolder)->willReturn(false);
- $this->rootFolder->method('getUserFolder')->willReturn($userFolder);
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('user0')
- ->setSharedBy('user1')
- ->setNode($userFolder);
- $this->invokePrivate($this->manager, 'generalCreateChecks', [$share]);
- }
- /**
- * @expectedException \OCP\Share\Exceptions\GenericShareException
- * @expectedExceptionMessage Expiration date is in the past
- */
- public function testvalidateExpirationDateInPast() {
- // Expire date in the past
- $past = new \DateTime();
- $past->sub(new \DateInterval('P1D'));
- $share = $this->manager->newShare();
- $share->setExpirationDate($past);
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- }
- /**
- * @expectedException InvalidArgumentException
- * @expectedExceptionMessage Expiration date is enforced
- */
- public function testvalidateExpirationDateEnforceButNotSet() {
- $share = $this->manager->newShare();
- $share->setProviderId('foo')->setId('bar');
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_default_expire_date', 'no', 'yes'],
- ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- }
- public function testvalidateExpirationDateEnforceButNotEnabledAndNotSet() {
- $share = $this->manager->newShare();
- $share->setProviderId('foo')->setId('bar');
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertNull($share->getExpirationDate());
- }
- public function testvalidateExpirationDateEnforceButNotSetNewShare() {
- $share = $this->manager->newShare();
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
- ['core', 'shareapi_expire_after_n_days', '7', '3'],
- ['core', 'shareapi_default_expire_date', 'no', 'yes'],
- ]));
- $expected = new \DateTime();
- $expected->setTime(0,0,0);
- $expected->add(new \DateInterval('P3D'));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertNotNull($share->getExpirationDate());
- $this->assertEquals($expected, $share->getExpirationDate());
- }
- public function testvalidateExpirationDateEnforceToFarIntoFuture() {
- // Expire date in the past
- $future = new \DateTime();
- $future->add(new \DateInterval('P7D'));
- $share = $this->manager->newShare();
- $share->setExpirationDate($future);
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
- ['core', 'shareapi_expire_after_n_days', '7', '3'],
- ]));
- try {
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- } catch (\OCP\Share\Exceptions\GenericShareException $e) {
- $this->assertEquals('Cannot set expiration date more than 3 days in the future', $e->getMessage());
- $this->assertEquals('Cannot set expiration date more than 3 days in the future', $e->getHint());
- $this->assertEquals(404, $e->getCode());
- }
- }
- public function testvalidateExpirationDateEnforceValid() {
- // Expire date in the past
- $future = new \DateTime();
- $future->add(new \DateInterval('P2D'));
- $future->setTime(0,0,0);
- $expected = clone $future;
- $future->setTime(1,2,3);
- $share = $this->manager->newShare();
- $share->setExpirationDate($future);
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
- ['core', 'shareapi_expire_after_n_days', '7', '3'],
- ]));
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
- \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
- $hookListner->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($future) {
- return $data['expirationDate'] == $future;
- }));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertEquals($expected, $share->getExpirationDate());
- }
- public function testvalidateExpirationDateNoDateNoDefaultNull() {
- $date = new \DateTime();
- $date->add(new \DateInterval('P5D'));
- $expected = clone $date;
- $expected->setTime(0,0,0);
- $share = $this->manager->newShare();
- $share->setExpirationDate($date);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
- \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
- $hookListner->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
- return $data['expirationDate'] == $expected && $data['passwordSet'] === false;
- }));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertEquals($expected, $share->getExpirationDate());
- }
- public function testvalidateExpirationDateNoDateNoDefault() {
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
- \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
- $hookListner->expects($this->once())->method('listener')->with($this->callback(function ($data) {
- return $data['expirationDate'] === null && $data['passwordSet'] === true;
- }));
- $share = $this->manager->newShare();
- $share->setPassword('password');
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertNull($share->getExpirationDate());
- }
- public function testvalidateExpirationDateNoDateDefault() {
- $future = new \DateTime();
- $future->add(new \DateInterval('P3D'));
- $future->setTime(0,0,0);
- $expected = clone $future;
- $share = $this->manager->newShare();
- $share->setExpirationDate($future);
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_default_expire_date', 'no', 'yes'],
- ['core', 'shareapi_expire_after_n_days', '7', '3'],
- ]));
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
- \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
- $hookListner->expects($this->once())->method('listener')->with($this->callback(function ($data) use ($expected) {
- return $data['expirationDate'] == $expected;
- }));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertEquals($expected, $share->getExpirationDate());
- }
- public function testValidateExpirationDateHookModification() {
- $nextWeek = new \DateTime();
- $nextWeek->add(new \DateInterval('P7D'));
- $nextWeek->setTime(0,0,0);
- $save = clone $nextWeek;
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
- \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
- $hookListner->expects($this->once())->method('listener')->will($this->returnCallback(function ($data) {
- $data['expirationDate']->sub(new \DateInterval('P2D'));
- }));
- $share = $this->manager->newShare();
- $share->setExpirationDate($nextWeek);
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $save->sub(new \DateInterval('P2D'));
- $this->assertEquals($save, $share->getExpirationDate());
- }
- /**
- * @expectedException \Exception
- * @expectedExceptionMessage Invalid date!
- */
- public function testValidateExpirationDateHookException() {
- $nextWeek = new \DateTime();
- $nextWeek->add(new \DateInterval('P7D'));
- $nextWeek->setTime(0,0,0);
- $share = $this->manager->newShare();
- $share->setExpirationDate($nextWeek);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listener'])->getMock();
- \OCP\Util::connectHook('\OC\Share', 'verifyExpirationDate', $hookListner, 'listener');
- $hookListner->expects($this->once())->method('listener')->will($this->returnCallback(function ($data) {
- $data['accepted'] = false;
- $data['message'] = 'Invalid date!';
- }));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- }
- public function testValidateExpirationDateExistingShareNoDefault() {
- $share = $this->manager->newShare();
- $share->setId('42')->setProviderId('foo');
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_default_expire_date', 'no', 'yes'],
- ['core', 'shareapi_expire_after_n_days', '7', '6'],
- ]));
- $this->invokePrivate($this->manager, 'validateExpirationDate', [$share]);
- $this->assertEquals(null, $share->getExpirationDate());
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Only sharing with group members is allowed
- */
- public function testUserCreateChecksShareWithGroupMembersOnlyDifferentGroups() {
- $share = $this->manager->newShare();
- $sharedBy = $this->createMock(IUser::class);
- $sharedWith = $this->createMock(IUser::class);
- $share->setSharedBy('sharedBy')->setSharedWith('sharedWith');
- $this->groupManager
- ->method('getUserGroupIds')
- ->will(
- $this->returnValueMap([
- [$sharedBy, ['group1']],
- [$sharedWith, ['group2']],
- ])
- );
- $this->userManager->method('get')->will($this->returnValueMap([
- ['sharedBy', $sharedBy],
- ['sharedWith', $sharedWith],
- ]));
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
- }
- public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup() {
- $share = $this->manager->newShare();
- $sharedBy = $this->createMock(IUser::class);
- $sharedWith = $this->createMock(IUser::class);
- $share->setSharedBy('sharedBy')->setSharedWith('sharedWith');
- $path = $this->createMock(Node::class);
- $share->setNode($path);
- $this->groupManager
- ->method('getUserGroupIds')
- ->will(
- $this->returnValueMap([
- [$sharedBy, ['group1', 'group3']],
- [$sharedWith, ['group2', 'group3']],
- ])
- );
- $this->userManager->method('get')->will($this->returnValueMap([
- ['sharedBy', $sharedBy],
- ['sharedWith', $sharedWith],
- ]));
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
- ]));
- $this->defaultProvider
- ->method('getSharesByPath')
- ->with($path)
- ->willReturn([]);
- $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Path already shared with this user
- */
- public function testUserCreateChecksIdenticalShareExists() {
- $share = $this->manager->newShare();
- $share2 = $this->manager->newShare();
- $sharedWith = $this->createMock(IUser::class);
- $path = $this->createMock(Node::class);
- $share->setSharedWith('sharedWith')->setNode($path)
- ->setProviderId('foo')->setId('bar');
- $share2->setSharedWith('sharedWith')->setNode($path)
- ->setProviderId('foo')->setId('baz');
- $this->defaultProvider
- ->method('getSharesByPath')
- ->with($path)
- ->willReturn([$share2]);
- $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Path already shared with this user
- */
- public function testUserCreateChecksIdenticalPathSharedViaGroup() {
- $share = $this->manager->newShare();
- $sharedWith = $this->createMock(IUser::class);
- $sharedWith->method('getUID')->willReturn('sharedWith');
- $this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
- $path = $this->createMock(Node::class);
- $share->setSharedWith('sharedWith')
- ->setNode($path)
- ->setShareOwner('shareOwner')
- ->setProviderId('foo')
- ->setId('bar');
- $share2 = $this->manager->newShare();
- $share2->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setShareOwner('shareOwner2')
- ->setProviderId('foo')
- ->setId('baz')
- ->setSharedWith('group');
- $group = $this->createMock(IGroup::class);
- $group->method('inGroup')
- ->with($sharedWith)
- ->willReturn(true);
- $this->groupManager->method('get')->with('group')->willReturn($group);
- $this->defaultProvider
- ->method('getSharesByPath')
- ->with($path)
- ->willReturn([$share2]);
- $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
- }
- public function testUserCreateChecksIdenticalPathNotSharedWithUser() {
- $share = $this->manager->newShare();
- $sharedWith = $this->createMock(IUser::class);
- $path = $this->createMock(Node::class);
- $share->setSharedWith('sharedWith')
- ->setNode($path)
- ->setShareOwner('shareOwner')
- ->setProviderId('foo')
- ->setId('bar');
- $this->userManager->method('get')->with('sharedWith')->willReturn($sharedWith);
- $share2 = $this->manager->newShare();
- $share2->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setShareOwner('shareOwner2')
- ->setProviderId('foo')
- ->setId('baz');
- $group = $this->createMock(IGroup::class);
- $group->method('inGroup')
- ->with($sharedWith)
- ->willReturn(false);
- $this->groupManager->method('get')->with('group')->willReturn($group);
- $share2->setSharedWith('group');
- $this->defaultProvider
- ->method('getSharesByPath')
- ->with($path)
- ->willReturn([$share2]);
- $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Group sharing is now allowed
- */
- public function testGroupCreateChecksShareWithGroupMembersGroupSharingNotAllowed() {
- $share = $this->manager->newShare();
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_group_sharing', 'yes', 'no'],
- ]));
- $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Only sharing within your own groups is allowed
- */
- public function testGroupCreateChecksShareWithGroupMembersOnlyNotInGroup() {
- $share = $this->manager->newShare();
- $user = $this->createMock(IUser::class);
- $group = $this->createMock(IGroup::class);
- $share->setSharedBy('user')->setSharedWith('group');
- $group->method('inGroup')->with($user)->willReturn(false);
- $this->groupManager->method('get')->with('group')->willReturn($group);
- $this->userManager->method('get')->with('user')->willReturn($user);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
- ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
- }
- public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup() {
- $share = $this->manager->newShare();
- $user = $this->createMock(IUser::class);
- $group = $this->createMock(IGroup::class);
- $share->setSharedBy('user')->setSharedWith('group');
- $this->userManager->method('get')->with('user')->willReturn($user);
- $this->groupManager->method('get')->with('group')->willReturn($group);
- $group->method('inGroup')->with($user)->willReturn(true);
- $path = $this->createMock(Node::class);
- $share->setNode($path);
- $this->defaultProvider->method('getSharesByPath')
- ->with($path)
- ->willReturn([]);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
- ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Path already shared with this group
- */
- public function testGroupCreateChecksPathAlreadySharedWithSameGroup() {
- $share = $this->manager->newShare();
- $path = $this->createMock(Node::class);
- $share->setSharedWith('sharedWith')
- ->setNode($path)
- ->setProviderId('foo')
- ->setId('bar');
- $share2 = $this->manager->newShare();
- $share2->setSharedWith('sharedWith')
- ->setProviderId('foo')
- ->setId('baz');
- $this->defaultProvider->method('getSharesByPath')
- ->with($path)
- ->willReturn([$share2]);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
- }
- public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup() {
- $share = $this->manager->newShare();
- $share->setSharedWith('sharedWith');
- $path = $this->createMock(Node::class);
- $share->setNode($path);
- $share2 = $this->manager->newShare();
- $share2->setSharedWith('sharedWith2');
- $this->defaultProvider->method('getSharesByPath')
- ->with($path)
- ->willReturn([$share2]);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_group_sharing', 'yes', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Link sharing not allowed
- */
- public function testLinkCreateChecksNoLinkSharesAllowed() {
- $share = $this->manager->newShare();
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_links', 'yes', 'no'],
- ]));
- $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Link shares can't have reshare permissions
- */
- public function testLinkCreateChecksSharePermissions() {
- $share = $this->manager->newShare();
- $share->setPermissions(\OCP\Constants::PERMISSION_SHARE);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_links', 'yes', 'yes'],
- ]));
- $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Public upload not allowed
- */
- public function testLinkCreateChecksNoPublicUpload() {
- $share = $this->manager->newShare();
- $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_links', 'yes', 'yes'],
- ['core', 'shareapi_allow_public_upload', 'yes', 'no']
- ]));
- $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
- }
- public function testLinkCreateChecksPublicUpload() {
- $share = $this->manager->newShare();
- $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_links', 'yes', 'yes'],
- ['core', 'shareapi_allow_public_upload', 'yes', 'yes']
- ]));
- $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
- }
- public function testLinkCreateChecksReadOnly() {
- $share = $this->manager->newShare();
- $share->setPermissions(\OCP\Constants::PERMISSION_READ);
- $this->config
- ->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_allow_links', 'yes', 'yes'],
- ['core', 'shareapi_allow_public_upload', 'yes', 'no']
- ]));
- $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
- }
- /**
- * @expectedException \InvalidArgumentException
- * @expectedExceptionMessage Path contains files shared with you
- */
- public function testPathCreateChecksContainsSharedMount() {
- $path = $this->createMock(Folder::class);
- $path->method('getPath')->willReturn('path');
- $mount = $this->createMock(IMountPoint::class);
- $storage = $this->createMock(Storage::class);
- $mount->method('getStorage')->willReturn($storage);
- $storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(true);
- $this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
- $this->invokePrivate($this->manager, 'pathCreateChecks', [$path]);
- }
- public function testPathCreateChecksContainsNoSharedMount() {
- $path = $this->createMock(Folder::class);
- $path->method('getPath')->willReturn('path');
- $mount = $this->createMock(IMountPoint::class);
- $storage = $this->createMock(Storage::class);
- $mount->method('getStorage')->willReturn($storage);
- $storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(false);
- $this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
- $this->invokePrivate($this->manager, 'pathCreateChecks', [$path]);
- }
- public function testPathCreateChecksContainsNoFolder() {
- $path = $this->createMock(File::class);
- $this->invokePrivate($this->manager, 'pathCreateChecks', [$path]);
- }
- public function dataIsSharingDisabledForUser() {
- $data = [];
- // No exclude groups
- $data[] = ['no', null, null, null, false];
- // empty exclude list, user no groups
- $data[] = ['yes', '', json_encode(['']), [], false];
- // empty exclude list, user groups
- $data[] = ['yes', '', json_encode(['']), ['group1', 'group2'], false];
- // Convert old list to json
- $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), [], false];
- // Old list partly groups in common
- $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1', 'group3'], false];
- // Old list only groups in common
- $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1'], true];
- // New list partly in common
- $data[] = ['yes', json_encode(['group1', 'group2']), null, ['group1', 'group3'], false];
- // New list only groups in common
- $data[] = ['yes', json_encode(['group1', 'group2']), null, ['group2'], true];
- return $data;
- }
- /**
- * @dataProvider dataIsSharingDisabledForUser
- *
- * @param string $excludeGroups
- * @param string $groupList
- * @param string $setList
- * @param string[] $groupIds
- * @param bool $expected
- */
- public function testIsSharingDisabledForUser($excludeGroups, $groupList, $setList, $groupIds, $expected) {
- $user = $this->createMock(IUser::class);
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_exclude_groups', 'no', $excludeGroups],
- ['core', 'shareapi_exclude_groups_list', '', $groupList],
- ]));
- if ($setList !== null) {
- $this->config->expects($this->once())
- ->method('setAppValue')
- ->with('core', 'shareapi_exclude_groups_list', $setList);
- } else {
- $this->config->expects($this->never())
- ->method('setAppValue');
- }
- $this->groupManager->method('getUserGroupIds')
- ->with($user)
- ->willReturn($groupIds);
- $this->userManager->method('get')->with('user')->willReturn($user);
- $res = $this->manager->sharingDisabledForUser('user');
- $this->assertEquals($expected, $res);
- }
- public function dataCanShare() {
- $data = [];
- /*
- * [expected, sharing enabled, disabled for user]
- */
- $data[] = [false, 'no', false];
- $data[] = [false, 'no', true];
- $data[] = [true, 'yes', false];
- $data[] = [false, 'yes', true];
- return $data;
- }
- /**
- * @dataProvider dataCanShare
- *
- * @param bool $expected
- * @param string $sharingEnabled
- * @param bool $disabledForUser
- */
- public function testCanShare($expected, $sharingEnabled, $disabledForUser) {
- $this->config->method('getAppValue')
- ->will($this->returnValueMap([
- ['core', 'shareapi_enabled', 'yes', $sharingEnabled],
- ]));
- $manager = $this->createManagerMock()
- ->setMethods(['sharingDisabledForUser'])
- ->getMock();
- $manager->method('sharingDisabledForUser')
- ->with('user')
- ->willReturn($disabledForUser);
- $share = $this->manager->newShare();
- $share->setSharedBy('user');
- $exception = false;
- try {
- $res = $this->invokePrivate($manager, 'canShare', [$share]);
- } catch (\Exception $e) {
- $exception = true;
- }
- $this->assertEquals($expected, !$exception);
- }
- public function testCreateShareUser() {
- $manager = $this->createManagerMock()
- ->setMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
- ->getMock();
- $shareOwner = $this->createMock(IUser::class);
- $shareOwner->method('getUID')->willReturn('shareOwner');
- $storage = $this->createMock(Storage::class);
- $path = $this->createMock(File::class);
- $path->method('getOwner')->willReturn($shareOwner);
- $path->method('getName')->willReturn('target');
- $path->method('getStorage')->willReturn($storage);
- $share = $this->createShare(
- null,
- \OCP\Share::SHARE_TYPE_USER,
- $path,
- 'sharedWith',
- 'sharedBy',
- null,
- \OCP\Constants::PERMISSION_ALL);
- $manager->expects($this->once())
- ->method('canShare')
- ->with($share)
- ->willReturn(true);
- $manager->expects($this->once())
- ->method('generalCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('userCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('pathCreateChecks')
- ->with($path);
- $this->defaultProvider
- ->expects($this->once())
- ->method('create')
- ->with($share)
- ->will($this->returnArgument(0));
- $share->expects($this->once())
- ->method('setShareOwner')
- ->with('shareOwner');
- $share->expects($this->once())
- ->method('setTarget')
- ->with('/target');
- $manager->createShare($share);
- }
- public function testCreateShareGroup() {
- $manager = $this->createManagerMock()
- ->setMethods(['canShare', 'generalCreateChecks', 'groupCreateChecks', 'pathCreateChecks'])
- ->getMock();
- $shareOwner = $this->createMock(IUser::class);
- $shareOwner->method('getUID')->willReturn('shareOwner');
- $storage = $this->createMock(Storage::class);
- $path = $this->createMock(File::class);
- $path->method('getOwner')->willReturn($shareOwner);
- $path->method('getName')->willReturn('target');
- $path->method('getStorage')->willReturn($storage);
- $share = $this->createShare(
- null,
- \OCP\Share::SHARE_TYPE_GROUP,
- $path,
- 'sharedWith',
- 'sharedBy',
- null,
- \OCP\Constants::PERMISSION_ALL);
- $manager->expects($this->once())
- ->method('canShare')
- ->with($share)
- ->willReturn(true);
- $manager->expects($this->once())
- ->method('generalCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('groupCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('pathCreateChecks')
- ->with($path);
- $this->defaultProvider
- ->expects($this->once())
- ->method('create')
- ->with($share)
- ->will($this->returnArgument(0));
- $share->expects($this->once())
- ->method('setShareOwner')
- ->with('shareOwner');
- $share->expects($this->once())
- ->method('setTarget')
- ->with('/target');
- $manager->createShare($share);
- }
- public function testCreateShareLink() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'generalCreateChecks',
- 'linkCreateChecks',
- 'pathCreateChecks',
- 'validateExpirationDate',
- 'verifyPassword',
- 'setLinkParent',
- ])
- ->getMock();
- $shareOwner = $this->createMock(IUser::class);
- $shareOwner->method('getUID')->willReturn('shareOwner');
- $storage = $this->createMock(Storage::class);
- $path = $this->createMock(File::class);
- $path->method('getOwner')->willReturn($shareOwner);
- $path->method('getName')->willReturn('target');
- $path->method('getId')->willReturn(1);
- $path->method('getStorage')->willReturn($storage);
- $date = new \DateTime();
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_LINK)
- ->setNode($path)
- ->setSharedBy('sharedBy')
- ->setPermissions(\OCP\Constants::PERMISSION_ALL)
- ->setExpirationDate($date)
- ->setPassword('password');
- $manager->expects($this->once())
- ->method('canShare')
- ->with($share)
- ->willReturn(true);
- $manager->expects($this->once())
- ->method('generalCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('linkCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('pathCreateChecks')
- ->with($path);
- $manager->expects($this->once())
- ->method('validateExpirationDate')
- ->with($share);
- $manager->expects($this->once())
- ->method('verifyPassword')
- ->with('password');
- $manager->expects($this->once())
- ->method('setLinkParent')
- ->with($share);
- $this->hasher->expects($this->once())
- ->method('hash')
- ->with('password')
- ->willReturn('hashed');
- $this->secureRandom->method('getMediumStrengthGenerator')
- ->will($this->returnSelf());
- $this->secureRandom->method('generate')
- ->willReturn('token');
- $this->defaultProvider
- ->expects($this->once())
- ->method('create')
- ->with($share)
- ->will($this->returnCallback(function(Share $share) {
- return $share->setId(42);
- }));
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['pre', 'post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'pre_shared', $hookListner, 'pre');
- \OCP\Util::connectHook('OCP\Share', 'post_shared', $hookListner, 'post');
- $hookListnerExpectsPre = [
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_LINK,
- 'uidOwner' => 'sharedBy',
- 'permissions' => 31,
- 'fileSource' => 1,
- 'expiration' => $date,
- 'token' => 'token',
- 'run' => true,
- 'error' => '',
- 'itemTarget' => '/target',
- 'shareWith' => null,
- ];
- $hookListnerExpectsPost = [
- 'itemType' => 'file',
- 'itemSource' => 1,
- 'shareType' => \OCP\Share::SHARE_TYPE_LINK,
- 'uidOwner' => 'sharedBy',
- 'permissions' => 31,
- 'fileSource' => 1,
- 'expiration' => $date,
- 'token' => 'token',
- 'id' => 42,
- 'itemTarget' => '/target',
- 'fileTarget' => '/target',
- 'shareWith' => null,
- ];
- $hookListner->expects($this->once())
- ->method('pre')
- ->with($this->equalTo($hookListnerExpectsPre));
- $hookListner->expects($this->once())
- ->method('post')
- ->with($this->equalTo($hookListnerExpectsPost));
- /** @var IShare $share */
- $share = $manager->createShare($share);
- $this->assertSame('shareOwner', $share->getShareOwner());
- $this->assertEquals('/target', $share->getTarget());
- $this->assertSame($date, $share->getExpirationDate());
- $this->assertEquals('token', $share->getToken());
- $this->assertEquals('hashed', $share->getPassword());
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage I won't let you share
- */
- public function testCreateShareHookError() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'generalCreateChecks',
- 'userCreateChecks',
- 'pathCreateChecks',
- ])
- ->getMock();
- $shareOwner = $this->createMock(IUser::class);
- $shareOwner->method('getUID')->willReturn('shareOwner');
- $storage = $this->createMock(Storage::class);
- $path = $this->createMock(File::class);
- $path->method('getOwner')->willReturn($shareOwner);
- $path->method('getName')->willReturn('target');
- $path->method('getStorage')->willReturn($storage);
- $share = $this->createShare(
- null,
- \OCP\Share::SHARE_TYPE_USER,
- $path,
- 'sharedWith',
- 'sharedBy',
- null,
- \OCP\Constants::PERMISSION_ALL);
- $manager->expects($this->once())
- ->method('canShare')
- ->with($share)
- ->willReturn(true);
- $manager->expects($this->once())
- ->method('generalCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('userCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('pathCreateChecks')
- ->with($path);
- $share->expects($this->once())
- ->method('setShareOwner')
- ->with('shareOwner');
- $share->expects($this->once())
- ->method('setTarget')
- ->with('/target');
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['pre'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'pre_shared', $hookListner, 'pre');
- $hookListner->expects($this->once())
- ->method('pre')
- ->will($this->returnCallback(function (array $data) {
- $data['run'] = false;
- $data['error'] = 'I won\'t let you share!';
- }));
- $manager->createShare($share);
- }
- public function testCreateShareOfIncommingFederatedShare() {
- $manager = $this->createManagerMock()
- ->setMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
- ->getMock();
- $shareOwner = $this->createMock(IUser::class);
- $shareOwner->method('getUID')->willReturn('shareOwner');
- $storage = $this->createMock(Storage::class);
- $storage->method('instanceOfStorage')
- ->with('OCA\Files_Sharing\External\Storage')
- ->willReturn(true);
- $storage2 = $this->createMock(Storage::class);
- $storage2->method('instanceOfStorage')
- ->with('OCA\Files_Sharing\External\Storage')
- ->willReturn(false);
- $path = $this->createMock(File::class);
- $path->expects($this->never())->method('getOwner');
- $path->method('getName')->willReturn('target');
- $path->method('getStorage')->willReturn($storage);
- $parent = $this->createMock(Folder::class);
- $parent->method('getStorage')->willReturn($storage);
- $parentParent = $this->createMock(Folder::class);
- $parentParent->method('getStorage')->willReturn($storage2);
- $parentParent->method('getOwner')->willReturn($shareOwner);
- $path->method('getParent')->willReturn($parent);
- $parent->method('getParent')->willReturn($parentParent);
- $share = $this->createShare(
- null,
- \OCP\Share::SHARE_TYPE_USER,
- $path,
- 'sharedWith',
- 'sharedBy',
- null,
- \OCP\Constants::PERMISSION_ALL);
- $manager->expects($this->once())
- ->method('canShare')
- ->with($share)
- ->willReturn(true);
- $manager->expects($this->once())
- ->method('generalCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('userCreateChecks')
- ->with($share);;
- $manager->expects($this->once())
- ->method('pathCreateChecks')
- ->with($path);
- $this->defaultProvider
- ->expects($this->once())
- ->method('create')
- ->with($share)
- ->will($this->returnArgument(0));
- $share->expects($this->once())
- ->method('setShareOwner')
- ->with('shareOwner');
- $share->expects($this->once())
- ->method('setTarget')
- ->with('/target');
- $manager->createShare($share);
- }
- public function testGetSharesBy() {
- $share = $this->manager->newShare();
- $node = $this->createMock(Folder::class);
- $this->defaultProvider->expects($this->once())
- ->method('getSharesBy')
- ->with(
- $this->equalTo('user'),
- $this->equalTo(\OCP\Share::SHARE_TYPE_USER),
- $this->equalTo($node),
- $this->equalTo(true),
- $this->equalTo(1),
- $this->equalTo(1)
- )->willReturn([$share]);
- $shares = $this->manager->getSharesBy('user', \OCP\Share::SHARE_TYPE_USER, $node, true, 1, 1);
- $this->assertCount(1, $shares);
- $this->assertSame($share, $shares[0]);
- }
- /**
- * Test to ensure we correctly remove expired link shares
- *
- * We have 8 Shares and we want the 3 first valid shares.
- * share 3-6 and 8 are expired. Thus at the end of this test we should
- * have received share 1,2 and 7. And from the manager. Share 3-6 should be
- * deleted (as they are evaluated). but share 8 should still be there.
- */
- public function testGetSharesByExpiredLinkShares() {
- $manager = $this->createManagerMock()
- ->setMethods(['deleteShare'])
- ->getMock();
- /** @var \OCP\Share\IShare[] $shares */
- $shares = [];
- /*
- * This results in an array of 8 IShare elements
- */
- for ($i = 0; $i < 8; $i++) {
- $share = $this->manager->newShare();
- $share->setId($i);
- $shares[] = $share;
- }
- $today = new \DateTime();
- $today->setTime(0,0,0);
- /*
- * Set the expiration date to today for some shares
- */
- $shares[2]->setExpirationDate($today);
- $shares[3]->setExpirationDate($today);
- $shares[4]->setExpirationDate($today);
- $shares[5]->setExpirationDate($today);
- /** @var \OCP\Share\IShare[] $i */
- $shares2 = [];
- for ($i = 0; $i < 8; $i++) {
- $shares2[] = clone $shares[$i];
- }
- $node = $this->createMock(File::class);
- /*
- * Simulate the getSharesBy call.
- */
- $this->defaultProvider
- ->method('getSharesBy')
- ->will($this->returnCallback(function($uid, $type, $node, $reshares, $limit, $offset) use (&$shares2) {
- return array_slice($shares2, $offset, $limit);
- }));
- /*
- * Simulate the deleteShare call.
- */
- $manager->method('deleteShare')
- ->will($this->returnCallback(function($share) use (&$shares2) {
- for($i = 0; $i < count($shares2); $i++) {
- if ($shares2[$i]->getId() === $share->getId()) {
- array_splice($shares2, $i, 1);
- break;
- }
- }
- }));
- $res = $manager->getSharesBy('user', \OCP\Share::SHARE_TYPE_LINK, $node, true, 3, 0);
- $this->assertCount(3, $res);
- $this->assertEquals($shares[0]->getId(), $res[0]->getId());
- $this->assertEquals($shares[1]->getId(), $res[1]->getId());
- $this->assertEquals($shares[6]->getId(), $res[2]->getId());
- $this->assertCount(4, $shares2);
- $this->assertEquals(0, $shares2[0]->getId());
- $this->assertEquals(1, $shares2[1]->getId());
- $this->assertEquals(6, $shares2[2]->getId());
- $this->assertEquals(7, $shares2[3]->getId());
- $this->assertSame($today, $shares[3]->getExpirationDate());
- }
- public function testGetShareByToken() {
- $factory = $this->createMock(IProviderFactory::class);
- $manager = new Manager(
- $this->logger,
- $this->config,
- $this->secureRandom,
- $this->hasher,
- $this->mountManager,
- $this->groupManager,
- $this->l,
- $factory,
- $this->userManager,
- $this->rootFolder,
- $this->eventDispatcher
- );
- $share = $this->createMock(IShare::class);
- $factory->expects($this->once())
- ->method('getProviderForType')
- ->with(\OCP\Share::SHARE_TYPE_LINK)
- ->willReturn($this->defaultProvider);
- $this->defaultProvider->expects($this->once())
- ->method('getShareByToken')
- ->with('token')
- ->willReturn($share);
- $ret = $manager->getShareByToken('token');
- $this->assertSame($share, $ret);
- }
- public function testGetShareByTokenWithException() {
- $factory = $this->createMock(IProviderFactory::class);
- $manager = new Manager(
- $this->logger,
- $this->config,
- $this->secureRandom,
- $this->hasher,
- $this->mountManager,
- $this->groupManager,
- $this->l,
- $factory,
- $this->userManager,
- $this->rootFolder,
- $this->eventDispatcher
- );
- $share = $this->createMock(IShare::class);
- $factory->expects($this->at(0))
- ->method('getProviderForType')
- ->with(\OCP\Share::SHARE_TYPE_LINK)
- ->willReturn($this->defaultProvider);
- $factory->expects($this->at(1))
- ->method('getProviderForType')
- ->with(\OCP\Share::SHARE_TYPE_REMOTE)
- ->willReturn($this->defaultProvider);
- $this->defaultProvider->expects($this->at(0))
- ->method('getShareByToken')
- ->with('token')
- ->will($this->throwException(new ShareNotFound()));
- $this->defaultProvider->expects($this->at(1))
- ->method('getShareByToken')
- ->with('token')
- ->willReturn($share);
- $ret = $manager->getShareByToken('token');
- $this->assertSame($share, $ret);
- }
- /**
- * @expectedException \OCP\Share\Exceptions\ShareNotFound
- */
- public function testGetShareByTokenExpired() {
- $manager = $this->createManagerMock()
- ->setMethods(['deleteShare'])
- ->getMock();
- $date = new \DateTime();
- $date->setTime(0,0,0);
- $share = $this->manager->newShare();
- $share->setExpirationDate($date);
- $this->defaultProvider->expects($this->once())
- ->method('getShareByToken')
- ->with('expiredToken')
- ->willReturn($share);
- $manager->expects($this->once())
- ->method('deleteShare')
- ->with($this->equalTo($share));
- $manager->getShareByToken('expiredToken');
- }
- public function testGetShareByTokenNotExpired() {
- $date = new \DateTime();
- $date->setTime(0,0,0);
- $date->add(new \DateInterval('P2D'));
- $share = $this->manager->newShare();
- $share->setExpirationDate($date);
- $this->defaultProvider->expects($this->once())
- ->method('getShareByToken')
- ->with('expiredToken')
- ->willReturn($share);
- $res = $this->manager->getShareByToken('expiredToken');
- $this->assertSame($share, $res);
- }
- public function testGetShareByTokenPublicSharingDisabled() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_LINK)
- ->setPermissions(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
- $this->config->method('getAppValue')->will($this->returnValueMap([
- ['core', 'shareapi_allow_public_upload', 'yes', 'no'],
- ]));
- $this->defaultProvider->expects($this->once())
- ->method('getShareByToken')
- ->willReturn('validToken')
- ->willReturn($share);
- $res = $this->manager->getShareByToken('validToken');
- $this->assertSame(\OCP\Constants::PERMISSION_READ, $res->getPermissions());
- }
- public function testCheckPasswordNoLinkShare() {
- $share = $this->createMock(IShare::class);
- $share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_USER);
- $this->assertFalse($this->manager->checkPassword($share, 'password'));
- }
- public function testCheckPasswordNoPassword() {
- $share = $this->createMock(IShare::class);
- $share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_LINK);
- $this->assertFalse($this->manager->checkPassword($share, 'password'));
- $share->method('getPassword')->willReturn('password');
- $this->assertFalse($this->manager->checkPassword($share, null));
- }
- public function testCheckPasswordInvalidPassword() {
- $share = $this->createMock(IShare::class);
- $share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_LINK);
- $share->method('getPassword')->willReturn('password');
- $this->hasher->method('verify')->with('invalidpassword', 'password', '')->willReturn(false);
- $this->assertFalse($this->manager->checkPassword($share, 'invalidpassword'));
- }
- public function testCheckPasswordValidPassword() {
- $share = $this->createMock(IShare::class);
- $share->method('getShareType')->willReturn(\OCP\Share::SHARE_TYPE_LINK);
- $share->method('getPassword')->willReturn('passwordHash');
- $this->hasher->method('verify')->with('password', 'passwordHash', '')->willReturn(true);
- $this->assertTrue($this->manager->checkPassword($share, 'password'));
- }
- public function testCheckPasswordUpdateShare() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_LINK)
- ->setPassword('passwordHash');
- $this->hasher->method('verify')->with('password', 'passwordHash', '')
- ->will($this->returnCallback(function($pass, $hash, &$newHash) {
- $newHash = 'newHash';
- return true;
- }));
- $this->defaultProvider->expects($this->once())
- ->method('update')
- ->with($this->callback(function (\OCP\Share\IShare $share) {
- return $share->getPassword() === 'newHash';
- }));
- $this->assertTrue($this->manager->checkPassword($share, 'password'));
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Can't change share type
- */
- public function testUpdateShareCantChangeShareType() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'getShareById'
- ])
- ->getMock();
- $originalShare = $this->manager->newShare();
- $originalShare->setShareType(\OCP\Share::SHARE_TYPE_GROUP);
- $manager->expects($this->once())->method('canShare')->willReturn(true);
- $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
- $share = $this->manager->newShare();
- $share->setProviderId('foo')
- ->setId('42')
- ->setShareType(\OCP\Share::SHARE_TYPE_USER);
- $manager->updateShare($share);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Can only update recipient on user shares
- */
- public function testUpdateShareCantChangeRecipientForGroupShare() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'getShareById'
- ])
- ->getMock();
- $originalShare = $this->manager->newShare();
- $originalShare->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setSharedWith('origGroup');
- $manager->expects($this->once())->method('canShare')->willReturn(true);
- $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
- $share = $this->manager->newShare();
- $share->setProviderId('foo')
- ->setId('42')
- ->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setSharedWith('newGroup');
- $manager->updateShare($share);
- }
- /**
- * @expectedException Exception
- * @expectedExceptionMessage Can't share with the share owner
- */
- public function testUpdateShareCantShareWithOwner() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'getShareById'
- ])
- ->getMock();
- $originalShare = $this->manager->newShare();
- $originalShare->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('sharedWith');
- $manager->expects($this->once())->method('canShare')->willReturn(true);
- $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
- $share = $this->manager->newShare();
- $share->setProviderId('foo')
- ->setId('42')
- ->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('newUser')
- ->setShareOwner('newUser');
- $manager->updateShare($share);
- }
- public function testUpdateShareUser() {
- $this->userManager->expects($this->any())->method('userExists')->willReturn(true);
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'getShareById',
- 'generalCreateChecks',
- 'userCreateChecks',
- 'pathCreateChecks',
- ])
- ->getMock();
- $originalShare = $this->manager->newShare();
- $originalShare->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('origUser')
- ->setPermissions(1);
- $node = $this->createMock(File::class);
- $node->method('getId')->willReturn(100);
- $node->method('getPath')->willReturn('/newUser/files/myPath');
- $manager->expects($this->once())->method('canShare')->willReturn(true);
- $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
- $share = $this->manager->newShare();
- $share->setProviderId('foo')
- ->setId('42')
- ->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setSharedWith('origUser')
- ->setShareOwner('newUser')
- ->setSharedBy('sharer')
- ->setPermissions(31)
- ->setNode($node);
- $this->defaultProvider->expects($this->once())
- ->method('update')
- ->with($share)
- ->willReturn($share);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListner, 'post');
- $hookListner->expects($this->never())->method('post');
- $this->rootFolder->method('getUserFolder')->with('newUser')->will($this->returnSelf());
- $this->rootFolder->method('getRelativePath')->with('/newUser/files/myPath')->willReturn('/myPath');
- $hookListner2 = $this->getMockBuilder('Dummy')->setMethods(['post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListner2, 'post');
- $hookListner2->expects($this->once())->method('post')->with([
- 'itemType' => 'file',
- 'itemSource' => 100,
- 'shareType' => \OCP\Share::SHARE_TYPE_USER,
- 'shareWith' => 'origUser',
- 'uidOwner' => 'sharer',
- 'permissions' => 31,
- 'path' => '/myPath',
- ]);
- $manager->updateShare($share);
- }
- public function testUpdateShareGroup() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'getShareById',
- 'generalCreateChecks',
- 'groupCreateChecks',
- 'pathCreateChecks',
- ])
- ->getMock();
- $originalShare = $this->manager->newShare();
- $originalShare->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setSharedWith('origUser')
- ->setPermissions(31);
- $manager->expects($this->once())->method('canShare')->willReturn(true);
- $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
- $node = $this->createMock(File::class);
- $share = $this->manager->newShare();
- $share->setProviderId('foo')
- ->setId('42')
- ->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setSharedWith('origUser')
- ->setShareOwner('owner')
- ->setNode($node)
- ->setPermissions(31);
- $this->defaultProvider->expects($this->once())
- ->method('update')
- ->with($share)
- ->willReturn($share);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListner, 'post');
- $hookListner->expects($this->never())->method('post');
- $hookListner2 = $this->getMockBuilder('Dummy')->setMethods(['post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListner2, 'post');
- $hookListner2->expects($this->never())->method('post');
- $manager->updateShare($share);
- }
- public function testUpdateShareLink() {
- $manager = $this->createManagerMock()
- ->setMethods([
- 'canShare',
- 'getShareById',
- 'generalCreateChecks',
- 'linkCreateChecks',
- 'pathCreateChecks',
- 'verifyPassword',
- 'validateExpirationDate',
- ])
- ->getMock();
- $originalShare = $this->manager->newShare();
- $originalShare->setShareType(\OCP\Share::SHARE_TYPE_LINK)
- ->setPermissions(15);
- $tomorrow = new \DateTime();
- $tomorrow->setTime(0,0,0);
- $tomorrow->add(new \DateInterval('P1D'));
- $file = $this->createMock(File::class);
- $file->method('getId')->willReturn(100);
- $share = $this->manager->newShare();
- $share->setProviderId('foo')
- ->setId('42')
- ->setShareType(\OCP\Share::SHARE_TYPE_LINK)
- ->setSharedBy('owner')
- ->setShareOwner('owner')
- ->setPassword('password')
- ->setExpirationDate($tomorrow)
- ->setNode($file)
- ->setPermissions(15);
- $manager->expects($this->once())->method('canShare')->willReturn(true);
- $manager->expects($this->once())->method('getShareById')->with('foo:42')->willReturn($originalShare);
- $manager->expects($this->once())->method('validateExpirationDate')->with($share);
- $this->defaultProvider->expects($this->once())
- ->method('update')
- ->with($share)
- ->willReturn($share);
- $hookListner = $this->getMockBuilder('Dummy')->setMethods(['post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'post_set_expiration_date', $hookListner, 'post');
- $hookListner->expects($this->once())->method('post')->with([
- 'itemType' => 'file',
- 'itemSource' => 100,
- 'date' => $tomorrow,
- 'uidOwner' => 'owner',
- ]);
- $hookListner2 = $this->getMockBuilder('Dummy')->setMethods(['post'])->getMock();
- \OCP\Util::connectHook('OCP\Share', 'post_update_permissions', $hookListner2, 'post');
- $hookListner2->expects($this->never())->method('post');
- $manager->updateShare($share);
- }
- /**
- * @expectedException \InvalidArgumentException
- * @expectedExceptionMessage Can't change target of link share
- */
- public function testMoveShareLink() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_LINK);
- $recipient = $this->createMock(IUser::class);
- $this->manager->moveShare($share, $recipient);
- }
- /**
- * @expectedException \InvalidArgumentException
- * @expectedExceptionMessage Invalid recipient
- */
- public function testMoveShareUserNotRecipient() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_USER);
- $share->setSharedWith('sharedWith');
- $this->manager->moveShare($share, 'recipient');
- }
- public function testMoveShareUser() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_USER)
- ->setId('42')
- ->setProviderId('foo');
- $share->setSharedWith('recipient');
- $this->defaultProvider->method('move')->with($share, 'recipient')->will($this->returnArgument(0));
- $this->manager->moveShare($share, 'recipient');
- }
- /**
- * @expectedException \InvalidArgumentException
- * @expectedExceptionMessage Invalid recipient
- */
- public function testMoveShareGroupNotRecipient() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_GROUP);
- $sharedWith = $this->createMock(IGroup::class);
- $share->setSharedWith('shareWith');
- $recipient = $this->createMock(IUser::class);
- $sharedWith->method('inGroup')->with($recipient)->willReturn(false);
- $this->groupManager->method('get')->with('shareWith')->willReturn($sharedWith);
- $this->userManager->method('get')->with('recipient')->willReturn($recipient);
- $this->manager->moveShare($share, 'recipient');
- }
- public function testMoveShareGroup() {
- $share = $this->manager->newShare();
- $share->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
- ->setId('42')
- ->setProviderId('foo');
- $group = $this->createMock(IGroup::class);
- $share->setSharedWith('group');
- $recipient = $this->createMock(IUser::class);
- $group->method('inGroup')->with($recipient)->willReturn(true);
- $this->groupManager->method('get')->with('group')->willReturn($group);
- $this->userManager->method('get')->with('recipient')->willReturn($recipient);
- $this->defaultProvider->method('move')->with($share, 'recipient')->will($this->returnArgument(0));
- $this->manager->moveShare($share, 'recipient');
- }
- }
- class DummyFactory implements IProviderFactory {
- /** @var IShareProvider */
- private $provider;
- public function __construct(\OCP\IServerContainer $serverContainer) {
- }
- /**
- * @param IShareProvider $provider
- */
- public function setProvider($provider) {
- $this->provider = $provider;
- }
- /**
- * @param string $id
- * @return IShareProvider
- */
- public function getProvider($id) {
- return $this->provider;
- }
- /**
- * @param int $shareType
- * @return IShareProvider
- */
- public function getProviderForType($shareType) {
- return $this->provider;
- }
- }
|