123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257 |
- <?php
- /**
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- *
- * @author Christoph Wurst <christoph@winzerhof-wurst.at>
- * @author Daniel Calviño Sánchez <danxuliu@gmail.com>
- * @author Daniel Kesselberg <mail@danielkesselberg.de>
- * @author Joas Schilling <coding@schilljs.com>
- * @author Morris Jobke <hey@morrisjobke.de>
- * @author Robin Appelman <robin@icewind.nl>
- * @author Roeland Jago Douma <roeland@famdouma.nl>
- * @author Thomas Müller <thomas.mueller@tmit.eu>
- * @author Vincent Petry <vincent@nextcloud.com>
- *
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
- */
- namespace OCA\DAV\Tests\unit\Connector\Sabre;
- use OC\AppFramework\Http\Request;
- use OC\Files\Filesystem;
- use OC\Files\Storage\Local;
- use OC\Files\Storage\Temporary;
- use OC\Files\Storage\Wrapper\PermissionsMask;
- use OC\Files\View;
- use OCA\DAV\Connector\Sabre\File;
- use OCP\Constants;
- use OCP\Files\FileInfo;
- use OCP\Files\ForbiddenException;
- use OCP\Files\Storage;
- use OCP\IConfig;
- use OCP\IRequestId;
- use OCP\Lock\ILockingProvider;
- use PHPUnit\Framework\MockObject\MockObject;
- use Test\HookHelper;
- use Test\TestCase;
- use Test\Traits\MountProviderTrait;
- use Test\Traits\UserTrait;
- /**
- * Class File
- *
- * @group DB
- *
- * @package OCA\DAV\Tests\unit\Connector\Sabre
- */
- class FileTest extends TestCase {
- use MountProviderTrait;
- use UserTrait;
- /**
- * @var string
- */
- private $user;
- /** @var IConfig|MockObject */
- protected $config;
- /** @var IRequestId|MockObject */
- protected $requestId;
- protected function setUp(): void {
- parent::setUp();
- unset($_SERVER['HTTP_OC_CHUNKED']);
- unset($_SERVER['CONTENT_LENGTH']);
- unset($_SERVER['REQUEST_METHOD']);
- \OC_Hook::clear();
- $this->user = 'test_user';
- $this->createUser($this->user, 'pass');
- $this->loginAsUser($this->user);
- $this->config = $this->createMock(IConfig::class);
- $this->requestId = $this->createMock(IRequestId::class);
- }
- protected function tearDown(): void {
- $userManager = \OC::$server->getUserManager();
- $userManager->get($this->user)->delete();
- unset($_SERVER['HTTP_OC_CHUNKED']);
- parent::tearDown();
- }
- /**
- * @return MockObject|Storage
- */
- private function getMockStorage() {
- $storage = $this->getMockBuilder(Storage::class)
- ->disableOriginalConstructor()
- ->getMock();
- $storage->method('getId')
- ->willReturn('home::someuser');
- return $storage;
- }
- /**
- * @param string $string
- */
- private function getStream($string) {
- $stream = fopen('php://temp', 'r+');
- fwrite($stream, $string);
- fseek($stream, 0);
- return $stream;
- }
- public function fopenFailuresProvider() {
- return [
- [
- // return false
- null,
- '\Sabre\Dav\Exception',
- false
- ],
- [
- new \OCP\Files\NotPermittedException(),
- 'Sabre\DAV\Exception\Forbidden'
- ],
- [
- new \OCP\Files\EntityTooLargeException(),
- 'OCA\DAV\Connector\Sabre\Exception\EntityTooLarge'
- ],
- [
- new \OCP\Files\InvalidContentException(),
- 'OCA\DAV\Connector\Sabre\Exception\UnsupportedMediaType'
- ],
- [
- new \OCP\Files\InvalidPathException(),
- 'Sabre\DAV\Exception\Forbidden'
- ],
- [
- new \OCP\Files\ForbiddenException('', true),
- 'OCA\DAV\Connector\Sabre\Exception\Forbidden'
- ],
- [
- new \OCP\Files\LockNotAcquiredException('/test.txt', 1),
- 'OCA\DAV\Connector\Sabre\Exception\FileLocked'
- ],
- [
- new \OCP\Lock\LockedException('/test.txt'),
- 'OCA\DAV\Connector\Sabre\Exception\FileLocked'
- ],
- [
- new \OCP\Encryption\Exceptions\GenericEncryptionException(),
- 'Sabre\DAV\Exception\ServiceUnavailable'
- ],
- [
- new \OCP\Files\StorageNotAvailableException(),
- 'Sabre\DAV\Exception\ServiceUnavailable'
- ],
- [
- new \Sabre\DAV\Exception('Generic sabre exception'),
- 'Sabre\DAV\Exception',
- false
- ],
- [
- new \Exception('Generic exception'),
- 'Sabre\DAV\Exception'
- ],
- ];
- }
- /**
- * @dataProvider fopenFailuresProvider
- */
- public function testSimplePutFails($thrownException, $expectedException, $checkPreviousClass = true): void {
- // setup
- $storage = $this->getMockBuilder(Local::class)
- ->setMethods(['writeStream'])
- ->setConstructorArgs([['datadir' => \OC::$server->getTempManager()->getTemporaryFolder()]])
- ->getMock();
- \OC\Files\Filesystem::mount($storage, [], $this->user . '/');
- /** @var View | MockObject $view */
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['getRelativePath', 'resolvePath'])
- ->getMock();
- $view->expects($this->atLeastOnce())
- ->method('resolvePath')
- ->willReturnCallback(
- function ($path) use ($storage) {
- return [$storage, $path];
- }
- );
- if ($thrownException !== null) {
- $storage->expects($this->once())
- ->method('writeStream')
- ->will($this->throwException($thrownException));
- } else {
- $storage->expects($this->once())
- ->method('writeStream')
- ->willReturn(0);
- }
- $view->expects($this->any())
- ->method('getRelativePath')
- ->willReturnArgument(0);
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $caughtException = null;
- try {
- $file->put('test data');
- } catch (\Exception $e) {
- $caughtException = $e;
- }
- $this->assertInstanceOf($expectedException, $caughtException);
- if ($checkPreviousClass) {
- $this->assertInstanceOf(get_class($thrownException), $caughtException->getPrevious());
- }
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- /**
- * Test putting a file using chunking
- *
- * @dataProvider fopenFailuresProvider
- */
- public function testChunkedPutFails($thrownException, $expectedException, $checkPreviousClass = false): void {
- // setup
- $storage = $this->getMockBuilder(Local::class)
- ->setMethods(['fopen'])
- ->setConstructorArgs([['datadir' => \OC::$server->getTempManager()->getTemporaryFolder()]])
- ->getMock();
- \OC\Files\Filesystem::mount($storage, [], $this->user . '/');
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['getRelativePath', 'resolvePath'])
- ->getMock();
- $view->expects($this->atLeastOnce())
- ->method('resolvePath')
- ->willReturnCallback(
- function ($path) use ($storage) {
- return [$storage, $path];
- }
- );
- if ($thrownException !== null) {
- $storage->expects($this->once())
- ->method('fopen')
- ->will($this->throwException($thrownException));
- } else {
- $storage->expects($this->once())
- ->method('fopen')
- ->willReturn(false);
- }
- $view->expects($this->any())
- ->method('getRelativePath')
- ->willReturnArgument(0);
- $_SERVER['HTTP_OC_CHUNKED'] = true;
- $info = new \OC\Files\FileInfo('/test.txt-chunking-12345-2-0', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // put first chunk
- $file->acquireLock(ILockingProvider::LOCK_SHARED);
- $this->assertNull($file->put('test data one'));
- $file->releaseLock(ILockingProvider::LOCK_SHARED);
- $info = new \OC\Files\FileInfo('/test.txt-chunking-12345-2-1', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $caughtException = null;
- try {
- // last chunk
- $file->acquireLock(ILockingProvider::LOCK_SHARED);
- $file->put('test data two');
- $file->releaseLock(ILockingProvider::LOCK_SHARED);
- } catch (\Exception $e) {
- $caughtException = $e;
- }
- $this->assertInstanceOf($expectedException, $caughtException);
- if ($checkPreviousClass) {
- $this->assertInstanceOf(get_class($thrownException), $caughtException->getPrevious());
- }
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- /**
- * Simulate putting a file to the given path.
- *
- * @param string $path path to put the file into
- * @param string $viewRoot root to use for the view
- * @param null|Request $request the HTTP request
- *
- * @return null|string of the PUT operation which is usually the etag
- */
- private function doPut($path, $viewRoot = null, Request $request = null) {
- $view = \OC\Files\Filesystem::getView();
- if (!is_null($viewRoot)) {
- $view = new \OC\Files\View($viewRoot);
- } else {
- $viewRoot = '/' . $this->user . '/files';
- }
- $info = new \OC\Files\FileInfo(
- $viewRoot . '/' . ltrim($path, '/'),
- $this->getMockStorage(),
- null,
- [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ],
- null
- );
- /** @var \OCA\DAV\Connector\Sabre\File | MockObject $file */
- $file = $this->getMockBuilder(\OCA\DAV\Connector\Sabre\File::class)
- ->setConstructorArgs([$view, $info, null, $request])
- ->setMethods(['header'])
- ->getMock();
- // beforeMethod locks
- $view->lockFile($path, ILockingProvider::LOCK_SHARED);
- $result = $file->put($this->getStream('test data'));
- // afterMethod unlocks
- $view->unlockFile($path, ILockingProvider::LOCK_SHARED);
- return $result;
- }
- /**
- * Test putting a single file
- */
- public function testPutSingleFile(): void {
- $this->assertNotEmpty($this->doPut('/foo.txt'));
- }
- public function legalMtimeProvider() {
- return [
- "string" => [
- 'HTTP_X_OC_MTIME' => "string",
- 'expected result' => null
- ],
- "castable string (int)" => [
- 'HTTP_X_OC_MTIME' => "987654321",
- 'expected result' => 987654321
- ],
- "castable string (float)" => [
- 'HTTP_X_OC_MTIME' => "123456789.56",
- 'expected result' => 123456789
- ],
- "float" => [
- 'HTTP_X_OC_MTIME' => 123456789.56,
- 'expected result' => 123456789
- ],
- "zero" => [
- 'HTTP_X_OC_MTIME' => 0,
- 'expected result' => null
- ],
- "zero string" => [
- 'HTTP_X_OC_MTIME' => "0",
- 'expected result' => null
- ],
- "negative zero string" => [
- 'HTTP_X_OC_MTIME' => "-0",
- 'expected result' => null
- ],
- "string starting with number following by char" => [
- 'HTTP_X_OC_MTIME' => "2345asdf",
- 'expected result' => null
- ],
- "string castable hex int" => [
- 'HTTP_X_OC_MTIME' => "0x45adf",
- 'expected result' => null
- ],
- "string that looks like invalid hex int" => [
- 'HTTP_X_OC_MTIME' => "0x123g",
- 'expected result' => null
- ],
- "negative int" => [
- 'HTTP_X_OC_MTIME' => -34,
- 'expected result' => null
- ],
- "negative float" => [
- 'HTTP_X_OC_MTIME' => -34.43,
- 'expected result' => null
- ],
- ];
- }
- /**
- * Test putting a file with string Mtime
- * @dataProvider legalMtimeProvider
- */
- public function testPutSingleFileLegalMtime($requestMtime, $resultMtime): void {
- $request = new Request([
- 'server' => [
- 'HTTP_X_OC_MTIME' => $requestMtime,
- ]
- ], $this->requestId, $this->config, null);
- $file = 'foo.txt';
- if ($resultMtime === null) {
- $this->expectException(\InvalidArgumentException::class);
- }
- $this->doPut($file, null, $request);
- if ($resultMtime !== null) {
- $this->assertEquals($resultMtime, $this->getFileInfos($file)['mtime']);
- }
- }
- /**
- * Test putting a file with string Mtime using chunking
- * @dataProvider legalMtimeProvider
- */
- public function testChunkedPutLegalMtime($requestMtime, $resultMtime): void {
- $request = new Request([
- 'server' => [
- 'HTTP_X_OC_MTIME' => $requestMtime,
- ]
- ], $this->requestId, $this->config, null);
- $_SERVER['HTTP_OC_CHUNKED'] = true;
- $file = 'foo.txt';
- if ($resultMtime === null) {
- $this->expectException(\Sabre\DAV\Exception::class);
- }
- $this->doPut($file.'-chunking-12345-2-0', null, $request);
- $this->doPut($file.'-chunking-12345-2-1', null, $request);
- if ($resultMtime !== null) {
- $this->assertEquals($resultMtime, $this->getFileInfos($file)['mtime']);
- }
- }
- /**
- * Test putting a file using chunking
- */
- public function testChunkedPut(): void {
- $_SERVER['HTTP_OC_CHUNKED'] = true;
- $this->assertNull($this->doPut('/test.txt-chunking-12345-2-0'));
- $this->assertNotEmpty($this->doPut('/test.txt-chunking-12345-2-1'));
- }
- /**
- * Test that putting a file triggers create hooks
- */
- public function testPutSingleFileTriggersHooks(): void {
- HookHelper::setUpHooks();
- $this->assertNotEmpty($this->doPut('/foo.txt'));
- $this->assertCount(4, HookHelper::$hookCalls);
- $this->assertHookCall(
- HookHelper::$hookCalls[0],
- Filesystem::signal_create,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[1],
- Filesystem::signal_write,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[2],
- Filesystem::signal_post_create,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[3],
- Filesystem::signal_post_write,
- '/foo.txt'
- );
- }
- /**
- * Test that putting a file triggers update hooks
- */
- public function testPutOverwriteFileTriggersHooks(): void {
- $view = \OC\Files\Filesystem::getView();
- $view->file_put_contents('/foo.txt', 'some content that will be replaced');
- HookHelper::setUpHooks();
- $this->assertNotEmpty($this->doPut('/foo.txt'));
- $this->assertCount(4, HookHelper::$hookCalls);
- $this->assertHookCall(
- HookHelper::$hookCalls[0],
- Filesystem::signal_update,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[1],
- Filesystem::signal_write,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[2],
- Filesystem::signal_post_update,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[3],
- Filesystem::signal_post_write,
- '/foo.txt'
- );
- }
- /**
- * Test that putting a file triggers hooks with the correct path
- * if the passed view was chrooted (can happen with public webdav
- * where the root is the share root)
- */
- public function testPutSingleFileTriggersHooksDifferentRoot(): void {
- $view = \OC\Files\Filesystem::getView();
- $view->mkdir('noderoot');
- HookHelper::setUpHooks();
- // happens with public webdav where the view root is the share root
- $this->assertNotEmpty($this->doPut('/foo.txt', '/' . $this->user . '/files/noderoot'));
- $this->assertCount(4, HookHelper::$hookCalls);
- $this->assertHookCall(
- HookHelper::$hookCalls[0],
- Filesystem::signal_create,
- '/noderoot/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[1],
- Filesystem::signal_write,
- '/noderoot/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[2],
- Filesystem::signal_post_create,
- '/noderoot/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[3],
- Filesystem::signal_post_write,
- '/noderoot/foo.txt'
- );
- }
- /**
- * Test that putting a file with chunks triggers create hooks
- */
- public function testPutChunkedFileTriggersHooks(): void {
- HookHelper::setUpHooks();
- $_SERVER['HTTP_OC_CHUNKED'] = true;
- $this->assertNull($this->doPut('/foo.txt-chunking-12345-2-0'));
- $this->assertNotEmpty($this->doPut('/foo.txt-chunking-12345-2-1'));
- $this->assertCount(4, HookHelper::$hookCalls);
- $this->assertHookCall(
- HookHelper::$hookCalls[0],
- Filesystem::signal_create,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[1],
- Filesystem::signal_write,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[2],
- Filesystem::signal_post_create,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[3],
- Filesystem::signal_post_write,
- '/foo.txt'
- );
- }
- /**
- * Test that putting a chunked file triggers update hooks
- */
- public function testPutOverwriteChunkedFileTriggersHooks(): void {
- $view = \OC\Files\Filesystem::getView();
- $view->file_put_contents('/foo.txt', 'some content that will be replaced');
- HookHelper::setUpHooks();
- $_SERVER['HTTP_OC_CHUNKED'] = true;
- $this->assertNull($this->doPut('/foo.txt-chunking-12345-2-0'));
- $this->assertNotEmpty($this->doPut('/foo.txt-chunking-12345-2-1'));
- $this->assertCount(4, HookHelper::$hookCalls);
- $this->assertHookCall(
- HookHelper::$hookCalls[0],
- Filesystem::signal_update,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[1],
- Filesystem::signal_write,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[2],
- Filesystem::signal_post_update,
- '/foo.txt'
- );
- $this->assertHookCall(
- HookHelper::$hookCalls[3],
- Filesystem::signal_post_write,
- '/foo.txt'
- );
- }
- public static function cancellingHook($params): void {
- self::$hookCalls[] = [
- 'signal' => Filesystem::signal_post_create,
- 'params' => $params
- ];
- }
- /**
- * Test put file with cancelled hook
- */
- public function testPutSingleFileCancelPreHook(): void {
- \OCP\Util::connectHook(
- Filesystem::CLASSNAME,
- Filesystem::signal_create,
- '\Test\HookHelper',
- 'cancellingCallback'
- );
- // action
- $thrown = false;
- try {
- $this->doPut('/foo.txt');
- } catch (\Sabre\DAV\Exception $e) {
- $thrown = true;
- }
- $this->assertTrue($thrown);
- $this->assertEmpty($this->listPartFiles(), 'No stray part files');
- }
- /**
- * Test exception when the uploaded size did not match
- */
- public function testSimplePutFailsSizeCheck(): void {
- // setup
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['rename', 'getRelativePath', 'filesize'])
- ->getMock();
- $view->expects($this->any())
- ->method('rename')
- ->withAnyParameters()
- ->willReturn(false);
- $view->expects($this->any())
- ->method('getRelativePath')
- ->willReturnArgument(0);
- $view->expects($this->any())
- ->method('filesize')
- ->willReturn(123456);
- $_SERVER['CONTENT_LENGTH'] = 123456;
- $_SERVER['REQUEST_METHOD'] = 'PUT';
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $thrown = false;
- try {
- // beforeMethod locks
- $file->acquireLock(ILockingProvider::LOCK_SHARED);
- $file->put($this->getStream('test data'));
- // afterMethod unlocks
- $file->releaseLock(ILockingProvider::LOCK_SHARED);
- } catch (\Sabre\DAV\Exception\BadRequest $e) {
- $thrown = true;
- }
- $this->assertTrue($thrown);
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- /**
- * Test exception during final rename in simple upload mode
- */
- public function testSimplePutFailsMoveFromStorage(): void {
- $view = new \OC\Files\View('/' . $this->user . '/files');
- // simulate situation where the target file is locked
- $view->lockFile('/test.txt', ILockingProvider::LOCK_EXCLUSIVE);
- $info = new \OC\Files\FileInfo('/' . $this->user . '/files/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $thrown = false;
- try {
- // beforeMethod locks
- $view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
- $file->put($this->getStream('test data'));
- // afterMethod unlocks
- $view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
- } catch (\OCA\DAV\Connector\Sabre\Exception\FileLocked $e) {
- $thrown = true;
- }
- $this->assertTrue($thrown);
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- /**
- * Test exception during final rename in chunk upload mode
- */
- public function testChunkedPutFailsFinalRename(): void {
- $view = new \OC\Files\View('/' . $this->user . '/files');
- // simulate situation where the target file is locked
- $view->lockFile('/test.txt', ILockingProvider::LOCK_EXCLUSIVE);
- $_SERVER['HTTP_OC_CHUNKED'] = true;
- $info = new \OC\Files\FileInfo('/' . $this->user . '/files/test.txt-chunking-12345-2-0', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- $file->acquireLock(ILockingProvider::LOCK_SHARED);
- $this->assertNull($file->put('test data one'));
- $file->releaseLock(ILockingProvider::LOCK_SHARED);
- $info = new \OC\Files\FileInfo('/' . $this->user . '/files/test.txt-chunking-12345-2-1', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $thrown = false;
- try {
- $file->acquireLock(ILockingProvider::LOCK_SHARED);
- $file->put($this->getStream('test data'));
- $file->releaseLock(ILockingProvider::LOCK_SHARED);
- } catch (\OCA\DAV\Connector\Sabre\Exception\FileLocked $e) {
- $thrown = true;
- }
- $this->assertTrue($thrown);
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- /**
- * Test put file with invalid chars
- */
- public function testSimplePutInvalidChars(): void {
- // setup
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['getRelativePath'])
- ->getMock();
- $view->expects($this->any())
- ->method('getRelativePath')
- ->willReturnArgument(0);
- $info = new \OC\Files\FileInfo('/*', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $thrown = false;
- try {
- // beforeMethod locks
- $view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
- $file->put($this->getStream('test data'));
- // afterMethod unlocks
- $view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
- } catch (\OCA\DAV\Connector\Sabre\Exception\InvalidPath $e) {
- $thrown = true;
- }
- $this->assertTrue($thrown);
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- /**
- * Test setting name with setName() with invalid chars
- *
- */
- public function testSetNameInvalidChars(): void {
- $this->expectException(\OCA\DAV\Connector\Sabre\Exception\InvalidPath::class);
- // setup
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['getRelativePath'])
- ->getMock();
- $view->expects($this->any())
- ->method('getRelativePath')
- ->willReturnArgument(0);
- $info = new \OC\Files\FileInfo('/*', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- $file->setName('/super*star.txt');
- }
- public function testUploadAbort(): void {
- // setup
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['rename', 'getRelativePath', 'filesize'])
- ->getMock();
- $view->expects($this->any())
- ->method('rename')
- ->withAnyParameters()
- ->willReturn(false);
- $view->expects($this->any())
- ->method('getRelativePath')
- ->willReturnArgument(0);
- $view->expects($this->any())
- ->method('filesize')
- ->willReturn(123456);
- $_SERVER['CONTENT_LENGTH'] = 12345;
- $_SERVER['REQUEST_METHOD'] = 'PUT';
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $thrown = false;
- try {
- // beforeMethod locks
- $view->lockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
- $file->put($this->getStream('test data'));
- // afterMethod unlocks
- $view->unlockFile($info->getPath(), ILockingProvider::LOCK_SHARED);
- } catch (\Sabre\DAV\Exception\BadRequest $e) {
- $thrown = true;
- }
- $this->assertTrue($thrown);
- $this->assertEmpty($this->listPartFiles($view, ''), 'No stray part files');
- }
- public function testDeleteWhenAllowed(): void {
- // setup
- $view = $this->getMockBuilder(View::class)
- ->getMock();
- $view->expects($this->once())
- ->method('unlink')
- ->willReturn(true);
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $file->delete();
- }
- public function testDeleteThrowsWhenDeletionNotAllowed(): void {
- $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
- // setup
- $view = $this->getMockBuilder(View::class)
- ->getMock();
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => 0,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $file->delete();
- }
- public function testDeleteThrowsWhenDeletionFailed(): void {
- $this->expectException(\Sabre\DAV\Exception\Forbidden::class);
- // setup
- $view = $this->getMockBuilder(View::class)
- ->getMock();
- // but fails
- $view->expects($this->once())
- ->method('unlink')
- ->willReturn(false);
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $file->delete();
- }
- public function testDeleteThrowsWhenDeletionThrows(): void {
- $this->expectException(\OCA\DAV\Connector\Sabre\Exception\Forbidden::class);
- // setup
- $view = $this->getMockBuilder(View::class)
- ->getMock();
- // but fails
- $view->expects($this->once())
- ->method('unlink')
- ->willThrowException(new ForbiddenException('', true));
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // action
- $file->delete();
- }
- /**
- * Asserts hook call
- *
- * @param array $callData hook call data to check
- * @param string $signal signal name
- * @param string $hookPath hook path
- */
- protected function assertHookCall($callData, $signal, $hookPath) {
- $this->assertEquals($signal, $callData['signal']);
- $params = $callData['params'];
- $this->assertEquals(
- $hookPath,
- $params[Filesystem::signal_param_path]
- );
- }
- /**
- * Test whether locks are set before and after the operation
- */
- public function testPutLocking(): void {
- $view = new \OC\Files\View('/' . $this->user . '/files/');
- $path = 'test-locking.txt';
- $info = new \OC\Files\FileInfo(
- '/' . $this->user . '/files/' . $path,
- $this->getMockStorage(),
- null,
- [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ],
- null
- );
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- $this->assertFalse(
- $this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_SHARED),
- 'File unlocked before put'
- );
- $this->assertFalse(
- $this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE),
- 'File unlocked before put'
- );
- $wasLockedPre = false;
- $wasLockedPost = false;
- $eventHandler = $this->getMockBuilder(\stdclass::class)
- ->setMethods(['writeCallback', 'postWriteCallback'])
- ->getMock();
- // both pre and post hooks might need access to the file,
- // so only shared lock is acceptable
- $eventHandler->expects($this->once())
- ->method('writeCallback')
- ->willReturnCallback(
- function () use ($view, $path, &$wasLockedPre): void {
- $wasLockedPre = $this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_SHARED);
- $wasLockedPre = $wasLockedPre && !$this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE);
- }
- );
- $eventHandler->expects($this->once())
- ->method('postWriteCallback')
- ->willReturnCallback(
- function () use ($view, $path, &$wasLockedPost): void {
- $wasLockedPost = $this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_SHARED);
- $wasLockedPost = $wasLockedPost && !$this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE);
- }
- );
- \OCP\Util::connectHook(
- Filesystem::CLASSNAME,
- Filesystem::signal_write,
- $eventHandler,
- 'writeCallback'
- );
- \OCP\Util::connectHook(
- Filesystem::CLASSNAME,
- Filesystem::signal_post_write,
- $eventHandler,
- 'postWriteCallback'
- );
- // beforeMethod locks
- $view->lockFile($path, ILockingProvider::LOCK_SHARED);
- $this->assertNotEmpty($file->put($this->getStream('test data')));
- // afterMethod unlocks
- $view->unlockFile($path, ILockingProvider::LOCK_SHARED);
- $this->assertTrue($wasLockedPre, 'File was locked during pre-hooks');
- $this->assertTrue($wasLockedPost, 'File was locked during post-hooks');
- $this->assertFalse(
- $this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_SHARED),
- 'File unlocked after put'
- );
- $this->assertFalse(
- $this->isFileLocked($view, $path, \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE),
- 'File unlocked after put'
- );
- }
- /**
- * Returns part files in the given path
- *
- * @param \OC\Files\View view which root is the current user's "files" folder
- * @param string $path path for which to list part files
- *
- * @return array list of part files
- */
- private function listPartFiles(\OC\Files\View $userView = null, $path = '') {
- if ($userView === null) {
- $userView = \OC\Files\Filesystem::getView();
- }
- $files = [];
- [$storage, $internalPath] = $userView->resolvePath($path);
- if ($storage instanceof Local) {
- $realPath = $storage->getSourcePath($internalPath);
- $dh = opendir($realPath);
- while (($file = readdir($dh)) !== false) {
- if (substr($file, strlen($file) - 5, 5) === '.part') {
- $files[] = $file;
- }
- }
- closedir($dh);
- }
- return $files;
- }
- /**
- * returns an array of file information filesize, mtime, filetype, mimetype
- *
- * @param string $path
- * @param View $userView
- * @return array
- */
- private function getFileInfos($path = '', View $userView = null) {
- if ($userView === null) {
- $userView = Filesystem::getView();
- }
- return [
- "filesize" => $userView->filesize($path),
- "mtime" => $userView->filemtime($path),
- "filetype" => $userView->filetype($path),
- "mimetype" => $userView->getMimeType($path)
- ];
- }
- public function testGetFopenFails(): void {
- $this->expectException(\Sabre\DAV\Exception\ServiceUnavailable::class);
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['fopen'])
- ->getMock();
- $view->expects($this->atLeastOnce())
- ->method('fopen')
- ->willReturn(false);
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FILE,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- $file->get();
- }
- public function testGetFopenThrows(): void {
- $this->expectException(\OCA\DAV\Connector\Sabre\Exception\Forbidden::class);
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['fopen'])
- ->getMock();
- $view->expects($this->atLeastOnce())
- ->method('fopen')
- ->willThrowException(new ForbiddenException('', true));
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FILE,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- $file->get();
- }
- public function testGetThrowsIfNoPermission(): void {
- $this->expectException(\Sabre\DAV\Exception\NotFound::class);
- $view = $this->getMockBuilder(View::class)
- ->setMethods(['fopen'])
- ->getMock();
- $view->expects($this->never())
- ->method('fopen');
- $info = new \OC\Files\FileInfo('/test.txt', $this->getMockStorage(), null, [
- 'permissions' => \OCP\Constants::PERMISSION_CREATE, // no read perm
- 'type' => FileInfo::TYPE_FOLDER,
- ], null);
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- $file->get();
- }
- public function testSimplePutNoCreatePermissions(): void {
- $this->logout();
- $storage = new Temporary([]);
- $storage->file_put_contents('file.txt', 'old content');
- $noCreateStorage = new PermissionsMask([
- 'storage' => $storage,
- 'mask' => Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE
- ]);
- $this->registerMount($this->user, $noCreateStorage, '/' . $this->user . '/files/root');
- $this->loginAsUser($this->user);
- $view = new View('/' . $this->user . '/files');
- $info = $view->getFileInfo('root/file.txt');
- $file = new File($view, $info);
- // beforeMethod locks
- $view->lockFile('root/file.txt', ILockingProvider::LOCK_SHARED);
- $file->put($this->getStream('new content'));
- // afterMethod unlocks
- $view->unlockFile('root/file.txt', ILockingProvider::LOCK_SHARED);
- $this->assertEquals('new content', $view->file_get_contents('root/file.txt'));
- }
- public function testPutLockExpired(): void {
- $view = new \OC\Files\View('/' . $this->user . '/files/');
- $path = 'test-locking.txt';
- $info = new \OC\Files\FileInfo(
- '/' . $this->user . '/files/' . $path,
- $this->getMockStorage(),
- null,
- [
- 'permissions' => \OCP\Constants::PERMISSION_ALL,
- 'type' => FileInfo::TYPE_FOLDER,
- ],
- null
- );
- $file = new \OCA\DAV\Connector\Sabre\File($view, $info);
- // don't lock before the PUT to simulate an expired shared lock
- $this->assertNotEmpty($file->put($this->getStream('test data')));
- // afterMethod unlocks
- $view->unlockFile($path, ILockingProvider::LOCK_SHARED);
- }
- }
|