ForwardedForHeaders.php 3.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104
  1. <?php
  2. declare(strict_types=1);
  3. /**
  4. * @copyright Copyright (c) 2023 Côme Chilliet <come.chilliet@nextcloud.com>
  5. *
  6. * @author Côme Chilliet <come.chilliet@nextcloud.com>
  7. *
  8. * @license GNU AGPL version 3 or any later version
  9. *
  10. * This program is free software: you can redistribute it and/or modify
  11. * it under the terms of the GNU Affero General Public License as
  12. * published by the Free Software Foundation, either version 3 of the
  13. * License, or (at your option) any later version.
  14. *
  15. * This program is distributed in the hope that it will be useful,
  16. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  17. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  18. * GNU Affero General Public License for more details.
  19. *
  20. * You should have received a copy of the GNU Affero General Public License
  21. * along with this program. If not, see <http://www.gnu.org/licenses/>.
  22. *
  23. */
  24. namespace OCA\Settings\SetupChecks;
  25. use OCP\IConfig;
  26. use OCP\IL10N;
  27. use OCP\IRequest;
  28. use OCP\IURLGenerator;
  29. use OCP\SetupCheck\ISetupCheck;
  30. use OCP\SetupCheck\SetupResult;
  31. class ForwardedForHeaders implements ISetupCheck {
  32. public function __construct(
  33. private IL10N $l10n,
  34. private IConfig $config,
  35. private IURLGenerator $urlGenerator,
  36. private IRequest $request,
  37. ) {
  38. }
  39. public function getCategory(): string {
  40. return 'security';
  41. }
  42. public function getName(): string {
  43. return $this->l10n->t('Forwarded for headers');
  44. }
  45. public function run(): SetupResult {
  46. $trustedProxies = $this->config->getSystemValue('trusted_proxies', []);
  47. $remoteAddress = $this->request->getHeader('REMOTE_ADDR');
  48. $detectedRemoteAddress = $this->request->getRemoteAddress();
  49. if (!\is_array($trustedProxies)) {
  50. return SetupResult::error($this->l10n->t('Your "trusted_proxies" setting is not correctly set, it should be an array.'));
  51. }
  52. foreach ($trustedProxies as $proxy) {
  53. $addressParts = explode('/', $proxy, 2);
  54. if (filter_var($addressParts[0], FILTER_VALIDATE_IP) === false || !ctype_digit($addressParts[1] ?? '24')) {
  55. return SetupResult::error(
  56. $this->l10n->t('Your "trusted_proxies" setting is not correctly set, it should be an array of IP addresses - optionally with range in CIDR notation.'),
  57. $this->urlGenerator->linkToDocs('admin-reverse-proxy'),
  58. );
  59. }
  60. }
  61. if (($remoteAddress === '') && ($detectedRemoteAddress === '')) {
  62. if (\OC::$CLI) {
  63. /* We were called from CLI */
  64. return SetupResult::info($this->l10n->t('Your remote address could not be determined.'));
  65. } else {
  66. /* Should never happen */
  67. return SetupResult::error($this->l10n->t('Your remote address could not be determined.'));
  68. }
  69. }
  70. if (empty($trustedProxies) && $this->request->getHeader('X-Forwarded-Host') !== '') {
  71. return SetupResult::error(
  72. $this->l10n->t('The reverse proxy header configuration is incorrect. This is a security issue and can allow an attacker to spoof their IP address as visible to the Nextcloud.'),
  73. $this->urlGenerator->linkToDocs('admin-reverse-proxy')
  74. );
  75. }
  76. if (\in_array($remoteAddress, $trustedProxies, true) && ($remoteAddress !== '127.0.0.1')) {
  77. if ($remoteAddress !== $detectedRemoteAddress) {
  78. /* Remote address was successfuly fixed */
  79. return SetupResult::success($this->l10n->t('Your IP address was resolved as %s', [$detectedRemoteAddress]));
  80. } else {
  81. return SetupResult::warning(
  82. $this->l10n->t('The reverse proxy header configuration is incorrect, or you are accessing Nextcloud from a trusted proxy. If not, this is a security issue and can allow an attacker to spoof their IP address as visible to the Nextcloud.'),
  83. $this->urlGenerator->linkToDocs('admin-reverse-proxy')
  84. );
  85. }
  86. }
  87. /* Either not enabled or working correctly */
  88. return SetupResult::success();
  89. }
  90. }