123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170 |
- <?php
- /**
- * ownCloud
- *
- * @author Robin Appelman
- * @copyright 2012 Robin Appelman icewind@owncloud.com
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU AFFERO GENERAL PUBLIC LICENSE for more details.
- *
- * You should have received a copy of the GNU Affero General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- *
- */
- namespace Test\Files\Storage;
- use OC\Files\Storage\Wrapper\Jail;
- use OC\Files\Storage\Wrapper\Wrapper;
- use OCP\Files\InvalidPathException;
- use PHPUnit\Framework\MockObject\MockObject;
- /**
- * Class CommonTest
- *
- * @group DB
- *
- * @package Test\Files\Storage
- */
- class CommonTest extends Storage {
- /**
- * @var string tmpDir
- */
- private $tmpDir;
- private array $invalidCharsBackup;
- protected function setUp(): void {
- parent::setUp();
- $this->tmpDir = \OC::$server->getTempManager()->getTemporaryFolder();
- $this->instance = new \OC\Files\Storage\CommonTest(['datadir' => $this->tmpDir]);
- $this->invalidCharsBackup = \OC::$server->getConfig()->getSystemValue('forbidden_chars', []);
- }
- protected function tearDown(): void {
- \OC_Helper::rmdirr($this->tmpDir);
- \OC::$server->getConfig()->setSystemValue('forbidden_chars', $this->invalidCharsBackup);
- parent::tearDown();
- }
- /**
- * @dataProvider dataVerifyPath
- */
- public function testVerifyPath(string $filename, array $additionalChars, bool $throws) {
- /** @var \OC\Files\Storage\CommonTest|MockObject $instance */
- $instance = $this->getMockBuilder(\OC\Files\Storage\CommonTest::class)
- ->onlyMethods(['copyFromStorage', 'rmdir', 'unlink'])
- ->setConstructorArgs([['datadir' => $this->tmpDir]])
- ->getMock();
- $instance->method('copyFromStorage')
- ->willThrowException(new \Exception('copy'));
- \OC::$server->getConfig()->setSystemValue('forbidden_chars', $additionalChars);
- if ($throws) {
- $this->expectException(InvalidPathException::class);
- } else {
- $this->expectNotToPerformAssertions();
- }
- $instance->verifyPath('/', $filename);
- }
- public function dataVerifyPath(): array {
- return [
- // slash is always forbidden
- 'invalid slash' => ['a/b.txt', [], true],
- // backslash is also forbidden
- 'invalid backslash' => ['a\\b.txt', [], true],
- // by default colon is not forbidden
- 'valid name' => ['a: b.txt', [], false],
- // colon can be added to the list of forbidden character
- 'invalid custom character' => ['a: b.txt', [':'], true],
- // make sure to not split the list entries as they migh contain Unicode sequences
- // in this example the "face in clouds" emoji contains the clouds emoji so only having clouds is ok
- 'valid unicode sequence' => ['🌫️.txt', ['😶🌫️'], false],
- // This is the reverse: clouds are forbidden -> so is also the face in the clouds emoji
- 'valid unicode sequence' => ['😶🌫️.txt', ['🌫️'], true],
- ];
- }
- public function testMoveFromStorageWrapped() {
- /** @var \OC\Files\Storage\CommonTest|MockObject $instance */
- $instance = $this->getMockBuilder(\OC\Files\Storage\CommonTest::class)
- ->onlyMethods(['copyFromStorage', 'rmdir', 'unlink'])
- ->setConstructorArgs([['datadir' => $this->tmpDir]])
- ->getMock();
- $instance->method('copyFromStorage')
- ->willThrowException(new \Exception('copy'));
- $source = new Wrapper([
- 'storage' => $instance,
- ]);
- $instance->file_put_contents('foo.txt', 'bar');
- $instance->moveFromStorage($source, 'foo.txt', 'bar.txt');
- $this->assertTrue($instance->file_exists('bar.txt'));
- }
- public function testMoveFromStorageJailed() {
- /** @var \OC\Files\Storage\CommonTest|MockObject $instance */
- $instance = $this->getMockBuilder(\OC\Files\Storage\CommonTest::class)
- ->onlyMethods(['copyFromStorage', 'rmdir', 'unlink'])
- ->setConstructorArgs([['datadir' => $this->tmpDir]])
- ->getMock();
- $instance->method('copyFromStorage')
- ->willThrowException(new \Exception('copy'));
- $source = new Jail([
- 'storage' => $instance,
- 'root' => 'foo'
- ]);
- $source = new Wrapper([
- 'storage' => $source
- ]);
- $instance->mkdir('foo');
- $instance->file_put_contents('foo/foo.txt', 'bar');
- $instance->moveFromStorage($source, 'foo.txt', 'bar.txt');
- $this->assertTrue($instance->file_exists('bar.txt'));
- }
- public function testMoveFromStorageNestedJail() {
- /** @var \OC\Files\Storage\CommonTest|MockObject $instance */
- $instance = $this->getMockBuilder(\OC\Files\Storage\CommonTest::class)
- ->onlyMethods(['copyFromStorage', 'rmdir', 'unlink'])
- ->setConstructorArgs([['datadir' => $this->tmpDir]])
- ->getMock();
- $instance->method('copyFromStorage')
- ->willThrowException(new \Exception('copy'));
- $source = new Jail([
- 'storage' => $instance,
- 'root' => 'foo'
- ]);
- $source = new Wrapper([
- 'storage' => $source
- ]);
- $source = new Jail([
- 'storage' => $source,
- 'root' => 'bar'
- ]);
- $source = new Wrapper([
- 'storage' => $source
- ]);
- $instance->mkdir('foo');
- $instance->mkdir('foo/bar');
- $instance->file_put_contents('foo/bar/foo.txt', 'bar');
- $instance->moveFromStorage($source, 'foo.txt', 'bar.txt');
- $this->assertTrue($instance->file_exists('bar.txt'));
- }
- }
|