12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279 |
- <?php
- /**
- * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
- * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
- * SPDX-License-Identifier: AGPL-3.0-or-later
- */
- namespace Test\AppFramework\Http;
- use OC\AppFramework\Http\Request;
- use OC\Security\CSRF\CsrfToken;
- use OC\Security\CSRF\CsrfTokenManager;
- use OCP\IConfig;
- use OCP\IRequestId;
- /**
- * Class RequestTest
- *
- * @package OC\AppFramework\Http
- */
- class RequestTest extends \Test\TestCase {
- /** @var string */
- protected $stream = 'fakeinput://data';
- /** @var IRequestId */
- protected $requestId;
- /** @var IConfig */
- protected $config;
- /** @var CsrfTokenManager */
- protected $csrfTokenManager;
- protected function setUp(): void {
- parent::setUp();
- if (in_array('fakeinput', stream_get_wrappers())) {
- stream_wrapper_unregister('fakeinput');
- }
- stream_wrapper_register('fakeinput', 'Test\AppFramework\Http\RequestStream');
- $this->requestId = $this->createMock(IRequestId::class);
- $this->config = $this->createMock(IConfig::class);
- $this->csrfTokenManager = $this->getMockBuilder(CsrfTokenManager::class)
- ->disableOriginalConstructor()
- ->getMock();
- }
- protected function tearDown(): void {
- stream_wrapper_unregister('fakeinput');
- parent::tearDown();
- }
- public function testRequestAccessors(): void {
- $vars = [
- 'get' => ['name' => 'John Q. Public', 'nickname' => 'Joey'],
- 'method' => 'GET',
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- // Countable
- $this->assertSame(2, count($request));
- // Array access
- $this->assertSame('Joey', $request['nickname']);
- // "Magic" accessors
- $this->assertSame('Joey', $request->{'nickname'});
- $this->assertTrue(isset($request['nickname']));
- $this->assertTrue(isset($request->{'nickname'}));
- $this->assertFalse(isset($request->{'flickname'}));
- // Only testing 'get', but same approach for post, files etc.
- $this->assertSame('Joey', $request->get['nickname']);
- // Always returns null if variable not set.
- $this->assertSame(null, $request->{'flickname'});
- }
- // urlParams has precedence over POST which has precedence over GET
- public function testPrecedence(): void {
- $vars = [
- 'get' => ['name' => 'John Q. Public', 'nickname' => 'Joey'],
- 'post' => ['name' => 'Jane Doe', 'nickname' => 'Janey'],
- 'urlParams' => ['user' => 'jw', 'name' => 'Johnny Weissmüller'],
- 'method' => 'GET'
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame(3, count($request));
- $this->assertSame('Janey', $request->{'nickname'});
- $this->assertSame('Johnny Weissmüller', $request->{'name'});
- }
- public function testImmutableArrayAccess(): void {
- $this->expectException(\RuntimeException::class);
- $vars = [
- 'get' => ['name' => 'John Q. Public', 'nickname' => 'Joey'],
- 'method' => 'GET'
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $request['nickname'] = 'Janey';
- }
- public function testImmutableMagicAccess(): void {
- $this->expectException(\RuntimeException::class);
- $vars = [
- 'get' => ['name' => 'John Q. Public', 'nickname' => 'Joey'],
- 'method' => 'GET'
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $request->{'nickname'} = 'Janey';
- }
- public function testGetTheMethodRight(): void {
- $this->expectException(\LogicException::class);
- $vars = [
- 'get' => ['name' => 'John Q. Public', 'nickname' => 'Joey'],
- 'method' => 'GET',
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $request->post;
- }
- public function testTheMethodIsRight(): void {
- $vars = [
- 'get' => ['name' => 'John Q. Public', 'nickname' => 'Joey'],
- 'method' => 'GET',
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('GET', $request->method);
- $result = $request->get;
- $this->assertSame('John Q. Public', $result['name']);
- $this->assertSame('Joey', $result['nickname']);
- }
- public function testJsonPost(): void {
- global $data;
- $data = '{"name": "John Q. Public", "nickname": "Joey"}';
- $vars = [
- 'method' => 'POST',
- 'server' => ['CONTENT_TYPE' => 'application/json; utf-8']
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('POST', $request->method);
- $result = $request->post;
- $this->assertSame('John Q. Public', $result['name']);
- $this->assertSame('Joey', $result['nickname']);
- $this->assertSame('Joey', $request->params['nickname']);
- $this->assertSame('Joey', $request['nickname']);
- }
- public function testScimJsonPost(): void {
- global $data;
- $data = '{"userName":"testusername", "displayName":"Example User"}';
- $vars = [
- 'method' => 'POST',
- 'server' => ['CONTENT_TYPE' => 'application/scim+json; utf-8']
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('POST', $request->method);
- $result = $request->post;
- $this->assertSame('testusername', $result['userName']);
- $this->assertSame('Example User', $result['displayName']);
- $this->assertSame('Example User', $request->params['displayName']);
- $this->assertSame('Example User', $request['displayName']);
- }
- public function testCustomJsonPost(): void {
- global $data;
- $data = '{"propertyA":"sometestvalue", "propertyB":"someothertestvalue"}';
- // Note: the content type used here is fictional and intended to check if the regex for JSON content types works fine
- $vars = [
- 'method' => 'POST',
- 'server' => ['CONTENT_TYPE' => 'application/custom-type+json; utf-8']
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('POST', $request->method);
- $result = $request->post;
- $this->assertSame('sometestvalue', $result['propertyA']);
- $this->assertSame('someothertestvalue', $result['propertyB']);
- }
- public function notJsonDataProvider() {
- return [
- ['this is not valid json'],
- ['"just a string"'],
- ['{"just a string"}'],
- ];
- }
- /**
- * @dataProvider notJsonDataProvider
- */
- public function testNotJsonPost($testData): void {
- global $data;
- $data = $testData;
- $vars = [
- 'method' => 'POST',
- 'server' => ['CONTENT_TYPE' => 'application/json; utf-8']
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertEquals('POST', $request->method);
- $result = $request->post;
- // ensure there's no error attempting to decode the content
- }
- public function testNotScimJsonPost(): void {
- global $data;
- $data = 'this is not valid scim json';
- $vars = [
- 'method' => 'POST',
- 'server' => ['CONTENT_TYPE' => 'application/scim+json; utf-8']
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertEquals('POST', $request->method);
- $result = $request->post;
- // ensure there's no error attempting to decode the content
- }
- public function testNotCustomJsonPost(): void {
- global $data;
- $data = 'this is not valid json';
- $vars = [
- 'method' => 'POST',
- 'server' => ['CONTENT_TYPE' => 'application/custom-type+json; utf-8']
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertEquals('POST', $request->method);
- $result = $request->post;
- // ensure there's no error attempting to decode the content
- }
- public function testPatch(): void {
- global $data;
- $data = http_build_query(['name' => 'John Q. Public', 'nickname' => 'Joey'], '', '&');
- $vars = [
- 'method' => 'PATCH',
- 'server' => ['CONTENT_TYPE' => 'application/x-www-form-urlencoded'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PATCH', $request->method);
- $result = $request->patch;
- $this->assertSame('John Q. Public', $result['name']);
- $this->assertSame('Joey', $result['nickname']);
- }
- public function testJsonPatchAndPut(): void {
- global $data;
- // PUT content
- $data = '{"name": "John Q. Public", "nickname": "Joey"}';
- $vars = [
- 'method' => 'PUT',
- 'server' => ['CONTENT_TYPE' => 'application/json; utf-8'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PUT', $request->method);
- $result = $request->put;
- $this->assertSame('John Q. Public', $result['name']);
- $this->assertSame('Joey', $result['nickname']);
- // PATCH content
- $data = '{"name": "John Q. Public", "nickname": null}';
- $vars = [
- 'method' => 'PATCH',
- 'server' => ['CONTENT_TYPE' => 'application/json; utf-8'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PATCH', $request->method);
- $result = $request->patch;
- $this->assertSame('John Q. Public', $result['name']);
- $this->assertSame(null, $result['nickname']);
- }
- public function testScimJsonPatchAndPut(): void {
- global $data;
- // PUT content
- $data = '{"userName": "sometestusername", "displayName": "Example User"}';
- $vars = [
- 'method' => 'PUT',
- 'server' => ['CONTENT_TYPE' => 'application/scim+json; utf-8'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PUT', $request->method);
- $result = $request->put;
- $this->assertSame('sometestusername', $result['userName']);
- $this->assertSame('Example User', $result['displayName']);
- // PATCH content
- $data = '{"userName": "sometestusername", "displayName": null}';
- $vars = [
- 'method' => 'PATCH',
- 'server' => ['CONTENT_TYPE' => 'application/scim+json; utf-8'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PATCH', $request->method);
- $result = $request->patch;
- $this->assertSame('sometestusername', $result['userName']);
- $this->assertSame(null, $result['displayName']);
- }
- public function testCustomJsonPatchAndPut(): void {
- global $data;
- // PUT content
- $data = '{"propertyA": "sometestvalue", "propertyB": "someothertestvalue"}';
- $vars = [
- 'method' => 'PUT',
- 'server' => ['CONTENT_TYPE' => 'application/custom-type+json; utf-8'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PUT', $request->method);
- $result = $request->put;
- $this->assertSame('sometestvalue', $result['propertyA']);
- $this->assertSame('someothertestvalue', $result['propertyB']);
- // PATCH content
- $data = '{"propertyA": "sometestvalue", "propertyB": null}';
- $vars = [
- 'method' => 'PATCH',
- 'server' => ['CONTENT_TYPE' => 'application/custom-type+json; utf-8'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PATCH', $request->method);
- $result = $request->patch;
- $this->assertSame('sometestvalue', $result['propertyA']);
- $this->assertSame(null, $result['propertyB']);
- }
- public function testPutStream(): void {
- global $data;
- $data = file_get_contents(__DIR__ . '/../../../data/testimage.png');
- $vars = [
- 'put' => $data,
- 'method' => 'PUT',
- 'server' => [
- 'CONTENT_TYPE' => 'image/png',
- 'CONTENT_LENGTH' => (string)strlen($data)
- ],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('PUT', $request->method);
- $resource = $request->put;
- $contents = stream_get_contents($resource);
- $this->assertSame($data, $contents);
- try {
- $resource = $request->put;
- } catch (\LogicException $e) {
- return;
- }
- $this->fail('Expected LogicException.');
- }
- public function testSetUrlParameters(): void {
- $vars = [
- 'post' => [],
- 'method' => 'POST',
- 'urlParams' => ['id' => '2'],
- ];
- $request = new Request(
- $vars,
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $newParams = ['id' => '3', 'test' => 'test2'];
- $request->setUrlParameters($newParams);
- $this->assertSame('test2', $request->getParam('test'));
- $this->assertEquals('3', $request->getParam('id'));
- $this->assertEquals('3', $request->getParams()['id']);
- }
- public function dataGetRemoteAddress(): array {
- return [
- 'IPv4 without trusted remote' => [
- [
- 'REMOTE_ADDR' => '10.0.0.2',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- [],
- [],
- '10.0.0.2',
- ],
- 'IPv4 without trusted headers' => [
- [
- 'REMOTE_ADDR' => '10.0.0.2',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['10.0.0.2'],
- [],
- '10.0.0.2',
- ],
- 'IPv4 with single trusted remote' => [
- [
- 'REMOTE_ADDR' => '10.0.0.2',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['10.0.0.2'],
- ['HTTP_X_FORWARDED'],
- '10.4.0.4',
- ],
- 'IPv6 with single trusted remote' => [
- [
- 'REMOTE_ADDR' => '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['2001:db8:85a3:8d3:1319:8a2e:370:7348'],
- ['HTTP_X_FORWARDED'],
- '10.4.0.4',
- ],
- 'IPv4 with multiple trusted remotes' => [
- [
- 'REMOTE_ADDR' => '10.0.0.2',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4, ::1',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['10.0.0.2', '::1'],
- ['HTTP_X_FORWARDED'],
- '10.4.0.4',
- ],
- 'IPv4 order of forwarded-for headers' => [
- [
- 'REMOTE_ADDR' => '10.0.0.2',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['10.0.0.2'],
- [
- 'HTTP_X_FORWARDED',
- 'HTTP_X_FORWARDED_FOR',
- 'HTTP_CLIENT_IP',
- ],
- '192.168.0.233',
- ],
- 'IPv4 order of forwarded-for headers (reversed)' => [
- [
- 'REMOTE_ADDR' => '10.0.0.2',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['10.0.0.2'],
- [
- 'HTTP_CLIENT_IP',
- 'HTTP_X_FORWARDED_FOR',
- 'HTTP_X_FORWARDED',
- ],
- '10.4.0.4',
- ],
- 'IPv6 order of forwarded-for headers' => [
- [
- 'REMOTE_ADDR' => '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['2001:db8:85a3:8d3:1319:8a2e:370:7348'],
- [
- 'HTTP_X_FORWARDED',
- 'HTTP_X_FORWARDED_FOR',
- 'HTTP_CLIENT_IP',
- ],
- '192.168.0.233',
- ],
- 'IPv4 matching CIDR of trusted proxy' => [
- [
- 'REMOTE_ADDR' => '192.168.3.99',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['192.168.2.0/24'],
- ['HTTP_X_FORWARDED_FOR'],
- '192.168.3.99',
- ],
- 'IPv6 matching CIDR of trusted proxy' => [
- [
- 'REMOTE_ADDR' => '2001:db8:85a3:8d3:1319:8a21:370:7348',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['2001:db8:85a3:8d3:1319:8a20::/95'],
- ['HTTP_X_FORWARDED_FOR'],
- '192.168.0.233',
- ],
- 'IPv6 not matching CIDR of trusted proxy' => [
- [
- 'REMOTE_ADDR' => '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['fd::/8'],
- [],
- '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- ],
- 'IPv6 with invalid trusted proxy' => [
- [
- 'REMOTE_ADDR' => '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- 'HTTP_X_FORWARDED' => '10.4.0.5, 10.4.0.4',
- 'HTTP_X_FORWARDED_FOR' => '192.168.0.233',
- ],
- ['fx::/8'],
- [],
- '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- ],
- 'IPv4 forwarded for IPv6' => [
- [
- 'REMOTE_ADDR' => '192.168.2.99',
- 'HTTP_X_FORWARDED_FOR' => '[2001:db8:85a3:8d3:1319:8a2e:370:7348]',
- ],
- ['192.168.2.0/24'],
- ['HTTP_X_FORWARDED_FOR'],
- '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- ],
- 'IPv4 with port' => [
- [
- 'REMOTE_ADDR' => '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- 'HTTP_X_FORWARDED_FOR' => '192.168.2.99:8080',
- ],
- ['2001:db8::/8'],
- ['HTTP_X_FORWARDED_FOR'],
- '192.168.2.99',
- ],
- 'IPv6 with port' => [
- [
- 'REMOTE_ADDR' => '192.168.2.99',
- 'HTTP_X_FORWARDED_FOR' => '[2001:db8:85a3:8d3:1319:8a2e:370:7348]:8080',
- ],
- ['192.168.2.0/24'],
- ['HTTP_X_FORWARDED_FOR'],
- '2001:db8:85a3:8d3:1319:8a2e:370:7348',
- ],
- ];
- }
- /**
- * @dataProvider dataGetRemoteAddress
- */
- public function testGetRemoteAddress(array $headers, array $trustedProxies, array $forwardedForHeaders, string $expected): void {
- $this->config
- ->method('getSystemValue')
- ->withConsecutive(
- ['trusted_proxies'],
- ['forwarded_for_headers'],
- )
- ->willReturnOnConsecutiveCalls(
- $trustedProxies,
- $forwardedForHeaders,
- );
- $request = new Request(
- [
- 'server' => $headers,
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getRemoteAddress());
- }
- /**
- * @return array
- */
- public function httpProtocolProvider() {
- return [
- // Valid HTTP 1.0
- ['HTTP/1.0', 'HTTP/1.0'],
- ['http/1.0', 'HTTP/1.0'],
- ['HTTp/1.0', 'HTTP/1.0'],
- // Valid HTTP 1.1
- ['HTTP/1.1', 'HTTP/1.1'],
- ['http/1.1', 'HTTP/1.1'],
- ['HTTp/1.1', 'HTTP/1.1'],
- // Valid HTTP 2.0
- ['HTTP/2', 'HTTP/2'],
- ['http/2', 'HTTP/2'],
- ['HTTp/2', 'HTTP/2'],
- // Invalid
- ['HTTp/394', 'HTTP/1.1'],
- ['InvalidProvider/1.1', 'HTTP/1.1'],
- [null, 'HTTP/1.1'],
- ['', 'HTTP/1.1'],
- ];
- }
- /**
- * @dataProvider httpProtocolProvider
- *
- * @param mixed $input
- * @param string $expected
- */
- public function testGetHttpProtocol($input, $expected): void {
- $request = new Request(
- [
- 'server' => [
- 'SERVER_PROTOCOL' => $input,
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getHttpProtocol());
- }
- public function testGetServerProtocolWithOverride(): void {
- $this->config
- ->expects($this->exactly(3))
- ->method('getSystemValueString')
- ->willReturnMap([
- ['overwriteprotocol', '', 'customProtocol'],
- ['overwritecondaddr', '', ''],
- ]);
- $request = new Request(
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('customProtocol', $request->getServerProtocol());
- }
- public function testGetServerProtocolWithProtoValid(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- }
- return $default;
- });
- $requestHttps = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_PROTO' => 'HtTpS',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $requestHttp = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_PROTO' => 'HTTp',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('https', $requestHttps->getServerProtocol());
- $this->assertSame('http', $requestHttp->getServerProtocol());
- }
- public function testGetServerProtocolWithHttpsServerValueOn(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTPS' => 'on'
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('https', $request->getServerProtocol());
- }
- public function testGetServerProtocolWithHttpsServerValueOff(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTPS' => 'off'
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('http', $request->getServerProtocol());
- }
- public function testGetServerProtocolWithHttpsServerValueEmpty(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTPS' => ''
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('http', $request->getServerProtocol());
- }
- public function testGetServerProtocolDefault(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- return $default;
- });
- $request = new Request(
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('http', $request->getServerProtocol());
- }
- public function testGetServerProtocolBehindLoadBalancers(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_PROTO' => 'https,http,http',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('https', $request->getServerProtocol());
- }
- /**
- * @dataProvider userAgentProvider
- * @param string $testAgent
- * @param array $userAgent
- * @param bool $matches
- */
- public function testUserAgent($testAgent, $userAgent, $matches): void {
- $request = new Request(
- [
- 'server' => [
- 'HTTP_USER_AGENT' => $testAgent,
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($matches, $request->isUserAgent($userAgent));
- }
- /**
- * @dataProvider userAgentProvider
- * @param string $testAgent
- * @param array $userAgent
- * @param bool $matches
- */
- public function testUndefinedUserAgent($testAgent, $userAgent, $matches): void {
- $request = new Request(
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertFalse($request->isUserAgent($userAgent));
- }
- /**
- * @return array
- */
- public function userAgentProvider() {
- return [
- [
- 'Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)',
- [
- Request::USER_AGENT_IE
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0',
- [
- Request::USER_AGENT_IE
- ],
- false,
- ],
- [
- 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36',
- [
- Request::USER_AGENT_CHROME
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/53.0.2785.143 Chrome/53.0.2785.143 Safari/537.36',
- [
- Request::USER_AGENT_CHROME
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (Linux; Android 4.4; Nexus 4 Build/KRT16S) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.59 Mobile Safari/537.36',
- [
- Request::USER_AGENT_ANDROID_MOBILE_CHROME
- ],
- true,
- ],
- [
- 'Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)',
- [
- Request::USER_AGENT_ANDROID_MOBILE_CHROME
- ],
- false,
- ],
- [
- 'Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)',
- [
- Request::USER_AGENT_IE,
- Request::USER_AGENT_ANDROID_MOBILE_CHROME,
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (Linux; Android 4.4; Nexus 4 Build/KRT16S) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.59 Mobile Safari/537.36',
- [
- Request::USER_AGENT_IE,
- Request::USER_AGENT_ANDROID_MOBILE_CHROME,
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0',
- [
- Request::USER_AGENT_FREEBOX
- ],
- false,
- ],
- [
- 'Mozilla/5.0',
- [
- Request::USER_AGENT_FREEBOX
- ],
- true,
- ],
- [
- 'Fake Mozilla/5.0',
- [
- Request::USER_AGENT_FREEBOX
- ],
- false,
- ],
- [
- 'Mozilla/5.0 (Android) ownCloud-android/2.0.0',
- [
- Request::USER_AGENT_CLIENT_ANDROID
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (Android) Nextcloud-android/2.0.0',
- [
- Request::USER_AGENT_CLIENT_ANDROID
- ],
- true,
- ],
- [
- 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.99 Safari/537.36 Vivaldi/2.9.1705.41',
- [
- Request::USER_AGENT_CHROME
- ],
- true
- ],
- [
- 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.38 Safari/537.36 Brave/75',
- [
- Request::USER_AGENT_CHROME
- ],
- true
- ],
- [
- 'Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 OPR/50.0.2762.67',
- [
- Request::USER_AGENT_CHROME
- ],
- true
- ]
- ];
- }
- public function dataMatchClientVersion(): array {
- return [
- [
- 'Mozilla/5.0 (Android) Nextcloud-android/3.24.1',
- Request::USER_AGENT_CLIENT_ANDROID,
- '3.24.1',
- ],
- [
- 'Mozilla/5.0 (iOS) Nextcloud-iOS/4.8.2',
- Request::USER_AGENT_CLIENT_IOS,
- '4.8.2',
- ],
- [
- 'Mozilla/5.0 (Windows) mirall/3.8.1',
- Request::USER_AGENT_CLIENT_DESKTOP,
- '3.8.1',
- ],
- [
- 'Mozilla/5.0 (Android) Nextcloud-Talk v17.10.0',
- Request::USER_AGENT_TALK_ANDROID,
- '17.10.0',
- ],
- [
- 'Mozilla/5.0 (iOS) Nextcloud-Talk v17.0.1',
- Request::USER_AGENT_TALK_IOS,
- '17.0.1',
- ],
- [
- 'Mozilla/5.0 (Windows) Nextcloud-Talk v0.6.0',
- Request::USER_AGENT_TALK_DESKTOP,
- '0.6.0',
- ],
- [
- 'Mozilla/5.0 (Windows) Nextcloud-Outlook v1.0.0',
- Request::USER_AGENT_OUTLOOK_ADDON,
- '1.0.0',
- ],
- [
- 'Mozilla/5.0 (Linux) Nextcloud-Thunderbird v1.0.0',
- Request::USER_AGENT_THUNDERBIRD_ADDON,
- '1.0.0',
- ],
- ];
- }
- /**
- * @dataProvider dataMatchClientVersion
- * @param string $testAgent
- * @param string $userAgent
- * @param string $version
- */
- public function testMatchClientVersion(string $testAgent, string $userAgent, string $version): void {
- preg_match($userAgent, $testAgent, $matches);
- $this->assertSame($version, $matches[1]);
- }
- public function testInsecureServerHostServerNameHeader(): void {
- $request = new Request(
- [
- 'server' => [
- 'SERVER_NAME' => 'from.server.name:8080',
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('from.server.name:8080', $request->getInsecureServerHost());
- }
- public function testInsecureServerHostHttpHostHeader(): void {
- $request = new Request(
- [
- 'server' => [
- 'SERVER_NAME' => 'from.server.name:8080',
- 'HTTP_HOST' => 'from.host.header:8080',
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('from.host.header:8080', $request->getInsecureServerHost());
- }
- public function testInsecureServerHostHttpFromForwardedHeaderSingle(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'SERVER_NAME' => 'from.server.name:8080',
- 'HTTP_HOST' => 'from.host.header:8080',
- 'HTTP_X_FORWARDED_HOST' => 'from.forwarded.host:8080',
- 'REMOTE_ADDR' => '1.2.3.4',
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('from.forwarded.host:8080', $request->getInsecureServerHost());
- }
- public function testInsecureServerHostHttpFromForwardedHeaderStacked(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'SERVER_NAME' => 'from.server.name:8080',
- 'HTTP_HOST' => 'from.host.header:8080',
- 'HTTP_X_FORWARDED_HOST' => 'from.forwarded.host2:8080,another.one:9000',
- 'REMOTE_ADDR' => '1.2.3.4',
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('from.forwarded.host2:8080', $request->getInsecureServerHost());
- }
- public function testGetServerHostWithOverwriteHost(): void {
- $this->config
- ->method('getSystemValueString')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'overwritecondaddr') {
- return '';
- } elseif ($key === 'overwritehost') {
- return 'my.overwritten.host';
- }
- return $default;
- });
- $request = new Request(
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('my.overwritten.host', $request->getServerHost());
- }
- public function testGetServerHostWithTrustedDomain(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- } elseif ($key === 'trusted_domains') {
- return ['my.trusted.host'];
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_HOST' => 'my.trusted.host',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('my.trusted.host', $request->getServerHost());
- }
- public function testGetServerHostWithUntrustedDomain(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- } elseif ($key === 'trusted_domains') {
- return ['my.trusted.host'];
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_HOST' => 'my.untrusted.host',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('my.trusted.host', $request->getServerHost());
- }
- public function testGetServerHostWithNoTrustedDomain(): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_HOST' => 'my.untrusted.host',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('', $request->getServerHost());
- }
- /**
- * @return array
- */
- public function dataGetServerHostTrustedDomain() {
- return [
- 'is array' => ['my.trusted.host', ['my.trusted.host']],
- 'is array but undefined index 0' => ['my.trusted.host', [2 => 'my.trusted.host']],
- 'is string' => ['my.trusted.host', 'my.trusted.host'],
- 'is null' => ['', null],
- ];
- }
- /**
- * @dataProvider dataGetServerHostTrustedDomain
- * @param $expected
- * @param $trustedDomain
- */
- public function testGetServerHostTrustedDomain($expected, $trustedDomain): void {
- $this->config
- ->method('getSystemValue')
- ->willReturnCallback(function ($key, $default) use ($trustedDomain) {
- if ($key === 'trusted_proxies') {
- return ['1.2.3.4'];
- }
- if ($key === 'trusted_domains') {
- return $trustedDomain;
- }
- return $default;
- });
- $request = new Request(
- [
- 'server' => [
- 'HTTP_X_FORWARDED_HOST' => 'my.untrusted.host',
- 'REMOTE_ADDR' => '1.2.3.4',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getServerHost());
- }
- public function testGetOverwriteHostDefaultNull(): void {
- $this->config
- ->expects($this->once())
- ->method('getSystemValueString')
- ->with('overwritehost')
- ->willReturn('');
- $request = new Request(
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertNull(self::invokePrivate($request, 'getOverwriteHost'));
- }
- public function testGetOverwriteHostWithOverwrite(): void {
- $this->config
- ->expects($this->exactly(3))
- ->method('getSystemValueString')
- ->willReturnMap([
- ['overwritehost', '', 'www.owncloud.org'],
- ['overwritecondaddr', '', ''],
- ]);
- $request = new Request(
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('www.owncloud.org', self::invokePrivate($request, 'getOverwriteHost'));
- }
- public function testGetPathInfoNotProcessible(): void {
- $this->expectException(\Exception::class);
- $this->expectExceptionMessage('The requested uri(/foo.php) cannot be processed by the script \'/var/www/index.php\')');
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => '/foo.php',
- 'SCRIPT_NAME' => '/var/www/index.php',
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $request->getPathInfo();
- }
- public function testGetRawPathInfoNotProcessible(): void {
- $this->expectException(\Exception::class);
- $this->expectExceptionMessage('The requested uri(/foo.php) cannot be processed by the script \'/var/www/index.php\')');
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => '/foo.php',
- 'SCRIPT_NAME' => '/var/www/index.php',
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $request->getRawPathInfo();
- }
- /**
- * @dataProvider genericPathInfoProvider
- * @param string $requestUri
- * @param string $scriptName
- * @param string $expected
- */
- public function testGetPathInfoWithoutSetEnvGeneric($requestUri, $scriptName, $expected): void {
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => $requestUri,
- 'SCRIPT_NAME' => $scriptName,
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getPathInfo());
- }
- /**
- * @dataProvider genericPathInfoProvider
- * @param string $requestUri
- * @param string $scriptName
- * @param string $expected
- */
- public function testGetRawPathInfoWithoutSetEnvGeneric($requestUri, $scriptName, $expected): void {
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => $requestUri,
- 'SCRIPT_NAME' => $scriptName,
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getRawPathInfo());
- }
- /**
- * @dataProvider rawPathInfoProvider
- * @param string $requestUri
- * @param string $scriptName
- * @param string $expected
- */
- public function testGetRawPathInfoWithoutSetEnv($requestUri, $scriptName, $expected): void {
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => $requestUri,
- 'SCRIPT_NAME' => $scriptName,
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getRawPathInfo());
- }
- /**
- * @dataProvider pathInfoProvider
- * @param string $requestUri
- * @param string $scriptName
- * @param string $expected
- */
- public function testGetPathInfoWithoutSetEnv($requestUri, $scriptName, $expected): void {
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => $requestUri,
- 'SCRIPT_NAME' => $scriptName,
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame($expected, $request->getPathInfo());
- }
- /**
- * @return array
- */
- public function genericPathInfoProvider() {
- return [
- ['/core/index.php?XDEBUG_SESSION_START=14600', '/core/index.php', ''],
- ['/index.php/apps/files/', 'index.php', '/apps/files/'],
- ['/index.php/apps/files/../&/&?someQueryParameter=QueryParam', 'index.php', '/apps/files/../&/&'],
- ['/remote.php/漢字編碼方法 / 汉字编码方法', 'remote.php', '/漢字編碼方法 / 汉字编码方法'],
- ['///removeTrailin//gSlashes///', 'remote.php', '/removeTrailin/gSlashes/'],
- ['/', '/', ''],
- ['', '', ''],
- ];
- }
- /**
- * @return array
- */
- public function rawPathInfoProvider() {
- return [
- ['/foo%2Fbar/subfolder', '', 'foo%2Fbar/subfolder'],
- ];
- }
- /**
- * @return array
- */
- public function pathInfoProvider() {
- return [
- ['/foo%2Fbar/subfolder', '', 'foo/bar/subfolder'],
- ];
- }
- public function testGetRequestUriWithoutOverwrite(): void {
- $this->config
- ->expects($this->once())
- ->method('getSystemValueString')
- ->with('overwritewebroot')
- ->willReturn('');
- $request = new Request(
- [
- 'server' => [
- 'REQUEST_URI' => '/test.php'
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- );
- $this->assertSame('/test.php', $request->getRequestUri());
- }
- public function providesGetRequestUriWithOverwriteData() {
- return [
- ['/scriptname.php/some/PathInfo', '/owncloud/', ''],
- ['/scriptname.php/some/PathInfo', '/owncloud/', '123', '123.123.123.123'],
- ];
- }
- /**
- * @dataProvider providesGetRequestUriWithOverwriteData
- */
- public function testGetRequestUriWithOverwrite($expectedUri, $overwriteWebRoot, $overwriteCondAddr, $remoteAddr = ''): void {
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueString')
- ->willReturnMap([
- ['overwritewebroot', '', $overwriteWebRoot],
- ['overwritecondaddr', '', $overwriteCondAddr],
- ]);
- $request = $this->getMockBuilder(Request::class)
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'REQUEST_URI' => '/test.php/some/PathInfo',
- 'SCRIPT_NAME' => '/test.php',
- 'REMOTE_ADDR' => $remoteAddr
- ]
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $request
- ->expects($this->once())
- ->method('getScriptName')
- ->willReturn('/scriptname.php');
- $this->assertSame($expectedUri, $request->getRequestUri());
- }
- public function testPassesCSRFCheckWithGet(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'get' => [
- 'requesttoken' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- 'nc_sameSiteCookiestrict' => 'true',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $token = new CsrfToken('AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds');
- $this->csrfTokenManager
- ->expects($this->once())
- ->method('isTokenValid')
- ->with($token)
- ->willReturn(true);
- $this->assertTrue($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithPost(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'post' => [
- 'requesttoken' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- 'nc_sameSiteCookiestrict' => 'true',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $token = new CsrfToken('AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds');
- $this->csrfTokenManager
- ->expects($this->once())
- ->method('isTokenValid')
- ->with($token)
- ->willReturn(true);
- $this->assertTrue($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithHeader(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- 'nc_sameSiteCookiestrict' => 'true',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $token = new CsrfToken('AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds');
- $this->csrfTokenManager
- ->expects($this->once())
- ->method('isTokenValid')
- ->with($token)
- ->willReturn(true);
- $this->assertTrue($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithGetAndWithoutCookies(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'get' => [
- 'requesttoken' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->csrfTokenManager
- ->expects($this->once())
- ->method('isTokenValid')
- ->willReturn(true);
- $this->assertTrue($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithPostAndWithoutCookies(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'post' => [
- 'requesttoken' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->csrfTokenManager
- ->expects($this->once())
- ->method('isTokenValid')
- ->willReturn(true);
- $this->assertTrue($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithHeaderAndWithoutCookies(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->csrfTokenManager
- ->expects($this->once())
- ->method('isTokenValid')
- ->willReturn(true);
- $this->assertTrue($request->passesCSRFCheck());
- }
- public function testFailsCSRFCheckWithHeaderAndNotAllChecksPassing(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookiestrict' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->csrfTokenManager
- ->expects($this->never())
- ->method('isTokenValid');
- $this->assertFalse($request->passesCSRFCheck());
- }
- public function testPassesStrictCookieCheckWithAllCookiesAndStrict(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName', 'getCookieParams'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- '__Host-nc_sameSiteCookiestrict' => 'true',
- '__Host-nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $request
- ->expects($this->any())
- ->method('getCookieParams')
- ->willReturn([
- 'secure' => true,
- 'path' => '/',
- ]);
- $this->assertTrue($request->passesStrictCookieCheck());
- }
- public function testFailsStrictCookieCheckWithAllCookiesAndMissingStrict(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName', 'getCookieParams'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookiestrict' => 'true',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $request
- ->expects($this->any())
- ->method('getCookieParams')
- ->willReturn([
- 'secure' => true,
- 'path' => '/',
- ]);
- $this->assertFalse($request->passesStrictCookieCheck());
- }
- public function testGetCookieParams(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder(Request::class)
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $actual = $request->getCookieParams();
- $this->assertSame(session_get_cookie_params(), $actual);
- }
- public function testPassesStrictCookieCheckWithAllCookies(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookiestrict' => 'true',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertTrue($request->passesStrictCookieCheck());
- }
- public function testPassesStrictCookieCheckWithRandomCookies(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- 'RandomCookie' => 'asdf',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertTrue($request->passesStrictCookieCheck());
- }
- public function testFailsStrictCookieCheckWithSessionCookie(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertFalse($request->passesStrictCookieCheck());
- }
- public function testFailsStrictCookieCheckWithRememberMeCookie(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- 'nc_token' => 'asdf',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertFalse($request->passesStrictCookieCheck());
- }
- public function testFailsCSRFCheckWithPostAndWithCookies(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'post' => [
- 'requesttoken' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'foo' => 'bar',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->csrfTokenManager
- ->expects($this->never())
- ->method('isTokenValid');
- $this->assertFalse($request->passesCSRFCheck());
- }
- public function testFailStrictCookieCheckWithOnlyLaxCookie(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertFalse($request->passesStrictCookieCheck());
- }
- public function testFailStrictCookieCheckWithOnlyStrictCookie(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookiestrict' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertFalse($request->passesStrictCookieCheck());
- }
- public function testPassesLaxCookieCheck(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookielax' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertTrue($request->passesLaxCookieCheck());
- }
- public function testFailsLaxCookieCheckWithOnlyStrictCookie(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookiestrict' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertFalse($request->passesLaxCookieCheck());
- }
- public function testSkipCookieCheckForOCSRequests(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => 'AAAHGxsTCTc3BgMQESAcNR0OAR0=:MyTotalSecretShareds',
- 'HTTP_OCS_APIREQUEST' => 'true',
- ],
- 'cookies' => [
- session_name() => 'asdf',
- 'nc_sameSiteCookiestrict' => 'false',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertTrue($request->passesStrictCookieCheck());
- }
- /**
- * @return array
- */
- public function invalidTokenDataProvider() {
- return [
- ['InvalidSentToken'],
- ['InvalidSentToken:InvalidSecret'],
- [''],
- ];
- }
- /**
- * @dataProvider invalidTokenDataProvider
- * @param string $invalidToken
- */
- public function testPassesCSRFCheckWithInvalidToken($invalidToken): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_REQUESTTOKEN' => $invalidToken,
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $token = new CsrfToken($invalidToken);
- $this->csrfTokenManager
- ->expects($this->any())
- ->method('isTokenValid')
- ->with($token)
- ->willReturn(false);
- $this->assertFalse($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithoutTokenFail(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertFalse($request->passesCSRFCheck());
- }
- public function testPassesCSRFCheckWithOCSAPIRequestHeader(): void {
- /** @var Request $request */
- $request = $this->getMockBuilder('\OC\AppFramework\Http\Request')
- ->setMethods(['getScriptName'])
- ->setConstructorArgs([
- [
- 'server' => [
- 'HTTP_OCS_APIREQUEST' => 'true',
- ],
- ],
- $this->requestId,
- $this->config,
- $this->csrfTokenManager,
- $this->stream
- ])
- ->getMock();
- $this->assertTrue($request->passesCSRFCheck());
- }
- }
|