123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425 |
- <?php
- /**
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- *
- * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
- * @author Christoph Wurst <christoph@winzerhof-wurst.at>
- * @author Joas Schilling <coding@schilljs.com>
- * @author Morris Jobke <hey@morrisjobke.de>
- * @author Roeland Jago Douma <roeland@famdouma.nl>
- * @author Thomas Müller <thomas.mueller@tmit.eu>
- * @author Victor Dubiniuk <dubiniuk@owncloud.com>
- * @author Vincent Petry <vincent@nextcloud.com>
- * @author Vinicius Cubas Brand <vinicius@eita.org.br>
- * @author Xuanwo <xuanwo@yunify.com>
- *
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
- */
- namespace OCA\User_LDAP\Tests;
- use OCA\User_LDAP\Access;
- use OCA\User_LDAP\Connection;
- use OCA\User_LDAP\Group_LDAP as GroupLDAP;
- use OCA\User_LDAP\GroupPluginManager;
- use OCA\User_LDAP\ILDAPWrapper;
- use OCA\User_LDAP\Mapping\GroupMapping;
- use OCA\User_LDAP\User\Manager;
- use OCA\User_LDAP\User\OfflineUser;
- use OCA\User_LDAP\User\User;
- use OCA\User_LDAP\User_Proxy;
- use OCP\GroupInterface;
- use OCP\IConfig;
- use OCP\IUser;
- use OCP\IUserManager;
- use PHPUnit\Framework\MockObject\MockObject;
- use Test\TestCase;
- /**
- * Class GroupLDAPTest
- *
- * @group DB
- *
- * @package OCA\User_LDAP\Tests
- */
- class Group_LDAPTest extends TestCase {
- private MockObject|Access $access;
- private MockObject|GroupPluginManager $pluginManager;
- private MockObject|IConfig $config;
- private MockObject|IUserManager $ncUserManager;
- private GroupLDAP $groupBackend;
- public function setUp(): void {
- parent::setUp();
- $this->access = $this->getAccessMock();
- $this->pluginManager = $this->createMock(GroupPluginManager::class);
- $this->config = $this->createMock(IConfig::class);
- $this->ncUserManager = $this->createMock(IUserManager::class);
- }
- public function initBackend(): void {
- $this->groupBackend = new GroupLDAP($this->access, $this->pluginManager, $this->config, $this->ncUserManager);
- }
- public function testCountEmptySearchString() {
- $groupDN = 'cn=group,dc=foo,dc=bar';
- $this->enableGroups();
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturn($groupDN);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturnCallback(function ($dn) use ($groupDN) {
- if ($dn === $groupDN) {
- return [
- 'uid=u11,ou=users,dc=foo,dc=bar',
- 'uid=u22,ou=users,dc=foo,dc=bar',
- 'uid=u33,ou=users,dc=foo,dc=bar',
- 'uid=u34,ou=users,dc=foo,dc=bar'
- ];
- }
- return [];
- });
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- // for primary groups
- $this->access->expects($this->once())
- ->method('countUsers')
- ->willReturn(2);
- $this->access->userManager->expects($this->any())
- ->method('getAttributes')
- ->willReturn(['displayName', 'mail']);
- $this->initBackend();
- $users = $this->groupBackend->countUsersInGroup('group');
- $this->assertSame(6, $users);
- }
- /**
- * @return MockObject|Access
- */
- private function getAccessMock() {
- static $conMethods;
- static $accMethods;
- if (is_null($conMethods) || is_null($accMethods)) {
- $conMethods = get_class_methods(Connection::class);
- $accMethods = get_class_methods(Access::class);
- }
- $lw = $this->createMock(ILDAPWrapper::class);
- $connector = $this->getMockBuilder(Connection::class)
- ->setMethods($conMethods)
- ->setConstructorArgs([$lw, '', null])
- ->getMock();
- $this->access = $this->createMock(Access::class);
- $this->access->connection = $connector;
- $this->access->userManager = $this->createMock(Manager::class);
- return $this->access;
- }
- private function enableGroups() {
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function ($name) {
- if ($name === 'ldapDynamicGroupMemberURL') {
- return '';
- } elseif ($name === 'ldapBaseGroups') {
- return [];
- }
- return 1;
- });
- }
- public function testCountWithSearchString() {
- $this->enableGroups();
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturn('cn=group,dc=foo,dc=bar');
- $this->access->expects($this->any())
- ->method('fetchListOfUsers')
- ->willReturn([]);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturnCallback(function ($name) {
- //the search operation will call readAttribute, thus we need
- //to analyze the "dn". All other times we just need to return
- //something that is neither null or false, but once an array
- //with the users in the group – so we do so all other times for
- //simplicicity.
- if (strpos($name, 'u') === 0) {
- return strpos($name, '3');
- }
- return ['u11', 'u22', 'u33', 'u34'];
- });
- $this->access->expects($this->any())
- ->method('dn2username')
- ->willReturnCallback(function () {
- return 'foobar' . \OC::$server->getSecureRandom()->generate(7);
- });
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- $this->access->expects($this->any())
- ->method('escapeFilterPart')
- ->willReturnArgument(0);
- $this->access->userManager->expects($this->any())
- ->method('getAttributes')
- ->willReturn(['displayName', 'mail']);
- $this->initBackend();
- $users = $this->groupBackend->countUsersInGroup('group', '3');
- $this->assertSame(2, $users);
- }
- public function testCountUsersWithPlugin() {
- /** @var GroupPluginManager|MockObject $pluginManager */
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'countUsersInGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::COUNT_USERS)
- ->willReturn(true);
- $this->pluginManager->expects($this->once())
- ->method('countUsersInGroup')
- ->with('gid', 'search')
- ->willReturn(42);
- $this->initBackend();
- $this->assertEquals($this->groupBackend->countUsersInGroup('gid', 'search'), 42);
- }
- public function testGidNumber2NameSuccess() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('searchGroups')
- ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
- $this->access->expects($this->once())
- ->method('dn2groupname')
- ->with('cn=foo,dc=barfoo,dc=bar')
- ->willReturn('MyGroup');
- $this->initBackend();
- $group = $this->groupBackend->gidNumber2Name('3117', $userDN);
- $this->assertSame('MyGroup', $group);
- }
- public function testGidNumberID2NameNoGroup() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('searchGroups')
- ->willReturn([]);
- $this->access->expects($this->never())
- ->method('dn2groupname');
- $this->initBackend();
- $group = $this->groupBackend->gidNumber2Name('3117', $userDN);
- $this->assertSame(false, $group);
- }
- public function testGidNumberID2NameNoName() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('searchGroups')
- ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
- $this->access->expects($this->once())
- ->method('dn2groupname')
- ->willReturn(false);
- $this->initBackend();
- $group = $this->groupBackend->gidNumber2Name('3117', $userDN);
- $this->assertSame(false, $group);
- }
- public function testGetEntryGidNumberValue() {
- $this->enableGroups();
- $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
- $attr = 'gidNumber';
- $this->access->expects($this->once())
- ->method('readAttribute')
- ->with($dn, $attr)
- ->willReturn(['3117']);
- $this->initBackend();
- $gid = $this->groupBackend->getGroupGidNumber($dn);
- $this->assertSame('3117', $gid);
- }
- public function testGetEntryGidNumberNoValue() {
- $this->enableGroups();
- $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
- $attr = 'gidNumber';
- $this->access->expects($this->once())
- ->method('readAttribute')
- ->with($dn, $attr)
- ->willReturn(false);
- $this->initBackend();
- $gid = $this->groupBackend->getGroupGidNumber($dn);
- $this->assertSame(false, $gid);
- }
- public function testPrimaryGroupID2NameSuccessCache() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $gid = '3117';
- /** @var MockObject $connection */
- $connection = $this->access->connection;
- $connection->expects($this->once())
- ->method('getFromCache')
- ->with('primaryGroupIDtoName_' . $gid)
- ->willReturn('MyGroup');
- $this->access->expects($this->never())
- ->method('getSID');
- $this->access->expects($this->never())
- ->method('searchGroups');
- $this->access->expects($this->never())
- ->method('dn2groupname');
- $this->initBackend();
- $group = $this->groupBackend->primaryGroupID2Name($gid, $userDN);
- $this->assertSame('MyGroup', $group);
- }
- public function testPrimaryGroupID2NameSuccess() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('getSID')
- ->with($userDN)
- ->willReturn('S-1-5-21-249921958-728525901-1594176202');
- $this->access->expects($this->once())
- ->method('searchGroups')
- ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
- $this->access->expects($this->once())
- ->method('dn2groupname')
- ->with('cn=foo,dc=barfoo,dc=bar')
- ->willReturn('MyGroup');
- $this->initBackend();
- $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
- $this->assertSame('MyGroup', $group);
- }
- public function testPrimaryGroupID2NameNoSID() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('getSID')
- ->with($userDN)
- ->willReturn(false);
- $this->access->expects($this->never())
- ->method('searchGroups');
- $this->access->expects($this->never())
- ->method('dn2groupname');
- $this->initBackend();
- $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
- $this->assertSame(false, $group);
- }
- public function testPrimaryGroupID2NameNoGroup() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('getSID')
- ->with($userDN)
- ->willReturn('S-1-5-21-249921958-728525901-1594176202');
- $this->access->expects($this->once())
- ->method('searchGroups')
- ->willReturn([]);
- $this->access->expects($this->never())
- ->method('dn2groupname');
- $this->initBackend();
- $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
- $this->assertSame(false, $group);
- }
- public function testPrimaryGroupID2NameNoName() {
- $this->enableGroups();
- $userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
- $this->access->expects($this->once())
- ->method('getSID')
- ->with($userDN)
- ->willReturn('S-1-5-21-249921958-728525901-1594176202');
- $this->access->expects($this->once())
- ->method('searchGroups')
- ->willReturn([['dn' => ['cn=foo,dc=barfoo,dc=bar']]]);
- $this->access->expects($this->once())
- ->method('dn2groupname')
- ->willReturn(false);
- $this->initBackend();
- $group = $this->groupBackend->primaryGroupID2Name('3117', $userDN);
- $this->assertSame(false, $group);
- }
- public function testGetEntryGroupIDValue() {
- //tests getEntryGroupID via getGroupPrimaryGroupID
- //which is basically identical to getUserPrimaryGroupIDs
- $this->enableGroups();
- $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
- $attr = 'primaryGroupToken';
- $this->access->expects($this->once())
- ->method('readAttribute')
- ->with($dn, $attr)
- ->willReturn(['3117']);
- $this->initBackend();
- $gid = $this->groupBackend->getGroupPrimaryGroupID($dn);
- $this->assertSame('3117', $gid);
- }
- public function testGetEntryGroupIDNoValue() {
- //tests getEntryGroupID via getGroupPrimaryGroupID
- //which is basically identical to getUserPrimaryGroupIDs
- $this->enableGroups();
- $dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
- $attr = 'primaryGroupToken';
- $this->access->expects($this->once())
- ->method('readAttribute')
- ->with($dn, $attr)
- ->willReturn(false);
- $this->initBackend();
- $gid = $this->groupBackend->getGroupPrimaryGroupID($dn);
- $this->assertSame(false, $gid);
- }
- /**
- * tests whether Group Backend behaves correctly when cache with uid and gid
- * is hit
- */
- public function testInGroupHitsUidGidCache() {
- $this->enableGroups();
- $uid = 'someUser';
- $gid = 'someGroup';
- $cacheKey = 'inGroup' . $uid . ':' . $gid;
- $this->access->connection->expects($this->once())
- ->method('getFromCache')
- ->with($cacheKey)
- ->willReturn(true);
- $this->access->expects($this->never())
- ->method('username2dn');
- $this->initBackend();
- $this->groupBackend->inGroup($uid, $gid);
- }
- public function groupWithMembersProvider() {
- return [
- [
- 'someGroup',
- 'cn=someGroup,ou=allTheGroups,ou=someDepartment,dc=someDomain,dc=someTld',
- [
- 'uid=oneUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
- 'uid=someUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
- 'uid=anotherUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
- 'uid=differentUser,ou=someTeam,ou=someDepartment,dc=someDomain,dc=someTld',
- ],
- ],
- ];
- }
- /**
- * @dataProvider groupWithMembersProvider
- */
- public function testInGroupMember(string $gid, string $groupDn, array $memberDNs) {
- $uid = 'someUser';
- $userDn = $memberDNs[0];
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function ($name) {
- switch ($name) {
- case 'ldapGroupMemberAssocAttr':
- return 'member';
- case 'ldapDynamicGroupMemberURL':
- return '';
- case 'hasPrimaryGroups':
- case 'ldapNestedGroups':
- return 0;
- default:
- return 1;
- }
- });
- $this->access->connection->expects($this->any())
- ->method('getFromCache')
- ->willReturn(null);
- $this->access->expects($this->once())
- ->method('username2dn')
- ->with($uid)
- ->willReturn($userDn);
- $this->access->expects($this->once())
- ->method('groupname2dn')
- ->willReturn($groupDn);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturn($memberDNs);
- $this->initBackend();
- $this->assertTrue($this->groupBackend->inGroup($uid, $gid));
- }
- /**
- * @dataProvider groupWithMembersProvider
- */
- public function testInGroupMemberNot(string $gid, string $groupDn, array $memberDNs) {
- $uid = 'unelatedUser';
- $userDn = 'uid=unrelatedUser,ou=unrelatedTeam,ou=unrelatedDepartment,dc=someDomain,dc=someTld';
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function ($name) {
- switch ($name) {
- case 'ldapGroupMemberAssocAttr':
- return 'member';
- case 'ldapDynamicGroupMemberURL':
- return '';
- case 'hasPrimaryGroups':
- case 'ldapNestedGroups':
- return 0;
- default:
- return 1;
- }
- });
- $this->access->connection->expects($this->any())
- ->method('getFromCache')
- ->willReturn(null);
- $this->access->expects($this->once())
- ->method('username2dn')
- ->with($uid)
- ->willReturn($userDn);
- $this->access->expects($this->once())
- ->method('groupname2dn')
- ->willReturn($groupDn);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturn($memberDNs);
- $this->initBackend();
- $this->assertFalse($this->groupBackend->inGroup($uid, $gid));
- }
- /**
- * @dataProvider groupWithMembersProvider
- */
- public function testInGroupMemberUid(string $gid, string $groupDn, array $memberDNs) {
- $memberUids = [];
- $userRecords = [];
- foreach ($memberDNs as $dn) {
- $memberUids[] = ldap_explode_dn($dn, false)[0];
- $userRecords[] = ['dn' => [$dn]];
- }
- $uid = 'someUser';
- $userDn = $memberDNs[0];
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function ($name) {
- switch ($name) {
- case 'ldapGroupMemberAssocAttr':
- return 'memberUid';
- case 'ldapDynamicGroupMemberURL':
- return '';
- case 'ldapLoginFilter':
- return 'uid=%uid';
- case 'hasPrimaryGroups':
- case 'ldapNestedGroups':
- return 0;
- default:
- return 1;
- }
- });
- $this->access->connection->expects($this->any())
- ->method('getFromCache')
- ->willReturn(null);
- $this->access->userManager->expects($this->any())
- ->method('getAttributes')
- ->willReturn(['uid', 'mail', 'displayname']);
- $this->access->expects($this->once())
- ->method('username2dn')
- ->with($uid)
- ->willReturn($userDn);
- $this->access->expects($this->once())
- ->method('groupname2dn')
- ->willReturn($groupDn);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturn($memberUids);
- $this->access->expects($this->any())
- ->method('fetchListOfUsers')
- ->willReturn($userRecords);
- $this->access->expects($this->any())
- ->method('combineFilterWithOr')
- ->willReturn('(|(pseudo=filter)(filter=pseudo))');
- $this->initBackend();
- $this->assertTrue($this->groupBackend->inGroup($uid, $gid));
- }
- public function testGetGroupsWithOffset() {
- $this->enableGroups();
- $this->access->expects($this->once())
- ->method('nextcloudGroupNames')
- ->willReturn(['group1', 'group2']);
- $this->initBackend();
- $groups = $this->groupBackend->getGroups('', 2, 2);
- $this->assertSame(2, count($groups));
- }
- /**
- * tests that a user listing is complete, if all its members have the group
- * as their primary.
- */
- public function testUsersInGroupPrimaryMembersOnly() {
- $this->enableGroups();
- $this->access->connection->expects($this->any())
- ->method('getFromCache')
- ->willReturn(null);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturnCallback(function ($dn, $attr) {
- if ($attr === 'primaryGroupToken') {
- return [1337];
- } elseif ($attr === 'gidNumber') {
- return [4211];
- }
- return [];
- });
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturn('cn=foobar,dc=foo,dc=bar');
- $this->access->expects($this->exactly(2))
- ->method('nextcloudUserNames')
- ->willReturnOnConsecutiveCalls(['lisa', 'bart', 'kira', 'brad'], ['walle', 'dino', 'xenia']);
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- $this->access->expects($this->any())
- ->method('combineFilterWithAnd')
- ->willReturn('pseudo=filter');
- $this->access->userManager->expects($this->any())
- ->method('getAttributes')
- ->willReturn(['displayName', 'mail']);
- $this->initBackend();
- $users = $this->groupBackend->usersInGroup('foobar');
- $this->assertSame(7, count($users));
- }
- /**
- * tests that a user listing is complete, if all its members have the group
- * as their primary.
- */
- public function testUsersInGroupPrimaryAndUnixMembers() {
- $this->enableGroups();
- $this->access->connection->expects($this->any())
- ->method('getFromCache')
- ->willReturn(null);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturnCallback(function ($dn, $attr) {
- if ($attr === 'primaryGroupToken') {
- return [1337];
- }
- return [];
- });
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturn('cn=foobar,dc=foo,dc=bar');
- $this->access->expects($this->once())
- ->method('nextcloudUserNames')
- ->willReturn(['lisa', 'bart', 'kira', 'brad']);
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- $this->access->expects($this->any())
- ->method('combineFilterWithAnd')
- ->willReturn('pseudo=filter');
- $this->access->userManager->expects($this->any())
- ->method('getAttributes')
- ->willReturn(['displayName', 'mail']);
- $this->initBackend();
- $users = $this->groupBackend->usersInGroup('foobar');
- $this->assertSame(4, count($users));
- }
- /**
- * tests that a user counting is complete, if all its members have the group
- * as their primary.
- */
- public function testCountUsersInGroupPrimaryMembersOnly() {
- $this->enableGroups();
- $this->access->connection->expects($this->any())
- ->method('getFromCache')
- ->willReturn(null);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturnCallback(function ($dn, $attr) {
- if ($attr === 'primaryGroupToken') {
- return [1337];
- }
- return [];
- });
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturn('cn=foobar,dc=foo,dc=bar');
- $this->access->expects($this->once())
- ->method('countUsers')
- ->willReturn(4);
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- $this->access->userManager->expects($this->any())
- ->method('getAttributes')
- ->willReturn(['displayName', 'mail']);
- $this->initBackend();
- $users = $this->groupBackend->countUsersInGroup('foobar');
- $this->assertSame(4, $users);
- }
- public function testGetUserGroupsMemberOf() {
- $this->enableGroups();
- $dn = 'cn=userX,dc=foobar';
- $this->access->connection->hasPrimaryGroups = false;
- $this->access->connection->hasGidNumber = false;
- $expectedGroups = ['cn=groupA,dc=foobar', 'cn=groupB,dc=foobar'];
- $this->access->expects($this->any())
- ->method('username2dn')
- ->willReturn($dn);
- $this->access->expects($this->exactly(5))
- ->method('readAttribute')
- ->will($this->onConsecutiveCalls($expectedGroups, [], [], [], []));
- $this->access->expects($this->any())
- ->method('dn2groupname')
- ->willReturnArgument(0);
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturnArgument(0);
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- $this->config->expects($this->once())
- ->method('setUserValue')
- ->with('userX', 'user_ldap', 'cached-group-memberships-', \json_encode($expectedGroups));
- $this->initBackend();
- $groups = $this->groupBackend->getUserGroups('userX');
- $this->assertSame(2, count($groups));
- }
- public function testGetUserGroupsMemberOfDisabled() {
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function ($name) {
- if ($name === 'useMemberOfToDetectMembership') {
- return 0;
- } elseif ($name === 'ldapDynamicGroupMemberURL') {
- return '';
- }
- return 1;
- });
- $dn = 'cn=userX,dc=foobar';
- $this->access->connection->hasPrimaryGroups = false;
- $this->access->connection->hasGidNumber = false;
- $this->access->expects($this->once())
- ->method('username2dn')
- ->willReturn($dn);
- $this->access->expects($this->never())
- ->method('readAttribute')
- ->with($dn, 'memberOf');
- $this->access->expects($this->once())
- ->method('nextcloudGroupNames')
- ->willReturn([]);
- // empty group result should not be oer
- $this->config->expects($this->once())
- ->method('setUserValue')
- ->with('userX', 'user_ldap', 'cached-group-memberships-', '[]');
- $ldapUser = $this->createMock(User::class);
- $this->access->userManager->expects($this->any())
- ->method('get')
- ->with('userX')
- ->willReturn($ldapUser);
- $userBackend = $this->createMock(User_Proxy::class);
- $userBackend->expects($this->once())
- ->method('userExistsOnLDAP')
- ->with('userX', true)
- ->willReturn(true);
- $ncUser = $this->createMock(IUser::class);
- $ncUser->expects($this->any())
- ->method('getBackend')
- ->willReturn($userBackend);
- $this->ncUserManager->expects($this->once())
- ->method('get')
- ->with('userX')
- ->willReturn($ncUser);
- $this->initBackend();
- $this->groupBackend->getUserGroups('userX');
- }
- public function testGetUserGroupsOfflineUser() {
- $this->enableGroups();
- $offlineUser = $this->createMock(OfflineUser::class);
- $this->config->expects($this->any())
- ->method('getUserValue')
- ->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
- ->willReturn(\json_encode(['groupB', 'groupF']));
- $this->access->userManager->expects($this->any())
- ->method('get')
- ->with('userX')
- ->willReturn($offlineUser);
- $this->initBackend();
- $returnedGroups = $this->groupBackend->getUserGroups('userX');
- $this->assertCount(2, $returnedGroups);
- $this->assertTrue(in_array('groupB', $returnedGroups));
- $this->assertTrue(in_array('groupF', $returnedGroups));
- }
- /**
- * regression tests against a case where a json object was stored instead of expected list
- * @see https://github.com/nextcloud/server/issues/42374
- */
- public function testGetUserGroupsOfflineUserUnexpectedJson() {
- $this->enableGroups();
- $offlineUser = $this->createMock(OfflineUser::class);
- $this->config->expects($this->any())
- ->method('getUserValue')
- ->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
- // results in a json object: {"0":"groupB","2":"groupF"}
- ->willReturn(\json_encode([0 => 'groupB', 2 => 'groupF']));
- $this->access->userManager->expects($this->any())
- ->method('get')
- ->with('userX')
- ->willReturn($offlineUser);
- $this->initBackend();
- $returnedGroups = $this->groupBackend->getUserGroups('userX');
- $this->assertCount(2, $returnedGroups);
- $this->assertTrue(in_array('groupB', $returnedGroups));
- $this->assertTrue(in_array('groupF', $returnedGroups));
- }
- public function testGetUserGroupsUnrecognizedOfflineUser() {
- $this->enableGroups();
- $dn = 'cn=userX,dc=foobar';
- $ldapUser = $this->createMock(User::class);
- $userBackend = $this->createMock(User_Proxy::class);
- $userBackend->expects($this->once())
- ->method('userExistsOnLDAP')
- ->with('userX', true)
- ->willReturn(false);
- $ncUser = $this->createMock(IUser::class);
- $ncUser->expects($this->any())
- ->method('getBackend')
- ->willReturn($userBackend);
- $this->config->expects($this->atLeastOnce())
- ->method('getUserValue')
- ->with('userX', 'user_ldap', 'cached-group-memberships-', $this->anything())
- ->willReturn(\json_encode(['groupB', 'groupF']));
- $this->access->expects($this->any())
- ->method('username2dn')
- ->willReturn($dn);
- $this->access->userManager->expects($this->any())
- ->method('get')
- ->with('userX')
- ->willReturn($ldapUser);
- $this->ncUserManager->expects($this->once())
- ->method('get')
- ->with('userX')
- ->willReturn($ncUser);
- $this->initBackend();
- $returnedGroups = $this->groupBackend->getUserGroups('userX');
- $this->assertCount(2, $returnedGroups);
- $this->assertTrue(in_array('groupB', $returnedGroups));
- $this->assertTrue(in_array('groupF', $returnedGroups));
- }
- public function nestedGroupsProvider(): array {
- return [
- [true],
- [false],
- ];
- }
- /**
- * @dataProvider nestedGroupsProvider
- */
- public function testGetGroupsByMember(bool $nestedGroups) {
- $groupFilter = '(&(objectclass=nextcloudGroup)(nextcloudEnabled=TRUE))';
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function (string $name) use ($nestedGroups, $groupFilter) {
- switch ($name) {
- case 'useMemberOfToDetectMembership':
- return 0;
- case 'ldapDynamicGroupMemberURL':
- return '';
- case 'ldapNestedGroups':
- return (int)$nestedGroups;
- case 'ldapGroupMemberAssocAttr':
- return 'member';
- case 'ldapGroupFilter':
- return $groupFilter;
- case 'ldapBaseGroups':
- return [];
- case 'ldapGroupDisplayName':
- return 'cn';
- }
- return 1;
- });
- $dn = 'cn=userX,dc=foobar';
- $this->access->connection->hasPrimaryGroups = false;
- $this->access->connection->hasGidNumber = false;
- $this->access->expects($this->exactly(2))
- ->method('username2dn')
- ->willReturn($dn);
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturn([]);
- $this->access->expects($this->any())
- ->method('combineFilterWithAnd')
- ->willReturnCallback(function (array $filterParts) {
- // ⚠ returns a pseudo-filter only, not real LDAP Filter syntax
- return implode('&', $filterParts);
- });
- $group1 = [
- 'cn' => 'group1',
- 'dn' => ['cn=group1,ou=groups,dc=domain,dc=com'],
- 'member' => [$dn],
- ];
- $group2 = [
- 'cn' => 'group2',
- 'dn' => ['cn=group2,ou=groups,dc=domain,dc=com'],
- 'member' => [$dn],
- ];
- $group3 = [
- 'cn' => 'group3',
- 'dn' => ['cn=group3,ou=groups,dc=domain,dc=com'],
- 'member' => [$group2['dn'][0]],
- ];
- $expectedGroups = ($nestedGroups ? [$group1, $group2, $group3] : [$group1, $group2]);
- $expectedGroupsNames = ($nestedGroups ? ['group1', 'group2', 'group3'] : ['group1', 'group2']);
- $this->access->expects($this->any())
- ->method('nextcloudGroupNames')
- ->with($expectedGroups)
- ->willReturn($expectedGroupsNames);
- $this->access->expects($nestedGroups ? $this->atLeastOnce() : $this->once())
- ->method('fetchListOfGroups')
- ->willReturnCallback(function ($filter, $attr, $limit, $offset) use ($nestedGroups, $groupFilter, $group1, $group2, $group3, $dn) {
- static $firstRun = true;
- if (!$nestedGroups) {
- // When nested groups are enabled, groups cannot be filtered early as it would
- // exclude intermediate groups. But we can, and should, when working with flat groups.
- $this->assertTrue(strpos($filter, $groupFilter) !== false);
- }
- [$memberFilter] = explode('&', $filter);
- if ($memberFilter === 'member='.$dn) {
- return [$group1, $group2];
- return [];
- } elseif ($memberFilter === 'member='.$group2['dn'][0]) {
- return [$group3];
- } else {
- return [];
- }
- });
- $this->access->expects($this->any())
- ->method('dn2groupname')
- ->willReturnCallback(function (string $dn) {
- return ldap_explode_dn($dn, 1)[0];
- });
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturnCallback(function (string $gid) use ($group1, $group2, $group3) {
- if ($gid === $group1['cn']) {
- return $group1['dn'][0];
- }
- if ($gid === $group2['cn']) {
- return $group2['dn'][0];
- }
- if ($gid === $group3['cn']) {
- return $group3['dn'][0];
- }
- });
- $this->access->expects($this->any())
- ->method('isDNPartOfBase')
- ->willReturn(true);
- $this->initBackend();
- $groups = $this->groupBackend->getUserGroups('userX');
- $this->assertEquals($expectedGroupsNames, $groups);
- $groupsAgain = $this->groupBackend->getUserGroups('userX');
- $this->assertEquals($expectedGroupsNames, $groupsAgain);
- }
- public function testCreateGroupWithPlugin() {
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'createGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::CREATE_GROUP)
- ->willReturn(true);
- $this->pluginManager->expects($this->once())
- ->method('createGroup')
- ->with('gid')
- ->willReturn('result');
- $this->initBackend();
- $this->assertEquals($this->groupBackend->createGroup('gid'), true);
- }
- public function testCreateGroupFailing() {
- $this->expectException(\Exception::class);
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'createGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::CREATE_GROUP)
- ->willReturn(false);
- $this->initBackend();
- $this->groupBackend->createGroup('gid');
- }
- public function testDeleteGroupWithPlugin() {
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'deleteGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::DELETE_GROUP)
- ->willReturn(true);
- $this->pluginManager->expects($this->once())
- ->method('deleteGroup')
- ->with('gid')
- ->willReturn(true);
- $mapper = $this->getMockBuilder(GroupMapping::class)
- ->setMethods(['unmap'])
- ->disableOriginalConstructor()
- ->getMock();
- $this->access->expects($this->any())
- ->method('getGroupMapper')
- ->willReturn($mapper);
- $this->initBackend();
- $this->assertTrue($this->groupBackend->deleteGroup('gid'));
- }
- public function testDeleteGroupFailing() {
- $this->expectException(\Exception::class);
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'deleteGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::DELETE_GROUP)
- ->willReturn(false);
- $this->initBackend();
- $this->groupBackend->deleteGroup('gid');
- }
- public function testAddToGroupWithPlugin() {
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'addToGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::ADD_TO_GROUP)
- ->willReturn(true);
- $this->pluginManager->expects($this->once())
- ->method('addToGroup')
- ->with('uid', 'gid')
- ->willReturn('result');
- $this->initBackend();
- $this->assertEquals($this->groupBackend->addToGroup('uid', 'gid'), 'result');
- }
- public function testAddToGroupFailing() {
- $this->expectException(\Exception::class);
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'addToGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::ADD_TO_GROUP)
- ->willReturn(false);
- $this->initBackend();
- $this->groupBackend->addToGroup('uid', 'gid');
- }
- public function testRemoveFromGroupWithPlugin() {
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'removeFromGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::REMOVE_FROM_GROUP)
- ->willReturn(true);
- $this->pluginManager->expects($this->once())
- ->method('removeFromGroup')
- ->with('uid', 'gid')
- ->willReturn('result');
- $this->initBackend();
- $this->assertEquals($this->groupBackend->removeFromGroup('uid', 'gid'), 'result');
- }
- public function testRemoveFromGroupFailing() {
- $this->expectException(\Exception::class);
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'removeFromGroup'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::REMOVE_FROM_GROUP)
- ->willReturn(false);
- $this->initBackend();
- $this->groupBackend->removeFromGroup('uid', 'gid');
- }
- public function testGetGroupDetailsWithPlugin() {
- /** @var GroupPluginManager|MockObject $pluginManager */
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'getGroupDetails'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::GROUP_DETAILS)
- ->willReturn(true);
- $this->pluginManager->expects($this->once())
- ->method('getGroupDetails')
- ->with('gid')
- ->willReturn('result');
- $this->initBackend();
- $this->assertEquals($this->groupBackend->getGroupDetails('gid'), 'result');
- }
- public function testGetGroupDetailsFailing() {
- $this->expectException(\Exception::class);
- $this->pluginManager = $this->getMockBuilder(GroupPluginManager::class)
- ->setMethods(['implementsActions', 'getGroupDetails'])
- ->getMock();
- $this->pluginManager->expects($this->once())
- ->method('implementsActions')
- ->with(GroupInterface::GROUP_DETAILS)
- ->willReturn(false);
- $this->initBackend();
- $this->groupBackend->getGroupDetails('gid');
- }
- public function groupMemberProvider() {
- $base = 'dc=species,dc=earth';
- $birdsDn = [
- 'uid=3723,' . $base,
- 'uid=8372,' . $base,
- 'uid=8427,' . $base,
- 'uid=2333,' . $base,
- 'uid=4754,' . $base,
- ];
- $birdsUid = [
- '3723',
- '8372',
- '8427',
- '2333',
- '4754',
- ];
- $animalsDn = [
- 'uid=lion,' . $base,
- 'uid=tiger,' . $base,
- ];
- $plantsDn = [
- 'uid=flower,' . $base,
- 'uid=tree,' . $base,
- ];
- $thingsDn = [
- 'uid=thing1,' . $base,
- 'uid=thing2,' . $base,
- ];
- return [
- [ #0 – test DNs
- ['cn=Birds,' . $base => $birdsDn],
- ['cn=Birds,' . $base => $birdsDn]
- ],
- [ #1 – test uids
- ['cn=Birds,' . $base => $birdsUid],
- ['cn=Birds,' . $base => $birdsUid]
- ],
- [ #2 – test simple nested group
- ['cn=Animals,' . $base => array_merge($birdsDn, $animalsDn)],
- [
- 'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
- 'cn=Birds,' . $base => $birdsDn,
- ]
- ],
- [ #3 – test recursive nested group
- [
- 'cn=Animals,' . $base => array_merge($birdsDn, $animalsDn),
- 'cn=Birds,' . $base => array_merge($birdsDn, $animalsDn),
- ],
- [
- 'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base,'cn=Birds,' . $base,'cn=Animals,' . $base], $animalsDn),
- 'cn=Birds,' . $base => array_merge(['cn=Animals,' . $base,'cn=Birds,' . $base], $birdsDn),
- ]
- ],
- [ #4 – Complicated nested group
- ['cn=Things,' . $base => array_merge($birdsDn, $animalsDn, $thingsDn, $plantsDn)],
- [
- 'cn=Animals,' . $base => array_merge(['cn=Birds,' . $base], $animalsDn),
- 'cn=Birds,' . $base => $birdsDn,
- 'cn=Plants,' . $base => $plantsDn,
- 'cn=Things,' . $base => array_merge(['cn=Animals,' . $base,'cn=Plants,' . $base], $thingsDn),
- ]
- ],
- ];
- }
- /**
- * @param string[] $expectedMembers
- * @dataProvider groupMemberProvider
- */
- public function testGroupMembers(array $expectedResult, array $groupsInfo = null) {
- $this->access->expects($this->any())
- ->method('readAttribute')
- ->willReturnCallback(function ($group) use ($groupsInfo) {
- if (isset($groupsInfo[$group])) {
- return $groupsInfo[$group];
- }
- return [];
- });
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function (string $name) {
- if ($name === 'ldapNestedGroups') {
- return 1;
- } elseif ($name === 'ldapGroupMemberAssocAttr') {
- return 'attr';
- }
- return null;
- });
- $this->initBackend();
- foreach ($expectedResult as $groupDN => $expectedMembers) {
- $resultingMembers = $this->invokePrivate($this->groupBackend, '_groupMembers', [$groupDN]);
- $this->assertEqualsCanonicalizing($expectedMembers, $resultingMembers);
- }
- }
- public function displayNameProvider() {
- return [
- ['Graphic Novelists', ['Graphic Novelists']],
- ['', false],
- ];
- }
- /**
- * @dataProvider displayNameProvider
- */
- public function testGetDisplayName(string $expected, $ldapResult) {
- $gid = 'graphic_novelists';
- $this->access->expects($this->atLeastOnce())
- ->method('readAttribute')
- ->willReturn($ldapResult);
- $this->access->connection->expects($this->any())
- ->method('__get')
- ->willReturnCallback(function ($name) {
- if ($name === 'ldapGroupMemberAssocAttr') {
- return 'member';
- } elseif ($name === 'ldapGroupFilter') {
- return 'objectclass=nextcloudGroup';
- } elseif ($name === 'ldapGroupDisplayName') {
- return 'cn';
- }
- return null;
- });
- $this->access->expects($this->any())
- ->method('groupname2dn')
- ->willReturn('fakedn');
- $this->initBackend();
- $this->assertSame($expected, $this->groupBackend->getDisplayName($gid));
- }
- }
|