123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614 |
- <?php
- declare(strict_types=1);
- /**
- * Copyright (c) 2015 Lukas Reschke <lukas@owncloud.com>
- * This file is licensed under the Affero General Public License version 3 or
- * later.
- * See the COPYING-README file.
- */
- namespace Test\Http\Client;
- use GuzzleHttp\Psr7\Response;
- use OC\Http\Client\Client;
- use OC\Security\CertificateManager;
- use OCP\Http\Client\LocalServerException;
- use OCP\ICertificateManager;
- use OCP\IConfig;
- use OCP\Security\IRemoteHostValidator;
- use PHPUnit\Framework\MockObject\MockObject;
- use Psr\Log\LoggerInterface;
- use function parse_url;
- /**
- * Class ClientTest
- */
- class ClientTest extends \Test\TestCase {
- /** @var \GuzzleHttp\Client|MockObject */
- private $guzzleClient;
- /** @var CertificateManager|MockObject */
- private $certificateManager;
- /** @var Client */
- private $client;
- /** @var IConfig|MockObject */
- private $config;
- /** @var IRemoteHostValidator|MockObject */
- private IRemoteHostValidator $remoteHostValidator;
- /** @var array */
- private $defaultRequestOptions;
- protected function setUp(): void {
- parent::setUp();
- $this->config = $this->createMock(IConfig::class);
- $this->guzzleClient = $this->createMock(\GuzzleHttp\Client::class);
- $this->certificateManager = $this->createMock(ICertificateManager::class);
- $this->remoteHostValidator = $this->createMock(IRemoteHostValidator::class);
- $this->logger = $this->createMock(LoggerInterface::class);
- $this->client = new Client(
- $this->config,
- $this->certificateManager,
- $this->guzzleClient,
- $this->remoteHostValidator,
- $this->logger,
- );
- }
- public function testGetProxyUri(): void {
- $this->config
- ->method('getSystemValueString')
- ->with('proxy', '')
- ->willReturn('');
- $this->assertNull(self::invokePrivate($this->client, 'getProxyUri'));
- }
- public function testGetProxyUriProxyHostEmptyPassword(): void {
- $this->config
- ->method('getSystemValue')
- ->will($this->returnValueMap([
- ['proxyexclude', [], []],
- ]));
- $this->config
- ->method('getSystemValueString')
- ->will($this->returnValueMap([
- ['proxy', '', 'foo'],
- ['proxyuserpwd', '', ''],
- ]));
- $this->assertEquals([
- 'http' => 'foo',
- 'https' => 'foo'
- ], self::invokePrivate($this->client, 'getProxyUri'));
- }
- public function testGetProxyUriProxyHostWithPassword(): void {
- $this->config
- ->expects($this->once())
- ->method('getSystemValue')
- ->with('proxyexclude', [])
- ->willReturn([]);
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueString')
- ->withConsecutive(
- ['proxy', ''],
- ['proxyuserpwd', ''],
- )
- ->willReturnOnConsecutiveCalls(
- 'foo',
- 'username:password',
- );
- $this->assertEquals([
- 'http' => 'username:password@foo',
- 'https' => 'username:password@foo'
- ], self::invokePrivate($this->client, 'getProxyUri'));
- }
- public function testGetProxyUriProxyHostWithPasswordAndExclude(): void {
- $this->config
- ->expects($this->once())
- ->method('getSystemValue')
- ->with('proxyexclude', [])
- ->willReturn(['bar']);
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueString')
- ->withConsecutive(
- ['proxy', ''],
- ['proxyuserpwd', ''],
- )
- ->willReturnOnConsecutiveCalls(
- 'foo',
- 'username:password',
- );
- $this->assertEquals([
- 'http' => 'username:password@foo',
- 'https' => 'username:password@foo',
- 'no' => ['bar']
- ], self::invokePrivate($this->client, 'getProxyUri'));
- }
- public function dataPreventLocalAddress():array {
- return [
- ['https://localhost/foo.bar'],
- ['https://localHost/foo.bar'],
- ['https://random-host/foo.bar'],
- ['https://[::1]/bla.blub'],
- ['https://[::]/bla.blub'],
- ['https://192.168.0.1'],
- ['https://172.16.42.1'],
- ['https://[fdf8:f53b:82e4::53]/secret.ics'],
- ['https://[fe80::200:5aee:feaa:20a2]/secret.ics'],
- ['https://[0:0:0:0:0:0:10.0.0.1]/secret.ics'],
- ['https://[0:0:0:0:0:ffff:127.0.0.0]/secret.ics'],
- ['https://10.0.0.1'],
- ['https://another-host.local'],
- ['https://service.localhost'],
- ['!@#$', true], // test invalid url
- ['https://normal.host.com'],
- ['https://com.one-.nextcloud-one.com'],
- ];
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressDisabledByGlobalConfig(string $uri): void {
- $this->config->expects($this->once())
- ->method('getSystemValueBool')
- ->with('allow_local_remote_servers', false)
- ->willReturn(true);
- self::invokePrivate($this->client, 'preventLocalAddress', [$uri, []]);
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressDisabledByOption(string $uri): void {
- $this->config->expects($this->never())
- ->method('getSystemValueBool');
- self::invokePrivate($this->client, 'preventLocalAddress', [$uri, [
- 'nextcloud' => ['allow_local_address' => true],
- ]]);
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressOnGet(string $uri): void {
- $host = parse_url($uri, PHP_URL_HOST);
- $this->expectException(LocalServerException::class);
- $this->remoteHostValidator
- ->method('isValid')
- ->with($host)
- ->willReturn(false);
- $this->client->get($uri);
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressOnHead(string $uri): void {
- $host = parse_url($uri, PHP_URL_HOST);
- $this->expectException(LocalServerException::class);
- $this->remoteHostValidator
- ->method('isValid')
- ->with($host)
- ->willReturn(false);
- $this->client->head($uri);
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressOnPost(string $uri): void {
- $host = parse_url($uri, PHP_URL_HOST);
- $this->expectException(LocalServerException::class);
- $this->remoteHostValidator
- ->method('isValid')
- ->with($host)
- ->willReturn(false);
- $this->client->post($uri);
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressOnPut(string $uri): void {
- $host = parse_url($uri, PHP_URL_HOST);
- $this->expectException(LocalServerException::class);
- $this->remoteHostValidator
- ->method('isValid')
- ->with($host)
- ->willReturn(false);
- $this->client->put($uri);
- }
- /**
- * @dataProvider dataPreventLocalAddress
- * @param string $uri
- */
- public function testPreventLocalAddressOnDelete(string $uri): void {
- $host = parse_url($uri, PHP_URL_HOST);
- $this->expectException(LocalServerException::class);
- $this->remoteHostValidator
- ->method('isValid')
- ->with($host)
- ->willReturn(false);
- $this->client->delete($uri);
- }
- private function setUpDefaultRequestOptions(): void {
- $this->config
- ->method('getSystemValue')
- ->will($this->returnValueMap([
- ['proxyexclude', [], []],
- ]));
- $this->config
- ->method('getSystemValueString')
- ->will($this->returnValueMap([
- ['proxy', '', 'foo'],
- ['proxyuserpwd', '', ''],
- ]));
- $this->config
- ->method('getSystemValueBool')
- ->will($this->returnValueMap([
- ['installed', false, true],
- ['allow_local_remote_servers', false, true],
- ]));
- $this->certificateManager
- ->expects($this->once())
- ->method('getAbsoluteBundlePath')
- ->with()
- ->willReturn('/my/path.crt');
- $this->defaultRequestOptions = [
- 'verify' => '/my/path.crt',
- 'proxy' => [
- 'http' => 'foo',
- 'https' => 'foo'
- ],
- 'headers' => [
- 'User-Agent' => 'Nextcloud Server Crawler',
- 'Accept-Encoding' => 'gzip',
- ],
- 'timeout' => 30,
- 'nextcloud' => [
- 'allow_local_address' => true,
- ],
- ];
- }
- public function testGet(): void {
- $this->setUpDefaultRequestOptions();
- $this->guzzleClient->method('request')
- ->with('get', 'http://localhost/', $this->defaultRequestOptions)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->get('http://localhost/', [])->getStatusCode());
- }
- public function testGetWithOptions(): void {
- $this->setUpDefaultRequestOptions();
- $options = array_merge($this->defaultRequestOptions, [
- 'verify' => false,
- 'proxy' => [
- 'http' => 'bar',
- 'https' => 'bar'
- ],
- ]);
- $this->guzzleClient->method('request')
- ->with('get', 'http://localhost/', $options)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->get('http://localhost/', $options)->getStatusCode());
- }
- public function testPost(): void {
- $this->setUpDefaultRequestOptions();
- $this->guzzleClient->method('request')
- ->with('post', 'http://localhost/', $this->defaultRequestOptions)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->post('http://localhost/', [])->getStatusCode());
- }
- public function testPostWithOptions(): void {
- $this->setUpDefaultRequestOptions();
- $options = array_merge($this->defaultRequestOptions, [
- 'verify' => false,
- 'proxy' => [
- 'http' => 'bar',
- 'https' => 'bar'
- ],
- ]);
- $this->guzzleClient->method('request')
- ->with('post', 'http://localhost/', $options)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->post('http://localhost/', $options)->getStatusCode());
- }
- public function testPut(): void {
- $this->setUpDefaultRequestOptions();
- $this->guzzleClient->method('request')
- ->with('put', 'http://localhost/', $this->defaultRequestOptions)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->put('http://localhost/', [])->getStatusCode());
- }
- public function testPutWithOptions(): void {
- $this->setUpDefaultRequestOptions();
- $options = array_merge($this->defaultRequestOptions, [
- 'verify' => false,
- 'proxy' => [
- 'http' => 'bar',
- 'https' => 'bar'
- ],
- ]);
- $this->guzzleClient->method('request')
- ->with('put', 'http://localhost/', $options)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->put('http://localhost/', $options)->getStatusCode());
- }
- public function testDelete(): void {
- $this->setUpDefaultRequestOptions();
- $this->guzzleClient->method('request')
- ->with('delete', 'http://localhost/', $this->defaultRequestOptions)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->delete('http://localhost/', [])->getStatusCode());
- }
- public function testDeleteWithOptions(): void {
- $this->setUpDefaultRequestOptions();
- $options = array_merge($this->defaultRequestOptions, [
- 'verify' => false,
- 'proxy' => [
- 'http' => 'bar',
- 'https' => 'bar'
- ],
- ]);
- $this->guzzleClient->method('request')
- ->with('delete', 'http://localhost/', $options)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->delete('http://localhost/', $options)->getStatusCode());
- }
- public function testOptions(): void {
- $this->setUpDefaultRequestOptions();
- $this->guzzleClient->method('request')
- ->with('options', 'http://localhost/', $this->defaultRequestOptions)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->options('http://localhost/', [])->getStatusCode());
- }
- public function testOptionsWithOptions(): void {
- $this->setUpDefaultRequestOptions();
- $options = array_merge($this->defaultRequestOptions, [
- 'verify' => false,
- 'proxy' => [
- 'http' => 'bar',
- 'https' => 'bar'
- ],
- ]);
- $this->guzzleClient->method('request')
- ->with('options', 'http://localhost/', $options)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->options('http://localhost/', $options)->getStatusCode());
- }
- public function testHead(): void {
- $this->setUpDefaultRequestOptions();
- $this->guzzleClient->method('request')
- ->with('head', 'http://localhost/', $this->defaultRequestOptions)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->head('http://localhost/', [])->getStatusCode());
- }
- public function testHeadWithOptions(): void {
- $this->setUpDefaultRequestOptions();
- $options = array_merge($this->defaultRequestOptions, [
- 'verify' => false,
- 'proxy' => [
- 'http' => 'bar',
- 'https' => 'bar'
- ],
- ]);
- $this->guzzleClient->method('request')
- ->with('head', 'http://localhost/', $options)
- ->willReturn(new Response(418));
- $this->assertEquals(418, $this->client->head('http://localhost/', $options)->getStatusCode());
- }
- public function testSetDefaultOptionsWithNotInstalled(): void {
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueBool')
- ->withConsecutive(
- ['installed', false],
- ['allow_local_remote_servers', false],
- )
- ->willReturnOnConsecutiveCalls(
- false,
- false,
- );
- $this->config
- ->expects($this->once())
- ->method('getSystemValueString')
- ->with('proxy', '')
- ->willReturn('');
- $this->certificateManager
- ->expects($this->never())
- ->method('listCertificates');
- $this->assertEquals([
- 'verify' => \OC::$SERVERROOT . '/resources/config/ca-bundle.crt',
- 'headers' => [
- 'User-Agent' => 'Nextcloud Server Crawler',
- 'Accept-Encoding' => 'gzip',
- ],
- 'timeout' => 30,
- 'nextcloud' => [
- 'allow_local_address' => false,
- ],
- 'allow_redirects' => [
- 'on_redirect' => function (
- \Psr\Http\Message\RequestInterface $request,
- \Psr\Http\Message\ResponseInterface $response,
- \Psr\Http\Message\UriInterface $uri
- ) {
- },
- ],
- ], self::invokePrivate($this->client, 'buildRequestOptions', [[]]));
- }
- public function testSetDefaultOptionsWithProxy(): void {
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueBool')
- ->withConsecutive(
- ['installed', false],
- ['allow_local_remote_servers', false],
- )
- ->willReturnOnConsecutiveCalls(
- true,
- false,
- );
- $this->config
- ->expects($this->once())
- ->method('getSystemValue')
- ->with('proxyexclude', [])
- ->willReturn([]);
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueString')
- ->withConsecutive(
- ['proxy', ''],
- ['proxyuserpwd', ''],
- )
- ->willReturnOnConsecutiveCalls(
- 'foo',
- '',
- );
- $this->certificateManager
- ->expects($this->once())
- ->method('getAbsoluteBundlePath')
- ->with()
- ->willReturn('/my/path.crt');
- $this->assertEquals([
- 'verify' => '/my/path.crt',
- 'proxy' => [
- 'http' => 'foo',
- 'https' => 'foo'
- ],
- 'headers' => [
- 'User-Agent' => 'Nextcloud Server Crawler',
- 'Accept-Encoding' => 'gzip',
- ],
- 'timeout' => 30,
- 'nextcloud' => [
- 'allow_local_address' => false,
- ],
- 'allow_redirects' => [
- 'on_redirect' => function (
- \Psr\Http\Message\RequestInterface $request,
- \Psr\Http\Message\ResponseInterface $response,
- \Psr\Http\Message\UriInterface $uri
- ) {
- },
- ],
- ], self::invokePrivate($this->client, 'buildRequestOptions', [[]]));
- }
- public function testSetDefaultOptionsWithProxyAndExclude(): void {
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueBool')
- ->withConsecutive(
- ['installed', false],
- ['allow_local_remote_servers', false],
- )
- ->willReturnOnConsecutiveCalls(
- true,
- false,
- );
- $this->config
- ->expects($this->once())
- ->method('getSystemValue')
- ->with('proxyexclude', [])
- ->willReturn(['bar']);
- $this->config
- ->expects($this->exactly(2))
- ->method('getSystemValueString')
- ->withConsecutive(
- ['proxy', ''],
- ['proxyuserpwd', ''],
- )
- ->willReturnOnConsecutiveCalls(
- 'foo',
- '',
- );
- $this->certificateManager
- ->expects($this->once())
- ->method('getAbsoluteBundlePath')
- ->with()
- ->willReturn('/my/path.crt');
- $this->assertEquals([
- 'verify' => '/my/path.crt',
- 'proxy' => [
- 'http' => 'foo',
- 'https' => 'foo',
- 'no' => ['bar']
- ],
- 'headers' => [
- 'User-Agent' => 'Nextcloud Server Crawler',
- 'Accept-Encoding' => 'gzip',
- ],
- 'timeout' => 30,
- 'nextcloud' => [
- 'allow_local_address' => false,
- ],
- 'allow_redirects' => [
- 'on_redirect' => function (
- \Psr\Http\Message\RequestInterface $request,
- \Psr\Http\Message\ResponseInterface $response,
- \Psr\Http\Message\UriInterface $uri
- ) {
- },
- ],
- ], self::invokePrivate($this->client, 'buildRequestOptions', [[]]));
- }
- }
|