Browse Source

Flake8 fixes to pagure/api

Pierre-Yves Chibon 7 years ago
parent
commit
4768f24df3
5 changed files with 32 additions and 25 deletions
  1. 14 11
      pagure/api/__init__.py
  2. 4 4
      pagure/api/fork.py
  3. 7 6
      pagure/api/issue.py
  4. 0 1
      pagure/api/project.py
  5. 7 3
      pagure/api/user.py

+ 14 - 11
pagure/api/__init__.py

@@ -26,11 +26,11 @@ import markupsafe
 API = flask.Blueprint('api_ns', __name__, url_prefix='/api/0')
 
 
-import pagure
-import pagure.lib
-from pagure import __api_version__, APP, SESSION, authenticated
-from pagure.doc_utils import load_doc, modify_rst, modify_html
-from pagure.exceptions import APIError
+import pagure  # noqa
+import pagure.lib  # noqa
+from pagure import __api_version__, APP, SESSION, authenticated  # noqa
+from pagure.doc_utils import load_doc, modify_rst, modify_html  # noqa
+from pagure.exceptions import APIError  # noqa
 
 
 def preload_docs(endpoint):
@@ -207,13 +207,13 @@ def api_method(function):
 
 
 if pagure.APP.config.get('ENABLE_TICKETS', True):
-    from pagure.api import issue
-from pagure.api import fork
-from pagure.api import project
-from pagure.api import user
+    from pagure.api import issue  # noqa
+from pagure.api import fork  # noqa
+from pagure.api import project  # noqa
+from pagure.api import user  # noqa
 
 if pagure.APP.config.get('PAGURE_CI_SERVICES', False):
-    from pagure.api.ci import jenkins
+    from pagure.api.ci import jenkins  # noqa
 
 
 @API.route('/version/')
@@ -428,7 +428,10 @@ def api_error_codes():
         }
 
     '''
-    errors = {val.name: val.value for val in APIERROR.__members__.values()}     # pylint: disable=no-member
+    errors = {
+        val.name: val.value
+        for val in APIERROR.__members__.values()
+    }  # pylint: disable=no-member
 
     return flask.jsonify(errors)
 

+ 4 - 4
pagure/api/fork.py

@@ -305,7 +305,7 @@ def api_pull_request_merge(repo, requestid, username=None, namespace=None):
           "message": "Changes merged!"
         }
 
-    """
+    """  # noqa
     output = {}
 
     repo = pagure.lib.get_project(
@@ -392,7 +392,7 @@ def api_pull_request_close(repo, requestid, username=None, namespace=None):
           "message": "Pull-request closed!"
         }
 
-    """
+    """  # noqa
     output = {}
 
     repo = pagure.lib.get_project(
@@ -497,7 +497,7 @@ def api_pull_request_add_comment(
           "message": "Comment added"
         }
 
-    """
+    """  # noqa
     repo = pagure.lib.get_project(
         SESSION, repo, user=username, namespace=namespace)
     output = {}
@@ -640,7 +640,7 @@ def api_pull_request_add_flag(repo, requestid, username=None, namespace=None):
           "message": "Flag updated"
         }
 
-    """
+    """  # noqa
     repo = pagure.lib.get_project(
         SESSION, repo, user=username, namespace=namespace)
     output = {}

+ 7 - 6
pagure/api/issue.py

@@ -18,7 +18,8 @@ import pagure.exceptions
 import pagure.lib
 
 from pagure import (
-    APP, SESSION, is_repo_committer, api_authenticated, urlpattern
+    APP, SESSION, is_repo_committer, api_authenticated, urlpattern,
+    is_repo_admin
 )
 from pagure.api import (
     API, api_method, api_login_required, api_login_optional, APIERROR
@@ -485,7 +486,7 @@ def api_view_issue_comment(
           }
         }
 
-    """
+    """  # noqa
 
     repo = pagure.lib.get_project(
         SESSION, repo, user=username, namespace=namespace)
@@ -879,7 +880,8 @@ def api_assign_issue(repo, issueid, username=None, namespace=None):
 
 
 @API.route('/<repo>/issue/<int:issueid>/subscribe', methods=['POST'])
-@API.route('/<namespace>/<repo>/issue/<int:issueid>/subscribe', methods=['POST'])
+@API.route(
+    '/<namespace>/<repo>/issue/<int:issueid>/subscribe', methods=['POST'])
 @API.route(
     '/fork/<username>/<repo>/issue/<int:issueid>/subscribe', methods=['POST'])
 @API.route(
@@ -925,7 +927,7 @@ def api_subscribe_issue(repo, issueid, username=None, namespace=None):
           "message": "User subscribed"
         }
 
-    """
+    """  # noqa
     repo = pagure.lib.get_project(
         SESSION, repo, user=username, namespace=namespace)
     output = {}
@@ -1027,7 +1029,7 @@ def api_update_custom_field(
           "message": "Custom field adjusted"
         }
 
-    """
+    """  # noqa
     repo = pagure.lib.get_project(
         SESSION, repo, user=username, namespace=namespace)
 
@@ -1095,7 +1097,6 @@ def api_update_custom_field(
         SESSION.rollback()
         raise pagure.exceptions.APIError(400, error_code=APIERROR.EDBERROR)
 
-
     if message:
         pagure.lib.add_metadata_update_notif(
             session=SESSION,

+ 0 - 1
pagure/api/project.py

@@ -220,7 +220,6 @@ def api_project(repo, username=None, namespace=None):
     return jsonout
 
 
-
 @API.route('/new/', methods=['POST'])
 @API.route('/new', methods=['POST'])
 @api_login_required(acls=['create_project'])

+ 7 - 3
pagure/api/user.py

@@ -64,7 +64,12 @@ def api_view_user(username):
               "tags": [],
               "namespace": None,
               "priorities": {},
-              "close_status": ["Invalid", "Insufficient data", "Fixed", "Duplicated"],
+              "close_status": [
+                "Invalid",
+                "Insufficient data",
+                "Fixed",
+                "Duplicated"
+              ],
               "milestones": {},
               "user": {
                 "fullname": "ralph",
@@ -120,7 +125,6 @@ def api_view_user(username):
     return jsonout
 
 
-
 @API.route('/user/<username>/activity/stats')
 @api_method
 def api_view_user_activity_stats(username):
@@ -296,7 +300,7 @@ def api_view_user_activity_date(username, date):
           ]
         }
 
-    """
+    """  # noqa
     grouped = str(flask.request.args.get('grouped')).lower() in ['1', 'true']
 
     try: