1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928 |
- # -*- coding: utf-8 -*-
- """
- (c) 2015 - Copyright Red Hat Inc
- Authors:
- Pierre-Yves Chibon <pingou@pingoured.fr>
- """
- from __future__ import unicode_literals, absolute_import
- import datetime
- import unittest
- import shutil
- import sys
- import os
- import json
- from mock import patch, MagicMock
- sys.path.insert(
- 0, os.path.join(os.path.dirname(os.path.abspath(__file__)), "..")
- )
- import pagure.lib.query
- import pagure.default_config
- import tests
- class PagureFlaskApiForktests(tests.Modeltests):
- """ Tests for the flask API of pagure for issue """
- maxDiff = None
- def setUp(self):
- """ Set up the environnment, ran before every tests. """
- super(PagureFlaskApiForktests, self).setUp()
- pagure.config.config["REQUESTS_FOLDER"] = None
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_views_pr_disabled(self):
- """ Test the api_pull_request_views method of the flask api when PR
- are disabled. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- output = self.app.get("/api/0/test/pull-requests")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_views_pr_closed(self):
- """ Test the api_pull_request_views method of the flask api to list
- the closed PRs. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- output = self.app.get("/api/0/test/pull-requests?status=closed")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data["pagination"][k] = "http://localhost..."
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "tags": [],
- "page": 1,
- "per_page": 20,
- "status": "closed",
- },
- "pagination": {
- "first": "http://localhost...",
- "last": "http://localhost...",
- "next": None,
- "page": 1,
- "pages": 0,
- "per_page": 20,
- "prev": None,
- },
- "requests": [],
- "total_requests": 0,
- },
- )
- # Close the PR and try again
- pagure.lib.query.close_pull_request(
- self.session, request=req, user="pingou", merged=False
- )
- output = self.app.get("/api/0/test/pull-requests?status=closed")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "tags": [],
- "page": 1,
- "per_page": 20,
- "status": "closed",
- },
- )
- self.assertEqual(data["total_requests"], 1)
- # Create two closed pull-requests
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="closed pullrequest by user foo on repo test",
- user="foo",
- status="Closed",
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="closed pullrequest by user pingou on repo test",
- user="pingou",
- status="Closed",
- )
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="merged pullrequest by user pingou on repo test",
- user="pingou",
- status="Merged",
- )
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="merged pullrequest by user foo on repo test",
- user="foo",
- status="Merged",
- )
- self.session.commit()
- # Test the API view of closed pull-requests
- output = self.app.get("/api/0/test/pull-requests?status=closed")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(len(data["requests"]), 3)
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- for req in data["requests"]:
- self.assertEqual(req["status"], "Closed")
- self.assertEqual(data["args"]["status"], "closed")
- self.assertEqual(data["args"]["page"], 1)
- self.assertEqual(data["total_requests"], 3)
- # Test the API view of merged pull-requests
- output = self.app.get("/api/0/test/pull-requests?status=merged")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(len(data["requests"]), 2)
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- for req in data["requests"]:
- self.assertEqual(req["status"], "Merged")
- self.assertEqual(data["args"]["status"], "merged")
- self.assertEqual(data["args"]["page"], 1)
- self.assertEqual(data["total_requests"], 2)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_views_all_pr(self):
- """ Test the api_pull_request_views method of the flask api to list
- all PRs. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- output = self.app.get("/api/0/test/pull-requests?status=all")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "tags": [],
- "page": 1,
- "per_page": 20,
- "status": "all",
- },
- )
- self.assertEqual(data["total_requests"], 1)
- # Close the PR and try again
- pagure.lib.query.close_pull_request(
- self.session, request=req, user="pingou", merged=False
- )
- output = self.app.get("/api/0/test/pull-requests?status=all")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "tags": [],
- "page": 1,
- "per_page": 20,
- "status": "all",
- },
- )
- self.assertEqual(data["total_requests"], 1)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_views(self, send_email):
- """ Test the api_pull_request_views method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Invalid repo
- output = self.app.get("/api/0/foo/pull-requests")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # List pull-requests
- output = self.app.get("/api/0/test/pull-requests")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["requests"][0]["date_created"] = "1431414800"
- data["requests"][0]["updated_on"] = "1431414800"
- data["requests"][0]["project"]["date_created"] = "1431414800"
- data["requests"][0]["project"]["date_modified"] = "1431414800"
- data["requests"][0]["repo_from"]["date_created"] = "1431414800"
- data["requests"][0]["repo_from"]["date_modified"] = "1431414800"
- data["requests"][0]["uid"] = "1431414800"
- data["requests"][0]["last_updated"] = "1431414800"
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data["pagination"][k] = "http://localhost..."
- expected_data = {
- "args": {
- "assignee": None,
- "author": None,
- "tags": [],
- "page": 1,
- "per_page": 20,
- "status": True,
- },
- "pagination": {
- "first": "http://localhost...",
- "last": "http://localhost...",
- "next": None,
- "page": 1,
- "pages": 1,
- "per_page": 20,
- "prev": None,
- },
- "requests": [
- {
- "assignee": None,
- "branch": "master",
- "branch_from": "master",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": None,
- "commit_stop": None,
- "date_created": "1431414800",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1431414800",
- "project": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "test pull-request",
- "uid": "1431414800",
- "updated_on": "1431414800",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- }
- ],
- "total_requests": 1,
- }
- self.assertDictEqual(data, expected_data)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Access Pull-Request authenticated
- output = self.app.get("/api/0/test/pull-requests", headers=headers)
- self.assertEqual(output.status_code, 200)
- data2 = json.loads(output.get_data(as_text=True))
- data2["requests"][0]["date_created"] = "1431414800"
- data2["requests"][0]["updated_on"] = "1431414800"
- data2["requests"][0]["project"]["date_created"] = "1431414800"
- data2["requests"][0]["project"]["date_modified"] = "1431414800"
- data2["requests"][0]["repo_from"]["date_created"] = "1431414800"
- data2["requests"][0]["repo_from"]["date_modified"] = "1431414800"
- data2["requests"][0]["uid"] = "1431414800"
- data2["requests"][0]["last_updated"] = "1431414800"
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data2["pagination"][k] = "http://localhost..."
- self.assertDictEqual(data, data2)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_view_tag_filtered(self, send_email):
- """ Test the api_pull_request_view method of the flask api to list
- tag filtered open PRs. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- # Add a tag
- pagure.lib.query.new_tag(
- self.session, "tag-1", "tag-1 description", "#ff0000", repo.id
- )
- # Create a pull-request
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- output = self.app.get("/api/0/test/pull-requests?tags=tag-1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data["pagination"][k] = "http://localhost..."
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "tags": ["tag-1"],
- "page": 1,
- "per_page": 20,
- "status": True,
- },
- "pagination": {
- "first": "http://localhost...",
- "last": "http://localhost...",
- "next": None,
- "page": 1,
- "pages": 0,
- "per_page": 20,
- "prev": None,
- },
- "requests": [],
- "total_requests": 0,
- },
- )
- # Tag the PR and try again
- pagure.lib.query.update_tags(
- self.session, obj=req, tags=["tag-1"], username="pingou"
- )
- self.session.commit()
- output = self.app.get("/api/0/test/pull-requests?tags=tag-1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "tags": ["tag-1"],
- "page": 1,
- "per_page": 20,
- "status": True,
- },
- )
- self.assertEqual(data["total_requests"], 1)
- # Try negative filtering
- output = self.app.get("/api/0/test/pull-requests?tags=!tag-1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data["pagination"][k] = "http://localhost..."
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "tags": ["!tag-1"],
- "page": 1,
- "per_page": 20,
- "status": True,
- },
- "pagination": {
- "first": "http://localhost...",
- "last": "http://localhost...",
- "next": None,
- "page": 1,
- "pages": 0,
- "per_page": 20,
- "prev": None,
- },
- "requests": [],
- "total_requests": 0,
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_view_pr_disabled(self, send_email):
- """ Test the api_pull_request_view method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_view(self, send_email):
- """ Test the api_pull_request_view method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Invalid repo
- output = self.app.get("/api/0/foo/pull-request/1")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Invalid issue for this repo
- output = self.app.get("/api/0/test2/pull-request/1")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid issue
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["date_created"] = "1431414800"
- data["updated_on"] = "1431414800"
- data["project"]["date_created"] = "1431414800"
- data["project"]["date_modified"] = "1431414800"
- data["repo_from"]["date_created"] = "1431414800"
- data["repo_from"]["date_modified"] = "1431414800"
- data["uid"] = "1431414800"
- data["last_updated"] = "1431414800"
- expected_data = {
- "assignee": None,
- "branch": "master",
- "branch_from": "master",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": None,
- "commit_stop": None,
- "date_created": "1431414800",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1431414800",
- "project": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "test pull-request",
- "uid": "1431414800",
- "updated_on": "1431414800",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- }
- self.assertDictEqual(data, expected_data)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Access Pull-Request authenticated
- output = self.app.get("/api/0/test/pull-request/1", headers=headers)
- self.assertEqual(output.status_code, 200)
- data2 = json.loads(output.get_data(as_text=True))
- data2["date_created"] = "1431414800"
- data2["project"]["date_created"] = "1431414800"
- data2["project"]["date_modified"] = "1431414800"
- data2["repo_from"]["date_created"] = "1431414800"
- data2["repo_from"]["date_modified"] = "1431414800"
- data2["uid"] = "1431414800"
- data2["date_created"] = "1431414800"
- data2["updated_on"] = "1431414800"
- data2["last_updated"] = "1431414800"
- self.assertDictEqual(data, data2)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_by_uid_view(self, send_email):
- """ Test the api_pull_request_by_uid_view method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- uid = req.uid
- # Invalid request
- output = self.app.get("/api/0/pull-requests/{}".format(uid + "aaa"))
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid issue
- output = self.app.get("/api/0/pull-requests/{}".format(uid))
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["date_created"] = "1431414800"
- data["updated_on"] = "1431414800"
- data["project"]["date_created"] = "1431414800"
- data["project"]["date_modified"] = "1431414800"
- data["repo_from"]["date_created"] = "1431414800"
- data["repo_from"]["date_modified"] = "1431414800"
- data["last_updated"] = "1431414800"
- expected_data = {
- "assignee": None,
- "branch": "master",
- "branch_from": "master",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": None,
- "commit_stop": None,
- "date_created": "1431414800",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1431414800",
- "project": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "test pull-request",
- "uid": uid,
- "updated_on": "1431414800",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- }
- self.assertDictEqual(data, expected_data)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Access Pull-Request authenticated
- output = self.app.get(
- "/api/0/pull-requests/{}".format(uid), headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data2 = json.loads(output.get_data(as_text=True))
- data2["date_created"] = "1431414800"
- data2["project"]["date_created"] = "1431414800"
- data2["project"]["date_modified"] = "1431414800"
- data2["repo_from"]["date_created"] = "1431414800"
- data2["repo_from"]["date_modified"] = "1431414800"
- data2["date_created"] = "1431414800"
- data2["updated_on"] = "1431414800"
- data2["last_updated"] = "1431414800"
- self.assertDictEqual(data, data2)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_close_pr_disabled(self, send_email):
- """ Test the api_pull_request_close method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_close(self, send_email):
- """ Test the api_pull_request_close method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # Invalid PR
- output = self.app.post(
- "/api/0/test/pull-request/2/close", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a token for foo for this project
- item = pagure.lib.model.Token(
- id="foobar_token",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- # Allow the token to close PR
- acls = pagure.lib.query.get_acls(self.session)
- for acl in acls:
- if acl.name == "pull_request_close":
- break
- item = pagure.lib.model.TokenAcl(
- token_id="foobar_token", acl_id=acl.id
- )
- self.session.add(item)
- self.session.commit()
- headers = {"Authorization": "token foobar_token"}
- # User not admin
- output = self.app.post(
- "/api/0/test/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to merge/close pull-request "
- "for this project",
- "error_code": "ENOPRCLOSE",
- },
- )
- headers = {"Authorization": "token aaabbbcccddd"}
- # Close PR
- output = self.app.post(
- "/api/0/test/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Pull-request closed!"})
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_pr_disabled(self, send_email):
- """ Test the api_pull_request_merge method of the flask api when PR
- are disabled. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_only_assigned(self, send_email):
- """ Test the api_pull_request_merge method of the flask api when
- only assignee can merge the PR and the PR isn't assigned. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Only_assignee_can_merge_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This request must be assigned to be merged",
- "error_code": "ENOTASSIGNED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_only_assigned_not_assignee(
- self, send_email
- ):
- """ Test the api_pull_request_merge method of the flask api when
- only assignee can merge the PR and the PR isn't assigned to the
- user asking to merge. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- req.assignee = pagure.lib.query.search_user(self.session, "foo")
- self.session.add(req)
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Only_assignee_can_merge_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Only the assignee can merge this request",
- "error_code": "ENOTASSIGNEE",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_minimal_score(self, send_email):
- """ Test the api_pull_request_merge method of the flask api when
- a PR requires a certain minimal score to be merged. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Minimum_score_to_merge_pull-request"] = 2
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This request does not have the minimum review "
- "score necessary to be merged",
- "error_code": "EPRSCORE",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge(self, send_email):
- """ Test the api_pull_request_merge method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # Invalid PR
- output = self.app.post(
- "/api/0/test/pull-request/2/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a token for foo for this project
- item = pagure.lib.model.Token(
- id="foobar_token",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- # Allow the token to merge PR
- acls = pagure.lib.query.get_acls(self.session)
- for acl in acls:
- if acl.name == "pull_request_merge":
- break
- item = pagure.lib.model.TokenAcl(
- token_id="foobar_token", acl_id=acl.id
- )
- self.session.add(item)
- self.session.commit()
- headers = {"Authorization": "token foobar_token"}
- # User not admin
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to merge/close pull-request "
- "for this project",
- "error_code": "ENOPRCLOSE",
- },
- )
- headers = {"Authorization": "token aaabbbcccddd"}
- # Merge PR
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Changes merged!"})
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_conflicting(self, send_email):
- """ Test the api_pull_request_merge method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.add_content_git_repo(
- os.path.join(self.path, "repos", "test.git")
- )
- # Fork
- project = pagure.lib.query.get_authorized_project(self.session, "test")
- task = pagure.lib.query.fork_project(
- session=self.session, user="pingou", repo=project
- )
- self.session.commit()
- self.assertEqual(
- task.get(),
- {
- "endpoint": "ui_ns.view_repo",
- "repo": "test",
- "namespace": None,
- "username": "pingou",
- },
- )
- # Add content to the fork
- tests.add_content_to_git(
- os.path.join(self.path, "repos", "forks", "pingou", "test.git"),
- filename="foobar",
- content="content from the fork",
- )
- # Add content to the main repo, so they conflict
- tests.add_content_to_git(
- os.path.join(self.path, "repos", "test.git"),
- filename="foobar",
- content="content from the main repo",
- )
- project = pagure.lib.query.get_authorized_project(self.session, "test")
- fork = pagure.lib.query.get_authorized_project(
- self.session, "test", user="pingou"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=fork,
- branch_from="master",
- repo_to=project,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Merge PR
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 409)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This pull-request conflicts and thus cannot be merged",
- "error_code": "EPRCONFLICTS",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_user_token(self, send_email):
- """ Test the api_pull_request_merge method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, invalid PR
- output = self.app.post(
- "/api/0/test2/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid token, invalid PR - other project
- output = self.app.post(
- "/api/0/test/pull-request/2/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a token for foo for this project
- item = pagure.lib.model.Token(
- id="foobar_token",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- # Allow the token to merge PR
- acls = pagure.lib.query.get_acls(self.session)
- acl = None
- for acl in acls:
- if acl.name == "pull_request_merge":
- break
- item = pagure.lib.model.TokenAcl(
- token_id="foobar_token", acl_id=acl.id
- )
- self.session.add(item)
- self.session.commit()
- headers = {"Authorization": "token foobar_token"}
- # User not admin
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to merge/close pull-request "
- "for this project",
- "error_code": "ENOPRCLOSE",
- },
- )
- headers = {"Authorization": "token aaabbbcccddd"}
- # Merge PR
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Changes merged!"})
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_add_comment(self, mockemail):
- """ Test the api_pull_request_add_comment method of the flask api. """
- mockemail.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # No input
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check comments before
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"title": "test issue"}
- # Incomplete request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"comment": ["This field is required."]},
- },
- )
- # No change
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"comment": "This is a very interesting question"}
- # Valid request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- # One comment added
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 1)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_add_comment_wrong_user(self):
- """ Test the api_pull_request_add_comment method of the flask api
- when the user is not found in the DB. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- data = {"comment": "This is a very interesting question"}
- # Valid request
- with patch(
- "pagure.lib.query.add_pull_request_comment",
- side_effect=pagure.exceptions.PagureException("error"),
- ):
- output = self.app.post(
- "/api/0/test/pull-request/1/comment",
- data=data,
- headers=headers,
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "error", "error_code": "ENOCODE"}
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_add_comment_pr_disabled(self):
- """ Test the api_pull_request_add_comment method of the flask api
- when PRs are disabled. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- data = {"comment": "This is a very interesting question"}
- # Valid request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- # no comment added
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_add_comment_user_token(self, mockemail):
- """ Test the api_pull_request_add_comment method of the flask api. """
- mockemail.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, invalid request
- output = self.app.post(
- "/api/0/test2/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid token, invalid request in another project
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check comments before
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"title": "test issue"}
- # Incomplete request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"comment": ["This field is required."]},
- },
- )
- # No change
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"comment": "This is a very interesting question"}
- # Valid request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- # One comment added
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 1)
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request_pr_disabled(self, p_send_email):
- """ Test the api_subscribe_pull_request method of the flask api. """
- p_send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request_invalid_token(
- self, p_send_email, p_ugt
- ):
- """ Test the api_subscribe_pull_request method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- item = pagure.lib.model.User(
- user="bar",
- fullname="bar foo",
- password="foo",
- default_email="bar@bar.com",
- )
- self.session.add(item)
- item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
- self.session.add(item)
- self.session.commit()
- tests.create_projects(self.session)
- tests.create_tokens(self.session, user_id=3, project_id=2)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Create pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="feature",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check subscribtion before
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit "
- "http://localhost.localdomain/settings#nav-api-tab to get or "
- "renew your API token.",
- "error_code": "EINVALIDTOK",
- },
- )
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request(self, p_send_email, p_ugt):
- """ Test the api_subscribe_pull_request method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- item = pagure.lib.model.User(
- user="bar",
- fullname="bar foo",
- password="foo",
- default_email="bar@bar.com",
- )
- self.session.add(item)
- item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
- self.session.add(item)
- self.session.commit()
- tests.create_projects(self.session)
- tests.create_tokens(self.session, user_id=3)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # No input
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="feature",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check subscribtion before
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- # Unsubscribe - no changes
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are no longer watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are no longer watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- # No change
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- # Subscribe
- data = {"status": True}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are now watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- # Subscribe - no changes
- data = {"status": True}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are now watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou", "bar"]),
- )
- # Unsubscribe
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are no longer watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request_logged_in(self, p_send_email, p_ugt):
- """ Test the api_subscribe_pull_request method of the flask api
- when the user is logged in via the UI. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- item = pagure.lib.model.User(
- user="bar",
- fullname="bar foo",
- password="foo",
- default_email="bar@bar.com",
- )
- self.session.add(item)
- item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
- self.session.add(item)
- self.session.commit()
- tests.create_projects(self.session)
- tests.create_tokens(self.session, user_id=3)
- tests.create_tokens_acl(self.session)
- # Create pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="feature",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check subscribtion before
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- # Subscribe
- user = tests.FakeUser(username="foo")
- with tests.user_set(self.app.application, user):
- data = {"status": True}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are now watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "foo",
- },
- )
- # Check subscribtions after
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou", "foo"]),
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_project(self):
- """ Test the api_pull_request_create method of the flask api when
- not the project doesn't exist.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/foobar/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_title(self):
- """ Test the api_pull_request_create method of the flask api when
- not title is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"title": ["This field is required."]},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_branch_to(self):
- """ Test the api_pull_request_create method of the flask api when
- not branch to is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"branch_to": ["This field is required."]},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_branch_from(self):
- """ Test the api_pull_request_create method of the flask api when
- not branch from is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"branch_from": ["This field is required."]},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_pr_disabled(self):
- """ Test the api_pull_request_create method of the flask api when
- the parent repo disabled pull-requests.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_signed_pr(self):
- """ Test the api_pull_request_create method of the flask api when
- the parent repo enforces signed-off pull-requests.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Enforce_signed-off_commits_in_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This repo enforces that all commits are signed "
- "off by their author.",
- "error_code": "ENOSIGNEDOFF",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_branch_from(self):
- """ Test the api_pull_request_create method of the flask api when
- the branch from does not exist.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Enforce_signed-off_commits_in_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "foobarbaz",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": "Branch foobarbaz does not exist",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_token(self):
- """ Test the api_pull_request_create method of the flask api when
- queried with an invalid token.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "foobarbaz",
- }
- output = self.app.post(
- "/api/0/test2/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit "
- "http://localhost.localdomain/settings#nav-api-tab to get or "
- "renew your API token.",
- "error_code": "EINVALIDTOK",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_access(self):
- """ Test the api_pull_request_create method of the flask api when
- the user opening the PR doesn't have commit access.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, user_id=2)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "foobarbaz",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You do not have sufficient permissions to "
- "perform this action",
- "error_code": "ENOTHIGHENOUGH",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_branch_to(self):
- """ Test the api_pull_request_create method of the flask api when
- the branch to does not exist.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Enforce_signed-off_commits_in_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "foobarbaz",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": "Branch foobarbaz could not be found in the "
- "target repo",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_project_token_different_project(self):
- """Test the api_pull_request_create method with the project token
- of a different project - fails"""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, project_id=2)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token foo_token"}
- data = {
- "title": "Test of PR",
- "inicial comment": "Some readme adjustment",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_user_token_invalid_acls(self):
- """Test the api_pull_request_create method with the user token, but with
- no acls for opening pull request - fails"""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, project_id=None)
- for acl in (
- "create_project",
- "fork_project",
- "modify_project",
- "update_watch_status",
- ):
- tests.create_tokens_acl(self.session, acl_name=acl)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test of PR",
- "initial_comment": "Some readme adjustment",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_from_branch_to_origin(self):
- """Test the api_pull_request_create method from a fork to a master,
- with project token of a origin with all the acls"""
- tests.create_projects(self.session)
- tests.create_projects(
- self.session, is_fork=True, hook_token_suffix="foo"
- )
- project_query = self.session.query(pagure.lib.model.Project)
- for project in project_query.filter_by(name="test").all():
- if project.parent_id == None:
- parent = project
- else:
- child = project
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(
- os.path.join(self.path, "repos", "forks", "pingou", "test.git"),
- branch="branch",
- )
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "forks", "pingou", "test.git"),
- branch="branch",
- )
- # Create tokens
- parent_token = pagure.lib.model.Token(
- id="iamparenttoken",
- user_id=parent.user_id,
- project_id=parent.id,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(parent_token)
- fork_token = pagure.lib.model.Token(
- id="iamforktoken",
- user_id=child.user_id,
- project_id=child.id,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(fork_token)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id="iamparenttoken")
- for acl in pagure.default_config.CROSS_PROJECT_ACLS:
- tests.create_tokens_acl(
- self.session, token_id="iamforktoken", acl_name=acl
- )
- headers = {"Authorization": "token iamforktoken"}
- data = {
- "title": "war of tomatoes",
- "initial_comment": "the manifest",
- "branch_to": "master",
- "branch_from": "branch",
- "repo_from": "test",
- "repo_from_username": "pingou",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open(self):
- """ Test the api_pull_request_create method of the flask api. """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["project"]["date_created"] = "1516348115"
- data["project"]["date_modified"] = "1516348115"
- data["repo_from"]["date_created"] = "1516348115"
- data["repo_from"]["date_modified"] = "1516348115"
- data["uid"] = "e8b68df8711648deac67c3afed15a798"
- data["commit_start"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["commit_stop"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["date_created"] = "1516348115"
- data["last_updated"] = "1516348115"
- data["updated_on"] = "1516348115"
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "branch": "master",
- "branch_from": "test",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "commit_stop": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "date_created": "1516348115",
- "id": 1,
- "initial_comment": "Nothing much, the changes speak for themselves",
- "last_updated": "1516348115",
- "project": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "Test PR",
- "uid": "e8b68df8711648deac67c3afed15a798",
- "updated_on": "1516348115",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_initial_comment(self):
- """ Test the api_pull_request_create method of the flask api when
- not initial comment is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["project"]["date_created"] = "1516348115"
- data["project"]["date_modified"] = "1516348115"
- data["repo_from"]["date_created"] = "1516348115"
- data["repo_from"]["date_modified"] = "1516348115"
- data["uid"] = "e8b68df8711648deac67c3afed15a798"
- data["commit_start"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["commit_stop"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["date_created"] = "1516348115"
- data["last_updated"] = "1516348115"
- data["updated_on"] = "1516348115"
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "branch": "master",
- "branch_from": "test",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "commit_stop": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "date_created": "1516348115",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1516348115",
- "project": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "Test PR",
- "uid": "e8b68df8711648deac67c3afed15a798",
- "updated_on": "1516348115",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- )
- class PagureFlaskApiForkPRDiffStatstests(tests.Modeltests):
- """ Tests for the flask API of pagure for the diff stats endpoint of PRs
- """
- maxDiff = None
- def setUp(self):
- """ Set up the environnment, ran before every tests. """
- super(PagureFlaskApiForkPRDiffStatstests, self).setUp()
- pagure.config.config["REQUESTS_FOLDER"] = None
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), ncommits=5
- )
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_no_repo(self):
- """ Test the api_pull_request_merge method of the flask api. """
- output = self.app.get("/api/0/invalid/pull-request/404/diffstats")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_no_pr(self):
- """ Test the api_pull_request_merge method of the flask api. """
- output = self.app.get("/api/0/test/pull-request/404/diffstats")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_file_modified(self):
- """ Test the api_pull_request_merge method of the flask api. """
- output = self.app.get("/api/0/test/pull-request/1/diffstats")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data,
- {
- "sources": {
- "lines_added": 10,
- "lines_removed": 0,
- "new_id": "540916fbd3d825d14cc0c0b2397606fda69379ce",
- "old_id": "265f133a7c94ede4cb183dd808219c5bf9e08f87",
- "old_path": "sources",
- "status": "M",
- }
- },
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_file_added_mofidied(self):
- """ Test the api_pull_request_merge method of the flask api. """
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), ncommits=5
- )
- tests.add_readme_git_repo(
- os.path.join(self.path, "repos", "test.git"),
- readme_name="README.md",
- branch="test",
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.requests), 1)
- output = self.app.get("/api/0/test/pull-request/1/diffstats")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertTrue(
- data
- in [
- {
- "README.md": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "bd913ea153650b94f33f53e5164c36a28b761bf4",
- "old_id": "0000000000000000000000000000000000000000",
- "old_path": "README.md",
- "status": "A",
- },
- "sources": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "540916fbd3d825d14cc0c0b2397606fda69379ce",
- "old_id": "293500070b9dfc6ab66e31383f8f7fccf6a95fe2",
- "old_path": "sources",
- "status": "M",
- },
- },
- {
- "README.md": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "bd913ea153650b94f33f53e5164c36a28b761bf4",
- "old_id": "0000000000000000000000000000000000000000",
- "old_path": "README.md",
- "status": "A",
- },
- "sources": {
- "lines_added": 10,
- "lines_removed": 0,
- "new_id": "540916fbd3d825d14cc0c0b2397606fda69379ce",
- "old_id": "265f133a7c94ede4cb183dd808219c5bf9e08f87",
- "old_path": "sources",
- "status": "M",
- },
- },
- ]
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_file_modified_deleted(self):
- """ Test the api_pull_request_merge method of the flask api. """
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.requests), 1)
- pagure.lib.tasks.update_pull_request(repo.requests[0].uid)
- tests.add_readme_git_repo(
- os.path.join(self.path, "repos", "test.git"),
- readme_name="README.md",
- branch="test",
- )
- tests.remove_file_git_repo(
- os.path.join(self.path, "repos", "test.git"),
- filename="sources",
- branch="test",
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.requests), 1)
- pagure.lib.tasks.update_pull_request(repo.requests[0].uid)
- output = self.app.get("/api/0/test/pull-request/1/diffstats")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data,
- {
- "README.md": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "bd913ea153650b94f33f53e5164c36a28b761bf4",
- "old_id": "0000000000000000000000000000000000000000",
- "old_path": "README.md",
- "status": "A",
- },
- "sources": {
- "lines_added": 0,
- "lines_removed": 5,
- "new_id": "0000000000000000000000000000000000000000",
- "old_id": "265f133a7c94ede4cb183dd808219c5bf9e08f87",
- "old_path": "sources",
- "status": "D",
- },
- },
- )
- class PagureApiThresholdReachedTests(tests.Modeltests):
- """ Test the behavior of the threshold_reached value returned by the API.
- """
- maxDiff = None
- def _clean_data(self, data):
- data["project"]["date_created"] = "1516348115"
- data["project"]["date_modified"] = "1516348115"
- data["repo_from"]["date_created"] = "1516348115"
- data["repo_from"]["date_modified"] = "1516348115"
- data["uid"] = "e8b68df8711648deac67c3afed15a798"
- data["commit_start"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["commit_stop"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["date_created"] = "1516348115"
- data["last_updated"] = "1516348115"
- data["updated_on"] = "1516348115"
- data["comments"] = [] # Let's not check the comments
- return data
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def setUp(self):
- """ Set up the environment for the tests. """
- super(PagureApiThresholdReachedTests, self).setUp()
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Add a token for user `foo`
- item = pagure.lib.model.Token(
- id="aaabbbcccddd_foo",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id="aaabbbcccddd_foo")
- # Add a minimal required score:
- repo = pagure.lib.query._get_project(self.session, "test")
- settings = repo.settings
- settings["Minimum_score_to_merge_pull-request"] = 2
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- self.expected_data = {
- "assignee": None,
- "branch": "master",
- "branch_from": "test",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "commit_stop": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "date_created": "1516348115",
- "id": 1,
- "initial_comment": "Nothing much, the changes speak for themselves",
- "last_updated": "1516348115",
- "project": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "collaborator": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "Test PR",
- "uid": "e8b68df8711648deac67c3afed15a798",
- "updated_on": "1516348115",
- "user": {
- "fullname": "PY C",
- "name": "pingou",
- "url_path": "user/pingou",
- },
- }
- def test_api_pull_request_no_comments(self):
- """ Check the value of threshold_reach when the PR has no comments.
- """
- # Check the PR with 0 comment:
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_one_comments(self):
- """ Check the value of threshold_reach when the PR has one comment.
- """
- # Check the PR with 1 comment:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_two_comments_one_person(self):
- """ Check the value of threshold_reach when the PR has two comments
- but from the same person.
- """
- # Add two comments from the same user:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "Indeed it is :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_two_comments_two_persons(self):
- """ Check the value of threshold_reach when the PR has two comments
- from two different persons.
- """
- # Add two comments from two users:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd_foo"}
- data = {"comment": "Indeed it is :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- data["comments"] = [] # Let's not check the comments
- self.expected_data["threshold_reached"] = True
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_three_comments_two_persons_changed_to_no(self):
- """ Check the value of threshold_reach when the PR has three
- comments from two person among which one changed their mind from
- +1 to -1.
- """
- # Add three comments from two users:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd_foo"}
- data = {"comment": "Indeed it is :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- data = {
- "comment": "Nevermind the bug is elsewhere in fact :thumbsdown:"
- }
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- data["comments"] = [] # Let's not check the comments
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_three_comments_two_persons_changed_to_yes(self):
- """ Check the value of threshold_reach when the PR has three
- comments from two person among which one changed their mind from
- -1 to +1
- """
- # Add three comments from two users:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd_foo"}
- data = {"comment": "I think the bug is elsewhere :thumbsdown:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- data = {"comment": "Nevermind it is here :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- data["comments"] = [] # Let's not check the comments
- self.expected_data["threshold_reached"] = True
- self.assertDictEqual(data, self.expected_data)
- class PagureFlaskApiForkGetCommenttests(tests.Modeltests):
- """ Tests for the flask API of pagure for the comment endpoint of PRs
- """
- maxDiff = None
- def setUp(self):
- """ Set up the environment, ran before every tests. """
- super(PagureFlaskApiForkGetCommenttests, self).setUp()
- pagure.config.config["REQUESTS_FOLDER"] = None
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), ncommits=5
- )
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- # Create the pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- pagure.lib.query.add_pull_request_comment(
- session=self.session,
- request=req,
- commit=None,
- tree_id=None,
- filename=None,
- row=None,
- comment="+1",
- user="pingou",
- notify=False,
- notification=True,
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- self.assertEqual(len(req.comments), 1)
- self.assertEqual(req.comments[0].id, 1)
- def test_api_pull_request_get_comment_not_found(self):
- """ Test the api_pull_request_get_comment method of the flask api. """
- output = self.app.get("/api/0/test/pull-request/1/comment/2")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data, {"error": "Comment not found", "error_code": "ENOCOMMENT"}
- )
- def test_api_pull_request_get_comment(self):
- """ Test the api_pull_request_get_comment method of the flask api. """
- output = self.app.get("/api/0/test/pull-request/1/comment/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(data["comment"], "+1")
- if __name__ == "__main__":
- unittest.main(verbosity=2)
|