123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594 |
- # -*- coding: utf-8 -*-
- """
- (c) 2015 - Copyright Red Hat Inc
- Authors:
- Pierre-Yves Chibon <pingou@pingoured.fr>
- """
- from __future__ import unicode_literals, absolute_import
- import datetime
- import unittest
- import shutil
- import sys
- import os
- import json
- from mock import patch, MagicMock
- sys.path.insert(
- 0, os.path.join(os.path.dirname(os.path.abspath(__file__)), "..")
- )
- import pagure.lib.query
- import pagure.default_config
- import tests
- class PagureFlaskApiForktests(tests.Modeltests):
- """ Tests for the flask API of pagure for issue """
- maxDiff = None
- def setUp(self):
- """ Set up the environnment, ran before every tests. """
- super(PagureFlaskApiForktests, self).setUp()
- pagure.config.config["REQUESTS_FOLDER"] = None
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_views_pr_disabled(self):
- """ Test the api_pull_request_views method of the flask api when PR
- are disabled. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- output = self.app.get("/api/0/test/pull-requests")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_views_pr_closed(self):
- """ Test the api_pull_request_views method of the flask api to list
- the closed PRs. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- output = self.app.get("/api/0/test/pull-requests?status=closed")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data["pagination"][k] = "http://localhost..."
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "page": 1,
- "per_page": 20,
- "status": "closed",
- },
- "pagination": {
- "first": "http://localhost...",
- "last": "http://localhost...",
- "next": None,
- "page": 1,
- "pages": 0,
- "per_page": 20,
- "prev": None,
- },
- "requests": [],
- "total_requests": 0,
- },
- )
- # Close the PR and try again
- pagure.lib.query.close_pull_request(
- self.session, request=req, user="pingou", merged=False
- )
- output = self.app.get("/api/0/test/pull-requests?status=closed")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "page": 1,
- "per_page": 20,
- "status": "closed",
- },
- )
- self.assertEqual(data["total_requests"], 1)
- # Create two closed pull-requests
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="closed pullrequest by user foo on repo test",
- user="foo",
- status="Closed",
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="closed pullrequest by user pingou on repo test",
- user="pingou",
- status="Closed",
- )
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="merged pullrequest by user pingou on repo test",
- user="pingou",
- status="Merged",
- )
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="merged pullrequest by user foo on repo test",
- user="foo",
- status="Merged",
- )
- self.session.commit()
- # Test the API view of closed pull-requests
- output = self.app.get("/api/0/test/pull-requests?status=closed")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(len(data["requests"]), 3)
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- for req in data["requests"]:
- self.assertEqual(req["status"], "Closed")
- self.assertEqual(data["args"]["status"], "closed")
- self.assertEqual(data["args"]["page"], 1)
- self.assertEqual(data["total_requests"], 3)
- # Test the API view of merged pull-requests
- output = self.app.get("/api/0/test/pull-requests?status=merged")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(len(data["requests"]), 2)
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- for req in data["requests"]:
- self.assertEqual(req["status"], "Merged")
- self.assertEqual(data["args"]["status"], "merged")
- self.assertEqual(data["args"]["page"], 1)
- self.assertEqual(data["total_requests"], 2)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_views_all_pr(self):
- """ Test the api_pull_request_views method of the flask api to list
- all PRs. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- output = self.app.get("/api/0/test/pull-requests?status=all")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "page": 1,
- "per_page": 20,
- "status": "all",
- },
- )
- self.assertEqual(data["total_requests"], 1)
- # Close the PR and try again
- pagure.lib.query.close_pull_request(
- self.session, request=req, user="pingou", merged=False
- )
- output = self.app.get("/api/0/test/pull-requests?status=all")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- sorted(data.keys()),
- ["args", "pagination", "requests", "total_requests"],
- )
- self.assertDictEqual(
- data["args"],
- {
- "assignee": None,
- "author": None,
- "page": 1,
- "per_page": 20,
- "status": "all",
- },
- )
- self.assertEqual(data["total_requests"], 1)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_views(self, send_email):
- """ Test the api_pull_request_views method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Invalid repo
- output = self.app.get("/api/0/foo/pull-requests")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # List pull-requests
- output = self.app.get("/api/0/test/pull-requests")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["requests"][0]["date_created"] = "1431414800"
- data["requests"][0]["updated_on"] = "1431414800"
- data["requests"][0]["project"]["date_created"] = "1431414800"
- data["requests"][0]["project"]["date_modified"] = "1431414800"
- data["requests"][0]["repo_from"]["date_created"] = "1431414800"
- data["requests"][0]["repo_from"]["date_modified"] = "1431414800"
- data["requests"][0]["uid"] = "1431414800"
- data["requests"][0]["last_updated"] = "1431414800"
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data["pagination"][k] = "http://localhost..."
- expected_data = {
- "args": {
- "assignee": None,
- "author": None,
- "page": 1,
- "per_page": 20,
- "status": True,
- },
- "pagination": {
- "first": "http://localhost...",
- "last": "http://localhost...",
- "next": None,
- "page": 1,
- "pages": 1,
- "per_page": 20,
- "prev": None,
- },
- "requests": [
- {
- "assignee": None,
- "branch": "master",
- "branch_from": "master",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": None,
- "commit_stop": None,
- "date_created": "1431414800",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1431414800",
- "project": {
- "access_groups": {
- "admin": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {
- "admin": [],
- "commit": [],
- "ticket": [],
- },
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "test pull-request",
- "uid": "1431414800",
- "updated_on": "1431414800",
- "user": {"fullname": "PY C", "name": "pingou"},
- }
- ],
- "total_requests": 1,
- }
- self.assertDictEqual(data, expected_data)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Access Pull-Request authenticated
- output = self.app.get("/api/0/test/pull-requests", headers=headers)
- self.assertEqual(output.status_code, 200)
- data2 = json.loads(output.get_data(as_text=True))
- data2["requests"][0]["date_created"] = "1431414800"
- data2["requests"][0]["updated_on"] = "1431414800"
- data2["requests"][0]["project"]["date_created"] = "1431414800"
- data2["requests"][0]["project"]["date_modified"] = "1431414800"
- data2["requests"][0]["repo_from"]["date_created"] = "1431414800"
- data2["requests"][0]["repo_from"]["date_modified"] = "1431414800"
- data2["requests"][0]["uid"] = "1431414800"
- data2["requests"][0]["last_updated"] = "1431414800"
- for k in ["first", "last"]:
- self.assertIsNotNone(data["pagination"][k])
- data2["pagination"][k] = "http://localhost..."
- self.assertDictEqual(data, data2)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_view_pr_disabled(self, send_email):
- """ Test the api_pull_request_view method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_view(self, send_email):
- """ Test the api_pull_request_view method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Invalid repo
- output = self.app.get("/api/0/foo/pull-request/1")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Invalid issue for this repo
- output = self.app.get("/api/0/test2/pull-request/1")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid issue
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["date_created"] = "1431414800"
- data["updated_on"] = "1431414800"
- data["project"]["date_created"] = "1431414800"
- data["project"]["date_modified"] = "1431414800"
- data["repo_from"]["date_created"] = "1431414800"
- data["repo_from"]["date_modified"] = "1431414800"
- data["uid"] = "1431414800"
- data["last_updated"] = "1431414800"
- expected_data = {
- "assignee": None,
- "branch": "master",
- "branch_from": "master",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": None,
- "commit_stop": None,
- "date_created": "1431414800",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1431414800",
- "project": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "test pull-request",
- "uid": "1431414800",
- "updated_on": "1431414800",
- "user": {"fullname": "PY C", "name": "pingou"},
- }
- self.assertDictEqual(data, expected_data)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Access Pull-Request authenticated
- output = self.app.get("/api/0/test/pull-request/1", headers=headers)
- self.assertEqual(output.status_code, 200)
- data2 = json.loads(output.get_data(as_text=True))
- data2["date_created"] = "1431414800"
- data2["project"]["date_created"] = "1431414800"
- data2["project"]["date_modified"] = "1431414800"
- data2["repo_from"]["date_created"] = "1431414800"
- data2["repo_from"]["date_modified"] = "1431414800"
- data2["uid"] = "1431414800"
- data2["date_created"] = "1431414800"
- data2["updated_on"] = "1431414800"
- data2["last_updated"] = "1431414800"
- self.assertDictEqual(data, data2)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_by_uid_view(self, send_email):
- """ Test the api_pull_request_by_uid_view method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- uid = req.uid
- # Invalid request
- output = self.app.get("/api/0/pull-requests/{}".format(uid + "aaa"))
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid issue
- output = self.app.get("/api/0/pull-requests/{}".format(uid))
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["date_created"] = "1431414800"
- data["updated_on"] = "1431414800"
- data["project"]["date_created"] = "1431414800"
- data["project"]["date_modified"] = "1431414800"
- data["repo_from"]["date_created"] = "1431414800"
- data["repo_from"]["date_modified"] = "1431414800"
- data["last_updated"] = "1431414800"
- expected_data = {
- "assignee": None,
- "branch": "master",
- "branch_from": "master",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": None,
- "commit_stop": None,
- "date_created": "1431414800",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1431414800",
- "project": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1431414800",
- "date_modified": "1431414800",
- "description": "test project #1",
- "fullname": "test",
- "url_path": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "test pull-request",
- "uid": uid,
- "updated_on": "1431414800",
- "user": {"fullname": "PY C", "name": "pingou"},
- }
- self.assertDictEqual(data, expected_data)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Access Pull-Request authenticated
- output = self.app.get(
- "/api/0/pull-requests/{}".format(uid), headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data2 = json.loads(output.get_data(as_text=True))
- data2["date_created"] = "1431414800"
- data2["project"]["date_created"] = "1431414800"
- data2["project"]["date_modified"] = "1431414800"
- data2["repo_from"]["date_created"] = "1431414800"
- data2["repo_from"]["date_modified"] = "1431414800"
- data2["date_created"] = "1431414800"
- data2["updated_on"] = "1431414800"
- data2["last_updated"] = "1431414800"
- self.assertDictEqual(data, data2)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_close_pr_disabled(self, send_email):
- """ Test the api_pull_request_close method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_close(self, send_email):
- """ Test the api_pull_request_close method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # Invalid PR
- output = self.app.post(
- "/api/0/test/pull-request/2/close", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a token for foo for this project
- item = pagure.lib.model.Token(
- id="foobar_token",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- # Allow the token to close PR
- acls = pagure.lib.query.get_acls(self.session)
- for acl in acls:
- if acl.name == "pull_request_close":
- break
- item = pagure.lib.model.TokenAcl(
- token_id="foobar_token", acl_id=acl.id
- )
- self.session.add(item)
- self.session.commit()
- headers = {"Authorization": "token foobar_token"}
- # User not admin
- output = self.app.post(
- "/api/0/test/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to merge/close pull-request "
- "for this project",
- "error_code": "ENOPRCLOSE",
- },
- )
- headers = {"Authorization": "token aaabbbcccddd"}
- # Close PR
- output = self.app.post(
- "/api/0/test/pull-request/1/close", headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Pull-request closed!"})
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_pr_disabled(self, send_email):
- """ Test the api_pull_request_merge method of the flask api when PR
- are disabled. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_only_assigned(self, send_email):
- """ Test the api_pull_request_merge method of the flask api when
- only assignee can merge the PR and the PR isn't assigned. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Only_assignee_can_merge_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This request must be assigned to be merged",
- "error_code": "ENOTASSIGNED",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_only_assigned_not_assignee(
- self, send_email
- ):
- """ Test the api_pull_request_merge method of the flask api when
- only assignee can merge the PR and the PR isn't assigned to the
- user asking to merge. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- req.assignee = pagure.lib.query.search_user(self.session, "foo")
- self.session.add(req)
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Only_assignee_can_merge_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Only the assignee can merge this request",
- "error_code": "ENOTASSIGNEE",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_minimal_score(self, send_email):
- """ Test the api_pull_request_merge method of the flask api when
- a PR requires a certain minimal score to be merged. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Minimum_score_to_merge_pull-request"] = 2
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This request does not have the minimum review "
- "score necessary to be merged",
- "error_code": "EPRSCORE",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge(self, send_email):
- """ Test the api_pull_request_merge method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # Invalid PR
- output = self.app.post(
- "/api/0/test/pull-request/2/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a token for foo for this project
- item = pagure.lib.model.Token(
- id="foobar_token",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- # Allow the token to merge PR
- acls = pagure.lib.query.get_acls(self.session)
- for acl in acls:
- if acl.name == "pull_request_merge":
- break
- item = pagure.lib.model.TokenAcl(
- token_id="foobar_token", acl_id=acl.id
- )
- self.session.add(item)
- self.session.commit()
- headers = {"Authorization": "token foobar_token"}
- # User not admin
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to merge/close pull-request "
- "for this project",
- "error_code": "ENOPRCLOSE",
- },
- )
- headers = {"Authorization": "token aaabbbcccddd"}
- # Merge PR
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Changes merged!"})
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_conflicting(self, send_email):
- """ Test the api_pull_request_merge method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.add_content_git_repo(
- os.path.join(self.path, "repos", "test.git")
- )
- # Fork
- project = pagure.lib.query.get_authorized_project(self.session, "test")
- task = pagure.lib.query.fork_project(
- session=self.session, user="pingou", repo=project
- )
- self.session.commit()
- self.assertEqual(
- task.get(),
- {
- "endpoint": "ui_ns.view_repo",
- "repo": "test",
- "namespace": None,
- "username": "pingou",
- },
- )
- # Add content to the fork
- tests.add_content_to_git(
- os.path.join(self.path, "repos", "forks", "pingou", "test.git"),
- filename="foobar",
- content="content from the fork",
- )
- # Add content to the main repo, so they conflict
- tests.add_content_to_git(
- os.path.join(self.path, "repos", "test.git"),
- filename="foobar",
- content="content from the main repo",
- )
- project = pagure.lib.query.get_authorized_project(self.session, "test")
- fork = pagure.lib.query.get_authorized_project(
- self.session, "test", user="pingou"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=fork,
- branch_from="master",
- repo_to=project,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Merge PR
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 409)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This pull-request conflicts and thus cannot be merged",
- "error_code": "EPRCONFLICTS",
- },
- )
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_merge_user_token(self, send_email):
- """ Test the api_pull_request_merge method of the flask api. """
- send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, invalid PR
- output = self.app.post(
- "/api/0/test2/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid token, invalid PR - other project
- output = self.app.post(
- "/api/0/test/pull-request/2/merge", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a token for foo for this project
- item = pagure.lib.model.Token(
- id="foobar_token",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- # Allow the token to merge PR
- acls = pagure.lib.query.get_acls(self.session)
- acl = None
- for acl in acls:
- if acl.name == "pull_request_merge":
- break
- item = pagure.lib.model.TokenAcl(
- token_id="foobar_token", acl_id=acl.id
- )
- self.session.add(item)
- self.session.commit()
- headers = {"Authorization": "token foobar_token"}
- # User not admin
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to merge/close pull-request "
- "for this project",
- "error_code": "ENOPRCLOSE",
- },
- )
- headers = {"Authorization": "token aaabbbcccddd"}
- # Merge PR
- output = self.app.post(
- "/api/0/test/pull-request/1/merge", headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Changes merged!"})
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_add_comment(self, mockemail):
- """ Test the api_pull_request_add_comment method of the flask api. """
- mockemail.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # No input
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check comments before
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"title": "test issue"}
- # Incomplete request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"comment": ["This field is required."]},
- },
- )
- # No change
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"comment": "This is a very interesting question"}
- # Valid request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- # One comment added
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 1)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_add_comment_wrong_user(self):
- """ Test the api_pull_request_add_comment method of the flask api
- when the user is not found in the DB. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- data = {"comment": "This is a very interesting question"}
- # Valid request
- with patch(
- "pagure.lib.query.add_pull_request_comment",
- side_effect=pagure.exceptions.PagureException("error"),
- ):
- output = self.app.post(
- "/api/0/test/pull-request/1/comment",
- data=data,
- headers=headers,
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "error", "error_code": "ENOCODE"}
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_add_comment_pr_disabled(self):
- """ Test the api_pull_request_add_comment method of the flask api
- when PRs are disabled. """
- tests.create_projects(self.session)
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- data = {"comment": "This is a very interesting question"}
- # Valid request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- # no comment added
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- @patch("pagure.lib.notify.send_email")
- def test_api_pull_request_add_comment_user_token(self, mockemail):
- """ Test the api_pull_request_add_comment method of the flask api. """
- mockemail.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session, project_id=None)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, invalid request
- output = self.app.post(
- "/api/0/test2/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Valid token, invalid request in another project
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create a pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- forked_repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=forked_repo,
- branch_from="master",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check comments before
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"title": "test issue"}
- # Incomplete request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"comment": ["This field is required."]},
- },
- )
- # No change
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 0)
- data = {"comment": "This is a very interesting question"}
- # Valid request
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- # One comment added
- self.session.commit()
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(len(request.comments), 1)
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request_pr_disabled(self, p_send_email):
- """ Test the api_subscribe_pull_request method of the flask api. """
- p_send_email.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request_invalid_token(
- self, p_send_email, p_ugt
- ):
- """ Test the api_subscribe_pull_request method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- item = pagure.lib.model.User(
- user="bar",
- fullname="bar foo",
- password="foo",
- default_email="bar@bar.com",
- )
- self.session.add(item)
- item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
- self.session.add(item)
- self.session.commit()
- tests.create_projects(self.session)
- tests.create_tokens(self.session, user_id=3, project_id=2)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Create pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="feature",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check subscribtion before
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit "
- "http://localhost.localdomain/settings#nav-api-tab to get or "
- "renew your API token.",
- "error_code": "EINVALIDTOK",
- },
- )
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request(self, p_send_email, p_ugt):
- """ Test the api_subscribe_pull_request method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- item = pagure.lib.model.User(
- user="bar",
- fullname="bar foo",
- password="foo",
- default_email="bar@bar.com",
- )
- self.session.add(item)
- item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
- self.session.add(item)
- self.session.commit()
- tests.create_projects(self.session)
- tests.create_tokens(self.session, user_id=3)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- # Invalid project
- output = self.app.post(
- "/api/0/foo/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- # Valid token, wrong project
- output = self.app.post(
- "/api/0/test2/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- pagure.api.APIERROR.EINVALIDTOK.name, data["error_code"]
- )
- self.assertEqual(pagure.api.APIERROR.EINVALIDTOK.value, data["error"])
- # No input
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", headers=headers
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- # Create pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="feature",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check subscribtion before
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- # Unsubscribe - no changes
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are no longer watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are no longer watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- # No change
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- # Subscribe
- data = {"status": True}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are now watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- # Subscribe - no changes
- data = {"status": True}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are now watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou", "bar"]),
- )
- # Unsubscribe
- data = {}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are no longer watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "bar",
- },
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_api_subscribe_pull_request_logged_in(self, p_send_email, p_ugt):
- """ Test the api_subscribe_pull_request method of the flask api
- when the user is logged in via the UI. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- item = pagure.lib.model.User(
- user="bar",
- fullname="bar foo",
- password="foo",
- default_email="bar@bar.com",
- )
- self.session.add(item)
- item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
- self.session.add(item)
- self.session.commit()
- tests.create_projects(self.session)
- tests.create_tokens(self.session, user_id=3)
- tests.create_tokens_acl(self.session)
- # Create pull-request
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="feature",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- # Check subscribtion before
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou"]),
- )
- # Subscribe
- user = tests.FakeUser(username="foo")
- with tests.user_set(self.app.application, user):
- data = {"status": True}
- output = self.app.post(
- "/api/0/test/pull-request/1/subscribe", data=data
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "message": "You are now watching this pull-request",
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "user": "foo",
- },
- )
- # Check subscribtions after
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- request = pagure.lib.query.search_pull_requests(
- self.session, project_id=1, requestid=1
- )
- self.assertEqual(
- pagure.lib.query.get_watch_list(self.session, request),
- set(["pingou", "foo"]),
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_project(self):
- """ Test the api_pull_request_create method of the flask api when
- not the project doesn't exist.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/foobar/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_title(self):
- """ Test the api_pull_request_create method of the flask api when
- not title is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"title": ["This field is required."]},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_branch_to(self):
- """ Test the api_pull_request_create method of the flask api when
- not branch to is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"branch_to": ["This field is required."]},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_branch_from(self):
- """ Test the api_pull_request_create method of the flask api when
- not branch from is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": {"branch_from": ["This field is required."]},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_pr_disabled(self):
- """ Test the api_pull_request_create method of the flask api when
- the parent repo disabled pull-requests.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["pull_requests"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Pull-Request have been deactivated for this project",
- "error_code": "EPULLREQUESTSDISABLED",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_signed_pr(self):
- """ Test the api_pull_request_create method of the flask api when
- the parent repo enforces signed-off pull-requests.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Enforce_signed-off_commits_in_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "This repo enforces that all commits are signed "
- "off by their author.",
- "error_code": "ENOSIGNEDOFF",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_branch_from(self):
- """ Test the api_pull_request_create method of the flask api when
- the branch from does not exist.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Enforce_signed-off_commits_in_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "foobarbaz",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": "Branch foobarbaz does not exist",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_token(self):
- """ Test the api_pull_request_create method of the flask api when
- queried with an invalid token.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "foobarbaz",
- }
- output = self.app.post(
- "/api/0/test2/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit "
- "http://localhost.localdomain/settings#nav-api-tab to get or "
- "renew your API token.",
- "error_code": "EINVALIDTOK",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_access(self):
- """ Test the api_pull_request_create method of the flask api when
- the user opening the PR doesn't have commit access.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, user_id=2)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "foobarbaz",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "You do not have sufficient permissions to "
- "perform this action",
- "error_code": "ENOTHIGHENOUGH",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_invalid_branch_to(self):
- """ Test the api_pull_request_create method of the flask api when
- the branch to does not exist.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Check the behavior if the project disabled the issue tracker
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- settings = repo.settings
- settings["Enforce_signed-off_commits_in_pull-request"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "foobarbaz",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submitted",
- "error_code": "EINVALIDREQ",
- "errors": "Branch foobarbaz could not be found in the "
- "target repo",
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_project_token_different_project(self):
- """Test the api_pull_request_create method with the project token
- of a different project - fails"""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, project_id=2)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token foo_token"}
- data = {
- "title": "Test of PR",
- "inicial comment": "Some readme adjustment",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_user_token_invalid_acls(self):
- """Test the api_pull_request_create method with the user token, but with
- no acls for opening pull request - fails"""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session, project_id=None)
- for acl in (
- "create_project",
- "fork_project",
- "modify_project",
- "update_watch_status",
- ):
- tests.create_tokens_acl(self.session, acl_name=acl)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test of PR",
- "initial_comment": "Some readme adjustment",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 401)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_from_branch_to_origin(self):
- """Test the api_pull_request_create method from a fork to a master,
- with project token of a origin with all the acls"""
- tests.create_projects(self.session)
- tests.create_projects(
- self.session, is_fork=True, hook_token_suffix="foo"
- )
- project_query = self.session.query(pagure.lib.model.Project)
- for project in project_query.filter_by(name="test").all():
- if project.parent_id == None:
- parent = project
- else:
- child = project
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(
- os.path.join(self.path, "repos", "forks", "pingou", "test.git"),
- branch="branch",
- )
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "forks", "pingou", "test.git"),
- branch="branch",
- )
- # Create tokens
- parent_token = pagure.lib.model.Token(
- id="iamparenttoken",
- user_id=parent.user_id,
- project_id=parent.id,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(parent_token)
- fork_token = pagure.lib.model.Token(
- id="iamforktoken",
- user_id=child.user_id,
- project_id=child.id,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(fork_token)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id="iamparenttoken")
- for acl in pagure.default_config.CROSS_PROJECT_ACLS:
- tests.create_tokens_acl(
- self.session, token_id="iamforktoken", acl_name=acl
- )
- headers = {"Authorization": "token iamforktoken"}
- data = {
- "title": "war of tomatoes",
- "initial_comment": "the manifest",
- "branch_to": "master",
- "branch_from": "branch",
- "repo_from": "test",
- "repo_from_username": "pingou",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open(self):
- """ Test the api_pull_request_create method of the flask api. """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["project"]["date_created"] = "1516348115"
- data["project"]["date_modified"] = "1516348115"
- data["repo_from"]["date_created"] = "1516348115"
- data["repo_from"]["date_modified"] = "1516348115"
- data["uid"] = "e8b68df8711648deac67c3afed15a798"
- data["commit_start"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["commit_stop"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["date_created"] = "1516348115"
- data["last_updated"] = "1516348115"
- data["updated_on"] = "1516348115"
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "branch": "master",
- "branch_from": "test",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "commit_stop": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "date_created": "1516348115",
- "id": 1,
- "initial_comment": "Nothing much, the changes speak for themselves",
- "last_updated": "1516348115",
- "project": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "Test PR",
- "uid": "e8b68df8711648deac67c3afed15a798",
- "updated_on": "1516348115",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- )
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_open_missing_initial_comment(self):
- """ Test the api_pull_request_create method of the flask api when
- not initial comment is submitted.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data["project"]["date_created"] = "1516348115"
- data["project"]["date_modified"] = "1516348115"
- data["repo_from"]["date_created"] = "1516348115"
- data["repo_from"]["date_modified"] = "1516348115"
- data["uid"] = "e8b68df8711648deac67c3afed15a798"
- data["commit_start"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["commit_stop"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["date_created"] = "1516348115"
- data["last_updated"] = "1516348115"
- data["updated_on"] = "1516348115"
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "branch": "master",
- "branch_from": "test",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "commit_stop": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "date_created": "1516348115",
- "id": 1,
- "initial_comment": None,
- "last_updated": "1516348115",
- "project": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "Test PR",
- "uid": "e8b68df8711648deac67c3afed15a798",
- "updated_on": "1516348115",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- )
- class PagureFlaskApiForkPRDiffStatstests(tests.Modeltests):
- """ Tests for the flask API of pagure for the diff stats endpoint of PRs
- """
- maxDiff = None
- def setUp(self):
- """ Set up the environnment, ran before every tests. """
- super(PagureFlaskApiForkPRDiffStatstests, self).setUp()
- pagure.config.config["REQUESTS_FOLDER"] = None
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), ncommits=5
- )
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- # Create the pull-request to close
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- req = pagure.lib.query.new_pull_request(
- session=self.session,
- repo_from=repo,
- branch_from="test",
- repo_to=repo,
- branch_to="master",
- title="test pull-request",
- user="pingou",
- )
- self.session.commit()
- self.assertEqual(req.id, 1)
- self.assertEqual(req.title, "test pull-request")
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_no_repo(self):
- """ Test the api_pull_request_merge method of the flask api. """
- output = self.app.get("/api/0/invalid/pull-request/404/diffstats")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data, {"error": "Project not found", "error_code": "ENOPROJECT"}
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_no_pr(self):
- """ Test the api_pull_request_merge method of the flask api. """
- output = self.app.get("/api/0/test/pull-request/404/diffstats")
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data, {"error": "Pull-Request not found", "error_code": "ENOREQ"}
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_file_modified(self):
- """ Test the api_pull_request_merge method of the flask api. """
- output = self.app.get("/api/0/test/pull-request/1/diffstats")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data,
- {
- "sources": {
- "lines_added": 10,
- "lines_removed": 0,
- "new_id": "540916fbd3d825d14cc0c0b2397606fda69379ce",
- "old_id": "265f133a7c94ede4cb183dd808219c5bf9e08f87",
- "old_path": "sources",
- "status": "M",
- }
- },
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_file_added_mofidied(self):
- """ Test the api_pull_request_merge method of the flask api. """
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), ncommits=5
- )
- tests.add_readme_git_repo(
- os.path.join(self.path, "repos", "test.git"),
- readme_name="README.md",
- branch="test",
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.requests), 1)
- output = self.app.get("/api/0/test/pull-request/1/diffstats")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertTrue(
- data
- in [
- {
- "README.md": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "bd913ea153650b94f33f53e5164c36a28b761bf4",
- "old_id": "0000000000000000000000000000000000000000",
- "old_path": "README.md",
- "status": "A",
- },
- "sources": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "540916fbd3d825d14cc0c0b2397606fda69379ce",
- "old_id": "293500070b9dfc6ab66e31383f8f7fccf6a95fe2",
- "old_path": "sources",
- "status": "M",
- },
- },
- {
- "README.md": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "bd913ea153650b94f33f53e5164c36a28b761bf4",
- "old_id": "0000000000000000000000000000000000000000",
- "old_path": "README.md",
- "status": "A",
- },
- "sources": {
- "lines_added": 10,
- "lines_removed": 0,
- "new_id": "540916fbd3d825d14cc0c0b2397606fda69379ce",
- "old_id": "265f133a7c94ede4cb183dd808219c5bf9e08f87",
- "old_path": "sources",
- "status": "M",
- },
- },
- ]
- )
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_api_pull_request_diffstats_file_modified_deleted(self):
- """ Test the api_pull_request_merge method of the flask api. """
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.requests), 1)
- pagure.lib.tasks.update_pull_request(repo.requests[0].uid)
- tests.add_readme_git_repo(
- os.path.join(self.path, "repos", "test.git"),
- readme_name="README.md",
- branch="test",
- )
- tests.remove_file_git_repo(
- os.path.join(self.path, "repos", "test.git"),
- filename="sources",
- branch="test",
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.requests), 1)
- pagure.lib.tasks.update_pull_request(repo.requests[0].uid)
- output = self.app.get("/api/0/test/pull-request/1/diffstats")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertEqual(
- data,
- {
- "README.md": {
- "lines_added": 5,
- "lines_removed": 0,
- "new_id": "bd913ea153650b94f33f53e5164c36a28b761bf4",
- "old_id": "0000000000000000000000000000000000000000",
- "old_path": "README.md",
- "status": "A",
- },
- "sources": {
- "lines_added": 0,
- "lines_removed": 5,
- "new_id": "0000000000000000000000000000000000000000",
- "old_id": "265f133a7c94ede4cb183dd808219c5bf9e08f87",
- "old_path": "sources",
- "status": "D",
- },
- },
- )
- class PagureApiThresholdReachedTests(tests.Modeltests):
- """ Test the behavior of the threshold_reached value returned by the API.
- """
- maxDiff = None
- def _clean_data(self, data):
- data["project"]["date_created"] = "1516348115"
- data["project"]["date_modified"] = "1516348115"
- data["repo_from"]["date_created"] = "1516348115"
- data["repo_from"]["date_modified"] = "1516348115"
- data["uid"] = "e8b68df8711648deac67c3afed15a798"
- data["commit_start"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["commit_stop"] = "114f1b468a5f05e635fcb6394273f3f907386eab"
- data["date_created"] = "1516348115"
- data["last_updated"] = "1516348115"
- data["updated_on"] = "1516348115"
- data["comments"] = [] # Let's not check the comments
- return data
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def setUp(self):
- """ Set up the environment for the tests. """
- super(PagureApiThresholdReachedTests, self).setUp()
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- tests.create_projects_git(
- os.path.join(self.path, "requests"), bare=True
- )
- tests.add_readme_git_repo(os.path.join(self.path, "repos", "test.git"))
- tests.add_commit_git_repo(
- os.path.join(self.path, "repos", "test.git"), branch="test"
- )
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- # Add a token for user `foo`
- item = pagure.lib.model.Token(
- id="aaabbbcccddd_foo",
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow()
- + datetime.timedelta(days=30),
- )
- self.session.add(item)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id="aaabbbcccddd_foo")
- # Add a minimal required score:
- repo = pagure.lib.query._get_project(self.session, "test")
- settings = repo.settings
- settings["Minimum_score_to_merge_pull-request"] = 2
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {
- "title": "Test PR",
- "initial_comment": "Nothing much, the changes speak for themselves",
- "branch_to": "master",
- "branch_from": "test",
- }
- output = self.app.post(
- "/api/0/test/pull-request/new", headers=headers, data=data
- )
- self.assertEqual(output.status_code, 200)
- self.expected_data = {
- "assignee": None,
- "branch": "master",
- "branch_from": "test",
- "cached_merge_status": "unknown",
- "closed_at": None,
- "closed_by": None,
- "comments": [],
- "commit_start": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "commit_stop": "114f1b468a5f05e635fcb6394273f3f907386eab",
- "date_created": "1516348115",
- "id": 1,
- "initial_comment": "Nothing much, the changes speak for themselves",
- "last_updated": "1516348115",
- "project": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "remote_git": None,
- "repo_from": {
- "access_groups": {"admin": [], "commit": [], "ticket": []},
- "access_users": {
- "admin": [],
- "commit": [],
- "owner": ["pingou"],
- "ticket": [],
- },
- "close_status": [
- "Invalid",
- "Insufficient data",
- "Fixed",
- "Duplicate",
- ],
- "custom_keys": [],
- "date_created": "1516348115",
- "date_modified": "1516348115",
- "description": "test project #1",
- "fullname": "test",
- "id": 1,
- "milestones": {},
- "name": "test",
- "namespace": None,
- "parent": None,
- "priorities": {},
- "tags": [],
- "url_path": "test",
- "user": {"fullname": "PY C", "name": "pingou"},
- },
- "status": "Open",
- "tags": [],
- "threshold_reached": None,
- "title": "Test PR",
- "uid": "e8b68df8711648deac67c3afed15a798",
- "updated_on": "1516348115",
- "user": {"fullname": "PY C", "name": "pingou"},
- }
- def test_api_pull_request_no_comments(self):
- """ Check the value of threshold_reach when the PR has no comments.
- """
- # Check the PR with 0 comment:
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_one_comments(self):
- """ Check the value of threshold_reach when the PR has one comment.
- """
- # Check the PR with 1 comment:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_two_comments_one_person(self):
- """ Check the value of threshold_reach when the PR has two comments
- but from the same person.
- """
- # Add two comments from the same user:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "Indeed it is :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_two_comments_two_persons(self):
- """ Check the value of threshold_reach when the PR has two comments
- from two different persons.
- """
- # Add two comments from two users:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd_foo"}
- data = {"comment": "Indeed it is :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- data["comments"] = [] # Let's not check the comments
- self.expected_data["threshold_reached"] = True
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_three_comments_two_persons_changed_to_no(self):
- """ Check the value of threshold_reach when the PR has three
- comments from two person among which one changed their mind from
- +1 to -1.
- """
- # Add three comments from two users:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd_foo"}
- data = {"comment": "Indeed it is :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- data = {
- "comment": "Nevermind the bug is elsewhere in fact :thumbsdown:"
- }
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- data["comments"] = [] # Let's not check the comments
- self.expected_data["threshold_reached"] = False
- self.assertDictEqual(data, self.expected_data)
- def test_api_pull_request_three_comments_two_persons_changed_to_yes(self):
- """ Check the value of threshold_reach when the PR has three
- comments from two person among which one changed their mind from
- -1 to +1
- """
- # Add three comments from two users:
- headers = {"Authorization": "token aaabbbcccddd"}
- data = {"comment": "This is a very interesting solution :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- headers = {"Authorization": "token aaabbbcccddd_foo"}
- data = {"comment": "I think the bug is elsewhere :thumbsdown:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- data = {"comment": "Nevermind it is here :thumbsup:"}
- output = self.app.post(
- "/api/0/test/pull-request/1/comment", data=data, headers=headers
- )
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- self.assertDictEqual(data, {"message": "Comment added"})
- output = self.app.get("/api/0/test/pull-request/1")
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.get_data(as_text=True))
- data = self._clean_data(data)
- data["comments"] = [] # Let's not check the comments
- self.expected_data["threshold_reached"] = True
- self.assertDictEqual(data, self.expected_data)
- if __name__ == "__main__":
- unittest.main(verbosity=2)
|