123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344 |
- # -*- coding: utf-8 -*-
- """
- (c) 2015 - Copyright Red Hat Inc
- Authors:
- Pierre-Yves Chibon <pingou@pingoured.fr>
- """
- __requires__ = ['SQLAlchemy >= 0.8']
- import pkg_resources
- import datetime
- import unittest
- import shutil
- import sys
- import os
- import json
- from mock import patch
- sys.path.insert(0, os.path.join(os.path.dirname(
- os.path.abspath(__file__)), '..'))
- import pagure.lib
- import tests
- class PagureFlaskApiIssuetests(tests.Modeltests):
- """ Tests for the flask API of pagure for issue """
- def setUp(self):
- """ Set up the environnment, ran before every tests. """
- super(PagureFlaskApiIssuetests, self).setUp()
- pagure.APP.config['TESTING'] = True
- pagure.SESSION = self.session
- pagure.api.SESSION = self.session
- pagure.api.issue.SESSION = self.session
- pagure.lib.SESSION = self.session
- pagure.APP.config['TICKETS_FOLDER'] = None
- self.app = pagure.APP.test_client()
- def test_api_new_issue(self):
- """ Test the api_new_issue method of the flask api. """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(tests.HERE, 'tickets'))
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/new_issue', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/new_issue', headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- data = {
- 'title': 'test issue',
- }
- # Invalid repo
- output = self.app.post(
- '/api/0/foo/new_issue', data=data, headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Incomplete request
- output = self.app.post(
- '/api/0/test/new_issue', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- data = {
- 'title': 'test issue',
- 'issue_content': 'This issue needs attention',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/new_issue', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Issue created'}
- )
- def test_api_view_issues(self):
- """ Test the api_view_issues method of the flask api. """
- self.test_api_new_issue()
- # Invalid repo
- output = self.app.get('/api/0/foo/issues')
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # List all opened issues
- output = self.app.get('/api/0/test/issues')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 1,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- # Create private issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=True,
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Access issues un-authenticated
- output = self.app.get('/api/0/test/issues')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 1,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- headers = {'Authorization': 'token aaabbbccc'}
- # Access issues authenticated but non-existing token
- output = self.app.get('/api/0/test/issues', headers=headers)
- self.assertEqual(output.status_code, 401)
- # Create a new token for another user
- item = pagure.lib.model.Token(
- id='bar_token',
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- headers = {'Authorization': 'token bar_token'}
- # Access issues authenticated but wrong token
- output = self.app.get('/api/0/test/issues', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 1,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Access issues authenticated correctly
- output = self.app.get('/api/0/test/issues', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- data['issues'][1]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 2,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- },
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- # List closed issue
- output = self.app.get('/api/0/test/issues?status=Closed', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": "Closed",
- "tags": []
- },
- "total_issues": 0,
- "issues": []
- }
- )
- # List closed issue
- output = self.app.get('/api/0/test/issues?status=Invalid', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": "Invalid",
- "tags": []
- },
- "total_issues": 0,
- "issues": []
- }
- )
- # List all issues
- output = self.app.get('/api/0/test/issues?status=All', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- data['issues'][1]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": "All",
- "tags": []
- },
- "total_issues": 2,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- },
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ],
- }
- )
- def test_api_view_issue(self):
- """ Test the api_view_issue method of the flask api. """
- self.test_api_new_issue()
- # Invalid repo
- output = self.app.get('/api/0/foo/issue/1')
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Invalid issue for this repo
- output = self.app.get('/api/0/test2/issue/1')
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Valid issue
- output = self.app.get('/api/0/test/issue/1')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Create private issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=True,
- issue_uid='aaabbbccc',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Access private issue un-authenticated
- output = self.app.get('/api/0/test/issue/2')
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to view this issue",
- "error_code": "EISSUENOTALLOWED",
- }
- )
- headers = {'Authorization': 'token aaabbbccc'}
- # Access private issue authenticated but non-existing token
- output = self.app.get('/api/0/test/issue/2', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK"
- }
- )
- # Create a new token for another user
- item = pagure.lib.model.Token(
- id='bar_token',
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- headers = {'Authorization': 'token bar_token'}
- # Access private issue authenticated but wrong token
- output = self.app.get('/api/0/test/issue/2', headers=headers)
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to view this issue",
- "error_code": "EISSUENOTALLOWED",
- }
- )
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Access private issue authenticated correctly
- output = self.app.get('/api/0/test/issue/2', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Access private issue authenticated correctly using the issue's uid
- output = self.app.get('/api/0/test/issue/aaabbbccc', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "closed_at": None,
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- def test_api_change_status_issue(self):
- """ Test the api_change_status_issue method of the flask api. """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(tests.HERE, 'tickets'))
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Invalid project
- output = self.app.post('/api/0/foo/issue/1/status', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/issue/1/status', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/issue/1/status', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Create normal issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue #1',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=False,
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue #1')
- # Create another project
- item = pagure.lib.model.Project(
- user_id=2, # pingou
- name='foo',
- description='test project #3',
- hook_token='aaabbbdddeee',
- )
- self.session.add(item)
- self.session.commit()
- # Create a token for pingou for this project
- item = pagure.lib.model.Token(
- id='pingou_foo',
- user_id=1,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- self.session.commit()
- # Give `change_status_issue` to this token
- item = pagure.lib.model.TokenAcl(
- token_id='pingou_foo',
- acl_id=6,
- )
- self.session.add(item)
- self.session.commit()
- repo = pagure.lib.get_project(self.session, 'foo')
- # Create private issue
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='foo',
- ticketfolder=None,
- private=True,
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Check status before
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'title': 'test issue',
- }
- # Incomplete request
- output = self.app.post(
- '/api/0/test/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'status': 'Open',
- }
- # Valid request but no change
- output = self.app.post(
- '/api/0/test/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'No changes'}
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'status': 'Fixed',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Successfully edited issue #1'}
- )
- headers = {'Authorization': 'token pingou_foo'}
- # Un-authorized issue
- output = self.app.post(
- '/api/0/foo/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please "
- "visit https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK"
- }
- )
- @patch('pagure.lib.git.update_git')
- @patch('pagure.lib.notify.send_email')
- def test_api_comment_issue(self, p_send_email, p_ugt):
- """ Test the api_comment_issue method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Invalid project
- output = self.app.post('/api/0/foo/issue/1/comment', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/issue/1/comment', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/issue/1/comment', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Create normal issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue #1',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=False,
- issue_uid='aaabbbccc#1',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue #1')
- # Check comments before
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- data = {
- 'title': 'test issue',
- }
- # Incomplete request
- output = self.app.post(
- '/api/0/test/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'comment': 'This is a very interesting question',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Comment added'}
- )
- # One comment added
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 1)
- # Create another project
- item = pagure.lib.model.Project(
- user_id=2, # foo
- name='foo',
- description='test project #3',
- hook_token='aaabbbdddeee',
- )
- self.session.add(item)
- self.session.commit()
- # Create a token for pingou for this project
- item = pagure.lib.model.Token(
- id='pingou_foo',
- user_id=1,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- self.session.commit()
- # Give `issue_change_status` to this token when `issue_comment`
- # is required
- item = pagure.lib.model.TokenAcl(
- token_id='pingou_foo',
- acl_id=2,
- )
- self.session.add(item)
- self.session.commit()
- repo = pagure.lib.get_project(self.session, 'foo')
- # Create private issue
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='foo',
- ticketfolder=None,
- private=True,
- issue_uid='aaabbbccc#2',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Check before
- repo = pagure.lib.get_project(self.session, 'foo')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- data = {
- 'comment': 'This is a very interesting question',
- }
- headers = {'Authorization': 'token pingou_foo'}
- # Valid request but un-authorized
- output = self.app.post(
- '/api/0/foo/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please "
- "visit https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK"
- }
- )
- # No comment added
- repo = pagure.lib.get_project(self.session, 'foo')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- # Create token for user foo
- item = pagure.lib.model.Token(
- id='foo_token2',
- user_id=2,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(days=30)
- )
- self.session.add(item)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id='foo_token2')
- data = {
- 'comment': 'This is a very interesting question',
- }
- headers = {'Authorization': 'token foo_token2'}
- # Valid request and authorized
- output = self.app.post(
- '/api/0/foo/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Comment added'}
- )
- @patch('pagure.lib.git.update_git')
- @patch('pagure.lib.notify.send_email')
- def test_api_view_issue_comment(self, p_send_email, p_ugt):
- """ Test the api_view_issue_comment endpoint. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- self.test_api_comment_issue()
- # View a comment that does not exist
- output = self.app.get('/api/0/foo/issue/100/comment/2')
- self.assertEqual(output.status_code, 404)
- # Issue exists but not the comment
- output = self.app.get('/api/0/test/issue/1/comment/2')
- self.assertEqual(output.status_code, 404)
- # Issue and comment exists
- output = self.app.get('/api/0/test/issue/1/comment/1')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1435821770'
- data["comment_date"] = "2015-07-02 09:22"
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "comment": "This is a very interesting question",
- "comment_date": "2015-07-02 09:22",
- "date_created": "1435821770",
- "edited_on": None,
- "editor": None,
- "notification": False,
- "id": 1,
- "parent": None,
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Issue and comment exists, using UID
- output = self.app.get('/api/0/test/issue/aaabbbccc#1/comment/1')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1435821770'
- data["comment_date"] = "2015-07-02 09:22"
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "comment": "This is a very interesting question",
- "comment_date": "2015-07-02 09:22",
- "date_created": "1435821770",
- "edited_on": None,
- "editor": None,
- "notification": False,
- "id": 1,
- "parent": None,
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Private issue
- output = self.app.get('/api/0/foo/issue/1/comment/2')
- self.assertEqual(output.status_code, 403)
- # Private issue - Auth - wrong token
- headers = {'Authorization': 'token pingou_foo'}
- output = self.app.get('/api/0/foo/issue/1/comment/2', headers=headers)
- self.assertEqual(output.status_code, 403)
- # Private issue - Auth - Invalid token
- headers = {'Authorization': 'token aaabbbcccddd'}
- output = self.app.get('/api/0/foo/issue/1/comment/2', headers=headers)
- self.assertEqual(output.status_code, 401)
- # Private issue - Auth - valid token - unknown comment
- headers = {'Authorization': 'token foo_token2'}
- output = self.app.get('/api/0/foo/issue/1/comment/3', headers=headers)
- self.assertEqual(output.status_code, 404)
- # Private issue - Auth - valid token - known comment
- headers = {'Authorization': 'token foo_token2'}
- output = self.app.get('/api/0/foo/issue/1/comment/2', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1435821770'
- data["comment_date"] = "2015-07-02 09:22"
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "comment": "This is a very interesting question",
- "comment_date": "2015-07-02 09:22",
- "date_created": "1435821770",
- "edited_on": None,
- "editor": None,
- "notification": False,
- "id": 2,
- "parent": None,
- "user": {
- "fullname": "foo bar",
- "name": "foo"
- }
- }
- )
- @patch('pagure.lib.git.update_git')
- @patch('pagure.lib.notify.send_email')
- def test_api_assign_issue(self, p_send_email, p_ugt):
- """ Test the api_assign_issue method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Invalid project
- output = self.app.post('/api/0/foo/issue/1/assign', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/issue/1/assign', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/issue/1/assign', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Create normal issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue #1',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=False,
- issue_uid='aaabbbccc#1',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue #1')
- # Check comments before
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- data = {
- 'title': 'test issue',
- }
- # Incomplete request
- output = self.app.post(
- '/api/0/test/issue/1/assign', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'assignee': 'pingou',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/issue/1/assign', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Issue assigned'}
- )
- # One comment added
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.assignee.user, 'pingou')
- # Create another project
- item = pagure.lib.model.Project(
- user_id=2, # foo
- name='foo',
- description='test project #3',
- hook_token='aaabbbdddeee',
- )
- self.session.add(item)
- self.session.commit()
- # Create a token for pingou for this project
- item = pagure.lib.model.Token(
- id='pingou_foo',
- user_id=1,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- self.session.commit()
- # Give `issue_change_status` to this token when `issue_comment`
- # is required
- item = pagure.lib.model.TokenAcl(
- token_id='pingou_foo',
- acl_id=5,
- )
- self.session.add(item)
- self.session.commit()
- repo = pagure.lib.get_project(self.session, 'foo')
- # Create private issue
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='foo',
- ticketfolder=None,
- private=True,
- issue_uid='aaabbbccc#2',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Check before
- repo = pagure.lib.get_project(self.session, 'foo')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- data = {
- 'assignee': 'pingou',
- }
- headers = {'Authorization': 'token pingou_foo'}
- # Valid request but un-authorized
- output = self.app.post(
- '/api/0/foo/issue/1/assign', data=data, headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please "
- "visit https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK"
- }
- )
- # No comment added
- repo = pagure.lib.get_project(self.session, 'foo')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- # Create token for user foo
- item = pagure.lib.model.Token(
- id='foo_token2',
- user_id=2,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(days=30)
- )
- self.session.add(item)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id='foo_token2')
- data = {
- 'assignee': 'pingou',
- }
- headers = {'Authorization': 'token foo_token2'}
- # Valid request and authorized
- output = self.app.post(
- '/api/0/foo/issue/1/assign', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Issue assigned'}
- )
- if __name__ == '__main__':
- SUITE = unittest.TestLoader().loadTestsFromTestCase(
- PagureFlaskApiIssuetests)
- unittest.TextTestRunner(verbosity=2).run(SUITE)
|