123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491 |
- # -*- coding: utf-8 -*-
- """
- (c) 2016-2018 - Copyright Red Hat Inc
- Authors:
- Pierre-Yves Chibon <pingou@pingoured.fr>
- """
- from __future__ import unicode_literals, absolute_import
- import datetime
- import json
- import unittest
- import shutil
- import sys
- import tempfile
- import os
- import pygit2
- from mock import patch, MagicMock
- sys.path.insert(
- 0, os.path.join(os.path.dirname(os.path.abspath(__file__)), "..")
- )
- import pagure.lib.query
- import tests
- from pagure.lib.repo import PagureRepo
- class PagureFlaskPrioritiestests(tests.Modeltests):
- """Tests for the behavior of priorities in pagure"""
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_ticket_with_no_priority(self, p_send_email, p_ugt):
- """Test creating a ticket without priority."""
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/new_issue")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertTrue(
- '<h4 class="font-weight-bold mb-4">New Issue</h4>\n'
- in output_text
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- # Create the issue
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertNotIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertNotIn('<option value="1">High</option>', output_text)
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_ticket_with_priorities(self, p_send_email, p_ugt):
- """Test creating a ticket with priorities."""
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Set some priorities
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- repo.priorities = {"1": "High", "2": "Normal"}
- self.session.add(repo)
- self.session.commit()
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/new_issue")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertTrue(
- '<h4 class="font-weight-bold mb-4">New Issue</h4>\n'
- in output_text
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- # Create the issue
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- def test_update_priorities(self):
- """Test updating priorities of a repo."""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Set some priorities
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/settings")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- data = {"priority_weigth": 1, "priority_title": "High"}
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- None, no CSRF
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.priorities, {})
- data = {
- "priority_weigth": 1,
- "priority_title": "High",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.priorities, {"": "", "1": "High"})
- data = {
- "priority_weigth": [1, 2, 3],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the ordering
- self.assertTrue(
- output_text.find("High") < output_text.find("Normal")
- )
- self.assertTrue(
- output_text.find("Normal") < output_text.find("Low")
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Check error - less weigths than titles
- data = {
- "priority_weigth": [1, 2],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn(
- "Priorities weights and titles are " "not of the same length",
- output_text,
- )
- # Check the result of the action -- Priorities un-changed
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Check error - weigths must be integer
- data = {
- "priority_weigth": [1, 2, "c"],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Priorities weights must be numbers", output_text)
- # Check the result of the action -- Priorities un-changed
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Check error - Twice the same priority weigth
- data = {
- "priority_weigth": [1, 2, 2],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Priority weight 2 is present 2 times", output_text)
- # Check the result of the action -- Priorities un-changed
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Check error - Twice the same priority title
- data = {
- "priority_weigth": [1, 2, 3],
- "priority_title": ["High", "Normal", "Normal"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Priority Normal is present 2 times", output_text)
- # Check the result of the action -- Priorities un-changed
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Check the behavior if the project disabled the issue tracker
- settings = repo.settings
- settings["issue_tracker"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- output = self.app.post("/test/update/priorities", data=data)
- self.assertEqual(output.status_code, 404)
- # Check for an invalid project
- output = self.app.post("/foo/update/priorities", data=data)
- self.assertEqual(output.status_code, 404)
- # Check for a non-admin user
- settings = repo.settings
- settings["issue_tracker"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- user.username = "ralph"
- with tests.user_set(self.app.application, user):
- output = self.app.post("/test/update/priorities", data=data)
- self.assertEqual(output.status_code, 403)
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_reset_priorities(self, p_send_email, p_ugt):
- """Test resetting the priorities of a repo."""
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Start from scrach on priorities
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/settings")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- # Set some priorities
- data = {
- "priority_weigth": [1, 2, 3],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Create an issue
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Check that the ticket *does* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Reset the priorities
- data = {"csrf_token": csrf_token}
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check that the issue list renders fine
- output = self.app.get("/test/issues")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check that the ticket *does not* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertNotIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertNotIn('<option value="1">High</option>', output_text)
- # Check the result of the action -- Priority reset
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- @patch("pagure.lib.git.update_git")
- @patch("pagure.lib.notify.send_email")
- def test_reset_priorities_None(self, p_send_email, p_ugt):
- """Test resetting the priorities of a repo."""
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Start from scrach on priorities
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/settings")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- # Set some priorities
- data = {
- "priority_weigth": [1, 2, 3],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Create an issue
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Check that the ticket *does* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Reset the priorities
- data = {"priority": None, "csrf_token": csrf_token}
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check that the issue list renders fine
- output = self.app.get("/test/issues")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check that the ticket *does not* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertNotIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertNotIn('<option value="1">High</option>', output_text)
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_set_priority_1_and_back(self):
- """Test setting the priority of a ticket to 1."""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Start from scrach on priorities
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/settings")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- # Set some priorities
- data = {
- "priority_weigth": [-1, 0, 1, 2, 3],
- "priority_title": [
- "Sky Falling",
- "Urgent",
- "High",
- "Normal",
- "Low",
- ],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(
- repo.priorities,
- {
- "": "",
- "-1": "Sky Falling",
- "0": "Urgent",
- "1": "High",
- "2": "Normal",
- "3": "Low",
- },
- )
- # Create an issue
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Check that the ticket *does* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option value="-1">Sky Falling</option>', output_text
- )
- self.assertIn('<option value="0">Urgent</option>', output_text)
- self.assertIn('<option value="1">High</option>', output_text)
- # Set the priority to High
- data = {"priority": "1", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/issue/1/update", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option value="-1">Sky Falling</option>', output_text
- )
- self.assertIn('<option value="0">Urgent</option>', output_text)
- self.assertIn(
- '<option selected value="1">High</option>', output_text
- )
- # Reset the priority
- data = {"priority": "", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/issue/1/update", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option value="-1">Sky Falling</option>', output_text
- )
- self.assertIn('<option value="0">Urgent</option>', output_text)
- self.assertIn('<option value="1">High</option>', output_text)
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_set_priority_0(self):
- """Test setting the priority of a ticket to 0."""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Start from scrach on priorities
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/settings")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- # Set some priorities
- data = {
- "priority_weigth": [-1, 0, 1, 2, 3],
- "priority_title": [
- "Sky Falling",
- "Urgent",
- "High",
- "Normal",
- "Low",
- ],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(
- repo.priorities,
- {
- "": "",
- "-1": "Sky Falling",
- "0": "Urgent",
- "1": "High",
- "2": "Normal",
- "3": "Low",
- },
- )
- # Create an issue
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Check that the ticket *does* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option value="-1">Sky Falling</option>', output_text
- )
- self.assertIn('<option value="0">Urgent</option>', output_text)
- self.assertIn('<option value="1">High</option>', output_text)
- # Set the priority to Urgent
- data = {"priority": "0", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/issue/1/update", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option value="-1">Sky Falling</option>', output_text
- )
- self.assertIn(
- '<option selected value="0">Urgent</option>', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_set_priority_minus1(self):
- """Test setting the priority of a ticket to -1."""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Start from scrach on priorities
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- # Get the CSRF token
- output = self.app.get("/test/settings")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- csrf_token = output_text.split(
- 'name="csrf_token" type="hidden" value="'
- )[1].split('">')[0]
- # Set some priorities
- data = {
- "priority_weigth": [-1, 0, 1, 2, 3],
- "priority_title": [
- "Sky Falling",
- "Urgent",
- "High",
- "Normal",
- "Low",
- ],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query._get_project(self.session, "test")
- self.assertEqual(
- repo.priorities,
- {
- "": "",
- "-1": "Sky Falling",
- "0": "Urgent",
- "1": "High",
- "2": "Normal",
- "3": "Low",
- },
- )
- # Create an issue
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn('<option value="1">High</option>', output_text)
- # Check that the ticket *does* have priorities
- output = self.app.get("/test/issue/1")
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option value="-1">Sky Falling</option>', output_text
- )
- self.assertIn('<option value="0">Urgent</option>', output_text)
- self.assertIn('<option value="1">High</option>', output_text)
- # Set the priority to Sky Falling
- data = {"priority": "-1", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/issue/1/update", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- self.assertIn(
- '<div class="ml-2" id="priority_plain">', output_text
- )
- self.assertIn(
- '<option selected value="-1">Sky Falling</option>', output_text
- )
- self.assertIn('<option value="0">Urgent</option>', output_text)
- self.assertIn('<option value="1">High</option>', output_text)
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_default_priority(self):
- """Test updating the default priority of a repo."""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Check the default priorities
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- self.assertEqual(repo.default_priority, None)
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- csrf_token = self.get_csrf()
- # Set some priorities
- data = {
- "priority_weigth": [1, 2, 3],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the ordering
- self.assertTrue(
- output_text.find("High") < output_text.find("Normal")
- )
- self.assertTrue(
- output_text.find("Normal") < output_text.find("Low")
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Try setting the default priority -- no csrf
- data = {"priority": "High"}
- output = self.app.post(
- "/test/update/default_priority",
- data=data,
- follow_redirects=True,
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- default_priority no change
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.default_priority, None)
- # Try setting the default priority
- data = {"priority": "High", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/update/default_priority",
- data=data,
- follow_redirects=True,
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Default priority set " "to High", output_text)
- # Check the result of the action -- default_priority no change
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.default_priority, "High")
- # Try setting a wrong default priority
- data = {"priority": "Smooth", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/update/default_priority",
- data=data,
- follow_redirects=True,
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the result of the action -- default_priority no change
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.default_priority, "High")
- # reset the default priority
- data = {"csrf_token": csrf_token, "priority": ""}
- output = self.app.post(
- "/test/update/default_priority",
- data=data,
- follow_redirects=True,
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Default priority reset", output_text)
- # Check the result of the action -- default_priority no change
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.default_priority, None)
- # Check the behavior if the project disabled the issue tracker
- settings = repo.settings
- settings["issue_tracker"] = False
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- output = self.app.post("/test/update/default_priority", data=data)
- self.assertEqual(output.status_code, 404)
- # Check for an invalid project
- output = self.app.post("/foo/update/default_priority", data=data)
- self.assertEqual(output.status_code, 404)
- # Check for a non-admin user
- settings = repo.settings
- settings["issue_tracker"] = True
- repo.settings = settings
- self.session.add(repo)
- self.session.commit()
- user.username = "ralph"
- with tests.user_set(self.app.application, user):
- output = self.app.post("/test/update/default_priority", data=data)
- self.assertEqual(output.status_code, 403)
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_default_priority_reset_when_updating_priorities(self):
- """Test updating the default priority of a repo when updating the
- priorities.
- """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Check the default priorities
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(repo.priorities, {})
- self.assertEqual(repo.default_priority, None)
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- csrf_token = self.get_csrf()
- # Set some priorities
- data = {
- "priority_weigth": [1, 2, 3],
- "priority_title": ["High", "Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- # Check the ordering
- self.assertTrue(
- output_text.find("High") < output_text.find("Normal")
- )
- self.assertTrue(
- output_text.find("Normal") < output_text.find("Low")
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities,
- {"": "", "1": "High", "2": "Normal", "3": "Low"},
- )
- # Try setting the default priority
- data = {"priority": "High", "csrf_token": csrf_token}
- output = self.app.post(
- "/test/update/default_priority",
- data=data,
- follow_redirects=True,
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Default priority set " "to High", output_text)
- # Check the result of the action -- default_priority no change
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(repo.default_priority, "High")
- # Remove the Hight priority
- data = {
- "priority_weigth": [1, 2],
- "priority_title": ["Normal", "Low"],
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/update/priorities", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- # Check the redirect
- self.assertIn(
- "<title>Settings - test - Pagure</title>", output_text
- )
- self.assertIn(
- '<h5 class="pl-2 font-weight-bold text-muted">'
- "Project Settings</h5>\n",
- output_text,
- )
- self.assertIn("Priorities updated", output_text)
- self.assertIn(
- "Default priority reset "
- "as it is no longer one of set priorities.",
- output_text,
- )
- # Check the ordering
- self.assertTrue(
- output_text.find("Normal") < output_text.find("Low")
- )
- # Check the result of the action -- Priority recorded
- self.session.commit()
- repo = pagure.lib.query.get_authorized_project(
- self.session, "test"
- )
- self.assertEqual(
- repo.priorities, {"": "", "1": "Normal", "2": "Low"}
- )
- # Default priority is now None
- self.assertIsNone(repo.default_priority)
- @patch("pagure.lib.git.update_git", MagicMock(return_value=True))
- @patch("pagure.lib.notify.send_email", MagicMock(return_value=True))
- def test_default_priority_on_new_ticket(self):
- """Test updating the default priority of a repo."""
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(self.path, "repos"), bare=True)
- # Set some priority and the default one
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- repo.priorities = {"1": "High", "2": "Normal"}
- repo.default_priority = "Normal"
- self.session.add(repo)
- self.session.commit()
- # Check the default priorities
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(repo.priorities, {"1": "High", "2": "Normal"})
- self.assertEqual(repo.default_priority, "Normal")
- user = tests.FakeUser()
- user.username = "pingou"
- with tests.user_set(self.app.application, user):
- csrf_token = self.get_csrf()
- data = {
- "title": "Test issue",
- "issue_content": "We really should improve on this issue",
- "status": "Open",
- "csrf_token": csrf_token,
- }
- output = self.app.post(
- "/test/new_issue", data=data, follow_redirects=True
- )
- self.assertEqual(output.status_code, 200)
- output_text = output.get_data(as_text=True)
- self.assertIn(
- "<title>Issue #1: Test issue - test - Pagure</title>",
- output_text,
- )
- self.assertIn(
- '<a class="btn btn-outline-secondary btn-sm border-0" '
- 'href="/test/issue/1/edit" title="Edit this issue">',
- output_text,
- )
- repo = pagure.lib.query.get_authorized_project(self.session, "test")
- self.assertEqual(len(repo.issues), 1)
- self.assertEqual(repo.issues[0].priority, 2)
- if __name__ == "__main__":
- unittest.main(verbosity=2)
|