1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117 |
- # -*- coding: utf-8 -*-
- """
- (c) 2015 - Copyright Red Hat Inc
- Authors:
- Pierre-Yves Chibon <pingou@pingoured.fr>
- """
- __requires__ = ['SQLAlchemy >= 0.8']
- import pkg_resources
- import datetime
- import unittest
- import shutil
- import sys
- import os
- import json
- from mock import patch
- sys.path.insert(0, os.path.join(os.path.dirname(
- os.path.abspath(__file__)), '..'))
- import pagure.lib
- import tests
- class PagureFlaskApiIssuetests(tests.Modeltests):
- """ Tests for the flask API of pagure for issue """
- def setUp(self):
- """ Set up the environnment, ran before every tests. """
- super(PagureFlaskApiIssuetests, self).setUp()
- pagure.APP.config['TESTING'] = True
- pagure.SESSION = self.session
- pagure.api.SESSION = self.session
- pagure.api.issue.SESSION = self.session
- pagure.lib.SESSION = self.session
- pagure.APP.config['TICKETS_FOLDER'] = None
- self.app = pagure.APP.test_client()
- def test_api_new_issue(self):
- """ Test the api_new_issue method of the flask api. """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(tests.HERE, 'tickets'))
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/new_issue', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/new_issue', headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- data = {
- 'title': 'test issue',
- }
- # Invalid repo
- output = self.app.post(
- '/api/0/foo/new_issue', data=data, headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Incomplete request
- output = self.app.post(
- '/api/0/test/new_issue', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- data = {
- 'title': 'test issue',
- 'issue_content': 'This issue needs attention',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/new_issue', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Issue created'}
- )
- def test_api_view_issues(self):
- """ Test the api_view_issues method of the flask api. """
- self.test_api_new_issue()
- # Invalid repo
- output = self.app.get('/api/0/foo/issues')
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # List all opened issues
- output = self.app.get('/api/0/test/issues')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 1,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- # Create private issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=True,
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Access issues un-authenticated
- output = self.app.get('/api/0/test/issues')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 1,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- headers = {'Authorization': 'token aaabbbccc'}
- # Access issues authenticated but non-existing token
- output = self.app.get('/api/0/test/issues', headers=headers)
- self.assertEqual(output.status_code, 401)
- # Create a new token for another user
- item = pagure.lib.model.Token(
- id='bar_token',
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- headers = {'Authorization': 'token bar_token'}
- # Access issues authenticated but wrong token
- output = self.app.get('/api/0/test/issues', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 1,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Access issues authenticated correctly
- output = self.app.get('/api/0/test/issues', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- data['issues'][1]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": None,
- "tags": []
- },
- "total_issues": 2,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- },
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ]
- }
- )
- # List closed issue
- output = self.app.get('/api/0/test/issues?status=Closed', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": "Closed",
- "tags": []
- },
- "total_issues": 0,
- "issues": []
- }
- )
- # List closed issue
- output = self.app.get('/api/0/test/issues?status=Invalid', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": "Invalid",
- "tags": []
- },
- "total_issues": 0,
- "issues": []
- }
- )
- # List all issues
- output = self.app.get('/api/0/test/issues?status=All', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['issues'][0]['date_created'] = '1431414800'
- data['issues'][1]['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "args": {
- "assignee": None,
- "author": None,
- "status": "All",
- "tags": []
- },
- "total_issues": 2,
- "issues": [
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- },
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- ],
- }
- )
- def test_api_view_issue(self):
- """ Test the api_view_issue method of the flask api. """
- self.test_api_new_issue()
- # Invalid repo
- output = self.app.get('/api/0/foo/issue/1')
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Invalid issue for this repo
- output = self.app.get('/api/0/test2/issue/1')
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Valid issue
- output = self.app.get('/api/0/test/issue/1')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "This issue needs attention",
- "date_created": "1431414800",
- "depends": [],
- "id": 1,
- "priority": None,
- "private": False,
- "status": "Open",
- "tags": [],
- "title": "test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Create private issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=True,
- issue_uid='aaabbbccc',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Access private issue un-authenticated
- output = self.app.get('/api/0/test/issue/2')
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to view this issue",
- "error_code": "EISSUENOTALLOWED",
- }
- )
- headers = {'Authorization': 'token aaabbbccc'}
- # Access private issue authenticated but non-existing token
- output = self.app.get('/api/0/test/issue/2', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK"
- }
- )
- # Create a new token for another user
- item = pagure.lib.model.Token(
- id='bar_token',
- user_id=2,
- project_id=1,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- headers = {'Authorization': 'token bar_token'}
- # Access private issue authenticated but wrong token
- output = self.app.get('/api/0/test/issue/2', headers=headers)
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to view this issue",
- "error_code": "EISSUENOTALLOWED",
- }
- )
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Access private issue authenticated correctly
- output = self.app.get('/api/0/test/issue/2', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Access private issue authenticated correctly using the issue's uid
- output = self.app.get('/api/0/test/issue/aaabbbccc', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1431414800'
- self.assertDictEqual(
- data,
- {
- "assignee": None,
- "blocks": [],
- "comments": [],
- "content": "We should work on this",
- "date_created": "1431414800",
- "depends": [],
- "id": 2,
- "priority": None,
- "private": True,
- "status": "Open",
- "tags": [],
- "title": "Test issue",
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- def test_api_change_status_issue(self):
- """ Test the api_change_status_issue method of the flask api. """
- tests.create_projects(self.session)
- tests.create_projects_git(os.path.join(tests.HERE, 'tickets'))
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Invalid project
- output = self.app.post('/api/0/foo/issue/1/status', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/issue/1/status', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/issue/1/status', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Create normal issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue #1',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=False,
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue #1')
- # Create another project
- item = pagure.lib.model.Project(
- user_id=2, # pingou
- name='foo',
- description='test project #3',
- hook_token='aaabbbdddeee',
- )
- self.session.add(item)
- self.session.commit()
- # Create a token for pingou for this project
- item = pagure.lib.model.Token(
- id='pingou_foo',
- user_id=1,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- self.session.commit()
- # Give `change_status_issue` to this token
- item = pagure.lib.model.TokenAcl(
- token_id='pingou_foo',
- acl_id=6,
- )
- self.session.add(item)
- self.session.commit()
- repo = pagure.lib.get_project(self.session, 'foo')
- # Create private issue
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='foo',
- ticketfolder=None,
- private=True,
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Check status before
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'title': 'test issue',
- }
- # Incomplete request
- output = self.app.post(
- '/api/0/test/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'status': 'Open',
- }
- # Valid request but no change
- output = self.app.post(
- '/api/0/test/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'No changes'}
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'status': 'Fixed',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Successfully edited issue #1'}
- )
- headers = {'Authorization': 'token pingou_foo'}
- # Un-authorized issue
- output = self.app.post(
- '/api/0/foo/issue/1/status', data=data, headers=headers)
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to view this issue",
- "error_code": "EISSUENOTALLOWED",
- }
- )
- @patch('pagure.lib.git.update_git')
- @patch('pagure.lib.notify.send_email')
- def test_api_comment_issue(self, p_send_email, p_ugt):
- """ Test the api_comment_issue method of the flask api. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- tests.create_projects(self.session)
- tests.create_tokens(self.session)
- tests.create_tokens_acl(self.session)
- headers = {'Authorization': 'token aaabbbcccddd'}
- # Invalid project
- output = self.app.post('/api/0/foo/issue/1/comment', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Project not found",
- "error_code": "ENOPROJECT",
- }
- )
- # Valid token, wrong project
- output = self.app.post('/api/0/test2/issue/1/comment', headers=headers)
- self.assertEqual(output.status_code, 401)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or expired token. Please visit " \
- "https://pagure.org/ to get or renew your API token.",
- "error_code": "EINVALIDTOK",
- }
- )
- # No input
- output = self.app.post('/api/0/test/issue/1/comment', headers=headers)
- self.assertEqual(output.status_code, 404)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Issue not found",
- "error_code": "ENOISSUE",
- }
- )
- # Create normal issue
- repo = pagure.lib.get_project(self.session, 'test')
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue #1',
- content='We should work on this',
- user='pingou',
- ticketfolder=None,
- private=False,
- issue_uid='aaabbbccc#1',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue #1')
- # Check comments before
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- data = {
- 'title': 'test issue',
- }
- # Incomplete request
- output = self.app.post(
- '/api/0/test/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 400)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "Invalid or incomplete input submited",
- "error_code": "EINVALIDREQ",
- }
- )
- # No change
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(issue.status, 'Open')
- data = {
- 'comment': 'This is a very interesting question',
- }
- # Valid request
- output = self.app.post(
- '/api/0/test/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Comment added'}
- )
- # One comment added
- repo = pagure.lib.get_project(self.session, 'test')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 1)
- # Create another project
- item = pagure.lib.model.Project(
- user_id=2, # foo
- name='foo',
- description='test project #3',
- hook_token='aaabbbdddeee',
- )
- self.session.add(item)
- self.session.commit()
- # Create a token for pingou for this project
- item = pagure.lib.model.Token(
- id='pingou_foo',
- user_id=1,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(
- days=30)
- )
- self.session.add(item)
- self.session.commit()
- # Give `change_status_issue` to this token
- item = pagure.lib.model.TokenAcl(
- token_id='pingou_foo',
- acl_id=1,
- )
- self.session.add(item)
- self.session.commit()
- repo = pagure.lib.get_project(self.session, 'foo')
- # Create private issue
- msg = pagure.lib.new_issue(
- session=self.session,
- repo=repo,
- title='Test issue',
- content='We should work on this',
- user='foo',
- ticketfolder=None,
- private=True,
- issue_uid='aaabbbccc#2',
- )
- self.session.commit()
- self.assertEqual(msg.title, 'Test issue')
- # Check before
- repo = pagure.lib.get_project(self.session, 'foo')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- data = {
- 'comment': 'This is a very interesting question',
- }
- headers = {'Authorization': 'token pingou_foo'}
- # Valid request but un-authorized
- output = self.app.post(
- '/api/0/foo/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 403)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {
- "error": "You are not allowed to view this issue",
- "error_code": "EISSUENOTALLOWED",
- }
- )
- # No comment added
- repo = pagure.lib.get_project(self.session, 'foo')
- issue = pagure.lib.search_issues(self.session, repo, issueid=1)
- self.assertEqual(len(issue.comments), 0)
- # Create token for user foo
- item = pagure.lib.model.Token(
- id='foo_token2',
- user_id=2,
- project_id=3,
- expiration=datetime.datetime.utcnow() + datetime.timedelta(days=30)
- )
- self.session.add(item)
- self.session.commit()
- tests.create_tokens_acl(self.session, token_id='foo_token2')
- data = {
- 'comment': 'This is a very interesting question',
- }
- headers = {'Authorization': 'token foo_token2'}
- # Valid request and authorized
- output = self.app.post(
- '/api/0/foo/issue/1/comment', data=data, headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- self.assertDictEqual(
- data,
- {'message': 'Comment added'}
- )
- @patch('pagure.lib.git.update_git')
- @patch('pagure.lib.notify.send_email')
- def test_api_view_issue_comment(self, p_send_email, p_ugt):
- """ Test the api_view_issue_comment endpoint. """
- p_send_email.return_value = True
- p_ugt.return_value = True
- self.test_api_comment_issue()
- # View a comment that does not exist
- output = self.app.get('/api/0/foo/issue/100/comment/2')
- self.assertEqual(output.status_code, 404)
- # Issue exists but not the comment
- output = self.app.get('/api/0/test/issue/1/comment/2')
- self.assertEqual(output.status_code, 404)
- # Issue and comment exists
- output = self.app.get('/api/0/test/issue/1/comment/1')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1435821770'
- data["comment_date"] = "2015-07-02 09:22"
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "comment": "This is a very interesting question",
- "comment_date": "2015-07-02 09:22",
- "date_created": "1435821770",
- "edited_on": None,
- "editor": None,
- "id": 1,
- "parent": None,
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Issue and comment exists, using UID
- output = self.app.get('/api/0/test/issue/aaabbbccc#1/comment/1')
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1435821770'
- data["comment_date"] = "2015-07-02 09:22"
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "comment": "This is a very interesting question",
- "comment_date": "2015-07-02 09:22",
- "date_created": "1435821770",
- "edited_on": None,
- "editor": None,
- "id": 1,
- "parent": None,
- "user": {
- "fullname": "PY C",
- "name": "pingou"
- }
- }
- )
- # Private issue
- output = self.app.get('/api/0/foo/issue/1/comment/2')
- self.assertEqual(output.status_code, 403)
- # Private issue - Auth - wrong token
- headers = {'Authorization': 'token pingou_foo'}
- output = self.app.get('/api/0/foo/issue/1/comment/2', headers=headers)
- self.assertEqual(output.status_code, 403)
- # Private issue - Auth - Invalid token
- headers = {'Authorization': 'token aaabbbcccddd'}
- output = self.app.get('/api/0/foo/issue/1/comment/2', headers=headers)
- self.assertEqual(output.status_code, 401)
- # Private issue - Auth - valid token - unknown comment
- headers = {'Authorization': 'token foo_token2'}
- output = self.app.get('/api/0/foo/issue/1/comment/3', headers=headers)
- self.assertEqual(output.status_code, 404)
- # Private issue - Auth - valid token - known comment
- headers = {'Authorization': 'token foo_token2'}
- output = self.app.get('/api/0/foo/issue/1/comment/2', headers=headers)
- self.assertEqual(output.status_code, 200)
- data = json.loads(output.data)
- data['date_created'] = '1435821770'
- data["comment_date"] = "2015-07-02 09:22"
- data["avatar_url"] = "https://seccdn.libravatar.org/avatar/..."
- self.assertDictEqual(
- data,
- {
- "avatar_url": "https://seccdn.libravatar.org/avatar/...",
- "comment": "This is a very interesting question",
- "comment_date": "2015-07-02 09:22",
- "date_created": "1435821770",
- "edited_on": None,
- "editor": None,
- "id": 2,
- "parent": None,
- "user": {
- "fullname": "foo bar",
- "name": "foo"
- }
- }
- )
- if __name__ == '__main__':
- SUITE = unittest.TestLoader().loadTestsFromTestCase(
- PagureFlaskApiIssuetests)
- unittest.TextTestRunner(verbosity=2).run(SUITE)
|