test_pagure_lib_notify.py 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574
  1. # -*- coding: utf-8 -*-
  2. """
  3. (c) 2016 - Copyright Red Hat Inc
  4. Authors:
  5. Pierre-Yves Chibon <pingou@pingoured.fr>
  6. """
  7. from __future__ import unicode_literals, absolute_import
  8. import unittest
  9. import shutil
  10. import sys
  11. import os
  12. from mock import patch, MagicMock
  13. sys.path.insert(
  14. 0, os.path.join(os.path.dirname(os.path.abspath(__file__)), "..")
  15. )
  16. import pagure.lib.model
  17. import pagure.lib.notify
  18. import pagure.lib.query
  19. import tests
  20. import munch
  21. class PagureLibNotifytests(tests.Modeltests):
  22. """ Tests for pagure.lib.notify """
  23. maxDiff = None
  24. def test_get_emails_for_obj_issue(self):
  25. """ Test the _get_emails_for_obj method from pagure.lib.notify. """
  26. # Create the project ns/test
  27. item = pagure.lib.model.Project(
  28. user_id=1, # pingou
  29. name="test3",
  30. namespace="ns",
  31. description="test project #1",
  32. hook_token="aaabbbcccdd",
  33. )
  34. item.close_status = ["Invalid", "Insufficient data", "Fixed"]
  35. self.session.add(item)
  36. self.session.commit()
  37. # Create the ticket
  38. iss = pagure.lib.query.new_issue(
  39. issue_id=4,
  40. session=self.session,
  41. repo=item,
  42. title="test issue",
  43. content="content test issue",
  44. user="pingou",
  45. )
  46. self.session.commit()
  47. self.assertEqual(iss.id, 4)
  48. self.assertEqual(iss.title, "test issue")
  49. exp = set(["bar@pingou.com"])
  50. out = pagure.lib.notify._get_emails_for_obj(iss)
  51. self.assertEqual(out, exp)
  52. # Comment on the ticket
  53. out = pagure.lib.query.add_issue_comment(
  54. self.session,
  55. issue=iss,
  56. comment="This is a comment",
  57. user="foo",
  58. notify=False,
  59. )
  60. self.assertEqual(out, "Comment added")
  61. exp = set(["bar@pingou.com", "foo@bar.com"])
  62. out = pagure.lib.notify._get_emails_for_obj(iss)
  63. self.assertEqual(out, exp)
  64. # Create user `bar`
  65. item = pagure.lib.model.User(
  66. user="bar",
  67. fullname="bar name",
  68. password="bar",
  69. default_email="bar@bar.com",
  70. )
  71. self.session.add(item)
  72. item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
  73. self.session.add(item)
  74. self.session.commit()
  75. # Watch the ticket
  76. out = pagure.lib.query.set_watch_obj(self.session, "bar", iss, True)
  77. self.assertEqual(out, "You are now watching this issue")
  78. exp = set(["bar@pingou.com", "foo@bar.com", "bar@bar.com"])
  79. out = pagure.lib.notify._get_emails_for_obj(iss)
  80. self.assertEqual(out, exp)
  81. def test_get_emails_for_obj_issue_watching_project(self):
  82. """ Test the _get_emails_for_obj method from pagure.lib.notify. """
  83. # Create the project ns/test
  84. item = pagure.lib.model.Project(
  85. user_id=1, # pingou
  86. name="test3",
  87. namespace="ns",
  88. description="test project #1",
  89. hook_token="aaabbbcccdd",
  90. )
  91. item.close_status = ["Invalid", "Insufficient data", "Fixed"]
  92. self.session.add(item)
  93. self.session.commit()
  94. # Create the ticket
  95. iss = pagure.lib.query.new_issue(
  96. issue_id=4,
  97. session=self.session,
  98. repo=item,
  99. title="test issue",
  100. content="content test issue",
  101. user="pingou",
  102. )
  103. self.session.commit()
  104. self.assertEqual(iss.id, 4)
  105. self.assertEqual(iss.title, "test issue")
  106. exp = set(["bar@pingou.com"])
  107. out = pagure.lib.notify._get_emails_for_obj(iss)
  108. self.assertEqual(out, exp)
  109. # Comment on the ticket
  110. out = pagure.lib.query.add_issue_comment(
  111. self.session,
  112. issue=iss,
  113. comment="This is a comment",
  114. user="foo",
  115. notify=False,
  116. )
  117. self.assertEqual(out, "Comment added")
  118. exp = set(["bar@pingou.com", "foo@bar.com"])
  119. out = pagure.lib.notify._get_emails_for_obj(iss)
  120. self.assertEqual(out, exp)
  121. # Create user `bar`
  122. item = pagure.lib.model.User(
  123. user="bar",
  124. fullname="bar name",
  125. password="bar",
  126. default_email="bar@bar.com",
  127. )
  128. self.session.add(item)
  129. item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
  130. self.session.add(item)
  131. self.session.commit()
  132. # Watch the project
  133. repo = pagure.lib.query.get_authorized_project(
  134. self.session, "test3", namespace="ns"
  135. )
  136. out = pagure.lib.query.update_watch_status(
  137. self.session, repo, "bar", "1"
  138. )
  139. self.assertEqual(
  140. out, "You are now watching issues and PRs on this project"
  141. )
  142. exp = set(["bar@pingou.com", "foo@bar.com", "bar@bar.com"])
  143. out = pagure.lib.notify._get_emails_for_obj(iss)
  144. self.assertEqual(out, exp)
  145. @patch("pagure.lib.notify.smtplib.SMTP")
  146. def test_get_emails_for_obj_pr(self, mock_smtp):
  147. """ Test the _get_emails_for_obj method from pagure.lib.notify. """
  148. mock_smtp.return_value = MagicMock()
  149. tests.create_projects(self.session)
  150. # Create the project ns/test
  151. item = pagure.lib.model.Project(
  152. user_id=1, # pingou
  153. name="test3",
  154. namespace="ns",
  155. description="test project #1",
  156. hook_token="aaabbbcccdd",
  157. )
  158. item.close_status = ["Invalid", "Insufficient data", "Fixed"]
  159. self.session.add(item)
  160. self.session.commit()
  161. # Create the PR
  162. repo = pagure.lib.query._get_project(self.session, "test")
  163. req = pagure.lib.query.new_pull_request(
  164. session=self.session,
  165. repo_from=repo,
  166. branch_from="master",
  167. repo_to=repo,
  168. branch_to="master",
  169. title="test pull-request",
  170. user="pingou",
  171. )
  172. self.session.commit()
  173. self.assertEqual(req.id, 1)
  174. self.assertEqual(req.title, "test pull-request")
  175. self.assertEqual(repo.open_requests, 1)
  176. exp = set(["bar@pingou.com"])
  177. out = pagure.lib.notify._get_emails_for_obj(req)
  178. self.assertEqual(out, exp)
  179. # Comment on the ticket
  180. out = pagure.lib.query.add_pull_request_comment(
  181. self.session,
  182. request=req,
  183. commit=None,
  184. tree_id=None,
  185. filename=None,
  186. row=None,
  187. comment="This is a comment",
  188. user="foo",
  189. notify=False,
  190. )
  191. self.assertEqual(out, "Comment added")
  192. exp = set(["bar@pingou.com", "foo@bar.com"])
  193. out = pagure.lib.notify._get_emails_for_obj(req)
  194. self.assertEqual(out, exp)
  195. # Create user `bar`
  196. item = pagure.lib.model.User(
  197. user="bar",
  198. fullname="bar name",
  199. password="bar",
  200. default_email="bar@bar.com",
  201. )
  202. self.session.add(item)
  203. item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
  204. self.session.add(item)
  205. self.session.commit()
  206. # Watch the pull-request
  207. out = pagure.lib.query.set_watch_obj(self.session, "bar", req, True)
  208. self.assertEqual(out, "You are now watching this pull-request")
  209. exp = set(["bar@pingou.com", "foo@bar.com", "bar@bar.com"])
  210. out = pagure.lib.notify._get_emails_for_obj(req)
  211. self.assertEqual(out, exp)
  212. @patch("pagure.lib.notify.smtplib.SMTP")
  213. def test_get_emails_for_obj_pr_watching_project(self, mock_smtp):
  214. """ Test the _get_emails_for_obj method from pagure.lib.notify. """
  215. mock_smtp.return_value = MagicMock()
  216. tests.create_projects(self.session)
  217. # Create the project ns/test
  218. item = pagure.lib.model.Project(
  219. user_id=1, # pingou
  220. name="test3",
  221. namespace="ns",
  222. description="test project #1",
  223. hook_token="aaabbbcccdd",
  224. )
  225. item.close_status = ["Invalid", "Insufficient data", "Fixed"]
  226. self.session.add(item)
  227. self.session.commit()
  228. # Create the PR
  229. repo = pagure.lib.query.get_authorized_project(self.session, "test")
  230. req = pagure.lib.query.new_pull_request(
  231. session=self.session,
  232. repo_from=repo,
  233. branch_from="master",
  234. repo_to=repo,
  235. branch_to="master",
  236. title="test pull-request",
  237. user="pingou",
  238. )
  239. self.session.commit()
  240. self.assertEqual(req.id, 1)
  241. self.assertEqual(req.title, "test pull-request")
  242. self.assertEqual(repo.open_requests, 1)
  243. exp = set(["bar@pingou.com"])
  244. out = pagure.lib.notify._get_emails_for_obj(req)
  245. self.assertEqual(out, exp)
  246. # Comment on the ticket
  247. out = pagure.lib.query.add_pull_request_comment(
  248. self.session,
  249. request=req,
  250. commit=None,
  251. tree_id=None,
  252. filename=None,
  253. row=None,
  254. comment="This is a comment",
  255. user="foo",
  256. notify=False,
  257. )
  258. self.assertEqual(out, "Comment added")
  259. exp = set(["bar@pingou.com", "foo@bar.com"])
  260. out = pagure.lib.notify._get_emails_for_obj(req)
  261. self.assertEqual(out, exp)
  262. # Create user `bar`
  263. item = pagure.lib.model.User(
  264. user="bar",
  265. fullname="bar name",
  266. password="bar",
  267. default_email="bar@bar.com",
  268. )
  269. self.session.add(item)
  270. item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
  271. self.session.add(item)
  272. self.session.commit()
  273. # Watch the project
  274. repo = pagure.lib.query.get_authorized_project(self.session, "test")
  275. out = pagure.lib.query.update_watch_status(
  276. self.session, repo, "bar", "1"
  277. )
  278. self.assertEqual(
  279. out, "You are now watching issues and PRs on this project"
  280. )
  281. exp = set(["bar@pingou.com", "foo@bar.com", "bar@bar.com"])
  282. out = pagure.lib.notify._get_emails_for_obj(req)
  283. self.assertEqual(out, exp)
  284. def test_get_emails_for_obj_private_issue(self):
  285. """ Test the _get_emails_for_obj method from pagure.lib.notify. """
  286. # Create the project ns/test
  287. item = pagure.lib.model.Project(
  288. user_id=1, # pingou
  289. name="test3",
  290. namespace="ns",
  291. description="test project #1",
  292. hook_token="aaabbbcccdd",
  293. )
  294. item.close_status = ["Invalid", "Insufficient data", "Fixed"]
  295. self.session.add(item)
  296. self.session.commit()
  297. # Create the private ticket
  298. iss = pagure.lib.query.new_issue(
  299. issue_id=4,
  300. session=self.session,
  301. repo=item,
  302. title="test issue",
  303. content="content test issue",
  304. user="pingou",
  305. private=True,
  306. )
  307. self.session.commit()
  308. self.assertEqual(iss.id, 4)
  309. self.assertEqual(iss.title, "test issue")
  310. exp = set(["bar@pingou.com"])
  311. out = pagure.lib.notify._get_emails_for_obj(iss)
  312. self.assertEqual(out, exp)
  313. # Comment on the ticket
  314. out = pagure.lib.query.add_issue_comment(
  315. self.session,
  316. issue=iss,
  317. comment="This is a comment",
  318. user="foo",
  319. notify=False,
  320. )
  321. self.assertEqual(out, "Comment added")
  322. exp = set(["bar@pingou.com", "foo@bar.com"])
  323. out = pagure.lib.notify._get_emails_for_obj(iss)
  324. self.assertEqual(out, exp)
  325. # Create user `bar`
  326. item = pagure.lib.model.User(
  327. user="bar",
  328. fullname="bar name",
  329. password="bar",
  330. default_email="bar@bar.com",
  331. )
  332. self.session.add(item)
  333. item = pagure.lib.model.UserEmail(user_id=3, email="bar@bar.com")
  334. self.session.add(item)
  335. self.session.commit()
  336. # Add bar on the project with ticket acl
  337. project = pagure.lib.query._get_project(
  338. self.session, "test3", namespace="ns"
  339. )
  340. msg = pagure.lib.query.add_user_to_project(
  341. session=self.session,
  342. project=project,
  343. new_user="bar",
  344. user="pingou",
  345. access="ticket",
  346. )
  347. self.session.commit()
  348. self.assertEqual(msg, "User added")
  349. exp = set(["bar@pingou.com", "foo@bar.com"])
  350. out = pagure.lib.notify._get_emails_for_obj(iss)
  351. self.assertEqual(out, exp)
  352. @patch.dict(
  353. "pagure.config.config", {"EVENTSOURCE_SOURCE": "localhost.localdomain"}
  354. )
  355. @patch("pagure.lib.notify.smtplib.SMTP")
  356. def test_send_email(self, mock_smtp):
  357. """ Test the send_email method from pagure.lib.notify. """
  358. mock_smtp.return_value = MagicMock()
  359. email = pagure.lib.notify.send_email(
  360. "Email content",
  361. "Email “Subject“",
  362. "foo@bar.com,zöé@foo.net",
  363. mail_id="test-pull-request-2edbf96ebe644f4bb31b94605e-1",
  364. in_reply_to="test-pull-request-2edbf96ebe644f4bb31b94605e",
  365. project_name="namespace/project",
  366. user_from="Zöé",
  367. )
  368. # Due to differences in the way Python2 and Python3 encode non-ascii
  369. # email headers, we compare the From and To headers separately from the
  370. # rest of the message.
  371. self.assertEqual(
  372. email["From"],
  373. "=?utf-8?b?WsO2w6k=?= <pagure@localhost.localdomain>",
  374. )
  375. self.assertEqual(email["To"], "zöé@foo.net")
  376. del email["From"]
  377. del email["To"]
  378. exp = """Content-Type: text/plain; charset="utf-8"
  379. MIME-Version: 1.0
  380. Content-Transfer-Encoding: base64
  381. Subject: =?utf-8?b?W25hbWVzcGFjZS9wcm9qZWN0XSBFbWFpbCDigJxTdWJqZWN04oCc?=
  382. mail-id: test-pull-request-2edbf96ebe644f4bb31b94605e-1@localhost.localdomain
  383. Message-Id: <test-pull-request-2edbf96ebe644f4bb31b94605e-1@localhost.localdomain>
  384. In-Reply-To: <test-pull-request-2edbf96ebe644f4bb31b94605e@localhost.localdomain>
  385. X-Auto-Response-Suppress: All
  386. X-pagure: http://localhost.localdomain/
  387. X-pagure-project: namespace/project
  388. List-ID: namespace/project
  389. List-Archive: http://localhost.localdomain/namespace/project
  390. Reply-To: reply+ddd73d6bcace71598118ece5808b9c1b8e68c73e1acc4302538257a0951bb920ea0765d3f262ddb3725e9369519b086a7873cb65fbfceb1a2a25897f8e2a54fa@localhost.localdomain
  391. Mail-Followup-To: reply+ddd73d6bcace71598118ece5808b9c1b8e68c73e1acc4302538257a0951bb920ea0765d3f262ddb3725e9369519b086a7873cb65fbfceb1a2a25897f8e2a54fa@localhost.localdomain
  392. RW1haWwgY29udGVudA==
  393. """
  394. self.assertEqual(email.as_string(), exp)
  395. email = pagure.lib.notify.send_email(
  396. "Email content",
  397. "Email “Subject“",
  398. "foo@bar.com,zöé@foo.net",
  399. mail_id="test-pull-request-2edbf96ebe644f4bb31b94605e-1",
  400. in_reply_to="test-pull-request-2edbf96ebe644f4bb31b94605e",
  401. project_name="namespace/project",
  402. user_from="Zöé",
  403. )
  404. self.assertEqual(
  405. email["From"],
  406. "=?utf-8?b?WsO2w6k=?= <pagure@localhost.localdomain>",
  407. )
  408. self.assertEqual(email["To"], "zöé@foo.net")
  409. del email["From"]
  410. del email["To"]
  411. self.assertEqual(email.as_string(), exp)
  412. exp = """Content-Type: text/plain; charset="utf-8"
  413. MIME-Version: 1.0
  414. Content-Transfer-Encoding: base64
  415. Subject: =?utf-8?b?W25hbWVzcGFjZS9wcm9qZWN0XSBFbWFpbCDigJxTdWJqZWN04oCc?=
  416. In-Reply-To: <test-pull-request-2edbf96ebe644f4bb31b94605e@localhost.localdomain>
  417. X-Auto-Response-Suppress: All
  418. X-pagure: http://localhost.localdomain/
  419. X-pagure-project: namespace/project
  420. List-ID: namespace/project
  421. List-Archive: http://localhost.localdomain/namespace/project
  422. RW1haWwgY29udGVudA==
  423. """
  424. email = pagure.lib.notify.send_email(
  425. "Email content",
  426. "Email “Subject“",
  427. "foo@bar.com,zöé@foo.net",
  428. mail_id=None,
  429. in_reply_to="test-pull-request-2edbf96ebe644f4bb31b94605e",
  430. project_name="namespace/project",
  431. user_from="Zöé",
  432. )
  433. del email["From"]
  434. del email["To"]
  435. self.assertEqual(email.as_string(), exp)
  436. @patch.dict("pagure.config.config", {"EVENTSOURCE_SOURCE": None})
  437. @patch("pagure.lib.notify.smtplib.SMTP")
  438. def test_send_email_no_reply_to(self, mock_smtp):
  439. """ Test the send_email method from pagure.lib.notify when there
  440. should not be a Reply-To header even if mail_id is defined. """
  441. mock_smtp.return_value = MagicMock()
  442. email = pagure.lib.notify.send_email(
  443. "Email content",
  444. "Email “Subject“",
  445. "foo@bar.com,zöé@foo.net",
  446. mail_id="test-pull-request-2edbf96ebe644f4bb31b94605e-1",
  447. in_reply_to="test-pull-request-2edbf96ebe644f4bb31b94605e",
  448. project_name="namespace/project",
  449. reporter="reporter",
  450. assignee="assignee",
  451. user_from="Zöé",
  452. )
  453. # Due to differences in the way Python2 and Python3 encode non-ascii
  454. # email headers, we compare the From and To headers separately from the
  455. # rest of the message.
  456. self.assertEqual(
  457. email["From"],
  458. "=?utf-8?b?WsO2w6k=?= <pagure@localhost.localdomain>",
  459. )
  460. self.assertEqual(email["To"], "zöé@foo.net")
  461. del email["From"]
  462. del email["To"]
  463. exp = """Content-Type: text/plain; charset="utf-8"
  464. MIME-Version: 1.0
  465. Content-Transfer-Encoding: base64
  466. Subject: =?utf-8?b?W25hbWVzcGFjZS9wcm9qZWN0XSBFbWFpbCDigJxTdWJqZWN04oCc?=
  467. mail-id: test-pull-request-2edbf96ebe644f4bb31b94605e-1@localhost.localdomain
  468. Message-Id: <test-pull-request-2edbf96ebe644f4bb31b94605e-1@localhost.localdomain>
  469. In-Reply-To: <test-pull-request-2edbf96ebe644f4bb31b94605e@localhost.localdomain>
  470. X-Auto-Response-Suppress: All
  471. X-pagure: http://localhost.localdomain/
  472. X-pagure-project: namespace/project
  473. List-ID: namespace/project
  474. List-Archive: http://localhost.localdomain/namespace/project
  475. X-pagure-reporter: reporter
  476. X-pagure-assignee: assignee
  477. RW1haWwgY29udGVudA==
  478. """
  479. self.assertEqual(email.as_string(), exp)
  480. def test_notification_mention(self):
  481. g = munch.Munch()
  482. g.session = self.session
  483. with patch("flask.g", g):
  484. def _check_mention(comment, exp):
  485. emails = set([])
  486. emails = pagure.lib.notify._add_mentioned_users(
  487. emails, comment
  488. )
  489. self.assertEqual(emails, exp)
  490. exp = set(["bar@pingou.com"])
  491. comment = "I think we should ask @pingou how to pronounce pagure"
  492. _check_mention(comment, exp)
  493. exp = set([])
  494. comment = """Let me quote him:
  495. ~~~~
  496. @pingou> Pagure is pronounced 'pa-gure', not 'pagu-re'
  497. ~~~~
  498. """
  499. _check_mention(comment, exp)
  500. if __name__ == "__main__":
  501. unittest.main(verbosity=2)