Browse Source

Merge pull request #302 from matrix-org/babolivier/request_token_success

Remove unspecified 'success' parameter from requestToken responses
Brendan Abolivier 3 years ago
parent
commit
052fdb3a43
2 changed files with 2 additions and 1 deletions
  1. 1 0
      changelog.d/302.bugfix
  2. 1 1
      sydent/http/servlets/emailservlet.py

+ 1 - 0
changelog.d/302.bugfix

@@ -0,0 +1 @@
+Stop sending the unspecified `success` parameter in responses to `/requestToken` requests.

+ 1 - 1
sydent/http/servlets/emailservlet.py

@@ -66,7 +66,7 @@ class EmailRequestCodeServlet(Resource):
             sid = self.sydent.validators.email.requestToken(
                 email, clientSecret, sendAttempt, nextLink, ipaddress=ipaddress
             )
-            resp = {'success': True, 'sid': str(sid)}
+            resp = {'sid': str(sid)}
         except EmailAddressException:
             request.setResponseCode(400)
             resp = {'errcode': 'M_INVALID_EMAIL', 'error': 'Invalid email address'}