sydent/CHANGELOG.md

Sydent 2.5.1 (2021-11-17)

This release fixes a bug in handling verification for third party IDs if requested via the deprecated /api/v1/ endpoint. The other changes are all designed to improve error handling, and make Sydent's logging have a higher signal-to-noise ratio.

Features

• Return HTTP 400 Bad Request rather than HTTP 500 Internal Server Error if /store-invite is given an invalid email address. (#464)

Bugfixes

• Fix a bug introduced in Sydent 2.5.0 where requests to validate an email or phone number would fail with an HTTP 500 Internal Server Error if arguments were given as a query string or as a www-form-urlencoded body. (#461, #462)

Internal Changes

• Improve exception logging in asyncjsonwrap for better Sentry reports. (#455)
• Handle federation request failures in /request explicitly, to reduce Sentry noise. (#456)
• Log a warning (not an error) when we refuse to send an SMS to an unsupported country. (#459)
• Demote a failure to parse JSON from homeservers in /register from an error to a warning. (#463)
• Handle errors to contact homeservers in /unbind. This returns a better error message and reduces Sentry spam. (#466)
• Log failures to send SMS as exceptions, not errors (to better debug in Sentry). (#467)

Sydent 2.5.0 (2021-11-03)

This release deprecates .eml templates in favour of Jinja 2 .eml.j2 templates. See the documentation for more details.

Features

• Support the stable room_type field for MSC3288. (#437)

Bugfixes

• Fix a bug which could cause SMS sending to fail silently. (#412)
• Fix a bug introduced in v2.4.0 that caused association unbindings to fail with an internal server error. (#397)
• Fix an issue which could cause new local associations to be replicated multiple times to peers. (#400)
• Fix an issue where obey_x_forwarded_for was not being honoured. (#403)
• Fix misleading logging and potential TypeErrors related to replication ports in Sydent's database. (#420)
• Fix a bug introduced in v2.0.0 where requesting GET from /identity/api/v1/validate/msisdn/submitToken or /identity/v2/validate/msisdn/submitToken would fail with an internal server error. (#445)
• Fix /v2/account/logout to return HTTP 400 BAD REQUEST instead of 200 OK if a token was not provided. (#447)
• Fix a long-standing spec compliance bug where the response to POST /identity/{api/v1,v2}/3pid/unbind was null, not {}. (#449)

Improved Documentation

• Fix the documentation around the command line arguments for the email address migration script. (#392)
• Add documentation on writing templates. Deprecate .eml templates. (#395)

Internal Changes

• Improve type annotations throughout Sydent. Sydent now passes mypy --strict. (#414 and others).
• Extend the changelog check so that it checks for the correct pull request number being used. (#382)
• Move the configuration file handling code into a separate module. (#385, #405)
• Add a primitive contributing guide and tweak the pull request template. (#393)
• Run mypy on the sydent package as part of CI. (#416)
• Configure @matrix-org/synapse-core to be the code owner for the repository. (#436)
• Run linters over stub files. (#441, #450)
• Include Sydent's version number (and git commit hash if available) when reporting to Sentry. (#453, #454)

Sydent 2.4.6 (2021-10-08)

Bugfixes

• Fix a long-standing bug with error handling around missing headers when dealing with the OpenMarket API, which could cause the wrong assumption that sending a SMS failed when it didn't. (#415)

Sydent 2.4.5 (2021-10-08)

Bugfixes

• Fix a long-standing bug in asynchronous code that could cause SMS messages not to be correctly sent. (#413)

Sydent 2.4.4 (2021-10-08)

Bugfixes

• Fix a bug introduced in v2.4.0 which could cause SMS sending to fail silently. (#412)

Sydent 2.4.3 (2021-09-14)

Bugfixes

• Fix a bug introduced in v2.4.0 that caused association unbindings to fail with an Internal Server Error. (#397)

Sydent 2.4.2 (2021-09-13)

Bugfixes

• Fix a bug causing the email address migration script to take a lot of time to run due to inefficient database queries. (#396)

Internal Changes

• Move dev tools from install_requires to extras_require. (#389)
• Run background jobs in run rather than in Sydent's constructor. (#394)

Sydent 2.4.1 (2021-09-10)

Bugfixes

• Fix a bug preventing the email migration script from running while Sydent is already running with Prometheus metrics enabled. (#391)

Sydent 2.4.0 (2021-09-09)

This release drops compatibility with Python 3.5 and older. Python 3.6 and later is required to run Sydent from this version onwards.

Action required when upgrading: server administrators should run the e-mail address migration script.

Features

• Experimental support for MSC3288, receiving room_type for 3pid invites over the /store-invite API and using it in Jinja templates for Space invites. (#375)
• Add support for using Jinja2 in e-mail templates. Contributed by @H-Shay. (#376)
• Case-fold email addresses when binding to MXIDs or performing look-ups. Contributed by @H-Shay. (#374, #378, #379, #386)

Bugfixes

• Handle CORS for GetValidated3pidServlet. Endpoint /3pid/getValidated3pid returns valid CORS headers. (#342)
• Use the web_client_location parameter in default templates for both text and HTML emails. (#380)

Internal Changes

• Add /_trial_temp.lock and /sydent.pid to .gitignore. (#384)
• Reformat code using Black. Contributed by @H-Shay. (#344, #369)
• Configure Flake8 and resolve errors. (#345, #347)
• Add GitHub Actions for unit tests (Python 3.6 and 3.9), matrix_is_tester tests (Python 3.6 and 3.9), towncrier checks and black and flake8 codestyle checks. (#346, #348)
• Remove support for Python < 3.6. Contributed by @sunweaver. (#349, #356)
• Bump minimum supported version of Twisted to 18.4.0 and stop calling deprecated APIs. (#350)
• Replace deprecated logging.warn() method with logging.warning(). (#351)
• Reformat imports using isort. (#352, #353)
• Update .gitignore to only ignore sydent.conf and sydent.db if they occur in the project's base folder. (#354)
• Add type hints and validate with mypy. (#355, #357, #358, #360, #361, #367, #371)
• Convert inlineCallbacks to async/await. (#364, #365, #368, #372, #373)
• Use mock module from the standard library. (#370)
• Fix email templates to be valid python format strings. (#377)

Sydent 2.3.0 (2021-04-15)

Note: this will be the last release of Sydent to support Python 3.5 or earlier. Future releases will require at least Python 3.6.

Security advisory

This release contains fixes to the following security issues:

• Denial of service attack via disk space or memory exhaustion (CVE-2021-29430).
• SSRF due to missing validation of hostnames (CVE-2021-29431).
• Malicious users could control the content of invitation emails (CVE-2021-29432).
• Denial of service (via resource exhaustion) due to improper input validation (CVE-2021-29433).

Although we are not aware of these vulnerabilities being exploited in the wild, Sydent server administrators are advised to update as soon as possible. Note that as well as changes to the package, there are also changes to the default email templates. If any templates have been updated locally, they must also be updated in line with the changes to the defaults for full protection from CVE-2021-29432.

Features

• Accept an optional web_client_location argument to the invite endpoint which allows customisation of the email template. (#326)
• Move templates to a per-brand subdirectory of /res. Add templates.path and brand.default config options. (#328)

Bugfixes

• Fix a regression in v2.2.0 where the wrong characters would be obfuscated in a 3pid invite. (#317)
• Fix a long-standing bug where invalid JSON would be accepted over the HTTP interfaces. (#337)
• During user registration on the identity server, validate that the MXID returned by the contacted homeserver is valid for that homeserver. (cc97fff)
• Ensure that /v2/ endpoints are correctly authenticated. (ce04a68)
• Perform additional validation on the response received when requesting server signing keys. (07e6da7)
• Validate the matrix_server_name parameter given during user registration. (9e57334, 8936925, 3d531ed, 0f00412)
• Limit the size of requests received from HTTP clients. (89071a1, 0523511, f56eee3)
• Limit the size of responses received from HTTP servers. (89071a1, 0523511, f56eee3)
• In invite emails, randomise the multipart boundary, and include MXIDs where available. (4469d1d, 6b405a8, 65a6e91)
• Perform additional validation on the client_secret and email parameters to various APIs. (3175fd3)

Updates to the Docker image

• Base docker image on Debian rather than Alpine Linux. (#335)

Internal Changes

• Fix test logging to allow braces in log output. (#318)
• Install prometheus_client in the Docker image. (#325)
• Bump the version of signedjson to 1.1.1. (#334)

Sydent 2.2.0 (2020-09-11)

Bugfixes

• Fix intermittent deadlock in Sentry integration. (#312)

Sydent 2.1.0 (2020-09-10)

Features

• Add a Dockerfile and allow environment variables SYDENT_SERVER_NAME, SYDENT_PID_FILE and SYDENT_DB_PATH to modify default configuration values. (#290)
• Add config options for controlling how email addresses are obfuscated in third party invites. (#311)

Bugfixes

• Fix a bug in the error handling of 3PID session validation, if the token submitted is incorrect. (#296)
• Stop sending the unspecified success parameter in responses to /requestToken requests. (#302)
• Fix a bug causing Sydent to ignore nextLink parameters. (#303)
• Fix the HTTP status code returned during some error responses. (#305)
• Sydent now correctly enforces the valid characters in the client_secret parameter used in various endpoints. (#309)

Internal Changes

• Replace instances of Riot with Element. (#308)

Sydent 2.0.1 (2020-05-20)

Features

• Add a config option to disable deleting invite tokens on bind. (#293)

Bugfixes

• Fix a bug that prevented Sydent from checking for access tokens in request parameters when running on Python3. (#294)

Internal Changes

• Make replication tests more reliable. (#278)
• Add a configuration for towncrier. (#295)

Changes in 2.0.0 (2020-02-25)

Note: Starting with this release, Sydent releases are available on PyPI. This means that the recommended method for stable installations is now by using the PyPI project rather than a tarball of the master branch of this repository. See the README for more details.

Warning: This release deprecates v1 APIs for existing endpoints in favour of v2 APIs. Homeserver and client developers are encouraged to migrate their applications to the v2 APIs. See below for more information.

Features

• Implement the items and MSCs from the privacy project targeting identity servers. This introduces v2 APIs for every existing endpoint. v1 APIs are now deprecated and homeserver and client developers are encouraged to migrate their applications to the v2 APIs.
• Add Python 3 compatibility to all of the codebase. Python 2 is still supported for now.
• Delete stored invites upon successful delivery to a homeserver
• Filter out delivered invites when delivering invites to a homeserver upon successful binding
• Implement support for authenticating unbind queries by providing a sid and a client_secret, as per MSC1915
• Add support for Prometheus and Sentry
• Handle .well-known files when talking to homeservers
• Validate client_secret parameters according to the Matrix specification
• Return 400/404 on incorrect session validation
• Add a default 10,000 address limit on v2 /lookup (which supports multiple lookups at once)

Documentation

• Rewrite part of the README to make it more user-friendly

Bugfixes

• Fix a bug that would prevent requests to the /store-invite endpoint with JSON payloads from being correctly processed
• Fix a bug where multiple cleanup tasks would be unnecessary spawned
• Fix logging so Sydent doesn't log 3PIDs when processing lookup requests
• Fix incorrect HTTP response from /3pid/getValidated3pid endpoint on failure.
• Prevent a single failure from aborting the federation loop
• Fix federation lookups in /onBind callbacks
• Don't fail the unbind request if the binding doesn't exist
• Fix the signing servlet missing a reference to the Sydent object
• Fix content types & OPTIONS requests

Internal changes

• Add unit tests to test startup and replication
• Add support for testing with matrix-is-tester
• Remove instances of setResponseCode(200)

Changes in 1.0.3 (2019-05-03)

• Use trustRoot instead of verify for request verification

Security Fixes

• Ensures that authentication tokens are generated using a secure random number generator, ensuring they cannot be predicted by an attacker. Thanks to @opnsec for identifying and responsibly disclosing the issue!
• Mitigate an HTML injection bug where an invalid room_id could result in malicious HTML being injected into validation emails. Thanks to @opnsec for identifying and responsibly disclosing this issue too!
• Randomise session_ids to avoid leaking info about the total number of identity validations, and whether a given ID has been validated. Thanks to @fs0c131y for this one.
• Don't send tracebacks to the browser when errors occur.

Changes in 1.0.2 (2019-04-18)

Security Fixes

• Fix for validating malformed email addresses: https://github.com/matrix-org/sydent/commit/3103b65dcfa37a9241dabedba560c4ded6c05ff6

Changes in 1.0.1 (2019-04-18)

Release pointed to wrong commit, fixed by 1.0.2