|
@@ -657,7 +657,7 @@ class URLPreviewTests(unittest.HomeserverTestCase):
|
|
|
"""If the preview image doesn't exist, ensure some data is returned."""
|
|
|
self.lookups["matrix.org"] = [(IPv4Address, "10.1.2.3")]
|
|
|
|
|
|
- end_content = (
|
|
|
+ result = (
|
|
|
b"""<html><body><img src="http://cdn.matrix.org/foo.jpg"></body></html>"""
|
|
|
)
|
|
|
|
|
@@ -678,8 +678,8 @@ class URLPreviewTests(unittest.HomeserverTestCase):
|
|
|
b"HTTP/1.0 200 OK\r\nContent-Length: %d\r\n"
|
|
|
b'Content-Type: text/html; charset="utf8"\r\n\r\n'
|
|
|
)
|
|
|
- % (len(end_content),)
|
|
|
- + end_content
|
|
|
+ % (len(result),)
|
|
|
+ + result
|
|
|
)
|
|
|
|
|
|
self.pump()
|
|
@@ -688,6 +688,44 @@ class URLPreviewTests(unittest.HomeserverTestCase):
|
|
|
# The image should not be in the result.
|
|
|
self.assertNotIn("og:image", channel.json_body)
|
|
|
|
|
|
+ def test_oembed_failure(self) -> None:
|
|
|
+ """If the autodiscovered oEmbed URL fails, ensure some data is returned."""
|
|
|
+ self.lookups["matrix.org"] = [(IPv4Address, "10.1.2.3")]
|
|
|
+
|
|
|
+ result = b"""
|
|
|
+ <title>oEmbed Autodiscovery Fail</title>
|
|
|
+ <link rel="alternate" type="application/json+oembed"
|
|
|
+ href="http://example.com/oembed?url=http%3A%2F%2Fmatrix.org&format=json"
|
|
|
+ title="matrixdotorg" />
|
|
|
+ """
|
|
|
+
|
|
|
+ channel = self.make_request(
|
|
|
+ "GET",
|
|
|
+ "preview_url?url=http://matrix.org",
|
|
|
+ shorthand=False,
|
|
|
+ await_result=False,
|
|
|
+ )
|
|
|
+ self.pump()
|
|
|
+
|
|
|
+ client = self.reactor.tcpClients[0][2].buildProtocol(None)
|
|
|
+ server = AccumulatingProtocol()
|
|
|
+ server.makeConnection(FakeTransport(client, self.reactor))
|
|
|
+ client.makeConnection(FakeTransport(server, self.reactor))
|
|
|
+ client.dataReceived(
|
|
|
+ (
|
|
|
+ b"HTTP/1.0 200 OK\r\nContent-Length: %d\r\n"
|
|
|
+ b'Content-Type: text/html; charset="utf8"\r\n\r\n'
|
|
|
+ )
|
|
|
+ % (len(result),)
|
|
|
+ + result
|
|
|
+ )
|
|
|
+
|
|
|
+ self.pump()
|
|
|
+ self.assertEqual(channel.code, 200)
|
|
|
+
|
|
|
+ # The image should not be in the result.
|
|
|
+ self.assertEqual(channel.json_body["og:title"], "oEmbed Autodiscovery Fail")
|
|
|
+
|
|
|
def test_data_url(self) -> None:
|
|
|
"""
|
|
|
Requesting to preview a data URL is not supported.
|