contributing_guide.html 43 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553
  1. <!DOCTYPE HTML>
  2. <html lang="en" class="sidebar-visible no-js light">
  3. <head>
  4. <!-- Book generated using mdBook -->
  5. <meta charset="UTF-8">
  6. <title>Contributing Guide - Synapse</title>
  7. <!-- Custom HTML head -->
  8. <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  9. <meta name="description" content="">
  10. <meta name="viewport" content="width=device-width, initial-scale=1">
  11. <meta name="theme-color" content="#ffffff" />
  12. <link rel="icon" href="../favicon.svg">
  13. <link rel="shortcut icon" href="../favicon.png">
  14. <link rel="stylesheet" href="../css/variables.css">
  15. <link rel="stylesheet" href="../css/general.css">
  16. <link rel="stylesheet" href="../css/chrome.css">
  17. <link rel="stylesheet" href="../css/print.css" media="print">
  18. <!-- Fonts -->
  19. <link rel="stylesheet" href="../FontAwesome/css/font-awesome.css">
  20. <link rel="stylesheet" href="../fonts/fonts.css">
  21. <!-- Highlight.js Stylesheets -->
  22. <link rel="stylesheet" href="../highlight.css">
  23. <link rel="stylesheet" href="../tomorrow-night.css">
  24. <link rel="stylesheet" href="../ayu-highlight.css">
  25. <!-- Custom theme stylesheets -->
  26. <link rel="stylesheet" href="../docs/website_files/table-of-contents.css">
  27. <link rel="stylesheet" href="../docs/website_files/remove-nav-buttons.css">
  28. <link rel="stylesheet" href="../docs/website_files/indent-section-headers.css">
  29. <link rel="stylesheet" href="../docs/website_files/version-picker.css">
  30. </head>
  31. <body>
  32. <!-- Provide site root to javascript -->
  33. <script type="text/javascript">
  34. var path_to_root = "../";
  35. var default_theme = window.matchMedia("(prefers-color-scheme: dark)").matches ? "navy" : "light";
  36. </script>
  37. <!-- Work around some values being stored in localStorage wrapped in quotes -->
  38. <script type="text/javascript">
  39. try {
  40. var theme = localStorage.getItem('mdbook-theme');
  41. var sidebar = localStorage.getItem('mdbook-sidebar');
  42. if (theme.startsWith('"') && theme.endsWith('"')) {
  43. localStorage.setItem('mdbook-theme', theme.slice(1, theme.length - 1));
  44. }
  45. if (sidebar.startsWith('"') && sidebar.endsWith('"')) {
  46. localStorage.setItem('mdbook-sidebar', sidebar.slice(1, sidebar.length - 1));
  47. }
  48. } catch (e) { }
  49. </script>
  50. <!-- Set the theme before any content is loaded, prevents flash -->
  51. <script type="text/javascript">
  52. var theme;
  53. try { theme = localStorage.getItem('mdbook-theme'); } catch(e) { }
  54. if (theme === null || theme === undefined) { theme = default_theme; }
  55. var html = document.querySelector('html');
  56. html.classList.remove('no-js')
  57. html.classList.remove('light')
  58. html.classList.add(theme);
  59. html.classList.add('js');
  60. </script>
  61. <!-- Hide / unhide sidebar before it is displayed -->
  62. <script type="text/javascript">
  63. var html = document.querySelector('html');
  64. var sidebar = 'hidden';
  65. if (document.body.clientWidth >= 1080) {
  66. try { sidebar = localStorage.getItem('mdbook-sidebar'); } catch(e) { }
  67. sidebar = sidebar || 'visible';
  68. }
  69. html.classList.remove('sidebar-visible');
  70. html.classList.add("sidebar-" + sidebar);
  71. </script>
  72. <nav id="sidebar" class="sidebar" aria-label="Table of contents">
  73. <div class="sidebar-scrollbox">
  74. <ol class="chapter"><li class="chapter-item expanded affix "><li class="part-title">Introduction</li><li class="chapter-item expanded "><a href="../welcome_and_overview.html">Welcome and Overview</a></li><li class="chapter-item expanded affix "><li class="part-title">Setup</li><li class="chapter-item expanded "><a href="../setup/installation.html">Installation</a></li><li class="chapter-item expanded "><a href="../postgres.html">Using Postgres</a></li><li class="chapter-item expanded "><a href="../reverse_proxy.html">Configuring a Reverse Proxy</a></li><li class="chapter-item expanded "><a href="../setup/forward_proxy.html">Configuring a Forward/Outbound Proxy</a></li><li class="chapter-item expanded "><a href="../turn-howto.html">Configuring a Turn Server</a></li><li class="chapter-item expanded "><a href="../delegate.html">Delegation</a></li><li class="chapter-item expanded affix "><li class="part-title">Upgrading</li><li class="chapter-item expanded "><a href="../upgrade.html">Upgrading between Synapse Versions</a></li><li class="chapter-item expanded "><a href="../MSC1711_certificates_FAQ.html">Upgrading from pre-Synapse 1.0</a></li><li class="chapter-item expanded affix "><li class="part-title">Usage</li><li class="chapter-item expanded "><a href="../federate.html">Federation</a></li><li class="chapter-item expanded "><a href="../usage/configuration/index.html">Configuration</a></li><li><ol class="section"><li class="chapter-item expanded "><a href="../usage/configuration/homeserver_sample_config.html">Homeserver Sample Config File</a></li><li class="chapter-item expanded "><a href="../usage/configuration/logging_sample_config.html">Logging Sample Config File</a></li><li class="chapter-item expanded "><a href="../structured_logging.html">Structured Logging</a></li><li class="chapter-item expanded "><a href="../templates.html">Templates</a></li><li class="chapter-item expanded "><a href="../usage/configuration/user_authentication/index.html">User Authentication</a></li><li><ol class="section"><li class="chapter-item expanded "><div>Single-Sign On</div></li><li><ol class="section"><li class="chapter-item expanded "><a href="../openid.html">OpenID Connect</a></li><li class="chapter-item expanded "><div>SAML</div></li><li class="chapter-item expanded "><div>CAS</div></li><li class="chapter-item expanded "><a href="../sso_mapping_providers.html">SSO Mapping Providers</a></li></ol></li><li class="chapter-item expanded "><a href="../password_auth_providers.html">Password Auth Providers</a></li><li class="chapter-item expanded "><a href="../jwt.html">JSON Web Tokens</a></li></ol></li><li class="chapter-item expanded "><a href="../CAPTCHA_SETUP.html">Registration Captcha</a></li><li class="chapter-item expanded "><a href="../application_services.html">Application Services</a></li><li class="chapter-item expanded "><a href="../server_notices.html">Server Notices</a></li><li class="chapter-item expanded "><a href="../consent_tracking.html">Consent Tracking</a></li><li class="chapter-item expanded "><a href="../development/url_previews.html">URL Previews</a></li><li class="chapter-item expanded "><a href="../user_directory.html">User Directory</a></li><li class="chapter-item expanded "><a href="../message_retention_policies.html">Message Retention Policies</a></li><li class="chapter-item expanded "><a href="../modules/index.html">Pluggable Modules</a></li><li><ol class="section"><li class="chapter-item expanded "><a href="../modules/writing_a_module.html">Writing a module</a></li><li><ol class="section"><li class="chapter-item expanded "><a href="../modules/spam_checker_callbacks.html">Spam checker callbacks</a></li><li class="chapter-item expanded "><a href="../modules/third_party_rules_callbacks.html">Third-party rules callbacks</a></li><li class="chapter-item expanded "><a href="../modules/presence_router_callbacks.html">Presence router callbacks</a></li><li class="chapter-item expanded "><a href="../modules/account_validity_callbacks.html">Account validity callbacks</a></li><li class="chapter-item expanded "><a href="../modules/password_auth_provider_callbacks.html">Password auth provider callbacks</a></li><li class="chapter-item expanded "><a href="../modules/porting_legacy_module.html">Porting a legacy module to the new interface</a></li></ol></li></ol></li><li class="chapter-item expanded "><a href="../workers.html">Workers</a></li><li><ol class="section"><li class="chapter-item expanded "><a href="../synctl_workers.html">Using synctl with Workers</a></li><li class="chapter-item expanded "><a href="../systemd-with-workers/index.html">Systemd</a></li></ol></li></ol></li><li class="chapter-item expanded "><a href="../usage/administration/index.html">Administration</a></li><li><ol class="section"><li class="chapter-item expanded "><a href="../usage/administration/admin_api/index.html">Admin API</a></li><li><ol class="section"><li class="chapter-item expanded "><a href="../admin_api/account_validity.html">Account Validity</a></li><li class="chapter-item expanded "><a href="../usage/administration/admin_api/background_updates.html">Background Updates</a></li><li class="chapter-item expanded "><a href="../admin_api/delete_group.html">Delete Group</a></li><li class="chapter-item expanded "><a href="../admin_api/event_reports.html">Event Reports</a></li><li class="chapter-item expanded "><a href="../admin_api/media_admin_api.html">Media</a></li><li class="chapter-item expanded "><a href="../admin_api/purge_history_api.html">Purge History</a></li><li class="chapter-item expanded "><a href="../admin_api/register_api.html">Register Users</a></li><li class="chapter-item expanded "><a href="../usage/administration/admin_api/registration_tokens.html">Registration Tokens</a></li><li class="chapter-item expanded "><a href="../admin_api/room_membership.html">Manipulate Room Membership</a></li><li class="chapter-item expanded "><a href="../admin_api/rooms.html">Rooms</a></li><li class="chapter-item expanded "><a href="../admin_api/server_notices.html">Server Notices</a></li><li class="chapter-item expanded "><a href="../admin_api/statistics.html">Statistics</a></li><li class="chapter-item expanded "><a href="../admin_api/user_admin_api.html">Users</a></li><li class="chapter-item expanded "><a href="../admin_api/version_api.html">Server Version</a></li></ol></li><li class="chapter-item expanded "><a href="../manhole.html">Manhole</a></li><li class="chapter-item expanded "><a href="../metrics-howto.html">Monitoring</a></li><li class="chapter-item expanded "><a href="../usage/administration/request_log.html">Request log format</a></li><li class="chapter-item expanded "><div>Scripts</div></li></ol></li><li class="chapter-item expanded "><li class="part-title">Development</li><li class="chapter-item expanded "><a href="../development/contributing_guide.html" class="active">Contributing Guide</a></li><li class="chapter-item expanded "><a href="../code_style.html">Code Style</a></li><li class="chapter-item expanded "><a href="../development/git.html">Git Usage</a></li><li class="chapter-item expanded "><div>Testing</div></li><li class="chapter-item expanded "><a href="../opentracing.html">OpenTracing</a></li><li class="chapter-item expanded "><a href="../development/database_schema.html">Database Schemas</a></li><li class="chapter-item expanded "><a href="../development/experimental_features.html">Experimental features</a></li><li class="chapter-item expanded "><div>Synapse Architecture</div></li><li><ol class="section"><li class="chapter-item expanded "><a href="../log_contexts.html">Log Contexts</a></li><li class="chapter-item expanded "><a href="../replication.html">Replication</a></li><li class="chapter-item expanded "><a href="../tcp_replication.html">TCP Replication</a></li></ol></li><li class="chapter-item expanded "><a href="../development/internal_documentation/index.html">Internal Documentation</a></li><li><ol class="section"><li class="chapter-item expanded "><div>Single Sign-On</div></li><li><ol class="section"><li class="chapter-item expanded "><a href="../development/saml.html">SAML</a></li><li class="chapter-item expanded "><a href="../development/cas.html">CAS</a></li></ol></li><li class="chapter-item expanded "><a href="../development/room-dag-concepts.html">Room DAG concepts</a></li><li class="chapter-item expanded "><div>State Resolution</div></li><li><ol class="section"><li class="chapter-item expanded "><a href="../auth_chain_difference_algorithm.html">The Auth Chain Difference Algorithm</a></li></ol></li><li class="chapter-item expanded "><a href="../media_repository.html">Media Repository</a></li><li class="chapter-item expanded "><a href="../room_and_user_statistics.html">Room and User Statistics</a></li></ol></li><li class="chapter-item expanded "><div>Scripts</div></li><li class="chapter-item expanded affix "><li class="part-title">Other</li><li class="chapter-item expanded "><a href="../deprecation_policy.html">Dependency Deprecation Policy</a></li></ol>
  75. </div>
  76. <div id="sidebar-resize-handle" class="sidebar-resize-handle"></div>
  77. </nav>
  78. <div id="page-wrapper" class="page-wrapper">
  79. <div class="page">
  80. <div id="menu-bar-hover-placeholder"></div>
  81. <div id="menu-bar" class="menu-bar sticky bordered">
  82. <div class="left-buttons">
  83. <button id="sidebar-toggle" class="icon-button" type="button" title="Toggle Table of Contents" aria-label="Toggle Table of Contents" aria-controls="sidebar">
  84. <i class="fa fa-bars"></i>
  85. </button>
  86. <button id="theme-toggle" class="icon-button" type="button" title="Change theme" aria-label="Change theme" aria-haspopup="true" aria-expanded="false" aria-controls="theme-list">
  87. <i class="fa fa-paint-brush"></i>
  88. </button>
  89. <ul id="theme-list" class="theme-popup" aria-label="Themes" role="menu">
  90. <li role="none"><button role="menuitem" class="theme" id="light">Light (default)</button></li>
  91. <li role="none"><button role="menuitem" class="theme" id="rust">Rust</button></li>
  92. <li role="none"><button role="menuitem" class="theme" id="coal">Coal</button></li>
  93. <li role="none"><button role="menuitem" class="theme" id="navy">Navy</button></li>
  94. <li role="none"><button role="menuitem" class="theme" id="ayu">Ayu</button></li>
  95. </ul>
  96. <button id="search-toggle" class="icon-button" type="button" title="Search. (Shortkey: s)" aria-label="Toggle Searchbar" aria-expanded="false" aria-keyshortcuts="S" aria-controls="searchbar">
  97. <i class="fa fa-search"></i>
  98. </button>
  99. <div class="version-picker">
  100. <div class="dropdown">
  101. <div class="select">
  102. <span></span>
  103. <i class="fa fa-chevron-down"></i>
  104. </div>
  105. <input type="hidden" name="version">
  106. <ul class="dropdown-menu">
  107. <!-- Versions will be added dynamically in version-picker.js -->
  108. </ul>
  109. </div>
  110. </div>
  111. </div>
  112. <h1 class="menu-title">Synapse</h1>
  113. <div class="right-buttons">
  114. <a href="../print.html" title="Print this book" aria-label="Print this book">
  115. <i id="print-button" class="fa fa-print"></i>
  116. </a>
  117. <a href="https://github.com/matrix-org/synapse" title="Git repository" aria-label="Git repository">
  118. <i id="git-repository-button" class="fa fa-github"></i>
  119. </a>
  120. <a href="https://github.com/matrix-org/synapse/edit/develop/docs/development/contributing_guide.md" title="Suggest an edit" aria-label="Suggest an edit">
  121. <i id="git-edit-button" class="fa fa-edit"></i>
  122. </a>
  123. </div>
  124. </div>
  125. <div id="search-wrapper" class="hidden">
  126. <form id="searchbar-outer" class="searchbar-outer">
  127. <input type="search" id="searchbar" name="searchbar" placeholder="Search this book ..." aria-controls="searchresults-outer" aria-describedby="searchresults-header">
  128. </form>
  129. <div id="searchresults-outer" class="searchresults-outer hidden">
  130. <div id="searchresults-header" class="searchresults-header"></div>
  131. <ul id="searchresults">
  132. </ul>
  133. </div>
  134. </div>
  135. <!-- Apply ARIA attributes after the sidebar and the sidebar toggle button are added to the DOM -->
  136. <script type="text/javascript">
  137. document.getElementById('sidebar-toggle').setAttribute('aria-expanded', sidebar === 'visible');
  138. document.getElementById('sidebar').setAttribute('aria-hidden', sidebar !== 'visible');
  139. Array.from(document.querySelectorAll('#sidebar a')).forEach(function(link) {
  140. link.setAttribute('tabIndex', sidebar === 'visible' ? 0 : -1);
  141. });
  142. </script>
  143. <div id="content" class="content">
  144. <main>
  145. <!-- Page table of contents -->
  146. <div class="sidetoc">
  147. <nav class="pagetoc"></nav>
  148. </div>
  149. <h1 id="contributing"><a class="header" href="#contributing">Contributing</a></h1>
  150. <p>This document aims to get you started with contributing to Synapse!</p>
  151. <h1 id="1-who-can-contribute-to-synapse"><a class="header" href="#1-who-can-contribute-to-synapse">1. Who can contribute to Synapse?</a></h1>
  152. <p>Everyone is welcome to contribute code to <a href="https://github.com/matrix-org">matrix.org
  153. projects</a>, provided that they are willing to
  154. license their contributions under the same license as the project itself. We
  155. follow a simple 'inbound=outbound' model for contributions: the act of
  156. submitting an 'inbound' contribution means that the contributor agrees to
  157. license the code under the same terms as the project's overall 'outbound'
  158. license - in our case, this is almost always Apache Software License v2 (see
  159. <a href="https://github.com/matrix-org/synapse/blob/develop/LICENSE">LICENSE</a>).</p>
  160. <h1 id="2-what-do-i-need"><a class="header" href="#2-what-do-i-need">2. What do I need?</a></h1>
  161. <p>If you are running Windows, the Windows Subsystem for Linux (WSL) is strongly
  162. recommended for development. More information about WSL can be found at
  163. <a href="https://docs.microsoft.com/en-us/windows/wsl/install">https://docs.microsoft.com/en-us/windows/wsl/install</a>. Running Synapse natively
  164. on Windows is not officially supported.</p>
  165. <p>The code of Synapse is written in Python 3. To do pretty much anything, you'll need <a href="https://wiki.python.org/moin/BeginnersGuide/Download">a recent version of Python 3</a>.</p>
  166. <p>The source code of Synapse is hosted on GitHub. You will also need <a href="https://github.com/git-guides/install-git">a recent version of git</a>.</p>
  167. <p>For some tests, you will need <a href="https://docs.docker.com/get-docker/">a recent version of Docker</a>.</p>
  168. <h1 id="3-get-the-source"><a class="header" href="#3-get-the-source">3. Get the source.</a></h1>
  169. <p>The preferred and easiest way to contribute changes is to fork the relevant
  170. project on GitHub, and then <a href="https://help.github.com/articles/using-pull-requests/">create a pull request</a> to ask us to pull your
  171. changes into our repo.</p>
  172. <p>Please base your changes on the <code>develop</code> branch.</p>
  173. <pre><code class="language-sh">git clone git@github.com:YOUR_GITHUB_USER_NAME/synapse.git
  174. git checkout develop
  175. </code></pre>
  176. <p>If you need help getting started with git, this is beyond the scope of the document, but you
  177. can find many good git tutorials on the web.</p>
  178. <h1 id="4-install-the-dependencies"><a class="header" href="#4-install-the-dependencies">4. Install the dependencies</a></h1>
  179. <p>Once you have installed Python 3 and added the source, please open a terminal and
  180. setup a <em>virtualenv</em>, as follows:</p>
  181. <pre><code class="language-sh">cd path/where/you/have/cloned/the/repository
  182. python3 -m venv ./env
  183. source ./env/bin/activate
  184. pip install -e &quot;.[all,dev]&quot;
  185. pip install tox
  186. </code></pre>
  187. <p>This will install the developer dependencies for the project.</p>
  188. <h1 id="5-get-in-touch"><a class="header" href="#5-get-in-touch">5. Get in touch.</a></h1>
  189. <p>Join our developer community on Matrix: <a href="https://matrix.to/#/#synapse-dev:matrix.org">#synapse-dev:matrix.org</a>!</p>
  190. <h1 id="6-pick-an-issue"><a class="header" href="#6-pick-an-issue">6. Pick an issue.</a></h1>
  191. <p>Fix your favorite problem or perhaps find a <a href="https://github.com/matrix-org/synapse/issues?q=is%3Aopen+is%3Aissue+label%3A%22Good+First+Issue%22">Good First Issue</a>
  192. to work on.</p>
  193. <h1 id="7-turn-coffee-into-code-and-documentation"><a class="header" href="#7-turn-coffee-into-code-and-documentation">7. Turn coffee into code and documentation!</a></h1>
  194. <p>There is a growing amount of documentation located in the
  195. <a href="https://github.com/matrix-org/synapse/tree/develop/docs"><code>docs</code></a>
  196. directory, with a rendered version <a href="https://matrix-org.github.io/synapse">available online</a>.
  197. This documentation is intended primarily for sysadmins running their
  198. own Synapse instance, as well as developers interacting externally with
  199. Synapse.
  200. <a href="https://github.com/matrix-org/synapse/tree/develop/docs/development"><code>docs/development</code></a>
  201. exists primarily to house documentation for
  202. Synapse developers.
  203. <a href="https://github.com/matrix-org/synapse/tree/develop/docs/admin_api"><code>docs/admin_api</code></a> houses documentation
  204. regarding Synapse's Admin API, which is used mostly by sysadmins and external
  205. service developers.</p>
  206. <p>Synapse's code style is documented <a href="../code_style.html">here</a>. Please follow
  207. it, including the conventions for the <a href="../code_style.html#configuration-file-format">sample configuration
  208. file</a>.</p>
  209. <p>We welcome improvements and additions to our documentation itself! When
  210. writing new pages, please
  211. <a href="https://github.com/matrix-org/synapse/tree/develop/docs#adding-to-the-documentation">build <code>docs</code> to a book</a>
  212. to check that your contributions render correctly. The docs are written in
  213. <a href="https://guides.github.com/features/mastering-markdown/">GitHub-Flavoured Markdown</a>.</p>
  214. <p>Some documentation also exists in <a href="https://github.com/matrix-org/synapse/wiki">Synapse's GitHub
  215. Wiki</a>, although this is primarily
  216. contributed to by community authors.</p>
  217. <h1 id="8-test-test-test"><a class="header" href="#8-test-test-test">8. Test, test, test!</a></h1>
  218. <p><a name="test-test-test"></a></p>
  219. <p>While you're developing and before submitting a patch, you'll
  220. want to test your code.</p>
  221. <h2 id="run-the-linters"><a class="header" href="#run-the-linters">Run the linters.</a></h2>
  222. <p>The linters look at your code and do two things:</p>
  223. <ul>
  224. <li>ensure that your code follows the coding style adopted by the project;</li>
  225. <li>catch a number of errors in your code.</li>
  226. </ul>
  227. <p>They're pretty fast, don't hesitate!</p>
  228. <pre><code class="language-sh">source ./env/bin/activate
  229. ./scripts-dev/lint.sh
  230. </code></pre>
  231. <p>Note that this script <em>will modify your files</em> to fix styling errors.
  232. Make sure that you have saved all your files.</p>
  233. <p>If you wish to restrict the linters to only the files changed since the last commit
  234. (much faster!), you can instead run:</p>
  235. <pre><code class="language-sh">source ./env/bin/activate
  236. ./scripts-dev/lint.sh -d
  237. </code></pre>
  238. <p>Or if you know exactly which files you wish to lint, you can instead run:</p>
  239. <pre><code class="language-sh">source ./env/bin/activate
  240. ./scripts-dev/lint.sh path/to/file1.py path/to/file2.py path/to/folder
  241. </code></pre>
  242. <h2 id="run-the-unit-tests-twisted-trial"><a class="header" href="#run-the-unit-tests-twisted-trial">Run the unit tests (Twisted trial).</a></h2>
  243. <p>The unit tests run parts of Synapse, including your changes, to see if anything
  244. was broken. They are slower than the linters but will typically catch more errors.</p>
  245. <pre><code class="language-sh">source ./env/bin/activate
  246. trial tests
  247. </code></pre>
  248. <p>If you wish to only run <em>some</em> unit tests, you may specify
  249. another module instead of <code>tests</code> - or a test class or a method:</p>
  250. <pre><code class="language-sh">source ./env/bin/activate
  251. trial tests.rest.admin.test_room tests.handlers.test_admin.ExfiltrateData.test_invite
  252. </code></pre>
  253. <p>If your tests fail, you may wish to look at the logs (the default log level is <code>ERROR</code>):</p>
  254. <pre><code class="language-sh">less _trial_temp/test.log
  255. </code></pre>
  256. <p>To increase the log level for the tests, set <code>SYNAPSE_TEST_LOG_LEVEL</code>:</p>
  257. <pre><code class="language-sh">SYNAPSE_TEST_LOG_LEVEL=DEBUG trial tests
  258. </code></pre>
  259. <h3 id="running-tests-under-postgresql"><a class="header" href="#running-tests-under-postgresql">Running tests under PostgreSQL</a></h3>
  260. <p>Invoking <code>trial</code> as above will use an in-memory SQLite database. This is great for
  261. quick development and testing. However, we recommend using a PostgreSQL database
  262. in production (and indeed, we have some code paths specific to each database).
  263. This means that we need to run our unit tests against PostgreSQL too. Our CI does
  264. this automatically for pull requests and release candidates, but it's sometimes
  265. useful to reproduce this locally.</p>
  266. <p>To do so, <a href="../postgres.html">configure Postgres</a> and run <code>trial</code> with the
  267. following environment variables matching your configuration:</p>
  268. <ul>
  269. <li><code>SYNAPSE_POSTGRES</code> to anything nonempty</li>
  270. <li><code>SYNAPSE_POSTGRES_HOST</code></li>
  271. <li><code>SYNAPSE_POSTGRES_USER</code></li>
  272. <li><code>SYNAPSE_POSTGRES_PASSWORD</code></li>
  273. </ul>
  274. <p>For example:</p>
  275. <pre><code class="language-shell">export SYNAPSE_POSTGRES=1
  276. export SYNAPSE_POSTGRES_HOST=localhost
  277. export SYNAPSE_POSTGRES_USER=postgres
  278. export SYNAPSE_POSTGRES_PASSWORD=mydevenvpassword
  279. trial
  280. </code></pre>
  281. <h4 id="prebuilt-container"><a class="header" href="#prebuilt-container">Prebuilt container</a></h4>
  282. <p>Since configuring PostgreSQL can be fiddly, we can make use of a pre-made
  283. Docker container to set up PostgreSQL and run our tests for us. To do so, run</p>
  284. <pre><code class="language-shell">scripts-dev/test_postgresql.sh
  285. </code></pre>
  286. <p>Any extra arguments to the script will be passed to <code>tox</code> and then to <code>trial</code>,
  287. so we can run a specific test in this container with e.g.</p>
  288. <pre><code class="language-shell">scripts-dev/test_postgresql.sh tests.replication.test_sharded_event_persister.EventPersisterShardTestCase
  289. </code></pre>
  290. <p>The container creates a folder in your Synapse checkout called
  291. <code>.tox-pg-container</code> and uses this as a tox environment. The output of any
  292. <code>trial</code> runs goes into <code>_trial_temp</code> in your synapse source directory — the same
  293. as running <code>trial</code> directly on your host machine.</p>
  294. <h2 id="run-the-integration-tests-sytest"><a class="header" href="#run-the-integration-tests-sytest">Run the integration tests (<a href="https://github.com/matrix-org/sytest">Sytest</a>).</a></h2>
  295. <p>The integration tests are a more comprehensive suite of tests. They
  296. run a full version of Synapse, including your changes, to check if
  297. anything was broken. They are slower than the unit tests but will
  298. typically catch more errors.</p>
  299. <p>The following command will let you run the integration test with the most common
  300. configuration:</p>
  301. <pre><code class="language-sh">$ docker run --rm -it -v /path/where/you/have/cloned/the/repository\:/src:ro -v /path/to/where/you/want/logs\:/logs matrixdotorg/sytest-synapse:buster
  302. </code></pre>
  303. <p>This configuration should generally cover your needs. For more details about other configurations, see <a href="https://github.com/matrix-org/sytest/blob/develop/docker/README.md">documentation in the SyTest repo</a>.</p>
  304. <h2 id="run-the-integration-tests-complement"><a class="header" href="#run-the-integration-tests-complement">Run the integration tests (<a href="https://github.com/matrix-org/complement">Complement</a>).</a></h2>
  305. <p><a href="https://github.com/matrix-org/complement">Complement</a> is a suite of black box tests that can be run on any homeserver implementation. It can also be thought of as end-to-end (e2e) tests.</p>
  306. <p>It's often nice to develop on Synapse and write Complement tests at the same time.
  307. Here is how to run your local Synapse checkout against your local Complement checkout.</p>
  308. <p>(checkout <a href="https://github.com/matrix-org/complement"><code>complement</code></a> alongside your <code>synapse</code> checkout)</p>
  309. <pre><code class="language-sh">COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh
  310. </code></pre>
  311. <p>To run a specific test file, you can pass the test name at the end of the command. The name passed comes from the naming structure in your Complement tests. If you're unsure of the name, you can do a full run and copy it from the test output:</p>
  312. <pre><code class="language-sh">COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh TestBackfillingHistory
  313. </code></pre>
  314. <p>To run a specific test, you can specify the whole name structure:</p>
  315. <pre><code class="language-sh">COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh TestBackfillingHistory/parallel/Backfilled_historical_events_resolve_with_proper_state_in_correct_order
  316. </code></pre>
  317. <h3 id="access-database-for-homeserver-after-complement-test-runs"><a class="header" href="#access-database-for-homeserver-after-complement-test-runs">Access database for homeserver after Complement test runs.</a></h3>
  318. <p>If you're curious what the database looks like after you run some tests, here are some steps to get you going in Synapse:</p>
  319. <ol>
  320. <li>In your Complement test comment out <code>defer deployment.Destroy(t)</code> and replace with <code>defer time.Sleep(2 * time.Hour)</code> to keep the homeserver running after the tests complete</li>
  321. <li>Start the Complement tests</li>
  322. <li>Find the name of the container, <code>docker ps -f name=complement_</code> (this will filter for just the Compelement related Docker containers)</li>
  323. <li>Access the container replacing the name with what you found in the previous step: <code>docker exec -it complement_1_hs_with_application_service.hs1_2 /bin/bash</code></li>
  324. <li>Install sqlite (database driver), <code>apt-get update &amp;&amp; apt-get install -y sqlite3</code></li>
  325. <li>Then run <code>sqlite3</code> and open the database <code>.open /conf/homeserver.db</code> (this db path comes from the Synapse homeserver.yaml)</li>
  326. </ol>
  327. <h1 id="9-submit-your-patch"><a class="header" href="#9-submit-your-patch">9. Submit your patch.</a></h1>
  328. <p>Once you're happy with your patch, it's time to prepare a Pull Request.</p>
  329. <p>To prepare a Pull Request, please:</p>
  330. <ol>
  331. <li>verify that <a href="#test-test-test">all the tests pass</a>, including the coding style;</li>
  332. <li><a href="#sign-off">sign off</a> your contribution;</li>
  333. <li><code>git push</code> your commit to your fork of Synapse;</li>
  334. <li>on GitHub, <a href="https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request">create the Pull Request</a>;</li>
  335. <li>add a <a href="#changelog">changelog entry</a> and push it to your Pull Request;</li>
  336. <li>for most contributors, that's all - however, if you are a member of the organization <code>matrix-org</code>, on GitHub, please request a review from <code>matrix.org / Synapse Core</code>.</li>
  337. <li>if you need to update your PR, please avoid rebasing and just add new commits to your branch.</li>
  338. </ol>
  339. <h2 id="changelog"><a class="header" href="#changelog">Changelog</a></h2>
  340. <p>All changes, even minor ones, need a corresponding changelog / newsfragment
  341. entry. These are managed by <a href="https://github.com/hawkowl/towncrier">Towncrier</a>.</p>
  342. <p>To create a changelog entry, make a new file in the <code>changelog.d</code> directory named
  343. in the format of <code>PRnumber.type</code>. The type can be one of the following:</p>
  344. <ul>
  345. <li><code>feature</code></li>
  346. <li><code>bugfix</code></li>
  347. <li><code>docker</code> (for updates to the Docker image)</li>
  348. <li><code>doc</code> (for updates to the documentation)</li>
  349. <li><code>removal</code> (also used for deprecations)</li>
  350. <li><code>misc</code> (for internal-only changes)</li>
  351. </ul>
  352. <p>This file will become part of our <a href="https://github.com/matrix-org/synapse/blob/master/CHANGES.md">changelog</a> at the next
  353. release, so the content of the file should be a short description of your
  354. change in the same style as the rest of the changelog. The file can contain Markdown
  355. formatting, and should end with a full stop (.) or an exclamation mark (!) for
  356. consistency.</p>
  357. <p>Adding credits to the changelog is encouraged, we value your
  358. contributions and would like to have you shouted out in the release notes!</p>
  359. <p>For example, a fix in PR #1234 would have its changelog entry in
  360. <code>changelog.d/1234.bugfix</code>, and contain content like:</p>
  361. <blockquote>
  362. <p>The security levels of Florbs are now validated when received
  363. via the <code>/federation/florb</code> endpoint. Contributed by Jane Matrix.</p>
  364. </blockquote>
  365. <p>If there are multiple pull requests involved in a single bugfix/feature/etc,
  366. then the content for each <code>changelog.d</code> file should be the same. Towncrier will
  367. merge the matching files together into a single changelog entry when we come to
  368. release.</p>
  369. <h3 id="how-do-i-know-what-to-call-the-changelog-file-before-i-create-the-pr"><a class="header" href="#how-do-i-know-what-to-call-the-changelog-file-before-i-create-the-pr">How do I know what to call the changelog file before I create the PR?</a></h3>
  370. <p>Obviously, you don't know if you should call your newsfile
  371. <code>1234.bugfix</code> or <code>5678.bugfix</code> until you create the PR, which leads to a
  372. chicken-and-egg problem.</p>
  373. <p>There are two options for solving this:</p>
  374. <ol>
  375. <li>
  376. <p>Open the PR without a changelog file, see what number you got, and <em>then</em>
  377. add the changelog file to your branch (see <a href="#updating-your-pull-request">Updating your pull
  378. request</a>), or:</p>
  379. </li>
  380. <li>
  381. <p>Look at the <a href="https://github.com/matrix-org/synapse/issues?q=">list of all
  382. issues/PRs</a>, add one to the
  383. highest number you see, and quickly open the PR before somebody else claims
  384. your number.</p>
  385. <p><a href="https://github.com/richvdh/scripts/blob/master/next_github_number.sh">This
  386. script</a>
  387. might be helpful if you find yourself doing this a lot.</p>
  388. </li>
  389. </ol>
  390. <p>Sorry, we know it's a bit fiddly, but it's <em>really</em> helpful for us when we come
  391. to put together a release!</p>
  392. <h3 id="debian-changelog"><a class="header" href="#debian-changelog">Debian changelog</a></h3>
  393. <p>Changes which affect the debian packaging files (in <code>debian</code>) are an
  394. exception to the rule that all changes require a <code>changelog.d</code> file.</p>
  395. <p>In this case, you will need to add an entry to the debian changelog for the
  396. next release. For this, run the following command:</p>
  397. <pre><code>dch
  398. </code></pre>
  399. <p>This will make up a new version number (if there isn't already an unreleased
  400. version in flight), and open an editor where you can add a new changelog entry.
  401. (Our release process will ensure that the version number and maintainer name is
  402. corrected for the release.)</p>
  403. <p>If your change affects both the debian packaging <em>and</em> files outside the debian
  404. directory, you will need both a regular newsfragment <em>and</em> an entry in the
  405. debian changelog. (Though typically such changes should be submitted as two
  406. separate pull requests.)</p>
  407. <h2 id="sign-off"><a class="header" href="#sign-off">Sign off</a></h2>
  408. <p>In order to have a concrete record that your contribution is intentional
  409. and you agree to license it under the same terms as the project's license, we've adopted the
  410. same lightweight approach that the Linux Kernel
  411. <a href="https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin%3E">submitting patches process</a>,
  412. <a href="https://github.com/docker/docker/blob/master/CONTRIBUTING.md">Docker</a>, and many other
  413. projects use: the DCO (Developer Certificate of Origin:
  414. http://developercertificate.org/). This is a simple declaration that you wrote
  415. the contribution or otherwise have the right to contribute it to Matrix:</p>
  416. <pre><code>Developer Certificate of Origin
  417. Version 1.1
  418. Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
  419. 660 York Street, Suite 102,
  420. San Francisco, CA 94110 USA
  421. Everyone is permitted to copy and distribute verbatim copies of this
  422. license document, but changing it is not allowed.
  423. Developer's Certificate of Origin 1.1
  424. By making a contribution to this project, I certify that:
  425. (a) The contribution was created in whole or in part by me and I
  426. have the right to submit it under the open source license
  427. indicated in the file; or
  428. (b) The contribution is based upon previous work that, to the best
  429. of my knowledge, is covered under an appropriate open source
  430. license and I have the right under that license to submit that
  431. work with modifications, whether created in whole or in part
  432. by me, under the same open source license (unless I am
  433. permitted to submit under a different license), as indicated
  434. in the file; or
  435. (c) The contribution was provided directly to me by some other
  436. person who certified (a), (b) or (c) and I have not modified
  437. it.
  438. (d) I understand and agree that this project and the contribution
  439. are public and that a record of the contribution (including all
  440. personal information I submit with it, including my sign-off) is
  441. maintained indefinitely and may be redistributed consistent with
  442. this project or the open source license(s) involved.
  443. </code></pre>
  444. <p>If you agree to this for your contribution, then all that's needed is to
  445. include the line in your commit or pull request comment:</p>
  446. <pre><code>Signed-off-by: Your Name &lt;your@email.example.org&gt;
  447. </code></pre>
  448. <p>We accept contributions under a legally identifiable name, such as
  449. your name on government documentation or common-law names (names
  450. claimed by legitimate usage or repute). Unfortunately, we cannot
  451. accept anonymous contributions at this time.</p>
  452. <p>Git allows you to add this signoff automatically when using the <code>-s</code>
  453. flag to <code>git commit</code>, which uses the name and email set in your
  454. <code>user.name</code> and <code>user.email</code> git configs.</p>
  455. <h1 id="10-turn-feedback-into-better-code"><a class="header" href="#10-turn-feedback-into-better-code">10. Turn feedback into better code.</a></h1>
  456. <p>Once the Pull Request is opened, you will see a few things:</p>
  457. <ol>
  458. <li>our automated CI (Continuous Integration) pipeline will run (again) the linters, the unit tests, the integration tests and more;</li>
  459. <li>one or more of the developers will take a look at your Pull Request and offer feedback.</li>
  460. </ol>
  461. <p>From this point, you should:</p>
  462. <ol>
  463. <li>Look at the results of the CI pipeline.
  464. <ul>
  465. <li>If there is any error, fix the error.</li>
  466. </ul>
  467. </li>
  468. <li>If a developer has requested changes, make these changes and let us know if it is ready for a developer to review again.</li>
  469. <li>Create a new commit with the changes.
  470. <ul>
  471. <li>Please do NOT overwrite the history. New commits make the reviewer's life easier.</li>
  472. <li>Push this commits to your Pull Request.</li>
  473. </ul>
  474. </li>
  475. <li>Back to 1.</li>
  476. </ol>
  477. <p>Once both the CI and the developers are happy, the patch will be merged into Synapse and released shortly!</p>
  478. <h1 id="11-find-a-new-issue"><a class="header" href="#11-find-a-new-issue">11. Find a new issue.</a></h1>
  479. <p>By now, you know the drill!</p>
  480. <h1 id="notes-for-maintainers-on-merging-prs-etc"><a class="header" href="#notes-for-maintainers-on-merging-prs-etc">Notes for maintainers on merging PRs etc</a></h1>
  481. <p>There are some notes for those with commit access to the project on how we
  482. manage git <a href="git.html">here</a>.</p>
  483. <h1 id="conclusion"><a class="header" href="#conclusion">Conclusion</a></h1>
  484. <p>That's it! Matrix is a very open and collaborative project as you might expect
  485. given our obsession with open communication. If we're going to successfully
  486. matrix together all the fragmented communication technologies out there we are
  487. reliant on contributions and collaboration from the community to do so. So
  488. please get involved - and we hope you have as much fun hacking on Matrix as we
  489. do!</p>
  490. </main>
  491. <nav class="nav-wrapper" aria-label="Page navigation">
  492. <!-- Mobile navigation buttons -->
  493. <a rel="prev" href="../usage/administration/request_log.html" class="mobile-nav-chapters previous" title="Previous chapter" aria-label="Previous chapter" aria-keyshortcuts="Left">
  494. <i class="fa fa-angle-left"></i>
  495. </a>
  496. <a rel="next" href="../code_style.html" class="mobile-nav-chapters next" title="Next chapter" aria-label="Next chapter" aria-keyshortcuts="Right">
  497. <i class="fa fa-angle-right"></i>
  498. </a>
  499. <div style="clear: both"></div>
  500. </nav>
  501. </div>
  502. </div>
  503. <nav class="nav-wide-wrapper" aria-label="Page navigation">
  504. <a rel="prev" href="../usage/administration/request_log.html" class="nav-chapters previous" title="Previous chapter" aria-label="Previous chapter" aria-keyshortcuts="Left">
  505. <i class="fa fa-angle-left"></i>
  506. </a>
  507. <a rel="next" href="../code_style.html" class="nav-chapters next" title="Next chapter" aria-label="Next chapter" aria-keyshortcuts="Right">
  508. <i class="fa fa-angle-right"></i>
  509. </a>
  510. </nav>
  511. </div>
  512. <script type="text/javascript">
  513. window.playground_copyable = true;
  514. </script>
  515. <script src="../elasticlunr.min.js" type="text/javascript" charset="utf-8"></script>
  516. <script src="../mark.min.js" type="text/javascript" charset="utf-8"></script>
  517. <script src="../searcher.js" type="text/javascript" charset="utf-8"></script>
  518. <script src="../clipboard.min.js" type="text/javascript" charset="utf-8"></script>
  519. <script src="../highlight.js" type="text/javascript" charset="utf-8"></script>
  520. <script src="../book.js" type="text/javascript" charset="utf-8"></script>
  521. <!-- Custom JS scripts -->
  522. <script type="text/javascript" src="../docs/website_files/table-of-contents.js"></script>
  523. <script type="text/javascript" src="../docs/website_files/version-picker.js"></script>
  524. <script type="text/javascript" src="../docs/website_files/version.js"></script>
  525. </body>
  526. </html>