test_filtering.py 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590
  1. # -*- coding: utf-8 -*-
  2. # Copyright 2015, 2016 OpenMarket Ltd
  3. #
  4. # Licensed under the Apache License, Version 2.0 (the "License");
  5. # you may not use this file except in compliance with the License.
  6. # You may obtain a copy of the License at
  7. #
  8. # http://www.apache.org/licenses/LICENSE-2.0
  9. #
  10. # Unless required by applicable law or agreed to in writing, software
  11. # distributed under the License is distributed on an "AS IS" BASIS,
  12. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13. # See the License for the specific language governing permissions and
  14. # limitations under the License.
  15. from tests import unittest
  16. from twisted.internet import defer
  17. from mock import Mock
  18. from tests.utils import (
  19. MockHttpResource, DeferredMockCallable, setup_test_homeserver
  20. )
  21. from synapse.api.filtering import Filter
  22. from synapse.events import FrozenEvent
  23. from synapse.api.errors import SynapseError
  24. import jsonschema
  25. user_localpart = "test_user"
  26. def MockEvent(**kwargs):
  27. if "event_id" not in kwargs:
  28. kwargs["event_id"] = "fake_event_id"
  29. if "type" not in kwargs:
  30. kwargs["type"] = "fake_type"
  31. return FrozenEvent(kwargs)
  32. class FilteringTestCase(unittest.TestCase):
  33. @defer.inlineCallbacks
  34. def setUp(self):
  35. self.mock_federation_resource = MockHttpResource()
  36. self.mock_http_client = Mock(spec=[])
  37. self.mock_http_client.put_json = DeferredMockCallable()
  38. hs = yield setup_test_homeserver(
  39. handlers=None,
  40. http_client=self.mock_http_client,
  41. keyring=Mock(),
  42. )
  43. self.filtering = hs.get_filtering()
  44. self.datastore = hs.get_datastore()
  45. def test_errors_on_invalid_filters(self):
  46. invalid_filters = [
  47. {"boom": {}},
  48. {"account_data": "Hello World"},
  49. {"event_fields": ["\\foo"]},
  50. {"room": {"timeline": {"limit": 0}, "state": {"not_bars": ["*"]}}},
  51. {"event_format": "other"},
  52. {"room": {"not_rooms": ["#foo:pik-test"]}},
  53. {"presence": {"senders": ["@bar;pik.test.com"]}}
  54. ]
  55. for filter in invalid_filters:
  56. with self.assertRaises(SynapseError) as check_filter_error:
  57. self.filtering.check_valid_filter(filter)
  58. self.assertIsInstance(check_filter_error.exception, SynapseError)
  59. def test_valid_filters(self):
  60. valid_filters = [
  61. {
  62. "room": {
  63. "timeline": {"limit": 20},
  64. "state": {"not_types": ["m.room.member"]},
  65. "ephemeral": {"limit": 0, "not_types": ["*"]},
  66. "include_leave": False,
  67. "rooms": ["!dee:pik-test"],
  68. "not_rooms": ["!gee:pik-test"],
  69. "account_data": {"limit": 0, "types": ["*"]}
  70. }
  71. },
  72. {
  73. "room": {
  74. "state": {
  75. "types": ["m.room.*"],
  76. "not_rooms": ["!726s6s6q:example.com"]
  77. },
  78. "timeline": {
  79. "limit": 10,
  80. "types": ["m.room.message"],
  81. "not_rooms": ["!726s6s6q:example.com"],
  82. "not_senders": ["@spam:example.com"]
  83. },
  84. "ephemeral": {
  85. "types": ["m.receipt", "m.typing"],
  86. "not_rooms": ["!726s6s6q:example.com"],
  87. "not_senders": ["@spam:example.com"]
  88. }
  89. },
  90. "presence": {
  91. "types": ["m.presence"],
  92. "not_senders": ["@alice:example.com"]
  93. },
  94. "event_format": "client",
  95. "event_fields": ["type", "content", "sender"]
  96. }
  97. ]
  98. for filter in valid_filters:
  99. try:
  100. self.filtering.check_valid_filter(filter)
  101. except jsonschema.ValidationError as e:
  102. self.fail(e)
  103. def test_limits_are_applied(self):
  104. # TODO
  105. pass
  106. def test_definition_types_works_with_literals(self):
  107. definition = {
  108. "types": ["m.room.message", "org.matrix.foo.bar"]
  109. }
  110. event = MockEvent(
  111. sender="@foo:bar",
  112. type="m.room.message",
  113. room_id="!foo:bar"
  114. )
  115. self.assertTrue(
  116. Filter(definition).check(event)
  117. )
  118. def test_definition_types_works_with_wildcards(self):
  119. definition = {
  120. "types": ["m.*", "org.matrix.foo.bar"]
  121. }
  122. event = MockEvent(
  123. sender="@foo:bar",
  124. type="m.room.message",
  125. room_id="!foo:bar"
  126. )
  127. self.assertTrue(
  128. Filter(definition).check(event)
  129. )
  130. def test_definition_types_works_with_unknowns(self):
  131. definition = {
  132. "types": ["m.room.message", "org.matrix.foo.bar"]
  133. }
  134. event = MockEvent(
  135. sender="@foo:bar",
  136. type="now.for.something.completely.different",
  137. room_id="!foo:bar"
  138. )
  139. self.assertFalse(
  140. Filter(definition).check(event)
  141. )
  142. def test_definition_not_types_works_with_literals(self):
  143. definition = {
  144. "not_types": ["m.room.message", "org.matrix.foo.bar"]
  145. }
  146. event = MockEvent(
  147. sender="@foo:bar",
  148. type="m.room.message",
  149. room_id="!foo:bar"
  150. )
  151. self.assertFalse(
  152. Filter(definition).check(event)
  153. )
  154. def test_definition_not_types_works_with_wildcards(self):
  155. definition = {
  156. "not_types": ["m.room.message", "org.matrix.*"]
  157. }
  158. event = MockEvent(
  159. sender="@foo:bar",
  160. type="org.matrix.custom.event",
  161. room_id="!foo:bar"
  162. )
  163. self.assertFalse(
  164. Filter(definition).check(event)
  165. )
  166. def test_definition_not_types_works_with_unknowns(self):
  167. definition = {
  168. "not_types": ["m.*", "org.*"]
  169. }
  170. event = MockEvent(
  171. sender="@foo:bar",
  172. type="com.nom.nom.nom",
  173. room_id="!foo:bar"
  174. )
  175. self.assertTrue(
  176. Filter(definition).check(event)
  177. )
  178. def test_definition_not_types_takes_priority_over_types(self):
  179. definition = {
  180. "not_types": ["m.*", "org.*"],
  181. "types": ["m.room.message", "m.room.topic"]
  182. }
  183. event = MockEvent(
  184. sender="@foo:bar",
  185. type="m.room.topic",
  186. room_id="!foo:bar"
  187. )
  188. self.assertFalse(
  189. Filter(definition).check(event)
  190. )
  191. def test_definition_senders_works_with_literals(self):
  192. definition = {
  193. "senders": ["@flibble:wibble"]
  194. }
  195. event = MockEvent(
  196. sender="@flibble:wibble",
  197. type="com.nom.nom.nom",
  198. room_id="!foo:bar"
  199. )
  200. self.assertTrue(
  201. Filter(definition).check(event)
  202. )
  203. def test_definition_senders_works_with_unknowns(self):
  204. definition = {
  205. "senders": ["@flibble:wibble"]
  206. }
  207. event = MockEvent(
  208. sender="@challenger:appears",
  209. type="com.nom.nom.nom",
  210. room_id="!foo:bar"
  211. )
  212. self.assertFalse(
  213. Filter(definition).check(event)
  214. )
  215. def test_definition_not_senders_works_with_literals(self):
  216. definition = {
  217. "not_senders": ["@flibble:wibble"]
  218. }
  219. event = MockEvent(
  220. sender="@flibble:wibble",
  221. type="com.nom.nom.nom",
  222. room_id="!foo:bar"
  223. )
  224. self.assertFalse(
  225. Filter(definition).check(event)
  226. )
  227. def test_definition_not_senders_works_with_unknowns(self):
  228. definition = {
  229. "not_senders": ["@flibble:wibble"]
  230. }
  231. event = MockEvent(
  232. sender="@challenger:appears",
  233. type="com.nom.nom.nom",
  234. room_id="!foo:bar"
  235. )
  236. self.assertTrue(
  237. Filter(definition).check(event)
  238. )
  239. def test_definition_not_senders_takes_priority_over_senders(self):
  240. definition = {
  241. "not_senders": ["@misspiggy:muppets"],
  242. "senders": ["@kermit:muppets", "@misspiggy:muppets"]
  243. }
  244. event = MockEvent(
  245. sender="@misspiggy:muppets",
  246. type="m.room.topic",
  247. room_id="!foo:bar"
  248. )
  249. self.assertFalse(
  250. Filter(definition).check(event)
  251. )
  252. def test_definition_rooms_works_with_literals(self):
  253. definition = {
  254. "rooms": ["!secretbase:unknown"]
  255. }
  256. event = MockEvent(
  257. sender="@foo:bar",
  258. type="m.room.message",
  259. room_id="!secretbase:unknown"
  260. )
  261. self.assertTrue(
  262. Filter(definition).check(event)
  263. )
  264. def test_definition_rooms_works_with_unknowns(self):
  265. definition = {
  266. "rooms": ["!secretbase:unknown"]
  267. }
  268. event = MockEvent(
  269. sender="@foo:bar",
  270. type="m.room.message",
  271. room_id="!anothersecretbase:unknown"
  272. )
  273. self.assertFalse(
  274. Filter(definition).check(event)
  275. )
  276. def test_definition_not_rooms_works_with_literals(self):
  277. definition = {
  278. "not_rooms": ["!anothersecretbase:unknown"]
  279. }
  280. event = MockEvent(
  281. sender="@foo:bar",
  282. type="m.room.message",
  283. room_id="!anothersecretbase:unknown"
  284. )
  285. self.assertFalse(
  286. Filter(definition).check(event)
  287. )
  288. def test_definition_not_rooms_works_with_unknowns(self):
  289. definition = {
  290. "not_rooms": ["!secretbase:unknown"]
  291. }
  292. event = MockEvent(
  293. sender="@foo:bar",
  294. type="m.room.message",
  295. room_id="!anothersecretbase:unknown"
  296. )
  297. self.assertTrue(
  298. Filter(definition).check(event)
  299. )
  300. def test_definition_not_rooms_takes_priority_over_rooms(self):
  301. definition = {
  302. "not_rooms": ["!secretbase:unknown"],
  303. "rooms": ["!secretbase:unknown"]
  304. }
  305. event = MockEvent(
  306. sender="@foo:bar",
  307. type="m.room.message",
  308. room_id="!secretbase:unknown"
  309. )
  310. self.assertFalse(
  311. Filter(definition).check(event)
  312. )
  313. def test_definition_combined_event(self):
  314. definition = {
  315. "not_senders": ["@misspiggy:muppets"],
  316. "senders": ["@kermit:muppets"],
  317. "rooms": ["!stage:unknown"],
  318. "not_rooms": ["!piggyshouse:muppets"],
  319. "types": ["m.room.message", "muppets.kermit.*"],
  320. "not_types": ["muppets.misspiggy.*"]
  321. }
  322. event = MockEvent(
  323. sender="@kermit:muppets", # yup
  324. type="m.room.message", # yup
  325. room_id="!stage:unknown" # yup
  326. )
  327. self.assertTrue(
  328. Filter(definition).check(event)
  329. )
  330. def test_definition_combined_event_bad_sender(self):
  331. definition = {
  332. "not_senders": ["@misspiggy:muppets"],
  333. "senders": ["@kermit:muppets"],
  334. "rooms": ["!stage:unknown"],
  335. "not_rooms": ["!piggyshouse:muppets"],
  336. "types": ["m.room.message", "muppets.kermit.*"],
  337. "not_types": ["muppets.misspiggy.*"]
  338. }
  339. event = MockEvent(
  340. sender="@misspiggy:muppets", # nope
  341. type="m.room.message", # yup
  342. room_id="!stage:unknown" # yup
  343. )
  344. self.assertFalse(
  345. Filter(definition).check(event)
  346. )
  347. def test_definition_combined_event_bad_room(self):
  348. definition = {
  349. "not_senders": ["@misspiggy:muppets"],
  350. "senders": ["@kermit:muppets"],
  351. "rooms": ["!stage:unknown"],
  352. "not_rooms": ["!piggyshouse:muppets"],
  353. "types": ["m.room.message", "muppets.kermit.*"],
  354. "not_types": ["muppets.misspiggy.*"]
  355. }
  356. event = MockEvent(
  357. sender="@kermit:muppets", # yup
  358. type="m.room.message", # yup
  359. room_id="!piggyshouse:muppets" # nope
  360. )
  361. self.assertFalse(
  362. Filter(definition).check(event)
  363. )
  364. def test_definition_combined_event_bad_type(self):
  365. definition = {
  366. "not_senders": ["@misspiggy:muppets"],
  367. "senders": ["@kermit:muppets"],
  368. "rooms": ["!stage:unknown"],
  369. "not_rooms": ["!piggyshouse:muppets"],
  370. "types": ["m.room.message", "muppets.kermit.*"],
  371. "not_types": ["muppets.misspiggy.*"]
  372. }
  373. event = MockEvent(
  374. sender="@kermit:muppets", # yup
  375. type="muppets.misspiggy.kisses", # nope
  376. room_id="!stage:unknown" # yup
  377. )
  378. self.assertFalse(
  379. Filter(definition).check(event)
  380. )
  381. @defer.inlineCallbacks
  382. def test_filter_presence_match(self):
  383. user_filter_json = {
  384. "presence": {
  385. "types": ["m.*"]
  386. }
  387. }
  388. filter_id = yield self.datastore.add_user_filter(
  389. user_localpart=user_localpart,
  390. user_filter=user_filter_json,
  391. )
  392. event = MockEvent(
  393. sender="@foo:bar",
  394. type="m.profile",
  395. )
  396. events = [event]
  397. user_filter = yield self.filtering.get_user_filter(
  398. user_localpart=user_localpart,
  399. filter_id=filter_id,
  400. )
  401. results = user_filter.filter_presence(events=events)
  402. self.assertEquals(events, results)
  403. @defer.inlineCallbacks
  404. def test_filter_presence_no_match(self):
  405. user_filter_json = {
  406. "presence": {
  407. "types": ["m.*"]
  408. }
  409. }
  410. filter_id = yield self.datastore.add_user_filter(
  411. user_localpart=user_localpart + "2",
  412. user_filter=user_filter_json,
  413. )
  414. event = MockEvent(
  415. event_id="$asdasd:localhost",
  416. sender="@foo:bar",
  417. type="custom.avatar.3d.crazy",
  418. )
  419. events = [event]
  420. user_filter = yield self.filtering.get_user_filter(
  421. user_localpart=user_localpart + "2",
  422. filter_id=filter_id,
  423. )
  424. results = user_filter.filter_presence(events=events)
  425. self.assertEquals([], results)
  426. @defer.inlineCallbacks
  427. def test_filter_room_state_match(self):
  428. user_filter_json = {
  429. "room": {
  430. "state": {
  431. "types": ["m.*"]
  432. }
  433. }
  434. }
  435. filter_id = yield self.datastore.add_user_filter(
  436. user_localpart=user_localpart,
  437. user_filter=user_filter_json,
  438. )
  439. event = MockEvent(
  440. sender="@foo:bar",
  441. type="m.room.topic",
  442. room_id="!foo:bar"
  443. )
  444. events = [event]
  445. user_filter = yield self.filtering.get_user_filter(
  446. user_localpart=user_localpart,
  447. filter_id=filter_id,
  448. )
  449. results = user_filter.filter_room_state(events=events)
  450. self.assertEquals(events, results)
  451. @defer.inlineCallbacks
  452. def test_filter_room_state_no_match(self):
  453. user_filter_json = {
  454. "room": {
  455. "state": {
  456. "types": ["m.*"]
  457. }
  458. }
  459. }
  460. filter_id = yield self.datastore.add_user_filter(
  461. user_localpart=user_localpart,
  462. user_filter=user_filter_json,
  463. )
  464. event = MockEvent(
  465. sender="@foo:bar",
  466. type="org.matrix.custom.event",
  467. room_id="!foo:bar"
  468. )
  469. events = [event]
  470. user_filter = yield self.filtering.get_user_filter(
  471. user_localpart=user_localpart,
  472. filter_id=filter_id,
  473. )
  474. results = user_filter.filter_room_state(events)
  475. self.assertEquals([], results)
  476. def test_filter_rooms(self):
  477. definition = {
  478. "rooms": ["!allowed:example.com", "!excluded:example.com"],
  479. "not_rooms": ["!excluded:example.com"],
  480. }
  481. room_ids = [
  482. "!allowed:example.com", # Allowed because in rooms and not in not_rooms.
  483. "!excluded:example.com", # Disallowed because in not_rooms.
  484. "!not_included:example.com", # Disallowed because not in rooms.
  485. ]
  486. filtered_room_ids = list(Filter(definition).filter_rooms(room_ids))
  487. self.assertEquals(filtered_room_ids, ["!allowed:example.com"])
  488. @defer.inlineCallbacks
  489. def test_add_filter(self):
  490. user_filter_json = {
  491. "room": {
  492. "state": {
  493. "types": ["m.*"]
  494. }
  495. }
  496. }
  497. filter_id = yield self.filtering.add_user_filter(
  498. user_localpart=user_localpart,
  499. user_filter=user_filter_json,
  500. )
  501. self.assertEquals(filter_id, 0)
  502. self.assertEquals(user_filter_json, (
  503. yield self.datastore.get_user_filter(
  504. user_localpart=user_localpart,
  505. filter_id=0,
  506. )
  507. ))
  508. @defer.inlineCallbacks
  509. def test_get_filter(self):
  510. user_filter_json = {
  511. "room": {
  512. "state": {
  513. "types": ["m.*"]
  514. }
  515. }
  516. }
  517. filter_id = yield self.datastore.add_user_filter(
  518. user_localpart=user_localpart,
  519. user_filter=user_filter_json,
  520. )
  521. filter = yield self.filtering.get_user_filter(
  522. user_localpart=user_localpart,
  523. filter_id=filter_id,
  524. )
  525. self.assertEquals(filter.get_filter_json(), user_filter_json)
  526. self.assertRegexpMatches(repr(filter), r"<FilterCollection \{.*\}>")