test_filtering.py 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488
  1. # -*- coding: utf-8 -*-
  2. # Copyright 2015, 2016 OpenMarket Ltd
  3. # Copyright 2017 Vector Creations Ltd
  4. # Copyright 2018-2019 New Vector Ltd
  5. # Copyright 2019 The Matrix.org Foundation C.I.C.
  6. #
  7. # Licensed under the Apache License, Version 2.0 (the "License");
  8. # you may not use this file except in compliance with the License.
  9. # You may obtain a copy of the License at
  10. #
  11. # http://www.apache.org/licenses/LICENSE-2.0
  12. #
  13. # Unless required by applicable law or agreed to in writing, software
  14. # distributed under the License is distributed on an "AS IS" BASIS,
  15. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16. # See the License for the specific language governing permissions and
  17. # limitations under the License.
  18. from mock import Mock
  19. import jsonschema
  20. from twisted.internet import defer
  21. from synapse.api.constants import EventContentFields
  22. from synapse.api.errors import SynapseError
  23. from synapse.api.filtering import Filter
  24. from synapse.events import make_event_from_dict
  25. from tests import unittest
  26. from tests.utils import DeferredMockCallable, MockHttpResource, setup_test_homeserver
  27. user_localpart = "test_user"
  28. def MockEvent(**kwargs):
  29. if "event_id" not in kwargs:
  30. kwargs["event_id"] = "fake_event_id"
  31. if "type" not in kwargs:
  32. kwargs["type"] = "fake_type"
  33. return make_event_from_dict(kwargs)
  34. class FilteringTestCase(unittest.TestCase):
  35. @defer.inlineCallbacks
  36. def setUp(self):
  37. self.mock_federation_resource = MockHttpResource()
  38. self.mock_http_client = Mock(spec=[])
  39. self.mock_http_client.put_json = DeferredMockCallable()
  40. hs = yield setup_test_homeserver(
  41. self.addCleanup,
  42. handlers=None,
  43. http_client=self.mock_http_client,
  44. keyring=Mock(),
  45. )
  46. self.filtering = hs.get_filtering()
  47. self.datastore = hs.get_datastore()
  48. def test_errors_on_invalid_filters(self):
  49. invalid_filters = [
  50. {"boom": {}},
  51. {"account_data": "Hello World"},
  52. {"event_fields": [r"\\foo"]},
  53. {"room": {"timeline": {"limit": 0}, "state": {"not_bars": ["*"]}}},
  54. {"event_format": "other"},
  55. {"room": {"not_rooms": ["#foo:pik-test"]}},
  56. {"presence": {"senders": ["@bar;pik.test.com"]}},
  57. ]
  58. for filter in invalid_filters:
  59. with self.assertRaises(SynapseError) as check_filter_error:
  60. self.filtering.check_valid_filter(filter)
  61. self.assertIsInstance(check_filter_error.exception, SynapseError)
  62. def test_valid_filters(self):
  63. valid_filters = [
  64. {
  65. "room": {
  66. "timeline": {"limit": 20},
  67. "state": {"not_types": ["m.room.member"]},
  68. "ephemeral": {"limit": 0, "not_types": ["*"]},
  69. "include_leave": False,
  70. "rooms": ["!dee:pik-test"],
  71. "not_rooms": ["!gee:pik-test"],
  72. "account_data": {"limit": 0, "types": ["*"]},
  73. }
  74. },
  75. {
  76. "room": {
  77. "state": {
  78. "types": ["m.room.*"],
  79. "not_rooms": ["!726s6s6q:example.com"],
  80. },
  81. "timeline": {
  82. "limit": 10,
  83. "types": ["m.room.message"],
  84. "not_rooms": ["!726s6s6q:example.com"],
  85. "not_senders": ["@spam:example.com"],
  86. "org.matrix.labels": ["#fun"],
  87. "org.matrix.not_labels": ["#work"],
  88. },
  89. "ephemeral": {
  90. "types": ["m.receipt", "m.typing"],
  91. "not_rooms": ["!726s6s6q:example.com"],
  92. "not_senders": ["@spam:example.com"],
  93. },
  94. },
  95. "presence": {
  96. "types": ["m.presence"],
  97. "not_senders": ["@alice:example.com"],
  98. },
  99. "event_format": "client",
  100. "event_fields": ["type", "content", "sender"],
  101. },
  102. # a single backslash should be permitted (though it is debatable whether
  103. # it should be permitted before anything other than `.`, and what that
  104. # actually means)
  105. #
  106. # (note that event_fields is implemented in
  107. # synapse.events.utils.serialize_event, and so whether this actually works
  108. # is tested elsewhere. We just want to check that it is allowed through the
  109. # filter validation)
  110. {"event_fields": [r"foo\.bar"]},
  111. ]
  112. for filter in valid_filters:
  113. try:
  114. self.filtering.check_valid_filter(filter)
  115. except jsonschema.ValidationError as e:
  116. self.fail(e)
  117. def test_limits_are_applied(self):
  118. # TODO
  119. pass
  120. def test_definition_types_works_with_literals(self):
  121. definition = {"types": ["m.room.message", "org.matrix.foo.bar"]}
  122. event = MockEvent(sender="@foo:bar", type="m.room.message", room_id="!foo:bar")
  123. self.assertTrue(Filter(definition).check(event))
  124. def test_definition_types_works_with_wildcards(self):
  125. definition = {"types": ["m.*", "org.matrix.foo.bar"]}
  126. event = MockEvent(sender="@foo:bar", type="m.room.message", room_id="!foo:bar")
  127. self.assertTrue(Filter(definition).check(event))
  128. def test_definition_types_works_with_unknowns(self):
  129. definition = {"types": ["m.room.message", "org.matrix.foo.bar"]}
  130. event = MockEvent(
  131. sender="@foo:bar",
  132. type="now.for.something.completely.different",
  133. room_id="!foo:bar",
  134. )
  135. self.assertFalse(Filter(definition).check(event))
  136. def test_definition_not_types_works_with_literals(self):
  137. definition = {"not_types": ["m.room.message", "org.matrix.foo.bar"]}
  138. event = MockEvent(sender="@foo:bar", type="m.room.message", room_id="!foo:bar")
  139. self.assertFalse(Filter(definition).check(event))
  140. def test_definition_not_types_works_with_wildcards(self):
  141. definition = {"not_types": ["m.room.message", "org.matrix.*"]}
  142. event = MockEvent(
  143. sender="@foo:bar", type="org.matrix.custom.event", room_id="!foo:bar"
  144. )
  145. self.assertFalse(Filter(definition).check(event))
  146. def test_definition_not_types_works_with_unknowns(self):
  147. definition = {"not_types": ["m.*", "org.*"]}
  148. event = MockEvent(sender="@foo:bar", type="com.nom.nom.nom", room_id="!foo:bar")
  149. self.assertTrue(Filter(definition).check(event))
  150. def test_definition_not_types_takes_priority_over_types(self):
  151. definition = {
  152. "not_types": ["m.*", "org.*"],
  153. "types": ["m.room.message", "m.room.topic"],
  154. }
  155. event = MockEvent(sender="@foo:bar", type="m.room.topic", room_id="!foo:bar")
  156. self.assertFalse(Filter(definition).check(event))
  157. def test_definition_senders_works_with_literals(self):
  158. definition = {"senders": ["@flibble:wibble"]}
  159. event = MockEvent(
  160. sender="@flibble:wibble", type="com.nom.nom.nom", room_id="!foo:bar"
  161. )
  162. self.assertTrue(Filter(definition).check(event))
  163. def test_definition_senders_works_with_unknowns(self):
  164. definition = {"senders": ["@flibble:wibble"]}
  165. event = MockEvent(
  166. sender="@challenger:appears", type="com.nom.nom.nom", room_id="!foo:bar"
  167. )
  168. self.assertFalse(Filter(definition).check(event))
  169. def test_definition_not_senders_works_with_literals(self):
  170. definition = {"not_senders": ["@flibble:wibble"]}
  171. event = MockEvent(
  172. sender="@flibble:wibble", type="com.nom.nom.nom", room_id="!foo:bar"
  173. )
  174. self.assertFalse(Filter(definition).check(event))
  175. def test_definition_not_senders_works_with_unknowns(self):
  176. definition = {"not_senders": ["@flibble:wibble"]}
  177. event = MockEvent(
  178. sender="@challenger:appears", type="com.nom.nom.nom", room_id="!foo:bar"
  179. )
  180. self.assertTrue(Filter(definition).check(event))
  181. def test_definition_not_senders_takes_priority_over_senders(self):
  182. definition = {
  183. "not_senders": ["@misspiggy:muppets"],
  184. "senders": ["@kermit:muppets", "@misspiggy:muppets"],
  185. }
  186. event = MockEvent(
  187. sender="@misspiggy:muppets", type="m.room.topic", room_id="!foo:bar"
  188. )
  189. self.assertFalse(Filter(definition).check(event))
  190. def test_definition_rooms_works_with_literals(self):
  191. definition = {"rooms": ["!secretbase:unknown"]}
  192. event = MockEvent(
  193. sender="@foo:bar", type="m.room.message", room_id="!secretbase:unknown"
  194. )
  195. self.assertTrue(Filter(definition).check(event))
  196. def test_definition_rooms_works_with_unknowns(self):
  197. definition = {"rooms": ["!secretbase:unknown"]}
  198. event = MockEvent(
  199. sender="@foo:bar",
  200. type="m.room.message",
  201. room_id="!anothersecretbase:unknown",
  202. )
  203. self.assertFalse(Filter(definition).check(event))
  204. def test_definition_not_rooms_works_with_literals(self):
  205. definition = {"not_rooms": ["!anothersecretbase:unknown"]}
  206. event = MockEvent(
  207. sender="@foo:bar",
  208. type="m.room.message",
  209. room_id="!anothersecretbase:unknown",
  210. )
  211. self.assertFalse(Filter(definition).check(event))
  212. def test_definition_not_rooms_works_with_unknowns(self):
  213. definition = {"not_rooms": ["!secretbase:unknown"]}
  214. event = MockEvent(
  215. sender="@foo:bar",
  216. type="m.room.message",
  217. room_id="!anothersecretbase:unknown",
  218. )
  219. self.assertTrue(Filter(definition).check(event))
  220. def test_definition_not_rooms_takes_priority_over_rooms(self):
  221. definition = {
  222. "not_rooms": ["!secretbase:unknown"],
  223. "rooms": ["!secretbase:unknown"],
  224. }
  225. event = MockEvent(
  226. sender="@foo:bar", type="m.room.message", room_id="!secretbase:unknown"
  227. )
  228. self.assertFalse(Filter(definition).check(event))
  229. def test_definition_combined_event(self):
  230. definition = {
  231. "not_senders": ["@misspiggy:muppets"],
  232. "senders": ["@kermit:muppets"],
  233. "rooms": ["!stage:unknown"],
  234. "not_rooms": ["!piggyshouse:muppets"],
  235. "types": ["m.room.message", "muppets.kermit.*"],
  236. "not_types": ["muppets.misspiggy.*"],
  237. }
  238. event = MockEvent(
  239. sender="@kermit:muppets", # yup
  240. type="m.room.message", # yup
  241. room_id="!stage:unknown", # yup
  242. )
  243. self.assertTrue(Filter(definition).check(event))
  244. def test_definition_combined_event_bad_sender(self):
  245. definition = {
  246. "not_senders": ["@misspiggy:muppets"],
  247. "senders": ["@kermit:muppets"],
  248. "rooms": ["!stage:unknown"],
  249. "not_rooms": ["!piggyshouse:muppets"],
  250. "types": ["m.room.message", "muppets.kermit.*"],
  251. "not_types": ["muppets.misspiggy.*"],
  252. }
  253. event = MockEvent(
  254. sender="@misspiggy:muppets", # nope
  255. type="m.room.message", # yup
  256. room_id="!stage:unknown", # yup
  257. )
  258. self.assertFalse(Filter(definition).check(event))
  259. def test_definition_combined_event_bad_room(self):
  260. definition = {
  261. "not_senders": ["@misspiggy:muppets"],
  262. "senders": ["@kermit:muppets"],
  263. "rooms": ["!stage:unknown"],
  264. "not_rooms": ["!piggyshouse:muppets"],
  265. "types": ["m.room.message", "muppets.kermit.*"],
  266. "not_types": ["muppets.misspiggy.*"],
  267. }
  268. event = MockEvent(
  269. sender="@kermit:muppets", # yup
  270. type="m.room.message", # yup
  271. room_id="!piggyshouse:muppets", # nope
  272. )
  273. self.assertFalse(Filter(definition).check(event))
  274. def test_definition_combined_event_bad_type(self):
  275. definition = {
  276. "not_senders": ["@misspiggy:muppets"],
  277. "senders": ["@kermit:muppets"],
  278. "rooms": ["!stage:unknown"],
  279. "not_rooms": ["!piggyshouse:muppets"],
  280. "types": ["m.room.message", "muppets.kermit.*"],
  281. "not_types": ["muppets.misspiggy.*"],
  282. }
  283. event = MockEvent(
  284. sender="@kermit:muppets", # yup
  285. type="muppets.misspiggy.kisses", # nope
  286. room_id="!stage:unknown", # yup
  287. )
  288. self.assertFalse(Filter(definition).check(event))
  289. def test_filter_labels(self):
  290. definition = {"org.matrix.labels": ["#fun"]}
  291. event = MockEvent(
  292. sender="@foo:bar",
  293. type="m.room.message",
  294. room_id="!secretbase:unknown",
  295. content={EventContentFields.LABELS: ["#fun"]},
  296. )
  297. self.assertTrue(Filter(definition).check(event))
  298. event = MockEvent(
  299. sender="@foo:bar",
  300. type="m.room.message",
  301. room_id="!secretbase:unknown",
  302. content={EventContentFields.LABELS: ["#notfun"]},
  303. )
  304. self.assertFalse(Filter(definition).check(event))
  305. def test_filter_not_labels(self):
  306. definition = {"org.matrix.not_labels": ["#fun"]}
  307. event = MockEvent(
  308. sender="@foo:bar",
  309. type="m.room.message",
  310. room_id="!secretbase:unknown",
  311. content={EventContentFields.LABELS: ["#fun"]},
  312. )
  313. self.assertFalse(Filter(definition).check(event))
  314. event = MockEvent(
  315. sender="@foo:bar",
  316. type="m.room.message",
  317. room_id="!secretbase:unknown",
  318. content={EventContentFields.LABELS: ["#notfun"]},
  319. )
  320. self.assertTrue(Filter(definition).check(event))
  321. @defer.inlineCallbacks
  322. def test_filter_presence_match(self):
  323. user_filter_json = {"presence": {"types": ["m.*"]}}
  324. filter_id = yield self.datastore.add_user_filter(
  325. user_localpart=user_localpart, user_filter=user_filter_json
  326. )
  327. event = MockEvent(sender="@foo:bar", type="m.profile")
  328. events = [event]
  329. user_filter = yield self.filtering.get_user_filter(
  330. user_localpart=user_localpart, filter_id=filter_id
  331. )
  332. results = user_filter.filter_presence(events=events)
  333. self.assertEquals(events, results)
  334. @defer.inlineCallbacks
  335. def test_filter_presence_no_match(self):
  336. user_filter_json = {"presence": {"types": ["m.*"]}}
  337. filter_id = yield self.datastore.add_user_filter(
  338. user_localpart=user_localpart + "2", user_filter=user_filter_json
  339. )
  340. event = MockEvent(
  341. event_id="$asdasd:localhost",
  342. sender="@foo:bar",
  343. type="custom.avatar.3d.crazy",
  344. )
  345. events = [event]
  346. user_filter = yield self.filtering.get_user_filter(
  347. user_localpart=user_localpart + "2", filter_id=filter_id
  348. )
  349. results = user_filter.filter_presence(events=events)
  350. self.assertEquals([], results)
  351. @defer.inlineCallbacks
  352. def test_filter_room_state_match(self):
  353. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  354. filter_id = yield self.datastore.add_user_filter(
  355. user_localpart=user_localpart, user_filter=user_filter_json
  356. )
  357. event = MockEvent(sender="@foo:bar", type="m.room.topic", room_id="!foo:bar")
  358. events = [event]
  359. user_filter = yield self.filtering.get_user_filter(
  360. user_localpart=user_localpart, filter_id=filter_id
  361. )
  362. results = user_filter.filter_room_state(events=events)
  363. self.assertEquals(events, results)
  364. @defer.inlineCallbacks
  365. def test_filter_room_state_no_match(self):
  366. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  367. filter_id = yield self.datastore.add_user_filter(
  368. user_localpart=user_localpart, user_filter=user_filter_json
  369. )
  370. event = MockEvent(
  371. sender="@foo:bar", type="org.matrix.custom.event", room_id="!foo:bar"
  372. )
  373. events = [event]
  374. user_filter = yield self.filtering.get_user_filter(
  375. user_localpart=user_localpart, filter_id=filter_id
  376. )
  377. results = user_filter.filter_room_state(events)
  378. self.assertEquals([], results)
  379. def test_filter_rooms(self):
  380. definition = {
  381. "rooms": ["!allowed:example.com", "!excluded:example.com"],
  382. "not_rooms": ["!excluded:example.com"],
  383. }
  384. room_ids = [
  385. "!allowed:example.com", # Allowed because in rooms and not in not_rooms.
  386. "!excluded:example.com", # Disallowed because in not_rooms.
  387. "!not_included:example.com", # Disallowed because not in rooms.
  388. ]
  389. filtered_room_ids = list(Filter(definition).filter_rooms(room_ids))
  390. self.assertEquals(filtered_room_ids, ["!allowed:example.com"])
  391. @defer.inlineCallbacks
  392. def test_add_filter(self):
  393. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  394. filter_id = yield self.filtering.add_user_filter(
  395. user_localpart=user_localpart, user_filter=user_filter_json
  396. )
  397. self.assertEquals(filter_id, 0)
  398. self.assertEquals(
  399. user_filter_json,
  400. (
  401. yield self.datastore.get_user_filter(
  402. user_localpart=user_localpart, filter_id=0
  403. )
  404. ),
  405. )
  406. @defer.inlineCallbacks
  407. def test_get_filter(self):
  408. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  409. filter_id = yield self.datastore.add_user_filter(
  410. user_localpart=user_localpart, user_filter=user_filter_json
  411. )
  412. filter = yield self.filtering.get_user_filter(
  413. user_localpart=user_localpart, filter_id=filter_id
  414. )
  415. self.assertEquals(filter.get_filter_json(), user_filter_json)
  416. self.assertRegexpMatches(repr(filter), r"<FilterCollection \{.*\}>")