test_federation_sender.py 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547
  1. # Copyright 2019 New Vector Ltd
  2. #
  3. # Licensed under the Apache License, Version 2.0 (the "License");
  4. # you may not use this file except in compliance with the License.
  5. # You may obtain a copy of the License at
  6. #
  7. # http://www.apache.org/licenses/LICENSE-2.0
  8. #
  9. # Unless required by applicable law or agreed to in writing, software
  10. # distributed under the License is distributed on an "AS IS" BASIS,
  11. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. # See the License for the specific language governing permissions and
  13. # limitations under the License.
  14. from typing import Optional
  15. from unittest.mock import Mock
  16. from signedjson import key, sign
  17. from signedjson.types import BaseKey, SigningKey
  18. from twisted.internet import defer
  19. from synapse.api.constants import RoomEncryptionAlgorithms
  20. from synapse.rest import admin
  21. from synapse.rest.client import login
  22. from synapse.types import JsonDict, ReadReceipt
  23. from tests.test_utils import make_awaitable
  24. from tests.unittest import HomeserverTestCase, override_config
  25. class FederationSenderReceiptsTestCases(HomeserverTestCase):
  26. def make_homeserver(self, reactor, clock):
  27. mock_state_handler = Mock(spec=["get_current_hosts_in_room"])
  28. # Ensure a new Awaitable is created for each call.
  29. mock_state_handler.get_current_hosts_in_room.return_value = make_awaitable(
  30. ["test", "host2"]
  31. )
  32. return self.setup_test_homeserver(
  33. state_handler=mock_state_handler,
  34. federation_transport_client=Mock(spec=["send_transaction"]),
  35. )
  36. @override_config({"send_federation": True})
  37. def test_send_receipts(self):
  38. mock_send_transaction = (
  39. self.hs.get_federation_transport_client().send_transaction
  40. )
  41. mock_send_transaction.return_value = make_awaitable({})
  42. sender = self.hs.get_federation_sender()
  43. receipt = ReadReceipt(
  44. "room_id", "m.read", "user_id", ["event_id"], {"ts": 1234}
  45. )
  46. self.successResultOf(defer.ensureDeferred(sender.send_read_receipt(receipt)))
  47. self.pump()
  48. # expect a call to send_transaction
  49. mock_send_transaction.assert_called_once()
  50. json_cb = mock_send_transaction.call_args[0][1]
  51. data = json_cb()
  52. self.assertEqual(
  53. data["edus"],
  54. [
  55. {
  56. "edu_type": "m.receipt",
  57. "content": {
  58. "room_id": {
  59. "m.read": {
  60. "user_id": {
  61. "event_ids": ["event_id"],
  62. "data": {"ts": 1234},
  63. }
  64. }
  65. }
  66. },
  67. }
  68. ],
  69. )
  70. @override_config({"send_federation": True})
  71. def test_send_receipts_with_backoff(self):
  72. """Send two receipts in quick succession; the second should be flushed, but
  73. only after 20ms"""
  74. mock_send_transaction = (
  75. self.hs.get_federation_transport_client().send_transaction
  76. )
  77. mock_send_transaction.return_value = make_awaitable({})
  78. sender = self.hs.get_federation_sender()
  79. receipt = ReadReceipt(
  80. "room_id", "m.read", "user_id", ["event_id"], {"ts": 1234}
  81. )
  82. self.successResultOf(defer.ensureDeferred(sender.send_read_receipt(receipt)))
  83. self.pump()
  84. # expect a call to send_transaction
  85. mock_send_transaction.assert_called_once()
  86. json_cb = mock_send_transaction.call_args[0][1]
  87. data = json_cb()
  88. self.assertEqual(
  89. data["edus"],
  90. [
  91. {
  92. "edu_type": "m.receipt",
  93. "content": {
  94. "room_id": {
  95. "m.read": {
  96. "user_id": {
  97. "event_ids": ["event_id"],
  98. "data": {"ts": 1234},
  99. }
  100. }
  101. }
  102. },
  103. }
  104. ],
  105. )
  106. mock_send_transaction.reset_mock()
  107. # send the second RR
  108. receipt = ReadReceipt(
  109. "room_id", "m.read", "user_id", ["other_id"], {"ts": 1234}
  110. )
  111. self.successResultOf(defer.ensureDeferred(sender.send_read_receipt(receipt)))
  112. self.pump()
  113. mock_send_transaction.assert_not_called()
  114. self.reactor.advance(19)
  115. mock_send_transaction.assert_not_called()
  116. self.reactor.advance(10)
  117. mock_send_transaction.assert_called_once()
  118. json_cb = mock_send_transaction.call_args[0][1]
  119. data = json_cb()
  120. self.assertEqual(
  121. data["edus"],
  122. [
  123. {
  124. "edu_type": "m.receipt",
  125. "content": {
  126. "room_id": {
  127. "m.read": {
  128. "user_id": {
  129. "event_ids": ["other_id"],
  130. "data": {"ts": 1234},
  131. }
  132. }
  133. }
  134. },
  135. }
  136. ],
  137. )
  138. class FederationSenderDevicesTestCases(HomeserverTestCase):
  139. servlets = [
  140. admin.register_servlets,
  141. login.register_servlets,
  142. ]
  143. def make_homeserver(self, reactor, clock):
  144. return self.setup_test_homeserver(
  145. federation_transport_client=Mock(spec=["send_transaction"]),
  146. )
  147. def default_config(self):
  148. c = super().default_config()
  149. c["send_federation"] = True
  150. return c
  151. def prepare(self, reactor, clock, hs):
  152. # stub out get_users_who_share_room_with_user so that it claims that
  153. # `@user2:host2` is in the room
  154. def get_users_who_share_room_with_user(user_id):
  155. return defer.succeed({"@user2:host2"})
  156. hs.get_datastore().get_users_who_share_room_with_user = (
  157. get_users_who_share_room_with_user
  158. )
  159. # whenever send_transaction is called, record the edu data
  160. self.edus = []
  161. self.hs.get_federation_transport_client().send_transaction.side_effect = (
  162. self.record_transaction
  163. )
  164. def record_transaction(self, txn, json_cb):
  165. data = json_cb()
  166. self.edus.extend(data["edus"])
  167. return defer.succeed({})
  168. def test_send_device_updates(self):
  169. """Basic case: each device update should result in an EDU"""
  170. # create a device
  171. u1 = self.register_user("user", "pass")
  172. self.login(u1, "pass", device_id="D1")
  173. # expect one edu
  174. self.assertEqual(len(self.edus), 1)
  175. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D1", None)
  176. # a second call should produce no new device EDUs
  177. self.hs.get_federation_sender().send_device_messages("host2")
  178. self.pump()
  179. self.assertEqual(self.edus, [])
  180. # a second device
  181. self.login("user", "pass", device_id="D2")
  182. self.assertEqual(len(self.edus), 1)
  183. self.check_device_update_edu(self.edus.pop(0), u1, "D2", stream_id)
  184. def test_upload_signatures(self):
  185. """Uploading signatures on some devices should produce updates for that user"""
  186. e2e_handler = self.hs.get_e2e_keys_handler()
  187. # register two devices
  188. u1 = self.register_user("user", "pass")
  189. self.login(u1, "pass", device_id="D1")
  190. self.login(u1, "pass", device_id="D2")
  191. # expect two edus
  192. self.assertEqual(len(self.edus), 2)
  193. stream_id = None
  194. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D1", stream_id)
  195. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D2", stream_id)
  196. # upload signing keys for each device
  197. device1_signing_key = self.generate_and_upload_device_signing_key(u1, "D1")
  198. device2_signing_key = self.generate_and_upload_device_signing_key(u1, "D2")
  199. # expect two more edus
  200. self.assertEqual(len(self.edus), 2)
  201. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D1", stream_id)
  202. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D2", stream_id)
  203. # upload master key and self-signing key
  204. master_signing_key = generate_self_id_key()
  205. master_key = {
  206. "user_id": u1,
  207. "usage": ["master"],
  208. "keys": {key_id(master_signing_key): encode_pubkey(master_signing_key)},
  209. }
  210. # private key: HvQBbU+hc2Zr+JP1sE0XwBe1pfZZEYtJNPJLZJtS+F8
  211. selfsigning_signing_key = generate_self_id_key()
  212. selfsigning_key = {
  213. "user_id": u1,
  214. "usage": ["self_signing"],
  215. "keys": {
  216. key_id(selfsigning_signing_key): encode_pubkey(selfsigning_signing_key)
  217. },
  218. }
  219. sign.sign_json(selfsigning_key, u1, master_signing_key)
  220. cross_signing_keys = {
  221. "master_key": master_key,
  222. "self_signing_key": selfsigning_key,
  223. }
  224. self.get_success(
  225. e2e_handler.upload_signing_keys_for_user(u1, cross_signing_keys)
  226. )
  227. # expect signing key update edu
  228. self.assertEqual(len(self.edus), 2)
  229. self.assertEqual(self.edus.pop(0)["edu_type"], "m.signing_key_update")
  230. self.assertEqual(self.edus.pop(0)["edu_type"], "org.matrix.signing_key_update")
  231. # sign the devices
  232. d1_json = build_device_dict(u1, "D1", device1_signing_key)
  233. sign.sign_json(d1_json, u1, selfsigning_signing_key)
  234. d2_json = build_device_dict(u1, "D2", device2_signing_key)
  235. sign.sign_json(d2_json, u1, selfsigning_signing_key)
  236. ret = self.get_success(
  237. e2e_handler.upload_signatures_for_device_keys(
  238. u1,
  239. {u1: {"D1": d1_json, "D2": d2_json}},
  240. )
  241. )
  242. self.assertEqual(ret["failures"], {})
  243. # expect two edus, in one or two transactions. We don't know what order the
  244. # devices will be updated.
  245. self.assertEqual(len(self.edus), 2)
  246. stream_id = None # FIXME: there is a discontinuity in the stream IDs: see #7142
  247. for edu in self.edus:
  248. self.assertEqual(edu["edu_type"], "m.device_list_update")
  249. c = edu["content"]
  250. if stream_id is not None:
  251. self.assertEqual(c["prev_id"], [stream_id])
  252. self.assertGreaterEqual(c["stream_id"], stream_id)
  253. stream_id = c["stream_id"]
  254. devices = {edu["content"]["device_id"] for edu in self.edus}
  255. self.assertEqual({"D1", "D2"}, devices)
  256. def test_delete_devices(self):
  257. """If devices are deleted, that should result in EDUs too"""
  258. # create devices
  259. u1 = self.register_user("user", "pass")
  260. self.login("user", "pass", device_id="D1")
  261. self.login("user", "pass", device_id="D2")
  262. self.login("user", "pass", device_id="D3")
  263. # expect three edus
  264. self.assertEqual(len(self.edus), 3)
  265. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D1", None)
  266. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D2", stream_id)
  267. stream_id = self.check_device_update_edu(self.edus.pop(0), u1, "D3", stream_id)
  268. # delete them again
  269. self.get_success(
  270. self.hs.get_device_handler().delete_devices(u1, ["D1", "D2", "D3"])
  271. )
  272. # expect three edus, in an unknown order
  273. self.assertEqual(len(self.edus), 3)
  274. for edu in self.edus:
  275. self.assertEqual(edu["edu_type"], "m.device_list_update")
  276. c = edu["content"]
  277. self.assertGreaterEqual(
  278. c.items(),
  279. {"user_id": u1, "prev_id": [stream_id], "deleted": True}.items(),
  280. )
  281. self.assertGreaterEqual(c["stream_id"], stream_id)
  282. stream_id = c["stream_id"]
  283. devices = {edu["content"]["device_id"] for edu in self.edus}
  284. self.assertEqual({"D1", "D2", "D3"}, devices)
  285. def test_unreachable_server(self):
  286. """If the destination server is unreachable, all the updates should get sent on
  287. recovery
  288. """
  289. mock_send_txn = self.hs.get_federation_transport_client().send_transaction
  290. mock_send_txn.side_effect = lambda t, cb: defer.fail(AssertionError("fail"))
  291. # create devices
  292. u1 = self.register_user("user", "pass")
  293. self.login("user", "pass", device_id="D1")
  294. self.login("user", "pass", device_id="D2")
  295. self.login("user", "pass", device_id="D3")
  296. # delete them again
  297. self.get_success(
  298. self.hs.get_device_handler().delete_devices(u1, ["D1", "D2", "D3"])
  299. )
  300. self.assertGreaterEqual(mock_send_txn.call_count, 4)
  301. # recover the server
  302. mock_send_txn.side_effect = self.record_transaction
  303. self.hs.get_federation_sender().send_device_messages("host2")
  304. self.pump()
  305. # for each device, there should be a single update
  306. self.assertEqual(len(self.edus), 3)
  307. stream_id = None
  308. for edu in self.edus:
  309. self.assertEqual(edu["edu_type"], "m.device_list_update")
  310. c = edu["content"]
  311. self.assertEqual(c["prev_id"], [stream_id] if stream_id is not None else [])
  312. if stream_id is not None:
  313. self.assertGreaterEqual(c["stream_id"], stream_id)
  314. stream_id = c["stream_id"]
  315. devices = {edu["content"]["device_id"] for edu in self.edus}
  316. self.assertEqual({"D1", "D2", "D3"}, devices)
  317. def test_prune_outbound_device_pokes1(self):
  318. """If a destination is unreachable, and the updates are pruned, we should get
  319. a single update.
  320. This case tests the behaviour when the server has never been reachable.
  321. """
  322. mock_send_txn = self.hs.get_federation_transport_client().send_transaction
  323. mock_send_txn.side_effect = lambda t, cb: defer.fail(AssertionError("fail"))
  324. # create devices
  325. u1 = self.register_user("user", "pass")
  326. self.login("user", "pass", device_id="D1")
  327. self.login("user", "pass", device_id="D2")
  328. self.login("user", "pass", device_id="D3")
  329. # delete them again
  330. self.get_success(
  331. self.hs.get_device_handler().delete_devices(u1, ["D1", "D2", "D3"])
  332. )
  333. self.assertGreaterEqual(mock_send_txn.call_count, 4)
  334. # run the prune job
  335. self.reactor.advance(10)
  336. self.get_success(
  337. self.hs.get_datastore()._prune_old_outbound_device_pokes(prune_age=1)
  338. )
  339. # recover the server
  340. mock_send_txn.side_effect = self.record_transaction
  341. self.hs.get_federation_sender().send_device_messages("host2")
  342. self.pump()
  343. # there should be a single update for this user.
  344. self.assertEqual(len(self.edus), 1)
  345. edu = self.edus.pop(0)
  346. self.assertEqual(edu["edu_type"], "m.device_list_update")
  347. c = edu["content"]
  348. # synapse uses an empty prev_id list to indicate "needs a full resync".
  349. self.assertEqual(c["prev_id"], [])
  350. def test_prune_outbound_device_pokes2(self):
  351. """If a destination is unreachable, and the updates are pruned, we should get
  352. a single update.
  353. This case tests the behaviour when the server was reachable, but then goes
  354. offline.
  355. """
  356. # create first device
  357. u1 = self.register_user("user", "pass")
  358. self.login("user", "pass", device_id="D1")
  359. # expect the update EDU
  360. self.assertEqual(len(self.edus), 1)
  361. self.check_device_update_edu(self.edus.pop(0), u1, "D1", None)
  362. # now the server goes offline
  363. mock_send_txn = self.hs.get_federation_transport_client().send_transaction
  364. mock_send_txn.side_effect = lambda t, cb: defer.fail(AssertionError("fail"))
  365. self.login("user", "pass", device_id="D2")
  366. self.login("user", "pass", device_id="D3")
  367. # delete them again
  368. self.get_success(
  369. self.hs.get_device_handler().delete_devices(u1, ["D1", "D2", "D3"])
  370. )
  371. self.assertGreaterEqual(mock_send_txn.call_count, 3)
  372. # run the prune job
  373. self.reactor.advance(10)
  374. self.get_success(
  375. self.hs.get_datastore()._prune_old_outbound_device_pokes(prune_age=1)
  376. )
  377. # recover the server
  378. mock_send_txn.side_effect = self.record_transaction
  379. self.hs.get_federation_sender().send_device_messages("host2")
  380. self.pump()
  381. # ... and we should get a single update for this user.
  382. self.assertEqual(len(self.edus), 1)
  383. edu = self.edus.pop(0)
  384. self.assertEqual(edu["edu_type"], "m.device_list_update")
  385. c = edu["content"]
  386. # synapse uses an empty prev_id list to indicate "needs a full resync".
  387. self.assertEqual(c["prev_id"], [])
  388. def check_device_update_edu(
  389. self,
  390. edu: JsonDict,
  391. user_id: str,
  392. device_id: str,
  393. prev_stream_id: Optional[int],
  394. ) -> int:
  395. """Check that the given EDU is an update for the given device
  396. Returns the stream_id.
  397. """
  398. self.assertEqual(edu["edu_type"], "m.device_list_update")
  399. content = edu["content"]
  400. expected = {
  401. "user_id": user_id,
  402. "device_id": device_id,
  403. "prev_id": [prev_stream_id] if prev_stream_id is not None else [],
  404. }
  405. self.assertLessEqual(expected.items(), content.items())
  406. if prev_stream_id is not None:
  407. self.assertGreaterEqual(content["stream_id"], prev_stream_id)
  408. return content["stream_id"]
  409. def check_signing_key_update_txn(
  410. self,
  411. txn: JsonDict,
  412. ) -> None:
  413. """Check that the txn has an EDU with a signing key update."""
  414. edus = txn["edus"]
  415. self.assertEqual(len(edus), 2)
  416. def generate_and_upload_device_signing_key(
  417. self, user_id: str, device_id: str
  418. ) -> SigningKey:
  419. """Generate a signing keypair for the given device, and upload it"""
  420. sk = key.generate_signing_key(device_id)
  421. device_dict = build_device_dict(user_id, device_id, sk)
  422. self.get_success(
  423. self.hs.get_e2e_keys_handler().upload_keys_for_user(
  424. user_id,
  425. device_id,
  426. {"device_keys": device_dict},
  427. )
  428. )
  429. return sk
  430. def generate_self_id_key() -> SigningKey:
  431. """generate a signing key whose version is its public key
  432. ... as used by the cross-signing-keys.
  433. """
  434. k = key.generate_signing_key("x")
  435. k.version = encode_pubkey(k)
  436. return k
  437. def key_id(k: BaseKey) -> str:
  438. return "%s:%s" % (k.alg, k.version)
  439. def encode_pubkey(sk: SigningKey) -> str:
  440. """Encode the public key corresponding to the given signing key as base64"""
  441. return key.encode_verify_key_base64(key.get_verify_key(sk))
  442. def build_device_dict(user_id: str, device_id: str, sk: SigningKey):
  443. """Build a dict representing the given device"""
  444. return {
  445. "user_id": user_id,
  446. "device_id": device_id,
  447. "algorithms": [
  448. "m.olm.curve25519-aes-sha2",
  449. RoomEncryptionAlgorithms.MEGOLM_V1_AES_SHA2,
  450. ],
  451. "keys": {
  452. "curve25519:" + device_id: "curve25519+key",
  453. key_id(sk): encode_pubkey(sk),
  454. },
  455. }