test_filtering.py 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442
  1. # -*- coding: utf-8 -*-
  2. # Copyright 2015, 2016 OpenMarket Ltd
  3. #
  4. # Licensed under the Apache License, Version 2.0 (the "License");
  5. # you may not use this file except in compliance with the License.
  6. # You may obtain a copy of the License at
  7. #
  8. # http://www.apache.org/licenses/LICENSE-2.0
  9. #
  10. # Unless required by applicable law or agreed to in writing, software
  11. # distributed under the License is distributed on an "AS IS" BASIS,
  12. # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13. # See the License for the specific language governing permissions and
  14. # limitations under the License.
  15. from mock import Mock
  16. import jsonschema
  17. from twisted.internet import defer
  18. from synapse.api.errors import SynapseError
  19. from synapse.api.filtering import Filter
  20. from synapse.events import FrozenEvent
  21. from tests import unittest
  22. from tests.utils import DeferredMockCallable, MockHttpResource, setup_test_homeserver
  23. user_localpart = "test_user"
  24. def MockEvent(**kwargs):
  25. if "event_id" not in kwargs:
  26. kwargs["event_id"] = "fake_event_id"
  27. if "type" not in kwargs:
  28. kwargs["type"] = "fake_type"
  29. return FrozenEvent(kwargs)
  30. class FilteringTestCase(unittest.TestCase):
  31. @defer.inlineCallbacks
  32. def setUp(self):
  33. self.mock_federation_resource = MockHttpResource()
  34. self.mock_http_client = Mock(spec=[])
  35. self.mock_http_client.put_json = DeferredMockCallable()
  36. hs = yield setup_test_homeserver(
  37. self.addCleanup,
  38. handlers=None,
  39. http_client=self.mock_http_client,
  40. keyring=Mock(),
  41. )
  42. self.filtering = hs.get_filtering()
  43. self.datastore = hs.get_datastore()
  44. def test_errors_on_invalid_filters(self):
  45. invalid_filters = [
  46. {"boom": {}},
  47. {"account_data": "Hello World"},
  48. {"event_fields": [r"\\foo"]},
  49. {"room": {"timeline": {"limit": 0}, "state": {"not_bars": ["*"]}}},
  50. {"event_format": "other"},
  51. {"room": {"not_rooms": ["#foo:pik-test"]}},
  52. {"presence": {"senders": ["@bar;pik.test.com"]}},
  53. ]
  54. for filter in invalid_filters:
  55. with self.assertRaises(SynapseError) as check_filter_error:
  56. self.filtering.check_valid_filter(filter)
  57. self.assertIsInstance(check_filter_error.exception, SynapseError)
  58. def test_valid_filters(self):
  59. valid_filters = [
  60. {
  61. "room": {
  62. "timeline": {"limit": 20},
  63. "state": {"not_types": ["m.room.member"]},
  64. "ephemeral": {"limit": 0, "not_types": ["*"]},
  65. "include_leave": False,
  66. "rooms": ["!dee:pik-test"],
  67. "not_rooms": ["!gee:pik-test"],
  68. "account_data": {"limit": 0, "types": ["*"]},
  69. }
  70. },
  71. {
  72. "room": {
  73. "state": {
  74. "types": ["m.room.*"],
  75. "not_rooms": ["!726s6s6q:example.com"],
  76. },
  77. "timeline": {
  78. "limit": 10,
  79. "types": ["m.room.message"],
  80. "not_rooms": ["!726s6s6q:example.com"],
  81. "not_senders": ["@spam:example.com"],
  82. },
  83. "ephemeral": {
  84. "types": ["m.receipt", "m.typing"],
  85. "not_rooms": ["!726s6s6q:example.com"],
  86. "not_senders": ["@spam:example.com"],
  87. },
  88. },
  89. "presence": {
  90. "types": ["m.presence"],
  91. "not_senders": ["@alice:example.com"],
  92. },
  93. "event_format": "client",
  94. "event_fields": ["type", "content", "sender"],
  95. },
  96. # a single backslash should be permitted (though it is debatable whether
  97. # it should be permitted before anything other than `.`, and what that
  98. # actually means)
  99. #
  100. # (note that event_fields is implemented in
  101. # synapse.events.utils.serialize_event, and so whether this actually works
  102. # is tested elsewhere. We just want to check that it is allowed through the
  103. # filter validation)
  104. {"event_fields": [r"foo\.bar"]},
  105. ]
  106. for filter in valid_filters:
  107. try:
  108. self.filtering.check_valid_filter(filter)
  109. except jsonschema.ValidationError as e:
  110. self.fail(e)
  111. def test_limits_are_applied(self):
  112. # TODO
  113. pass
  114. def test_definition_types_works_with_literals(self):
  115. definition = {"types": ["m.room.message", "org.matrix.foo.bar"]}
  116. event = MockEvent(sender="@foo:bar", type="m.room.message", room_id="!foo:bar")
  117. self.assertTrue(Filter(definition).check(event))
  118. def test_definition_types_works_with_wildcards(self):
  119. definition = {"types": ["m.*", "org.matrix.foo.bar"]}
  120. event = MockEvent(sender="@foo:bar", type="m.room.message", room_id="!foo:bar")
  121. self.assertTrue(Filter(definition).check(event))
  122. def test_definition_types_works_with_unknowns(self):
  123. definition = {"types": ["m.room.message", "org.matrix.foo.bar"]}
  124. event = MockEvent(
  125. sender="@foo:bar",
  126. type="now.for.something.completely.different",
  127. room_id="!foo:bar",
  128. )
  129. self.assertFalse(Filter(definition).check(event))
  130. def test_definition_not_types_works_with_literals(self):
  131. definition = {"not_types": ["m.room.message", "org.matrix.foo.bar"]}
  132. event = MockEvent(sender="@foo:bar", type="m.room.message", room_id="!foo:bar")
  133. self.assertFalse(Filter(definition).check(event))
  134. def test_definition_not_types_works_with_wildcards(self):
  135. definition = {"not_types": ["m.room.message", "org.matrix.*"]}
  136. event = MockEvent(
  137. sender="@foo:bar", type="org.matrix.custom.event", room_id="!foo:bar"
  138. )
  139. self.assertFalse(Filter(definition).check(event))
  140. def test_definition_not_types_works_with_unknowns(self):
  141. definition = {"not_types": ["m.*", "org.*"]}
  142. event = MockEvent(sender="@foo:bar", type="com.nom.nom.nom", room_id="!foo:bar")
  143. self.assertTrue(Filter(definition).check(event))
  144. def test_definition_not_types_takes_priority_over_types(self):
  145. definition = {
  146. "not_types": ["m.*", "org.*"],
  147. "types": ["m.room.message", "m.room.topic"],
  148. }
  149. event = MockEvent(sender="@foo:bar", type="m.room.topic", room_id="!foo:bar")
  150. self.assertFalse(Filter(definition).check(event))
  151. def test_definition_senders_works_with_literals(self):
  152. definition = {"senders": ["@flibble:wibble"]}
  153. event = MockEvent(
  154. sender="@flibble:wibble", type="com.nom.nom.nom", room_id="!foo:bar"
  155. )
  156. self.assertTrue(Filter(definition).check(event))
  157. def test_definition_senders_works_with_unknowns(self):
  158. definition = {"senders": ["@flibble:wibble"]}
  159. event = MockEvent(
  160. sender="@challenger:appears", type="com.nom.nom.nom", room_id="!foo:bar"
  161. )
  162. self.assertFalse(Filter(definition).check(event))
  163. def test_definition_not_senders_works_with_literals(self):
  164. definition = {"not_senders": ["@flibble:wibble"]}
  165. event = MockEvent(
  166. sender="@flibble:wibble", type="com.nom.nom.nom", room_id="!foo:bar"
  167. )
  168. self.assertFalse(Filter(definition).check(event))
  169. def test_definition_not_senders_works_with_unknowns(self):
  170. definition = {"not_senders": ["@flibble:wibble"]}
  171. event = MockEvent(
  172. sender="@challenger:appears", type="com.nom.nom.nom", room_id="!foo:bar"
  173. )
  174. self.assertTrue(Filter(definition).check(event))
  175. def test_definition_not_senders_takes_priority_over_senders(self):
  176. definition = {
  177. "not_senders": ["@misspiggy:muppets"],
  178. "senders": ["@kermit:muppets", "@misspiggy:muppets"],
  179. }
  180. event = MockEvent(
  181. sender="@misspiggy:muppets", type="m.room.topic", room_id="!foo:bar"
  182. )
  183. self.assertFalse(Filter(definition).check(event))
  184. def test_definition_rooms_works_with_literals(self):
  185. definition = {"rooms": ["!secretbase:unknown"]}
  186. event = MockEvent(
  187. sender="@foo:bar", type="m.room.message", room_id="!secretbase:unknown"
  188. )
  189. self.assertTrue(Filter(definition).check(event))
  190. def test_definition_rooms_works_with_unknowns(self):
  191. definition = {"rooms": ["!secretbase:unknown"]}
  192. event = MockEvent(
  193. sender="@foo:bar",
  194. type="m.room.message",
  195. room_id="!anothersecretbase:unknown",
  196. )
  197. self.assertFalse(Filter(definition).check(event))
  198. def test_definition_not_rooms_works_with_literals(self):
  199. definition = {"not_rooms": ["!anothersecretbase:unknown"]}
  200. event = MockEvent(
  201. sender="@foo:bar",
  202. type="m.room.message",
  203. room_id="!anothersecretbase:unknown",
  204. )
  205. self.assertFalse(Filter(definition).check(event))
  206. def test_definition_not_rooms_works_with_unknowns(self):
  207. definition = {"not_rooms": ["!secretbase:unknown"]}
  208. event = MockEvent(
  209. sender="@foo:bar",
  210. type="m.room.message",
  211. room_id="!anothersecretbase:unknown",
  212. )
  213. self.assertTrue(Filter(definition).check(event))
  214. def test_definition_not_rooms_takes_priority_over_rooms(self):
  215. definition = {
  216. "not_rooms": ["!secretbase:unknown"],
  217. "rooms": ["!secretbase:unknown"],
  218. }
  219. event = MockEvent(
  220. sender="@foo:bar", type="m.room.message", room_id="!secretbase:unknown"
  221. )
  222. self.assertFalse(Filter(definition).check(event))
  223. def test_definition_combined_event(self):
  224. definition = {
  225. "not_senders": ["@misspiggy:muppets"],
  226. "senders": ["@kermit:muppets"],
  227. "rooms": ["!stage:unknown"],
  228. "not_rooms": ["!piggyshouse:muppets"],
  229. "types": ["m.room.message", "muppets.kermit.*"],
  230. "not_types": ["muppets.misspiggy.*"],
  231. }
  232. event = MockEvent(
  233. sender="@kermit:muppets", # yup
  234. type="m.room.message", # yup
  235. room_id="!stage:unknown", # yup
  236. )
  237. self.assertTrue(Filter(definition).check(event))
  238. def test_definition_combined_event_bad_sender(self):
  239. definition = {
  240. "not_senders": ["@misspiggy:muppets"],
  241. "senders": ["@kermit:muppets"],
  242. "rooms": ["!stage:unknown"],
  243. "not_rooms": ["!piggyshouse:muppets"],
  244. "types": ["m.room.message", "muppets.kermit.*"],
  245. "not_types": ["muppets.misspiggy.*"],
  246. }
  247. event = MockEvent(
  248. sender="@misspiggy:muppets", # nope
  249. type="m.room.message", # yup
  250. room_id="!stage:unknown", # yup
  251. )
  252. self.assertFalse(Filter(definition).check(event))
  253. def test_definition_combined_event_bad_room(self):
  254. definition = {
  255. "not_senders": ["@misspiggy:muppets"],
  256. "senders": ["@kermit:muppets"],
  257. "rooms": ["!stage:unknown"],
  258. "not_rooms": ["!piggyshouse:muppets"],
  259. "types": ["m.room.message", "muppets.kermit.*"],
  260. "not_types": ["muppets.misspiggy.*"],
  261. }
  262. event = MockEvent(
  263. sender="@kermit:muppets", # yup
  264. type="m.room.message", # yup
  265. room_id="!piggyshouse:muppets", # nope
  266. )
  267. self.assertFalse(Filter(definition).check(event))
  268. def test_definition_combined_event_bad_type(self):
  269. definition = {
  270. "not_senders": ["@misspiggy:muppets"],
  271. "senders": ["@kermit:muppets"],
  272. "rooms": ["!stage:unknown"],
  273. "not_rooms": ["!piggyshouse:muppets"],
  274. "types": ["m.room.message", "muppets.kermit.*"],
  275. "not_types": ["muppets.misspiggy.*"],
  276. }
  277. event = MockEvent(
  278. sender="@kermit:muppets", # yup
  279. type="muppets.misspiggy.kisses", # nope
  280. room_id="!stage:unknown", # yup
  281. )
  282. self.assertFalse(Filter(definition).check(event))
  283. @defer.inlineCallbacks
  284. def test_filter_presence_match(self):
  285. user_filter_json = {"presence": {"types": ["m.*"]}}
  286. filter_id = yield self.datastore.add_user_filter(
  287. user_localpart=user_localpart, user_filter=user_filter_json
  288. )
  289. event = MockEvent(sender="@foo:bar", type="m.profile")
  290. events = [event]
  291. user_filter = yield self.filtering.get_user_filter(
  292. user_localpart=user_localpart, filter_id=filter_id
  293. )
  294. results = user_filter.filter_presence(events=events)
  295. self.assertEquals(events, results)
  296. @defer.inlineCallbacks
  297. def test_filter_presence_no_match(self):
  298. user_filter_json = {"presence": {"types": ["m.*"]}}
  299. filter_id = yield self.datastore.add_user_filter(
  300. user_localpart=user_localpart + "2", user_filter=user_filter_json
  301. )
  302. event = MockEvent(
  303. event_id="$asdasd:localhost",
  304. sender="@foo:bar",
  305. type="custom.avatar.3d.crazy",
  306. )
  307. events = [event]
  308. user_filter = yield self.filtering.get_user_filter(
  309. user_localpart=user_localpart + "2", filter_id=filter_id
  310. )
  311. results = user_filter.filter_presence(events=events)
  312. self.assertEquals([], results)
  313. @defer.inlineCallbacks
  314. def test_filter_room_state_match(self):
  315. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  316. filter_id = yield self.datastore.add_user_filter(
  317. user_localpart=user_localpart, user_filter=user_filter_json
  318. )
  319. event = MockEvent(sender="@foo:bar", type="m.room.topic", room_id="!foo:bar")
  320. events = [event]
  321. user_filter = yield self.filtering.get_user_filter(
  322. user_localpart=user_localpart, filter_id=filter_id
  323. )
  324. results = user_filter.filter_room_state(events=events)
  325. self.assertEquals(events, results)
  326. @defer.inlineCallbacks
  327. def test_filter_room_state_no_match(self):
  328. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  329. filter_id = yield self.datastore.add_user_filter(
  330. user_localpart=user_localpart, user_filter=user_filter_json
  331. )
  332. event = MockEvent(
  333. sender="@foo:bar", type="org.matrix.custom.event", room_id="!foo:bar"
  334. )
  335. events = [event]
  336. user_filter = yield self.filtering.get_user_filter(
  337. user_localpart=user_localpart, filter_id=filter_id
  338. )
  339. results = user_filter.filter_room_state(events)
  340. self.assertEquals([], results)
  341. def test_filter_rooms(self):
  342. definition = {
  343. "rooms": ["!allowed:example.com", "!excluded:example.com"],
  344. "not_rooms": ["!excluded:example.com"],
  345. }
  346. room_ids = [
  347. "!allowed:example.com", # Allowed because in rooms and not in not_rooms.
  348. "!excluded:example.com", # Disallowed because in not_rooms.
  349. "!not_included:example.com", # Disallowed because not in rooms.
  350. ]
  351. filtered_room_ids = list(Filter(definition).filter_rooms(room_ids))
  352. self.assertEquals(filtered_room_ids, ["!allowed:example.com"])
  353. @defer.inlineCallbacks
  354. def test_add_filter(self):
  355. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  356. filter_id = yield self.filtering.add_user_filter(
  357. user_localpart=user_localpart, user_filter=user_filter_json
  358. )
  359. self.assertEquals(filter_id, 0)
  360. self.assertEquals(
  361. user_filter_json,
  362. (
  363. yield self.datastore.get_user_filter(
  364. user_localpart=user_localpart, filter_id=0
  365. )
  366. ),
  367. )
  368. @defer.inlineCallbacks
  369. def test_get_filter(self):
  370. user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
  371. filter_id = yield self.datastore.add_user_filter(
  372. user_localpart=user_localpart, user_filter=user_filter_json
  373. )
  374. filter = yield self.filtering.get_user_filter(
  375. user_localpart=user_localpart, filter_id=filter_id
  376. )
  377. self.assertEquals(filter.get_filter_json(), user_filter_json)
  378. self.assertRegexpMatches(repr(filter), r"<FilterCollection \{.*\}>")