|
@@ -4,7 +4,7 @@
|
|
|
|
|
|
--- a/android_webview/browser/aw_browser_context.cc
|
|
--- a/android_webview/browser/aw_browser_context.cc
|
|
+++ b/android_webview/browser/aw_browser_context.cc
|
|
+++ b/android_webview/browser/aw_browser_context.cc
|
|
-@@ -48,7 +48,6 @@
|
|
|
|
|
|
+@@ -54,7 +54,6 @@
|
|
#include "components/prefs/pref_service_factory.h"
|
|
#include "components/prefs/pref_service_factory.h"
|
|
#include "components/prefs/segregated_pref_store.h"
|
|
#include "components/prefs/segregated_pref_store.h"
|
|
#include "components/profile_metrics/browser_profile_type.h"
|
|
#include "components/profile_metrics/browser_profile_type.h"
|
|
@@ -12,7 +12,7 @@
|
|
#include "components/url_formatter/url_fixer.h"
|
|
#include "components/url_formatter/url_fixer.h"
|
|
#include "components/user_prefs/user_prefs.h"
|
|
#include "components/user_prefs/user_prefs.h"
|
|
#include "components/visitedlink/browser/visitedlink_writer.h"
|
|
#include "components/visitedlink/browser/visitedlink_writer.h"
|
|
-@@ -474,8 +473,6 @@ void AwBrowserContext::RebuildTable(
|
|
|
|
|
|
+@@ -501,8 +500,6 @@ void AwBrowserContext::RebuildTable(
|
|
}
|
|
}
|
|
|
|
|
|
void AwBrowserContext::SetExtendedReportingAllowed(bool allowed) {
|
|
void AwBrowserContext::SetExtendedReportingAllowed(bool allowed) {
|
|
@@ -23,7 +23,7 @@
|
|
// TODO(amalova): Make sure NetworkContextParams is configured correctly when
|
|
// TODO(amalova): Make sure NetworkContextParams is configured correctly when
|
|
--- a/chrome/app/settings_strings.grdp
|
|
--- a/chrome/app/settings_strings.grdp
|
|
+++ b/chrome/app/settings_strings.grdp
|
|
+++ b/chrome/app/settings_strings.grdp
|
|
-@@ -2076,69 +2076,9 @@
|
|
|
|
|
|
+@@ -2144,69 +2144,9 @@
|
|
<message name="IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESC_COOKIES_PAGE" desc="On the cookies page, the secondary text next to the checkbox that enables prediction of network actions.">
|
|
<message name="IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESC_COOKIES_PAGE" desc="On the cookies page, the secondary text next to the checkbox that enables prediction of network actions.">
|
|
Preloads pages that Chrome thinks you might visit. To do this, Chrome may use cookies, if you allow cookies, and may encrypt and send pages through Google to hide your identity from sites.
|
|
Preloads pages that Chrome thinks you might visit. To do this, Chrome may use cookies, if you allow cookies, and may encrypt and send pages through Google to hide your identity from sites.
|
|
</message>
|
|
</message>
|
|
@@ -207,7 +207,7 @@
|
|
user_manager::KnownUser known_user(g_browser_process->local_state());
|
|
user_manager::KnownUser known_user(g_browser_process->local_state());
|
|
--- a/chrome/browser/chrome_content_browser_client.cc
|
|
--- a/chrome/browser/chrome_content_browser_client.cc
|
|
+++ b/chrome/browser/chrome_content_browser_client.cc
|
|
+++ b/chrome/browser/chrome_content_browser_client.cc
|
|
-@@ -239,7 +239,6 @@
|
|
|
|
|
|
+@@ -243,7 +243,6 @@
|
|
#include "components/safe_browsing/core/browser/realtime/url_lookup_service.h"
|
|
#include "components/safe_browsing/core/browser/realtime/url_lookup_service.h"
|
|
#include "components/safe_browsing/core/browser/url_checker_delegate.h"
|
|
#include "components/safe_browsing/core/browser/url_checker_delegate.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
@@ -227,7 +227,7 @@
|
|
#include "content/public/browser/browser_task_traits.h"
|
|
#include "content/public/browser/browser_task_traits.h"
|
|
--- a/chrome/browser/download/download_item_model.cc
|
|
--- a/chrome/browser/download/download_item_model.cc
|
|
+++ b/chrome/browser/download/download_item_model.cc
|
|
+++ b/chrome/browser/download/download_item_model.cc
|
|
-@@ -867,6 +867,7 @@ void DownloadItemModel::ExecuteCommand(D
|
|
|
|
|
|
+@@ -886,6 +886,7 @@ void DownloadItemModel::ExecuteCommand(D
|
|
DownloadUIModel::ExecuteCommand(download_commands, command);
|
|
DownloadUIModel::ExecuteCommand(download_commands, command);
|
|
break;
|
|
break;
|
|
case DownloadCommands::DEEP_SCAN:
|
|
case DownloadCommands::DEEP_SCAN:
|
|
@@ -235,7 +235,7 @@
|
|
safe_browsing::SafeBrowsingService* sb_service =
|
|
safe_browsing::SafeBrowsingService* sb_service =
|
|
g_browser_process->safe_browsing_service();
|
|
g_browser_process->safe_browsing_service();
|
|
if (!sb_service)
|
|
if (!sb_service)
|
|
-@@ -899,6 +900,7 @@ void DownloadItemModel::ExecuteCommand(D
|
|
|
|
|
|
+@@ -918,6 +919,7 @@ void DownloadItemModel::ExecuteCommand(D
|
|
safe_browsing::DeepScanningRequest::DeepScanTrigger::
|
|
safe_browsing::DeepScanningRequest::DeepScanTrigger::
|
|
TRIGGER_APP_PROMPT,
|
|
TRIGGER_APP_PROMPT,
|
|
safe_browsing::DownloadCheckResult::UNKNOWN, std::move(settings));
|
|
safe_browsing::DownloadCheckResult::UNKNOWN, std::move(settings));
|
|
@@ -245,7 +245,7 @@
|
|
}
|
|
}
|
|
--- a/chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc
|
|
--- a/chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc
|
|
+++ b/chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc
|
|
+++ b/chrome/browser/enterprise/connectors/analysis/content_analysis_delegate.cc
|
|
-@@ -41,7 +41,6 @@
|
|
|
|
|
|
+@@ -42,7 +42,6 @@
|
|
#include "components/policy/core/common/chrome_schema.h"
|
|
#include "components/policy/core/common/chrome_schema.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
@@ -263,7 +263,7 @@
|
|
#include "components/signin/public/base/consent_level.h"
|
|
#include "components/signin/public/base/consent_level.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/user_prefs/user_prefs.h"
|
|
#include "components/user_prefs/user_prefs.h"
|
|
-@@ -374,8 +373,7 @@ std::string ConnectorsService::GetManage
|
|
|
|
|
|
+@@ -376,8 +375,7 @@ std::string ConnectorsService::GetManage
|
|
|
|
|
|
absl::optional<policy::PolicyScope> scope = absl::nullopt;
|
|
absl::optional<policy::PolicyScope> scope = absl::nullopt;
|
|
for (const char* scope_pref :
|
|
for (const char* scope_pref :
|
|
@@ -273,7 +273,7 @@
|
|
ConnectorScopePref(AnalysisConnector::FILE_DOWNLOADED),
|
|
ConnectorScopePref(AnalysisConnector::FILE_DOWNLOADED),
|
|
ConnectorScopePref(AnalysisConnector::BULK_DATA_ENTRY),
|
|
ConnectorScopePref(AnalysisConnector::BULK_DATA_ENTRY),
|
|
ConnectorScopePref(AnalysisConnector::PRINT),
|
|
ConnectorScopePref(AnalysisConnector::PRINT),
|
|
-@@ -427,20 +425,6 @@ std::string ConnectorsService::GetManage
|
|
|
|
|
|
+@@ -429,20 +427,6 @@ std::string ConnectorsService::GetManage
|
|
|
|
|
|
absl::optional<std::string> ConnectorsService::GetDMTokenForRealTimeUrlCheck()
|
|
absl::optional<std::string> ConnectorsService::GetDMTokenForRealTimeUrlCheck()
|
|
const {
|
|
const {
|
|
@@ -363,7 +363,7 @@
|
|
class PolicyBlocklistService;
|
|
class PolicyBlocklistService;
|
|
--- a/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
|
|
--- a/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
|
|
+++ b/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
|
|
+++ b/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_api.cc
|
|
-@@ -99,45 +99,10 @@ api::enterprise_reporting_private::Conte
|
|
|
|
|
|
+@@ -97,45 +97,10 @@ api::enterprise_reporting_private::Conte
|
|
info.browser_version = std::move(signals.browser_version);
|
|
info.browser_version = std::move(signals.browser_version);
|
|
info.built_in_dns_client_enabled = signals.built_in_dns_client_enabled;
|
|
info.built_in_dns_client_enabled = signals.built_in_dns_client_enabled;
|
|
|
|
|
|
@@ -415,7 +415,7 @@
|
|
}
|
|
}
|
|
--- a/chrome/browser/extensions/api/identity/identity_apitest.cc
|
|
--- a/chrome/browser/extensions/api/identity/identity_apitest.cc
|
|
+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc
|
|
+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc
|
|
-@@ -57,7 +57,6 @@
|
|
|
|
|
|
+@@ -59,7 +59,6 @@
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/signin/core/browser/account_reconcilor.h"
|
|
#include "components/signin/core/browser/account_reconcilor.h"
|
|
#include "components/signin/public/base/list_accounts_test_utils.h"
|
|
#include "components/signin/public/base/list_accounts_test_utils.h"
|
|
@@ -444,7 +444,7 @@
|
|
std::string GetOAuth2MintTokenFlowVersion() {
|
|
std::string GetOAuth2MintTokenFlowVersion() {
|
|
--- a/chrome/browser/extensions/api/preference/preference_api.cc
|
|
--- a/chrome/browser/extensions/api/preference/preference_api.cc
|
|
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
|
|
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
|
|
-@@ -35,7 +35,6 @@
|
|
|
|
|
|
+@@ -34,7 +34,6 @@
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
#include "components/proxy_config/proxy_config_pref_names.h"
|
|
#include "components/proxy_config/proxy_config_pref_names.h"
|
|
@@ -452,7 +452,7 @@
|
|
#include "components/spellcheck/browser/pref_names.h"
|
|
#include "components/spellcheck/browser/pref_names.h"
|
|
#include "components/translate/core/browser/translate_pref_names.h"
|
|
#include "components/translate/core/browser/translate_pref_names.h"
|
|
#include "extensions/browser/api/content_settings/content_settings_service.h"
|
|
#include "extensions/browser/api/content_settings/content_settings_service.h"
|
|
-@@ -118,11 +117,6 @@ const PrefMappingEntry kPrefMapping[] =
|
|
|
|
|
|
+@@ -130,11 +129,6 @@ const PrefMappingEntry kPrefMapping[] =
|
|
APIPermissionID::kPrivacy},
|
|
APIPermissionID::kPrivacy},
|
|
{"doNotTrackEnabled", prefs::kEnableDoNotTrack, APIPermissionID::kPrivacy,
|
|
{"doNotTrackEnabled", prefs::kEnableDoNotTrack, APIPermissionID::kPrivacy,
|
|
APIPermissionID::kPrivacy},
|
|
APIPermissionID::kPrivacy},
|
|
@@ -464,7 +464,7 @@
|
|
{"searchSuggestEnabled", prefs::kSearchSuggestEnabled,
|
|
{"searchSuggestEnabled", prefs::kSearchSuggestEnabled,
|
|
APIPermissionID::kPrivacy, APIPermissionID::kPrivacy},
|
|
APIPermissionID::kPrivacy, APIPermissionID::kPrivacy},
|
|
{"spellingServiceEnabled", spellcheck::prefs::kSpellCheckUseSpellingService,
|
|
{"spellingServiceEnabled", spellcheck::prefs::kSpellCheckUseSpellingService,
|
|
-@@ -1059,18 +1053,6 @@ ExtensionFunction::ResponseAction SetPre
|
|
|
|
|
|
+@@ -1074,18 +1068,6 @@ ExtensionFunction::ResponseAction SetPre
|
|
base::Value(browser_pref_value->GetBool()));
|
|
base::Value(browser_pref_value->GetBool()));
|
|
}
|
|
}
|
|
|
|
|
|
@@ -483,7 +483,7 @@
|
|
base::Value val =
|
|
base::Value val =
|
|
base::Value::FromUniquePtrValue(std::move(browser_pref_value));
|
|
base::Value::FromUniquePtrValue(std::move(browser_pref_value));
|
|
|
|
|
|
-@@ -1166,17 +1148,6 @@ ExtensionFunction::ResponseAction ClearP
|
|
|
|
|
|
+@@ -1175,17 +1157,6 @@ ExtensionFunction::ResponseAction ClearP
|
|
PreferenceAPI::Get(browser_context())
|
|
PreferenceAPI::Get(browser_context())
|
|
->RemoveExtensionControlledPref(extension_id(), browser_pref, scope);
|
|
->RemoveExtensionControlledPref(extension_id(), browser_pref, scope);
|
|
|
|
|
|
@@ -557,7 +557,7 @@
|
|
#include "extensions/browser/test_event_router.h"
|
|
#include "extensions/browser/test_event_router.h"
|
|
--- a/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
|
--- a/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
|
+++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
|
+++ b/chrome/browser/extensions/api/settings_private/prefs_util.cc
|
|
-@@ -46,7 +46,6 @@
|
|
|
|
|
|
+@@ -45,7 +45,6 @@
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
#include "components/proxy_config/proxy_config_pref_names.h"
|
|
#include "components/proxy_config/proxy_config_pref_names.h"
|
|
@@ -565,7 +565,7 @@
|
|
#include "components/search_engines/default_search_manager.h"
|
|
#include "components/search_engines/default_search_manager.h"
|
|
#include "components/spellcheck/browser/pref_names.h"
|
|
#include "components/spellcheck/browser/pref_names.h"
|
|
#include "components/translate/core/browser/translate_pref_names.h"
|
|
#include "components/translate/core/browser/translate_pref_names.h"
|
|
-@@ -308,16 +307,6 @@ const PrefsUtil::TypedPrefMap& PrefsUtil
|
|
|
|
|
|
+@@ -303,16 +302,6 @@ const PrefsUtil::TypedPrefMap& PrefsUtil
|
|
settings_api::PrefType::PREF_TYPE_BOOLEAN;
|
|
settings_api::PrefType::PREF_TYPE_BOOLEAN;
|
|
|
|
|
|
// Security page
|
|
// Security page
|
|
@@ -673,14 +673,14 @@
|
|
--- a/chrome/browser/net/profile_network_context_service.cc
|
|
--- a/chrome/browser/net/profile_network_context_service.cc
|
|
+++ b/chrome/browser/net/profile_network_context_service.cc
|
|
+++ b/chrome/browser/net/profile_network_context_service.cc
|
|
@@ -52,7 +52,6 @@
|
|
@@ -52,7 +52,6 @@
|
|
- #include "components/pref_registry/pref_registry_syncable.h"
|
|
|
|
#include "components/prefs/pref_registry_simple.h"
|
|
#include "components/prefs/pref_registry_simple.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
|
|
+ #include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
-#include "components/safe_browsing/core/common/safe_browsing_prefs.h"
|
|
-#include "components/safe_browsing/core/common/safe_browsing_prefs.h"
|
|
#include "content/public/browser/browser_context.h"
|
|
#include "content/public/browser/browser_context.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
#include "content/public/browser/first_party_sets_handler.h"
|
|
#include "content/public/browser/first_party_sets_handler.h"
|
|
-@@ -865,15 +864,8 @@ void ProfileNetworkContextService::Confi
|
|
|
|
|
|
+@@ -873,15 +872,8 @@ void ProfileNetworkContextService::Confi
|
|
network_context_params->enable_certificate_reporting = true;
|
|
network_context_params->enable_certificate_reporting = true;
|
|
network_context_params->enable_expect_ct_reporting = true;
|
|
network_context_params->enable_expect_ct_reporting = true;
|
|
|
|
|
|
@@ -729,7 +729,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
TrialComparisonCertVerifierController::
|
|
TrialComparisonCertVerifierController::
|
|
-@@ -100,9 +93,7 @@ bool TrialComparisonCertVerifierControll
|
|
|
|
|
|
+@@ -93,9 +86,7 @@ bool TrialComparisonCertVerifierControll
|
|
if (!MaybeAllowedForProfile(profile_))
|
|
if (!MaybeAllowedForProfile(profile_))
|
|
return false;
|
|
return false;
|
|
|
|
|
|
@@ -870,7 +870,7 @@
|
|
}
|
|
}
|
|
--- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
|
|
--- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
|
|
+++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
|
|
+++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
|
|
-@@ -96,14 +96,11 @@
|
|
|
|
|
|
+@@ -97,14 +97,11 @@
|
|
#include "components/proxy_config/proxy_policy_handler.h"
|
|
#include "components/proxy_config/proxy_policy_handler.h"
|
|
#include "components/safe_browsing/buildflags.h"
|
|
#include "components/safe_browsing/buildflags.h"
|
|
#include "components/safe_browsing/content/common/file_type_policies_prefs.h"
|
|
#include "components/safe_browsing/content/common/file_type_policies_prefs.h"
|
|
@@ -885,7 +885,7 @@
|
|
#include "components/spellcheck/spellcheck_buildflags.h"
|
|
#include "components/spellcheck/spellcheck_buildflags.h"
|
|
#include "components/sync/base/pref_names.h"
|
|
#include "components/sync/base/pref_names.h"
|
|
#include "components/sync/driver/sync_policy_handler.h"
|
|
#include "components/sync/driver/sync_policy_handler.h"
|
|
-@@ -220,9 +217,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -221,9 +218,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
{ key::kDefaultPopupsSetting,
|
|
{ key::kDefaultPopupsSetting,
|
|
prefs::kManagedDefaultPopupsSetting,
|
|
prefs::kManagedDefaultPopupsSetting,
|
|
base::Value::Type::INTEGER },
|
|
base::Value::Type::INTEGER },
|
|
@@ -895,7 +895,7 @@
|
|
{ key::kEditBookmarksEnabled,
|
|
{ key::kEditBookmarksEnabled,
|
|
bookmarks::prefs::kEditBookmarksEnabled,
|
|
bookmarks::prefs::kEditBookmarksEnabled,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
-@@ -242,9 +236,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -243,9 +237,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
prefs::kPrintingEnabled,
|
|
prefs::kPrintingEnabled,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
#endif // BUILDFLAG(ENABLE_PRINTING)
|
|
#endif // BUILDFLAG(ENABLE_PRINTING)
|
|
@@ -905,7 +905,7 @@
|
|
{ key::kSavingBrowserHistoryDisabled,
|
|
{ key::kSavingBrowserHistoryDisabled,
|
|
prefs::kSavingBrowserHistoryDisabled,
|
|
prefs::kSavingBrowserHistoryDisabled,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
-@@ -306,9 +297,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -307,9 +298,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
{ key::kAdsSettingForIntrusiveAdsSites,
|
|
{ key::kAdsSettingForIntrusiveAdsSites,
|
|
prefs::kManagedDefaultAdsSetting,
|
|
prefs::kManagedDefaultAdsSetting,
|
|
base::Value::Type::INTEGER },
|
|
base::Value::Type::INTEGER },
|
|
@@ -915,7 +915,7 @@
|
|
{ key::kAllowCrossOriginAuthPrompt,
|
|
{ key::kAllowCrossOriginAuthPrompt,
|
|
prefs::kAllowCrossOriginAuthPrompt,
|
|
prefs::kAllowCrossOriginAuthPrompt,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
-@@ -508,15 +496,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -506,15 +494,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
{ key::kPasswordDismissCompromisedAlertEnabled,
|
|
{ key::kPasswordDismissCompromisedAlertEnabled,
|
|
password_manager::prefs::kPasswordDismissCompromisedAlertEnabled,
|
|
password_manager::prefs::kPasswordDismissCompromisedAlertEnabled,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
@@ -931,7 +931,7 @@
|
|
{ key::kPolicyRefreshRate,
|
|
{ key::kPolicyRefreshRate,
|
|
policy_prefs::kUserPolicyRefreshRate,
|
|
policy_prefs::kUserPolicyRefreshRate,
|
|
base::Value::Type::INTEGER },
|
|
base::Value::Type::INTEGER },
|
|
-@@ -555,9 +534,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -553,9 +532,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
{ key::kRestoreOnStartupURLs,
|
|
{ key::kRestoreOnStartupURLs,
|
|
prefs::kURLsToRestoreOnStartup,
|
|
prefs::kURLsToRestoreOnStartup,
|
|
base::Value::Type::LIST },
|
|
base::Value::Type::LIST },
|
|
@@ -941,7 +941,7 @@
|
|
{ key::kSafeSitesFilterBehavior,
|
|
{ key::kSafeSitesFilterBehavior,
|
|
policy_prefs::kSafeSitesFilterBehavior,
|
|
policy_prefs::kSafeSitesFilterBehavior,
|
|
base::Value::Type::INTEGER },
|
|
base::Value::Type::INTEGER },
|
|
-@@ -680,9 +656,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -678,9 +654,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
{ key::kAdditionalDnsQueryTypesEnabled,
|
|
{ key::kAdditionalDnsQueryTypesEnabled,
|
|
prefs::kAdditionalDnsQueryTypesEnabled,
|
|
prefs::kAdditionalDnsQueryTypesEnabled,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
@@ -951,7 +951,7 @@
|
|
{ key::kForceGoogleSafeSearch,
|
|
{ key::kForceGoogleSafeSearch,
|
|
prefs::kForceGoogleSafeSearch,
|
|
prefs::kForceGoogleSafeSearch,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
-@@ -1482,9 +1455,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
|
|
|
|
+@@ -1489,9 +1462,6 @@ const PolicyToPreferenceMapEntry kSimple
|
|
{ key::kIdleProfileCloseTimeout,
|
|
{ key::kIdleProfileCloseTimeout,
|
|
prefs::kIdleProfileCloseTimeout,
|
|
prefs::kIdleProfileCloseTimeout,
|
|
base::Value::Type::INTEGER },
|
|
base::Value::Type::INTEGER },
|
|
@@ -961,7 +961,7 @@
|
|
{ key::kHardwareAccelerationModeEnabled,
|
|
{ key::kHardwareAccelerationModeEnabled,
|
|
prefs::kHardwareAccelerationModeEnabled,
|
|
prefs::kHardwareAccelerationModeEnabled,
|
|
base::Value::Type::BOOLEAN },
|
|
base::Value::Type::BOOLEAN },
|
|
-@@ -1872,12 +1842,6 @@ std::unique_ptr<ConfigurationPolicyHandl
|
|
|
|
|
|
+@@ -1898,12 +1868,6 @@ std::unique_ptr<ConfigurationPolicyHandl
|
|
SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED,
|
|
SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED,
|
|
SimpleSchemaValidatingPolicyHandler::MANDATORY_ALLOWED));
|
|
SimpleSchemaValidatingPolicyHandler::MANDATORY_ALLOWED));
|
|
|
|
|
|
@@ -974,7 +974,7 @@
|
|
|
|
|
|
handlers->AddHandler(
|
|
handlers->AddHandler(
|
|
std::make_unique<ManagedAccountRestrictionsPolicyHandler>(chrome_schema));
|
|
std::make_unique<ManagedAccountRestrictionsPolicyHandler>(chrome_schema));
|
|
-@@ -2052,24 +2016,6 @@ std::unique_ptr<ConfigurationPolicyHandl
|
|
|
|
|
|
+@@ -2084,24 +2048,6 @@ std::unique_ptr<ConfigurationPolicyHandl
|
|
#else // BUILDFLAG(IS_CHROMEOS)
|
|
#else // BUILDFLAG(IS_CHROMEOS)
|
|
std::vector<std::unique_ptr<ConfigurationPolicyHandler>>
|
|
std::vector<std::unique_ptr<ConfigurationPolicyHandler>>
|
|
signin_legacy_policies;
|
|
signin_legacy_policies;
|
|
@@ -1001,7 +1001,7 @@
|
|
std::make_unique<BrowserSigninPolicyHandler>(chrome_schema)));
|
|
std::make_unique<BrowserSigninPolicyHandler>(chrome_schema)));
|
|
--- a/chrome/browser/prefs/browser_prefs.cc
|
|
--- a/chrome/browser/prefs/browser_prefs.cc
|
|
+++ b/chrome/browser/prefs/browser_prefs.cc
|
|
+++ b/chrome/browser/prefs/browser_prefs.cc
|
|
-@@ -133,7 +133,6 @@
|
|
|
|
|
|
+@@ -135,7 +135,6 @@
|
|
#include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_prefs.h"
|
|
#include "components/proxy_config/pref_proxy_config_tracker_impl.h"
|
|
#include "components/proxy_config/pref_proxy_config_tracker_impl.h"
|
|
#include "components/safe_browsing/content/common/file_type_policies_prefs.h"
|
|
#include "components/safe_browsing/content/common/file_type_policies_prefs.h"
|
|
@@ -1009,7 +1009,7 @@
|
|
#include "components/search_engines/template_url_prepopulate_data.h"
|
|
#include "components/search_engines/template_url_prepopulate_data.h"
|
|
#include "components/security_interstitials/content/insecure_form_blocking_page.h"
|
|
#include "components/security_interstitials/content/insecure_form_blocking_page.h"
|
|
#include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h"
|
|
#include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h"
|
|
-@@ -1064,7 +1063,6 @@ void RegisterLocalState(PrefRegistrySimp
|
|
|
|
|
|
+@@ -1035,7 +1034,6 @@ void RegisterLocalState(PrefRegistrySimp
|
|
PushMessagingServiceImpl::RegisterPrefs(registry);
|
|
PushMessagingServiceImpl::RegisterPrefs(registry);
|
|
#endif
|
|
#endif
|
|
RegisterScreenshotPrefs(registry);
|
|
RegisterScreenshotPrefs(registry);
|
|
@@ -1017,7 +1017,7 @@
|
|
secure_origin_allowlist::RegisterPrefs(registry);
|
|
secure_origin_allowlist::RegisterPrefs(registry);
|
|
segmentation_platform::SegmentationPlatformService::RegisterLocalStatePrefs(
|
|
segmentation_platform::SegmentationPlatformService::RegisterLocalStatePrefs(
|
|
registry);
|
|
registry);
|
|
-@@ -1320,8 +1318,6 @@ void RegisterProfilePrefs(user_prefs::Pr
|
|
|
|
|
|
+@@ -1293,8 +1291,6 @@ void RegisterProfilePrefs(user_prefs::Pr
|
|
PushMessagingAppIdentifier::RegisterProfilePrefs(registry);
|
|
PushMessagingAppIdentifier::RegisterProfilePrefs(registry);
|
|
QuietNotificationPermissionUiState::RegisterProfilePrefs(registry);
|
|
QuietNotificationPermissionUiState::RegisterProfilePrefs(registry);
|
|
RegisterBrowserUserPrefs(registry);
|
|
RegisterBrowserUserPrefs(registry);
|
|
@@ -1178,22 +1178,22 @@
|
|
params.account_id.GetAccountIdKey());
|
|
params.account_id.GetAccountIdKey());
|
|
- info.SetBoolKey(prefs::kSignedInWithCredentialProvider,
|
|
- info.SetBoolKey(prefs::kSignedInWithCredentialProvider,
|
|
- params.is_signed_in_with_credential_provider);
|
|
- params.is_signed_in_with_credential_provider);
|
|
- attributes->SetKey(key, std::move(info));
|
|
|
|
|
|
+ attributes.Set(key, std::move(info));
|
|
|
|
|
|
ProfileAttributesEntry* entry = InitEntryWithKey(key, params.is_omitted);
|
|
ProfileAttributesEntry* entry = InitEntryWithKey(key, params.is_omitted);
|
|
--- a/chrome/browser/profiles/profile_impl.cc
|
|
--- a/chrome/browser/profiles/profile_impl.cc
|
|
+++ b/chrome/browser/profiles/profile_impl.cc
|
|
+++ b/chrome/browser/profiles/profile_impl.cc
|
|
-@@ -148,7 +148,6 @@
|
|
|
|
|
|
+@@ -145,7 +145,6 @@
|
|
|
|
+ #include "components/prefs/scoped_user_pref_update.h"
|
|
#include "components/profile_metrics/browser_profile_type.h"
|
|
#include "components/profile_metrics/browser_profile_type.h"
|
|
#include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h"
|
|
#include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h"
|
|
- #include "components/services/screen_ai/buildflags/buildflags.h"
|
|
|
|
-#include "components/signin/public/base/signin_pref_names.h"
|
|
-#include "components/signin/public/base/signin_pref_names.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/site_isolation/site_isolation_policy.h"
|
|
#include "components/site_isolation/site_isolation_policy.h"
|
|
#include "components/spellcheck/spellcheck_buildflags.h"
|
|
#include "components/spellcheck/spellcheck_buildflags.h"
|
|
--- a/chrome/browser/profiles/profile_manager.cc
|
|
--- a/chrome/browser/profiles/profile_manager.cc
|
|
+++ b/chrome/browser/profiles/profile_manager.cc
|
|
+++ b/chrome/browser/profiles/profile_manager.cc
|
|
-@@ -93,7 +93,6 @@
|
|
|
|
|
|
+@@ -94,7 +94,6 @@
|
|
#include "components/signin/public/base/consent_level.h"
|
|
#include "components/signin/public/base/consent_level.h"
|
|
#include "components/signin/public/base/signin_buildflags.h"
|
|
#include "components/signin/public/base/signin_buildflags.h"
|
|
#include "components/signin/public/base/signin_metrics.h"
|
|
#include "components/signin/public/base/signin_metrics.h"
|
|
@@ -1201,7 +1201,7 @@
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/primary_account_mutator.h"
|
|
#include "components/signin/public/identity_manager/primary_account_mutator.h"
|
|
#include "components/sync/base/stop_source.h"
|
|
#include "components/sync/base/stop_source.h"
|
|
-@@ -2256,8 +2255,7 @@ void ProfileManager::AddProfileToStorage
|
|
|
|
|
|
+@@ -2268,8 +2267,7 @@ void ProfileManager::AddProfileToStorage
|
|
entry->SetAuthInfo(account_info.gaia, username,
|
|
entry->SetAuthInfo(account_info.gaia, username,
|
|
is_consented_primary_account);
|
|
is_consented_primary_account);
|
|
|
|
|
|
@@ -1211,9 +1211,9 @@
|
|
|
|
|
|
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS_ASH)
|
|
// Sign out if force-sign-in policy is enabled and profile is not signed
|
|
// Sign out if force-sign-in policy is enabled and profile is not signed
|
|
-@@ -2312,14 +2310,13 @@ void ProfileManager::AddProfileToStorage
|
|
|
|
|
|
+@@ -2324,14 +2322,13 @@ void ProfileManager::AddProfileToStorage
|
|
|
|
|
|
- init_params.is_ephemeral = IsEphemeral(profile);
|
|
|
|
|
|
+ init_params.is_ephemeral = IsForceEphemeralProfilesEnabled(profile);
|
|
init_params.is_signed_in_with_credential_provider =
|
|
init_params.is_signed_in_with_credential_provider =
|
|
- profile->GetPrefs()->GetBoolean(prefs::kSignedInWithCredentialProvider);
|
|
- profile->GetPrefs()->GetBoolean(prefs::kSignedInWithCredentialProvider);
|
|
+ false;
|
|
+ false;
|
|
@@ -1264,7 +1264,7 @@
|
|
</cr-dialog>
|
|
</cr-dialog>
|
|
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
|
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
|
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
|
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
|
|
-@@ -583,7 +583,7 @@
|
|
|
|
|
|
+@@ -576,7 +576,7 @@
|
|
</category-setting-exceptions>
|
|
</category-setting-exceptions>
|
|
</settings-subpage>
|
|
</settings-subpage>
|
|
</template>
|
|
</template>
|
|
@@ -1275,7 +1275,7 @@
|
|
<settings-subpage page-title="$i18n{siteSettingsAds}"
|
|
<settings-subpage page-title="$i18n{siteSettingsAds}"
|
|
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
|
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
|
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
|
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.ts
|
|
-@@ -98,7 +98,7 @@ export class SettingsPrivacyPageElement
|
|
|
|
|
|
+@@ -97,7 +97,7 @@ export class SettingsPrivacyPageElement
|
|
enableSafeBrowsingSubresourceFilter_: {
|
|
enableSafeBrowsingSubresourceFilter_: {
|
|
type: Boolean,
|
|
type: Boolean,
|
|
value() {
|
|
value() {
|
|
@@ -1403,7 +1403,7 @@
|
|
- </template>
|
|
- </template>
|
|
--- a/chrome/browser/resources/settings/privacy_page/security_page.ts
|
|
--- a/chrome/browser/resources/settings/privacy_page/security_page.ts
|
|
+++ b/chrome/browser/resources/settings/privacy_page/security_page.ts
|
|
+++ b/chrome/browser/resources/settings/privacy_page/security_page.ts
|
|
-@@ -216,17 +216,6 @@ export class SettingsSecurityPageElement
|
|
|
|
|
|
+@@ -219,20 +219,6 @@ export class SettingsSecurityPageElement
|
|
|
|
|
|
override ready() {
|
|
override ready() {
|
|
super.ready();
|
|
super.ready();
|
|
@@ -1418,10 +1418,13 @@
|
|
- this.$.safeBrowsingStandard.expanded = true;
|
|
- this.$.safeBrowsingStandard.expanded = true;
|
|
- }
|
|
- }
|
|
- });
|
|
- });
|
|
|
|
+-
|
|
|
|
+- this.registerHelpBubbleIdentifier(
|
|
|
|
+- 'kEnhancedProtectionSettingElementId', 'safeBrowsingEnhanced');
|
|
}
|
|
}
|
|
|
|
|
|
/**
|
|
/**
|
|
-@@ -275,8 +264,7 @@ export class SettingsSecurityPageElement
|
|
|
|
|
|
+@@ -281,8 +267,7 @@ export class SettingsSecurityPageElement
|
|
}
|
|
}
|
|
|
|
|
|
private getDisabledExtendedSafeBrowsing_(): boolean {
|
|
private getDisabledExtendedSafeBrowsing_(): boolean {
|
|
@@ -1557,7 +1560,7 @@
|
|
namespace safe_browsing {
|
|
namespace safe_browsing {
|
|
--- a/chrome/browser/safe_browsing/chrome_password_protection_service.cc
|
|
--- a/chrome/browser/safe_browsing/chrome_password_protection_service.cc
|
|
+++ b/chrome/browser/safe_browsing/chrome_password_protection_service.cc
|
|
+++ b/chrome/browser/safe_browsing/chrome_password_protection_service.cc
|
|
-@@ -65,7 +65,6 @@
|
|
|
|
|
|
+@@ -66,7 +66,6 @@
|
|
#include "components/safe_browsing/core/browser/verdict_cache_manager.h"
|
|
#include "components/safe_browsing/core/browser/verdict_cache_manager.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
#include "components/safe_browsing/core/common/proto/csd.pb.h"
|
|
#include "components/safe_browsing/core/common/proto/csd.pb.h"
|
|
@@ -1635,7 +1638,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
RequestOutcome ChromePasswordProtectionService::GetPingNotSentReason(
|
|
RequestOutcome ChromePasswordProtectionService::GetPingNotSentReason(
|
|
-@@ -1672,22 +1626,6 @@ MaybeCreateCommitDeferringCondition(
|
|
|
|
|
|
+@@ -1671,22 +1625,6 @@ MaybeCreateCommitDeferringCondition(
|
|
: nullptr;
|
|
: nullptr;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -2082,7 +2085,7 @@
|
|
#include "content/public/browser/download_item_utils.h"
|
|
#include "content/public/browser/download_item_utils.h"
|
|
--- a/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
|
|
--- a/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
|
|
+++ b/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
|
|
+++ b/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
|
|
-@@ -21,7 +21,6 @@
|
|
|
|
|
|
+@@ -22,7 +22,6 @@
|
|
#include "components/safe_browsing/core/browser/db/database_manager.h"
|
|
#include "components/safe_browsing/core/browser/db/database_manager.h"
|
|
#include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h"
|
|
#include "components/safe_browsing/core/browser/db/v4_protocol_manager_util.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
@@ -2488,7 +2491,7 @@
|
|
#include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h"
|
|
#include "components/security_interstitials/content/stateful_ssl_host_state_delegate.h"
|
|
--- a/chrome/browser/supervised_user/supervised_user_pref_store.cc
|
|
--- a/chrome/browser/supervised_user/supervised_user_pref_store.cc
|
|
+++ b/chrome/browser/supervised_user/supervised_user_pref_store.cc
|
|
+++ b/chrome/browser/supervised_user/supervised_user_pref_store.cc
|
|
-@@ -25,7 +25,6 @@
|
|
|
|
|
|
+@@ -27,7 +27,6 @@
|
|
#include "chrome/common/pref_names.h"
|
|
#include "chrome/common/pref_names.h"
|
|
#include "components/feed/core/shared_prefs/pref_names.h"
|
|
#include "components/feed/core/shared_prefs/pref_names.h"
|
|
#include "components/prefs/pref_value_map.h"
|
|
#include "components/prefs/pref_value_map.h"
|
|
@@ -2496,7 +2499,7 @@
|
|
#include "components/signin/public/base/signin_switches.h"
|
|
#include "components/signin/public/base/signin_switches.h"
|
|
#include "extensions/buildflags/buildflags.h"
|
|
#include "extensions/buildflags/buildflags.h"
|
|
|
|
|
|
-@@ -58,10 +57,6 @@ SupervisedUserSettingsPrefMappingEntry k
|
|
|
|
|
|
+@@ -60,10 +59,6 @@ SupervisedUserSettingsPrefMappingEntry k
|
|
prefs::kSupervisedUserSafeSites,
|
|
prefs::kSupervisedUserSafeSites,
|
|
},
|
|
},
|
|
{
|
|
{
|
|
@@ -2507,7 +2510,7 @@
|
|
supervised_users::kUserName,
|
|
supervised_users::kUserName,
|
|
prefs::kProfileName,
|
|
prefs::kProfileName,
|
|
},
|
|
},
|
|
-@@ -126,7 +121,6 @@ void SupervisedUserPrefStore::OnNewSetti
|
|
|
|
|
|
+@@ -128,7 +123,6 @@ void SupervisedUserPrefStore::OnNewSetti
|
|
prefs_->SetInteger(prefs::kForceYouTubeRestrict,
|
|
prefs_->SetInteger(prefs::kForceYouTubeRestrict,
|
|
safe_search_util::YOUTUBE_RESTRICT_MODERATE);
|
|
safe_search_util::YOUTUBE_RESTRICT_MODERATE);
|
|
prefs_->SetBoolean(prefs::kHideWebStoreIcon, false);
|
|
prefs_->SetBoolean(prefs::kHideWebStoreIcon, false);
|
|
@@ -2546,7 +2549,7 @@
|
|
|
|
|
|
InitCommandState();
|
|
InitCommandState();
|
|
|
|
|
|
-@@ -1628,7 +1623,7 @@ void BrowserCommandController::UpdateSho
|
|
|
|
|
|
+@@ -1629,7 +1624,7 @@ void BrowserCommandController::UpdateSho
|
|
return;
|
|
return;
|
|
|
|
|
|
command_updater_.UpdateCommandEnabled(
|
|
command_updater_.UpdateCommandEnabled(
|
|
@@ -2585,7 +2588,7 @@
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#endif
|
|
#endif
|
|
|
|
|
|
-@@ -593,13 +592,7 @@ void ShowBrowserSignin(Browser* browser,
|
|
|
|
|
|
+@@ -592,13 +591,7 @@ void ShowBrowserSignin(Browser* browser,
|
|
|
|
|
|
void ShowBrowserSigninOrSettings(Browser* browser,
|
|
void ShowBrowserSigninOrSettings(Browser* browser,
|
|
signin_metrics::AccessPoint access_point) {
|
|
signin_metrics::AccessPoint access_point) {
|
|
@@ -2747,7 +2750,7 @@
|
|
#include "components/user_education/common/tutorial_identifier.h"
|
|
#include "components/user_education/common/tutorial_identifier.h"
|
|
#include "components/user_education/common/tutorial_service.h"
|
|
#include "components/user_education/common/tutorial_service.h"
|
|
#include "ui/base/interaction/element_identifier.h"
|
|
#include "ui/base/interaction/element_identifier.h"
|
|
-@@ -70,13 +69,6 @@ void BrowserCommandHandler::CanExecuteCo
|
|
|
|
|
|
+@@ -71,13 +70,6 @@ void BrowserCommandHandler::CanExecuteCo
|
|
case Command::kOpenSafetyCheck:
|
|
case Command::kOpenSafetyCheck:
|
|
can_execute = !chrome::enterprise_util::IsBrowserManaged(profile_);
|
|
can_execute = !chrome::enterprise_util::IsBrowserManaged(profile_);
|
|
break;
|
|
break;
|
|
@@ -2875,7 +2878,7 @@
|
|
#include "content/public/browser/storage_partition.h"
|
|
#include "content/public/browser/storage_partition.h"
|
|
--- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
|
--- a/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
|
+++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
|
+++ b/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
|
|
-@@ -67,7 +67,6 @@
|
|
|
|
|
|
+@@ -69,7 +69,6 @@
|
|
#include "components/password_manager/core/common/password_manager_features.h"
|
|
#include "components/password_manager/core/common/password_manager_features.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_features.h"
|
|
#include "components/privacy_sandbox/privacy_sandbox_features.h"
|
|
@@ -2883,7 +2886,7 @@
|
|
#include "components/signin/public/base/signin_buildflags.h"
|
|
#include "components/signin/public/base/signin_buildflags.h"
|
|
#include "components/strings/grit/components_chromium_strings.h"
|
|
#include "components/strings/grit/components_chromium_strings.h"
|
|
#include "components/strings/grit/components_strings.h"
|
|
#include "components/strings/grit/components_strings.h"
|
|
-@@ -1518,44 +1517,6 @@ void AddPrivacyStrings(content::WebUIDat
|
|
|
|
|
|
+@@ -1577,44 +1576,6 @@ void AddPrivacyStrings(content::WebUIDat
|
|
{"clearBrowsingData", IDS_SETTINGS_CLEAR_BROWSING_DATA},
|
|
{"clearBrowsingData", IDS_SETTINGS_CLEAR_BROWSING_DATA},
|
|
{"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION},
|
|
{"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION},
|
|
{"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT},
|
|
{"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT},
|
|
@@ -2928,7 +2931,7 @@
|
|
{"safeBrowsingSectionLabel", IDS_SETTINGS_SAFEBROWSING_SECTION_LABEL},
|
|
{"safeBrowsingSectionLabel", IDS_SETTINGS_SAFEBROWSING_SECTION_LABEL},
|
|
{"syncAndGoogleServicesPrivacyDescription",
|
|
{"syncAndGoogleServicesPrivacyDescription",
|
|
IDS_SETTINGS_SYNC_AND_GOOGLE_SERVICES_PRIVACY_DESC_UNIFIED_CONSENT},
|
|
IDS_SETTINGS_SYNC_AND_GOOGLE_SERVICES_PRIVACY_DESC_UNIFIED_CONSENT},
|
|
-@@ -2935,11 +2896,6 @@ void AddSiteSettingsStrings(content::Web
|
|
|
|
|
|
+@@ -2927,11 +2888,6 @@ void AddSiteSettingsStrings(content::Web
|
|
html_source->AddLocalizedStrings(kSensorsLocalizedStrings);
|
|
html_source->AddLocalizedStrings(kSensorsLocalizedStrings);
|
|
|
|
|
|
html_source->AddBoolean(
|
|
html_source->AddBoolean(
|
|
@@ -2947,10 +2950,10 @@
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
#include "components/safe_browsing/core/common/features.h"
|
|
-#include "components/signin/public/base/signin_pref_names.h"
|
|
-#include "components/signin/public/base/signin_pref_names.h"
|
|
|
|
+ #include "components/sync/base/features.h"
|
|
#include "content/public/browser/url_data_source.h"
|
|
#include "content/public/browser/url_data_source.h"
|
|
#include "content/public/browser/web_contents.h"
|
|
#include "content/public/browser/web_contents.h"
|
|
- #include "content/public/browser/web_ui.h"
|
|
|
|
-@@ -272,9 +271,7 @@ SettingsUI::SettingsUI(content::WebUI* w
|
|
|
|
|
|
+@@ -274,9 +273,7 @@ SettingsUI::SettingsUI(content::WebUI* w
|
|
std::make_unique<IncompatibleApplicationsHandler>());
|
|
std::make_unique<IncompatibleApplicationsHandler>());
|
|
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
|
|
#endif // BUILDFLAG(IS_WIN) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
|
|
|
|
|
|
@@ -2982,7 +2985,7 @@
|
|
default_email.clear();
|
|
default_email.clear();
|
|
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
|
|
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
|
|
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
|
|
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
|
|
-@@ -67,7 +67,6 @@
|
|
|
|
|
|
+@@ -68,7 +68,6 @@
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/signin/core/browser/about_signin_internals.h"
|
|
#include "components/signin/core/browser/about_signin_internals.h"
|
|
#include "components/signin/public/base/signin_metrics.h"
|
|
#include "components/signin/public/base/signin_metrics.h"
|
|
@@ -3051,7 +3054,7 @@
|
|
}
|
|
}
|
|
--- a/chrome/browser/ui/webui/signin/turn_sync_on_helper.cc
|
|
--- a/chrome/browser/ui/webui/signin/turn_sync_on_helper.cc
|
|
+++ b/chrome/browser/ui/webui/signin/turn_sync_on_helper.cc
|
|
+++ b/chrome/browser/ui/webui/signin/turn_sync_on_helper.cc
|
|
-@@ -43,7 +43,6 @@
|
|
|
|
|
|
+@@ -42,7 +42,6 @@
|
|
#include "components/policy/core/common/management/management_service.h"
|
|
#include "components/policy/core/common/management/management_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/signin/public/base/signin_metrics.h"
|
|
#include "components/signin/public/base/signin_metrics.h"
|
|
@@ -3059,7 +3062,7 @@
|
|
#include "components/signin/public/identity_manager/accounts_mutator.h"
|
|
#include "components/signin/public/identity_manager/accounts_mutator.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/identity_manager.h"
|
|
#include "components/signin/public/identity_manager/primary_account_mutator.h"
|
|
#include "components/signin/public/identity_manager/primary_account_mutator.h"
|
|
-@@ -235,8 +234,7 @@ TurnSyncOnHelper::TurnSyncOnHelper(
|
|
|
|
|
|
+@@ -266,8 +265,7 @@ void TurnSyncOnHelper::TurnSyncOnInterna
|
|
// last authenticated account of the current profile, then Chrome will show a
|
|
// last authenticated account of the current profile, then Chrome will show a
|
|
// confirmation dialog before starting sync.
|
|
// confirmation dialog before starting sync.
|
|
// TODO(skym): Warn for high risk upgrade scenario (https://crbug.com/572754).
|
|
// TODO(skym): Warn for high risk upgrade scenario (https://crbug.com/572754).
|
|
@@ -3145,10 +3148,10 @@
|
|
#include "services/network/public/cpp/shared_url_loader_factory.h"
|
|
#include "services/network/public/cpp/shared_url_loader_factory.h"
|
|
|
|
|
|
namespace password_manager {
|
|
namespace password_manager {
|
|
-@@ -175,28 +174,7 @@ void LeakDetectionDelegate::OnError(Leak
|
|
|
|
|
|
+@@ -174,28 +173,7 @@ void LeakDetectionDelegate::OnError(Leak
|
|
|
|
|
|
bool CanStartLeakCheck(const PrefService& prefs,
|
|
bool CanStartLeakCheck(const PrefService& prefs,
|
|
- const PasswordManagerClient* client) {
|
|
|
|
|
|
+ PasswordManagerClient* client) {
|
|
- const bool is_leak_protection_on =
|
|
- const bool is_leak_protection_on =
|
|
- prefs.GetBoolean(password_manager::prefs::kPasswordLeakDetectionEnabled);
|
|
- prefs.GetBoolean(password_manager::prefs::kPasswordLeakDetectionEnabled);
|
|
-
|
|
-
|
|
@@ -3452,7 +3455,7 @@
|
|
#include "content/public/browser/global_routing_id.h"
|
|
#include "content/public/browser/global_routing_id.h"
|
|
#include "services/network/public/mojom/cookie_manager.mojom.h"
|
|
#include "services/network/public/mojom/cookie_manager.mojom.h"
|
|
#if BUILDFLAG(FULL_SAFE_BROWSING)
|
|
#if BUILDFLAG(FULL_SAFE_BROWSING)
|
|
-@@ -1378,17 +1377,7 @@ std::string SerializeHitReport(const Hit
|
|
|
|
|
|
+@@ -1488,17 +1487,7 @@ std::string SerializeHitReport(const Hit
|
|
}
|
|
}
|
|
hit_report_dict.Set("threat_source", threat_source);
|
|
hit_report_dict.Set("threat_source", threat_source);
|
|
std::string extended_reporting_level;
|
|
std::string extended_reporting_level;
|
|
@@ -3470,7 +3473,7 @@
|
|
hit_report_dict.Set("extended_reporting_level", extended_reporting_level);
|
|
hit_report_dict.Set("extended_reporting_level", extended_reporting_level);
|
|
hit_report_dict.Set("is_enhanced_protection",
|
|
hit_report_dict.Set("is_enhanced_protection",
|
|
hit_report.is_enhanced_protection);
|
|
hit_report.is_enhanced_protection);
|
|
-@@ -2267,18 +2256,13 @@ void SafeBrowsingUIHandler::GetPrefs(con
|
|
|
|
|
|
+@@ -2377,18 +2366,13 @@ void SafeBrowsingUIHandler::GetPrefs(con
|
|
AllowJavascript();
|
|
AllowJavascript();
|
|
DCHECK(!args.empty());
|
|
DCHECK(!args.empty());
|
|
std::string callback_id = args[0].GetString();
|
|
std::string callback_id = args[0].GetString();
|
|
@@ -3520,7 +3523,7 @@
|
|
|
|
|
|
--- a/components/safe_browsing/core/browser/db/v4_local_database_manager.cc
|
|
--- a/components/safe_browsing/core/browser/db/v4_local_database_manager.cc
|
|
+++ b/components/safe_browsing/core/browser/db/v4_local_database_manager.cc
|
|
+++ b/components/safe_browsing/core/browser/db/v4_local_database_manager.cc
|
|
-@@ -333,10 +333,9 @@ const V4LocalDatabaseManager*
|
|
|
|
|
|
+@@ -335,10 +335,9 @@ const V4LocalDatabaseManager*
|
|
scoped_refptr<V4LocalDatabaseManager> V4LocalDatabaseManager::Create(
|
|
scoped_refptr<V4LocalDatabaseManager> V4LocalDatabaseManager::Create(
|
|
const base::FilePath& base_path,
|
|
const base::FilePath& base_path,
|
|
scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
|
|
scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
|
|
@@ -3533,7 +3536,7 @@
|
|
std::move(io_task_runner), nullptr));
|
|
std::move(io_task_runner), nullptr));
|
|
}
|
|
}
|
|
|
|
|
|
-@@ -359,14 +358,12 @@ void V4LocalDatabaseManager::CollectData
|
|
|
|
|
|
+@@ -361,14 +360,12 @@ void V4LocalDatabaseManager::CollectData
|
|
|
|
|
|
V4LocalDatabaseManager::V4LocalDatabaseManager(
|
|
V4LocalDatabaseManager::V4LocalDatabaseManager(
|
|
const base::FilePath& base_path,
|
|
const base::FilePath& base_path,
|
|
@@ -3548,7 +3551,7 @@
|
|
list_infos_(GetListInfos()),
|
|
list_infos_(GetListInfos()),
|
|
task_runner_(task_runner_for_tests
|
|
task_runner_(task_runner_for_tests
|
|
? task_runner_for_tests
|
|
? task_runner_for_tests
|
|
-@@ -1116,8 +1113,7 @@ void V4LocalDatabaseManager::SetupUpdate
|
|
|
|
|
|
+@@ -1129,8 +1126,7 @@ void V4LocalDatabaseManager::SetupUpdate
|
|
weak_factory_.GetWeakPtr());
|
|
weak_factory_.GetWeakPtr());
|
|
|
|
|
|
v4_update_protocol_manager_ = V4UpdateProtocolManager::Create(
|
|
v4_update_protocol_manager_ = V4UpdateProtocolManager::Create(
|
|
@@ -3578,7 +3581,7 @@
|
|
scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
|
|
scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
|
|
scoped_refptr<base::SequencedTaskRunner> io_task_runner,
|
|
scoped_refptr<base::SequencedTaskRunner> io_task_runner,
|
|
scoped_refptr<base::SequencedTaskRunner> task_runner_for_tests);
|
|
scoped_refptr<base::SequencedTaskRunner> task_runner_for_tests);
|
|
-@@ -368,10 +366,6 @@ class V4LocalDatabaseManager : public Sa
|
|
|
|
|
|
+@@ -395,10 +393,6 @@ class V4LocalDatabaseManager : public Sa
|
|
// ready to process next update.
|
|
// ready to process next update.
|
|
DatabaseUpdatedCallback db_updated_callback_;
|
|
DatabaseUpdatedCallback db_updated_callback_;
|
|
|
|
|
|
@@ -3812,7 +3815,7 @@
|
|
switch (hit_report.threat_type) {
|
|
switch (hit_report.threat_type) {
|
|
--- a/components/safe_browsing/core/browser/realtime/policy_engine.cc
|
|
--- a/components/safe_browsing/core/browser/realtime/policy_engine.cc
|
|
+++ b/components/safe_browsing/core/browser/realtime/policy_engine.cc
|
|
+++ b/components/safe_browsing/core/browser/realtime/policy_engine.cc
|
|
-@@ -8,7 +8,6 @@
|
|
|
|
|
|
+@@ -9,7 +9,6 @@
|
|
#include "base/metrics/histogram_macros.h"
|
|
#include "base/metrics/histogram_macros.h"
|
|
#include "build/build_config.h"
|
|
#include "build/build_config.h"
|
|
#include "components/prefs/pref_service.h"
|
|
#include "components/prefs/pref_service.h"
|
|
@@ -3820,7 +3823,7 @@
|
|
#include "components/safe_browsing/core/common/utils.h"
|
|
#include "components/safe_browsing/core/common/utils.h"
|
|
#include "components/unified_consent/pref_names.h"
|
|
#include "components/unified_consent/pref_names.h"
|
|
#include "components/user_prefs/user_prefs.h"
|
|
#include "components/user_prefs/user_prefs.h"
|
|
-@@ -36,7 +35,7 @@ bool RealTimePolicyEngine::IsUserMbbOpte
|
|
|
|
|
|
+@@ -54,7 +53,7 @@ bool RealTimePolicyEngine::IsUserMbbOpte
|
|
|
|
|
|
// static
|
|
// static
|
|
bool RealTimePolicyEngine::IsUserEpOptedIn(PrefService* pref_service) {
|
|
bool RealTimePolicyEngine::IsUserEpOptedIn(PrefService* pref_service) {
|
|
@@ -3829,13 +3832,19 @@
|
|
}
|
|
}
|
|
|
|
|
|
// static
|
|
// static
|
|
-@@ -82,9 +81,7 @@ bool RealTimePolicyEngine::CanPerformEnt
|
|
|
|
|
|
+@@ -107,15 +106,7 @@ bool RealTimePolicyEngine::CanPerformEnt
|
|
return false;
|
|
return false;
|
|
}
|
|
}
|
|
|
|
|
|
-- return pref_service->GetInteger(
|
|
|
|
-- prefs::kSafeBrowsingEnterpriseRealTimeUrlCheckMode) ==
|
|
|
|
-- REAL_TIME_CHECK_FOR_MAINFRAME_ENABLED;
|
|
|
|
|
|
+- if (pref_service->GetInteger(
|
|
|
|
+- prefs::kSafeBrowsingEnterpriseRealTimeUrlCheckMode) !=
|
|
|
|
+- REAL_TIME_CHECK_FOR_MAINFRAME_ENABLED) {
|
|
|
|
+- base::UmaHistogramEnumeration("SafeBrowsing.RT.ConsumerVersionReason",
|
|
|
|
+- ConsumerVersionReason::POLICY_DISABLED);
|
|
|
|
+- return false;
|
|
|
|
+- }
|
|
|
|
+-
|
|
|
|
+- return true;
|
|
+ return false;
|
|
+ return false;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -3948,7 +3957,7 @@
|
|
ScheduleNextLoggingAfterInterval(base::Days(kMetricsLoggingIntervalDay));
|
|
ScheduleNextLoggingAfterInterval(base::Days(kMetricsLoggingIntervalDay));
|
|
}
|
|
}
|
|
|
|
|
|
-@@ -103,87 +83,16 @@ void SafeBrowsingMetricsCollector::Sched
|
|
|
|
|
|
+@@ -103,88 +83,16 @@ void SafeBrowsingMetricsCollector::Sched
|
|
}
|
|
}
|
|
|
|
|
|
void SafeBrowsingMetricsCollector::LogDailyOptInMetrics() {
|
|
void SafeBrowsingMetricsCollector::LogDailyOptInMetrics() {
|
|
@@ -4004,17 +4013,18 @@
|
|
}
|
|
}
|
|
|
|
|
|
void SafeBrowsingMetricsCollector::RemoveOldEventsFromPref() {
|
|
void SafeBrowsingMetricsCollector::RemoveOldEventsFromPref() {
|
|
-- DictionaryPrefUpdate update(pref_service_,
|
|
|
|
|
|
+- ScopedDictPrefUpdate update(pref_service_,
|
|
- prefs::kSafeBrowsingEventTimestamps);
|
|
- prefs::kSafeBrowsingEventTimestamps);
|
|
-- base::Value::Dict* mutable_state_dict = update->GetIfDict();
|
|
|
|
-- bool is_pref_valid = !!mutable_state_dict;
|
|
|
|
-- base::UmaHistogramBoolean("SafeBrowsing.MetricsCollector.IsPrefValid",
|
|
|
|
-- is_pref_valid);
|
|
|
|
-- if (!is_pref_valid) {
|
|
|
|
-- return;
|
|
|
|
-- }
|
|
|
|
|
|
+- base::Value::Dict& mutable_state_dict = update.Get();
|
|
-
|
|
-
|
|
-- for (auto state_map : *mutable_state_dict) {
|
|
|
|
|
|
+- // Histogram to check whether prefs::kSafeBrowsingEventTimestamp is a dict.
|
|
|
|
+- // Prefs DCHECKs if it's the wrong type, or not registered, so this is not
|
|
|
|
+- // actually needed.
|
|
|
|
+- //
|
|
|
|
+- // TODO(mmenke): Remove this histogram.
|
|
|
|
+- base::UmaHistogramBoolean("SafeBrowsing.MetricsCollector.IsPrefValid", true);
|
|
|
|
+-
|
|
|
|
+- for (auto state_map : mutable_state_dict) {
|
|
- for (auto event_map : state_map.second.GetDict()) {
|
|
- for (auto event_map : state_map.second.GetDict()) {
|
|
- event_map.second.GetList().EraseIf([&](const auto& timestamp) {
|
|
- event_map.second.GetList().EraseIf([&](const auto& timestamp) {
|
|
- return base::Time::Now() - PrefValueToTime(timestamp) >
|
|
- return base::Time::Now() - PrefValueToTime(timestamp) >
|
|
@@ -4036,7 +4046,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
void SafeBrowsingMetricsCollector::AddBypassEventToPref(
|
|
void SafeBrowsingMetricsCollector::AddBypassEventToPref(
|
|
-@@ -220,15 +129,7 @@ absl::optional<base::Time>
|
|
|
|
|
|
+@@ -221,15 +129,7 @@ absl::optional<base::Time>
|
|
SafeBrowsingMetricsCollector::GetLatestEventTimestamp(
|
|
SafeBrowsingMetricsCollector::GetLatestEventTimestamp(
|
|
EventTypeFilter event_type_filter) {
|
|
EventTypeFilter event_type_filter) {
|
|
// Events are not logged when Safe Browsing is disabled.
|
|
// Events are not logged when Safe Browsing is disabled.
|
|
@@ -4052,13 +4062,13 @@
|
|
}
|
|
}
|
|
|
|
|
|
absl::optional<base::Time>
|
|
absl::optional<base::Time>
|
|
-@@ -240,45 +141,15 @@ SafeBrowsingMetricsCollector::GetLatestS
|
|
|
|
|
|
+@@ -241,45 +141,15 @@ SafeBrowsingMetricsCollector::GetLatestS
|
|
void SafeBrowsingMetricsCollector::AddSafeBrowsingEventAndUserStateToPref(
|
|
void SafeBrowsingMetricsCollector::AddSafeBrowsingEventAndUserStateToPref(
|
|
UserState user_state,
|
|
UserState user_state,
|
|
EventType event_type) {
|
|
EventType event_type) {
|
|
-- DictionaryPrefUpdate update(pref_service_,
|
|
|
|
|
|
+- ScopedDictPrefUpdate update(pref_service_,
|
|
- prefs::kSafeBrowsingEventTimestamps);
|
|
- prefs::kSafeBrowsingEventTimestamps);
|
|
-- base::Value::Dict& mutable_state_dict = update->GetDict();
|
|
|
|
|
|
+- base::Value::Dict& mutable_state_dict = update.Get();
|
|
- base::Value::Dict* event_dict =
|
|
- base::Value::Dict* event_dict =
|
|
- mutable_state_dict.EnsureDict(UserStateToPrefKey(user_state));
|
|
- mutable_state_dict.EnsureDict(UserStateToPrefKey(user_state));
|
|
- base::Value::List* timestamps =
|
|
- base::Value::List* timestamps =
|
|
@@ -4099,7 +4109,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
absl::optional<SafeBrowsingMetricsCollector::Event>
|
|
absl::optional<SafeBrowsingMetricsCollector::Event>
|
|
-@@ -440,20 +311,7 @@ int SafeBrowsingMetricsCollector::GetEve
|
|
|
|
|
|
+@@ -441,20 +311,7 @@ int SafeBrowsingMetricsCollector::GetEve
|
|
}
|
|
}
|
|
|
|
|
|
UserState SafeBrowsingMetricsCollector::GetUserState() {
|
|
UserState SafeBrowsingMetricsCollector::GetUserState() {
|
|
@@ -4147,7 +4157,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
TailoredSecurityService::~TailoredSecurityService() {
|
|
TailoredSecurityService::~TailoredSecurityService() {
|
|
-@@ -406,20 +396,6 @@ void TailoredSecurityService::MaybeNotif
|
|
|
|
|
|
+@@ -406,24 +396,6 @@ void TailoredSecurityService::MaybeNotif
|
|
return;
|
|
return;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -4157,13 +4167,17 @@
|
|
- }
|
|
- }
|
|
-
|
|
-
|
|
- if (is_enabled && !IsEnhancedProtectionEnabled(*prefs())) {
|
|
- if (is_enabled && !IsEnhancedProtectionEnabled(*prefs())) {
|
|
-- ShowSyncNotification(true);
|
|
|
|
|
|
+- for (auto& observer : observer_list_) {
|
|
|
|
+- observer.OnSyncNotificationMessageRequest(true);
|
|
|
|
+- }
|
|
- }
|
|
- }
|
|
-
|
|
-
|
|
- if (!is_enabled && IsEnhancedProtectionEnabled(*prefs()) &&
|
|
- if (!is_enabled && IsEnhancedProtectionEnabled(*prefs()) &&
|
|
- prefs()->GetBoolean(
|
|
- prefs()->GetBoolean(
|
|
- prefs::kEnhancedProtectionEnabledViaTailoredSecurity)) {
|
|
- prefs::kEnhancedProtectionEnabledViaTailoredSecurity)) {
|
|
-- ShowSyncNotification(false);
|
|
|
|
|
|
+- for (auto& observer : observer_list_) {
|
|
|
|
+- observer.OnSyncNotificationMessageRequest(false);
|
|
|
|
+- }
|
|
- }
|
|
- }
|
|
}
|
|
}
|
|
|
|
|
|
@@ -4649,7 +4663,7 @@
|
|
} else if (currently_authenticated && !previously_authenticated_) {
|
|
} else if (currently_authenticated && !previously_authenticated_) {
|
|
SignedInAccountRelationReport(signed_in_accounts, signed_out_accounts,
|
|
SignedInAccountRelationReport(signed_in_accounts, signed_out_accounts,
|
|
ReportingType::ON_CHANGE);
|
|
ReportingType::ON_CHANGE);
|
|
-@@ -247,10 +230,6 @@ void AccountInvestigator::DoPeriodicRepo
|
|
|
|
|
|
+@@ -246,10 +229,6 @@ void AccountInvestigator::DoPeriodicRepo
|
|
}
|
|
}
|
|
|
|
|
|
periodic_pending_ = false;
|
|
periodic_pending_ = false;
|
|
@@ -4660,7 +4674,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
void AccountInvestigator::SharedCookieJarReport(
|
|
void AccountInvestigator::SharedCookieJarReport(
|
|
-@@ -258,8 +237,7 @@ void AccountInvestigator::SharedCookieJa
|
|
|
|
|
|
+@@ -257,8 +236,7 @@ void AccountInvestigator::SharedCookieJa
|
|
const std::vector<ListedAccount>& signed_out_accounts,
|
|
const std::vector<ListedAccount>& signed_out_accounts,
|
|
const Time now,
|
|
const Time now,
|
|
const ReportingType type) {
|
|
const ReportingType type) {
|
|
@@ -4738,7 +4752,7 @@
|
|
}
|
|
}
|
|
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
|
|
#endif // BUILDFLAG(IS_CHROMEOS_ASH)
|
|
|
|
|
|
-@@ -552,27 +544,6 @@ void AccountTrackerService::OnAccountIma
|
|
|
|
|
|
+@@ -552,26 +544,6 @@ void AccountTrackerService::OnAccountIma
|
|
const CoreAccountId& account_id,
|
|
const CoreAccountId& account_id,
|
|
const std::string& image_url_with_size,
|
|
const std::string& image_url_with_size,
|
|
bool success) {
|
|
bool success) {
|
|
@@ -4746,9 +4760,8 @@
|
|
- return;
|
|
- return;
|
|
-
|
|
-
|
|
- base::Value::Dict* dict = nullptr;
|
|
- base::Value::Dict* dict = nullptr;
|
|
-- ListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
-- base::Value::List& list = update->GetList();
|
|
|
|
-- for (base::Value& value : list) {
|
|
|
|
|
|
+- ScopedListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
+- for (base::Value& value : *update) {
|
|
- base::Value::Dict* maybe_dict = value.GetIfDict();
|
|
- base::Value::Dict* maybe_dict = value.GetIfDict();
|
|
- if (maybe_dict) {
|
|
- if (maybe_dict) {
|
|
- const std::string* account_key = maybe_dict->FindString(kAccountKeyKey);
|
|
- const std::string* account_key = maybe_dict->FindString(kAccountKeyKey);
|
|
@@ -4766,7 +4779,7 @@
|
|
}
|
|
}
|
|
|
|
|
|
void AccountTrackerService::RemoveAccountImageFromDisk(
|
|
void AccountTrackerService::RemoveAccountImageFromDisk(
|
|
-@@ -584,177 +555,16 @@ void AccountTrackerService::RemoveAccoun
|
|
|
|
|
|
+@@ -583,176 +555,16 @@ void AccountTrackerService::RemoveAccoun
|
|
}
|
|
}
|
|
|
|
|
|
void AccountTrackerService::LoadFromPrefs() {
|
|
void AccountTrackerService::LoadFromPrefs() {
|
|
@@ -4803,8 +4816,8 @@
|
|
- ? signin::Tribool::kTrue
|
|
- ? signin::Tribool::kTrue
|
|
- : signin::Tribool::kFalse;
|
|
- : signin::Tribool::kFalse;
|
|
- // Migrate to kAccountChildAttributeKey.
|
|
- // Migrate to kAccountChildAttributeKey.
|
|
-- ListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
-- base::Value::Dict& update_dict = update->GetList()[i].GetDict();
|
|
|
|
|
|
+- ScopedListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
+- base::Value::Dict& update_dict = (*update)[i].GetDict();
|
|
- update_dict.Set(kAccountChildAttributeKey,
|
|
- update_dict.Set(kAccountChildAttributeKey,
|
|
- static_cast<int>(account_info.is_child_account));
|
|
- static_cast<int>(account_info.is_child_account));
|
|
- update_dict.Remove(kDeprecatedChildStatusKey);
|
|
- update_dict.Remove(kDeprecatedChildStatusKey);
|
|
@@ -4824,8 +4837,8 @@
|
|
- dict->FindIntByDottedPath(
|
|
- dict->FindIntByDottedPath(
|
|
- kDeprecatedCanOfferExtendedChromeSyncPromosPrefPath)) {
|
|
- kDeprecatedCanOfferExtendedChromeSyncPromosPrefPath)) {
|
|
- // Migrate to Capability names based pref paths.
|
|
- // Migrate to Capability names based pref paths.
|
|
-- ListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
-- base::Value::Dict& update_dict = update->GetList()[i].GetDict();
|
|
|
|
|
|
+- ScopedListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
+- base::Value::Dict& update_dict = (*update)[i].GetDict();
|
|
- SetAccountCapabilityState(
|
|
- SetAccountCapabilityState(
|
|
- update_dict, kCanOfferExtendedChromeSyncPromosCapabilityName,
|
|
- update_dict, kCanOfferExtendedChromeSyncPromosCapabilityName,
|
|
- ParseTribool(can_offer_extended_chrome_sync_promos));
|
|
- ParseTribool(can_offer_extended_chrome_sync_promos));
|
|
@@ -4888,9 +4901,8 @@
|
|
- return;
|
|
- return;
|
|
-
|
|
-
|
|
- base::Value::Dict* dict = nullptr;
|
|
- base::Value::Dict* dict = nullptr;
|
|
-- ListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
-- base::Value::List& list = update->GetList();
|
|
|
|
-- for (base::Value& value : list) {
|
|
|
|
|
|
+- ScopedListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
+- for (base::Value& value : *update) {
|
|
- base::Value::Dict* maybe_dict = value.GetIfDict();
|
|
- base::Value::Dict* maybe_dict = value.GetIfDict();
|
|
- if (maybe_dict) {
|
|
- if (maybe_dict) {
|
|
- const std::string* account_key = maybe_dict->FindString(kAccountKeyKey);
|
|
- const std::string* account_key = maybe_dict->FindString(kAccountKeyKey);
|
|
@@ -4902,8 +4914,8 @@
|
|
- }
|
|
- }
|
|
-
|
|
-
|
|
- if (!dict) {
|
|
- if (!dict) {
|
|
-- list.Append(base::Value::Dict());
|
|
|
|
-- dict = &list.back().GetDict();
|
|
|
|
|
|
+- update->Append(base::Value::Dict());
|
|
|
|
+- dict = &update->back().GetDict();
|
|
- dict->Set(kAccountKeyKey, account_info.account_id.ToString());
|
|
- dict->Set(kAccountKeyKey, account_info.account_id.ToString());
|
|
- }
|
|
- }
|
|
-
|
|
-
|
|
@@ -4933,9 +4945,9 @@
|
|
if (!pref_service_)
|
|
if (!pref_service_)
|
|
return;
|
|
return;
|
|
|
|
|
|
-- ListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
|
|
|
|
+- ScopedListPrefUpdate update(pref_service_, prefs::kAccountInfo);
|
|
const std::string account_id = account_info.account_id.ToString();
|
|
const std::string account_id = account_info.account_id.ToString();
|
|
-- update->GetList().EraseIf([&account_id](const base::Value& value) {
|
|
|
|
|
|
+- update->EraseIf([&account_id](const base::Value& value) {
|
|
- if (!value.is_dict())
|
|
- if (!value.is_dict())
|
|
- return false;
|
|
- return false;
|
|
- const std::string* account_key = value.GetDict().FindString(kAccountKeyKey);
|
|
- const std::string* account_key = value.GetDict().FindString(kAccountKeyKey);
|
|
@@ -5359,7 +5371,7 @@
|
|
#include "components/signin/public/identity_manager/identity_test_utils.h"
|
|
#include "components/signin/public/identity_manager/identity_test_utils.h"
|
|
--- a/tools/metrics/histograms/enums.xml
|
|
--- a/tools/metrics/histograms/enums.xml
|
|
+++ b/tools/metrics/histograms/enums.xml
|
|
+++ b/tools/metrics/histograms/enums.xml
|
|
-@@ -97060,7 +97060,6 @@ Full version information for the fingerp
|
|
|
|
|
|
+@@ -97846,7 +97846,6 @@ Full version information for the fingerp
|
|
<int value="3" label="kRestoreOnStartup"/>
|
|
<int value="3" label="kRestoreOnStartup"/>
|
|
<int value="4" label="kURLsToRestoreOnStartup"/>
|
|
<int value="4" label="kURLsToRestoreOnStartup"/>
|
|
<int value="5" label="extensions::pref_names::kExtensions"/>
|
|
<int value="5" label="extensions::pref_names::kExtensions"/>
|
|
@@ -5367,7 +5379,7 @@
|
|
<int value="7" label="kSearchProviderOverrides"/>
|
|
<int value="7" label="kSearchProviderOverrides"/>
|
|
<int value="8" label="kDefaultSearchProviderSearchURL (Obsolete 12/2016)"/>
|
|
<int value="8" label="kDefaultSearchProviderSearchURL (Obsolete 12/2016)"/>
|
|
<int value="9" label="kDefaultSearchProviderKeyword (Obsolete 12/2016)"/>
|
|
<int value="9" label="kDefaultSearchProviderKeyword (Obsolete 12/2016)"/>
|
|
-@@ -97075,10 +97074,7 @@ Full version information for the fingerp
|
|
|
|
|
|
+@@ -97861,10 +97860,7 @@ Full version information for the fingerp
|
|
<int value="18" label="kSafeBrowsingIncidentsSent"/>
|
|
<int value="18" label="kSafeBrowsingIncidentsSent"/>
|
|
<int value="19" label="kSwReporterPromptVersion"/>
|
|
<int value="19" label="kSwReporterPromptVersion"/>
|
|
<int value="20" label="kSwReporterPromptReason"/>
|
|
<int value="20" label="kSwReporterPromptReason"/>
|