071-v4.7-0003-net-bgmac-Remove-superflous-netif_carrier_on.patch 963 B

12345678910111213141516171819202122232425262728
  1. From 3894396e64994f31c3ef5c7e6f63dded0593e567 Mon Sep 17 00:00:00 2001
  2. From: Florian Fainelli <f.fainelli@gmail.com>
  3. Date: Thu, 23 Jun 2016 14:25:33 -0700
  4. Subject: [PATCH 3/3] net: bgmac: Remove superflous netif_carrier_on()
  5. bgmac_open() calls phy_start() to initialize the PHY state machine,
  6. which will set the interface's carrier state accordingly, no need to
  7. force that as this could be conflicting with the PHY state determined by
  8. PHYLIB.
  9. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")
  10. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
  11. Signed-off-by: David S. Miller <davem@davemloft.net>
  12. ---
  13. drivers/net/ethernet/broadcom/bgmac.c | 2 --
  14. 1 file changed, 2 deletions(-)
  15. --- a/drivers/net/ethernet/broadcom/bgmac.c
  16. +++ b/drivers/net/ethernet/broadcom/bgmac.c
  17. @@ -1326,8 +1326,6 @@ static int bgmac_open(struct net_device
  18. phy_start(net_dev->phydev);
  19. - netif_carrier_on(net_dev);
  20. -
  21. netif_start_queue(net_dev);
  22. return 0;