0064-wifi-ath11k-add-peer-mac-information-in-failure-case.patch 2.8 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374
  1. From 20487cc3ff36bbfa9505f0a078ba98f09abfc717 Mon Sep 17 00:00:00 2001
  2. From: Harshitha Prem <quic_hprem@quicinc.com>
  3. Date: Mon, 17 Apr 2023 13:35:01 +0300
  4. Subject: [PATCH] wifi: ath11k: add peer mac information in failure cases
  5. During reo command failure, the peer mac detail for which the reo
  6. command was not successful is unknown. Hence, to improve the
  7. debuggability, add the peer mac information in the failure cases
  8. which would be useful during multi client cases.
  9. Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
  10. Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
  11. Signed-off-by: Sathishkumar Muruganandam <quic_murugana@quicinc.com>
  12. Signed-off-by: Harshitha Prem <quic_hprem@quicinc.com>
  13. Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
  14. Link: https://lore.kernel.org/r/20230403182420.23375-4-quic_hprem@quicinc.com
  15. ---
  16. drivers/net/wireless/ath/ath11k/dp_rx.c | 16 ++++++++++------
  17. 1 file changed, 10 insertions(+), 6 deletions(-)
  18. --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
  19. +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
  20. @@ -1009,7 +1009,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
  21. peer = ath11k_peer_find(ab, vdev_id, peer_mac);
  22. if (!peer) {
  23. - ath11k_warn(ab, "failed to find the peer to set up rx tid\n");
  24. + ath11k_warn(ab, "failed to find the peer %pM to set up rx tid\n",
  25. + peer_mac);
  26. spin_unlock_bh(&ab->base_lock);
  27. return -ENOENT;
  28. }
  29. @@ -1022,7 +1023,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
  30. ba_win_sz, ssn, true);
  31. spin_unlock_bh(&ab->base_lock);
  32. if (ret) {
  33. - ath11k_warn(ab, "failed to update reo for rx tid %d\n", tid);
  34. + ath11k_warn(ab, "failed to update reo for peer %pM rx tid %d\n: %d",
  35. + peer_mac, tid, ret);
  36. return ret;
  37. }
  38. @@ -1030,8 +1032,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
  39. peer_mac, paddr,
  40. tid, 1, ba_win_sz);
  41. if (ret)
  42. - ath11k_warn(ab, "failed to send wmi command to update rx reorder queue, tid :%d (%d)\n",
  43. - tid, ret);
  44. + ath11k_warn(ab, "failed to send wmi rx reorder queue for peer %pM tid %d: %d\n",
  45. + peer_mac, tid, ret);
  46. return ret;
  47. }
  48. @@ -1064,6 +1066,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
  49. ret = dma_mapping_error(ab->dev, paddr);
  50. if (ret) {
  51. spin_unlock_bh(&ab->base_lock);
  52. + ath11k_warn(ab, "failed to setup dma map for peer %pM rx tid %d: %d\n",
  53. + peer_mac, tid, ret);
  54. goto err_mem_free;
  55. }
  56. @@ -1077,8 +1081,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
  57. ret = ath11k_wmi_peer_rx_reorder_queue_setup(ar, vdev_id, peer_mac,
  58. paddr, tid, 1, ba_win_sz);
  59. if (ret) {
  60. - ath11k_warn(ar->ab, "failed to setup rx reorder queue, tid :%d (%d)\n",
  61. - tid, ret);
  62. + ath11k_warn(ar->ab, "failed to setup rx reorder queue for peer %pM tid %d: %d\n",
  63. + peer_mac, tid, ret);
  64. ath11k_dp_rx_tid_mem_free(ab, peer_mac, vdev_id, tid);
  65. }