1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374 |
- From 20487cc3ff36bbfa9505f0a078ba98f09abfc717 Mon Sep 17 00:00:00 2001
- From: Harshitha Prem <quic_hprem@quicinc.com>
- Date: Mon, 17 Apr 2023 13:35:01 +0300
- Subject: [PATCH] wifi: ath11k: add peer mac information in failure cases
- During reo command failure, the peer mac detail for which the reo
- command was not successful is unknown. Hence, to improve the
- debuggability, add the peer mac information in the failure cases
- which would be useful during multi client cases.
- Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
- Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
- Signed-off-by: Sathishkumar Muruganandam <quic_murugana@quicinc.com>
- Signed-off-by: Harshitha Prem <quic_hprem@quicinc.com>
- Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
- Link: https://lore.kernel.org/r/20230403182420.23375-4-quic_hprem@quicinc.com
- ---
- drivers/net/wireless/ath/ath11k/dp_rx.c | 16 ++++++++++------
- 1 file changed, 10 insertions(+), 6 deletions(-)
- --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
- +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
- @@ -1009,7 +1009,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
-
- peer = ath11k_peer_find(ab, vdev_id, peer_mac);
- if (!peer) {
- - ath11k_warn(ab, "failed to find the peer to set up rx tid\n");
- + ath11k_warn(ab, "failed to find the peer %pM to set up rx tid\n",
- + peer_mac);
- spin_unlock_bh(&ab->base_lock);
- return -ENOENT;
- }
- @@ -1022,7 +1023,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
- ba_win_sz, ssn, true);
- spin_unlock_bh(&ab->base_lock);
- if (ret) {
- - ath11k_warn(ab, "failed to update reo for rx tid %d\n", tid);
- + ath11k_warn(ab, "failed to update reo for peer %pM rx tid %d\n: %d",
- + peer_mac, tid, ret);
- return ret;
- }
-
- @@ -1030,8 +1032,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
- peer_mac, paddr,
- tid, 1, ba_win_sz);
- if (ret)
- - ath11k_warn(ab, "failed to send wmi command to update rx reorder queue, tid :%d (%d)\n",
- - tid, ret);
- + ath11k_warn(ab, "failed to send wmi rx reorder queue for peer %pM tid %d: %d\n",
- + peer_mac, tid, ret);
- return ret;
- }
-
- @@ -1064,6 +1066,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
- ret = dma_mapping_error(ab->dev, paddr);
- if (ret) {
- spin_unlock_bh(&ab->base_lock);
- + ath11k_warn(ab, "failed to setup dma map for peer %pM rx tid %d: %d\n",
- + peer_mac, tid, ret);
- goto err_mem_free;
- }
-
- @@ -1077,8 +1081,8 @@ int ath11k_peer_rx_tid_setup(struct ath1
- ret = ath11k_wmi_peer_rx_reorder_queue_setup(ar, vdev_id, peer_mac,
- paddr, tid, 1, ba_win_sz);
- if (ret) {
- - ath11k_warn(ar->ab, "failed to setup rx reorder queue, tid :%d (%d)\n",
- - tid, ret);
- + ath11k_warn(ar->ab, "failed to setup rx reorder queue for peer %pM tid %d: %d\n",
- + peer_mac, tid, ret);
- ath11k_dp_rx_tid_mem_free(ab, peer_mac, vdev_id, tid);
- }
-
|