101-arm-cns3xxx-use-actual-size-reads-for-PCIe.patch 1.9 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546
  1. From 4cc30de79d293f1e8c5f50ae3a9c005def9564a0 Mon Sep 17 00:00:00 2001
  2. From: Koen Vandeputte <koen.vandeputte@ncentric.com>
  3. Date: Mon, 7 Jan 2019 14:14:27 +0100
  4. Subject: [PATCH 2/2] arm: cns3xxx: use actual size reads for PCIe
  5. commit 802b7c06adc7 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
  6. reimplemented cns3xxx_pci_read_config() using pci_generic_config_read32(),
  7. which preserved the property of only doing 32-bit reads.
  8. It also replaced cns3xxx_pci_write_config() with pci_generic_config_write(),
  9. so it changed writes from always being 32 bits to being the actual size,
  10. which works just fine.
  11. Due to:
  12. - The documentation does not mention that only 32 bit access is allowed.
  13. - Writes are already executed using the actual size
  14. - Extensive testing shows that 8b, 16b and 32b reads work as intended
  15. It makes perfectly sense to also swap 32 bit reading in favor of actual size.
  16. Fixes: 802b7c06adc7 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
  17. Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
  18. Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
  19. CC: Arnd Bergmann <arnd@arndb.de>
  20. CC: Krzysztof Halasa <khalasa@piap.pl>
  21. CC: Olof Johansson <olof@lixom.net>
  22. CC: Robin Leblon <robin.leblon@ncentric.com>
  23. CC: Rob Herring <robh@kernel.org>
  24. CC: Russell King <linux@armlinux.org.uk>
  25. CC: Tim Harvey <tharvey@gateworks.com>
  26. CC: stable@vger.kernel.org # v4.0+
  27. ---
  28. arch/arm/mach-cns3xxx/pcie.c | 2 +-
  29. 1 file changed, 1 insertion(+), 1 deletion(-)
  30. --- a/arch/arm/mach-cns3xxx/pcie.c
  31. +++ b/arch/arm/mach-cns3xxx/pcie.c
  32. @@ -93,7 +93,7 @@ static int cns3xxx_pci_read_config(struc
  33. u32 mask = (0x1ull << (size * 8)) - 1;
  34. int shift = (where % 4) * 8;
  35. - ret = pci_generic_config_read32(bus, devfn, where, size, val);
  36. + ret = pci_generic_config_read(bus, devfn, where, size, val);
  37. if (ret == PCIBIOS_SUCCESSFUL && !bus->number && !devfn &&
  38. (where & 0xffc) == PCI_CLASS_REVISION)