302-v4.16-netfilter-nf_tables_inet-don-t-use-multihook-infrast.patch 4.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161
  1. From: Pablo Neira Ayuso <pablo@netfilter.org>
  2. Date: Sat, 9 Dec 2017 15:36:24 +0100
  3. Subject: [PATCH] netfilter: nf_tables_inet: don't use multihook infrastructure
  4. anymore
  5. Use new native NFPROTO_INET support in netfilter core, this gets rid of
  6. ad-hoc code in the nf_tables API codebase.
  7. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  8. ---
  9. --- a/include/net/netfilter/nf_tables_ipv4.h
  10. +++ b/include/net/netfilter/nf_tables_ipv4.h
  11. @@ -53,6 +53,4 @@ static inline void nft_set_pktinfo_ipv4_
  12. nft_set_pktinfo_unspec(pkt, skb);
  13. }
  14. -extern struct nft_af_info nft_af_ipv4;
  15. -
  16. #endif
  17. --- a/include/net/netfilter/nf_tables_ipv6.h
  18. +++ b/include/net/netfilter/nf_tables_ipv6.h
  19. @@ -69,6 +69,4 @@ static inline void nft_set_pktinfo_ipv6_
  20. nft_set_pktinfo_unspec(pkt, skb);
  21. }
  22. -extern struct nft_af_info nft_af_ipv6;
  23. -
  24. #endif
  25. --- a/net/ipv4/netfilter/nf_tables_ipv4.c
  26. +++ b/net/ipv4/netfilter/nf_tables_ipv4.c
  27. @@ -45,7 +45,7 @@ static unsigned int nft_ipv4_output(void
  28. return nft_do_chain_ipv4(priv, skb, state);
  29. }
  30. -struct nft_af_info nft_af_ipv4 __read_mostly = {
  31. +static struct nft_af_info nft_af_ipv4 __read_mostly = {
  32. .family = NFPROTO_IPV4,
  33. .nhooks = NF_INET_NUMHOOKS,
  34. .owner = THIS_MODULE,
  35. @@ -58,7 +58,6 @@ struct nft_af_info nft_af_ipv4 __read_mo
  36. [NF_INET_POST_ROUTING] = nft_do_chain_ipv4,
  37. },
  38. };
  39. -EXPORT_SYMBOL_GPL(nft_af_ipv4);
  40. static int nf_tables_ipv4_init_net(struct net *net)
  41. {
  42. --- a/net/ipv6/netfilter/nf_tables_ipv6.c
  43. +++ b/net/ipv6/netfilter/nf_tables_ipv6.c
  44. @@ -42,7 +42,7 @@ static unsigned int nft_ipv6_output(void
  45. return nft_do_chain_ipv6(priv, skb, state);
  46. }
  47. -struct nft_af_info nft_af_ipv6 __read_mostly = {
  48. +static struct nft_af_info nft_af_ipv6 __read_mostly = {
  49. .family = NFPROTO_IPV6,
  50. .nhooks = NF_INET_NUMHOOKS,
  51. .owner = THIS_MODULE,
  52. @@ -55,7 +55,6 @@ struct nft_af_info nft_af_ipv6 __read_mo
  53. [NF_INET_POST_ROUTING] = nft_do_chain_ipv6,
  54. },
  55. };
  56. -EXPORT_SYMBOL_GPL(nft_af_ipv6);
  57. static int nf_tables_ipv6_init_net(struct net *net)
  58. {
  59. --- a/net/netfilter/nf_tables_inet.c
  60. +++ b/net/netfilter/nf_tables_inet.c
  61. @@ -9,6 +9,7 @@
  62. #include <linux/init.h>
  63. #include <linux/module.h>
  64. #include <linux/ip.h>
  65. +#include <linux/ipv6.h>
  66. #include <linux/netfilter_ipv4.h>
  67. #include <linux/netfilter_ipv6.h>
  68. #include <net/netfilter/nf_tables.h>
  69. @@ -16,26 +17,71 @@
  70. #include <net/netfilter/nf_tables_ipv6.h>
  71. #include <net/ip.h>
  72. -static void nft_inet_hook_ops_init(struct nf_hook_ops *ops, unsigned int n)
  73. +static unsigned int nft_do_chain_inet(void *priv, struct sk_buff *skb,
  74. + const struct nf_hook_state *state)
  75. {
  76. - struct nft_af_info *afi;
  77. + struct nft_pktinfo pkt;
  78. - if (n == 1)
  79. - afi = &nft_af_ipv4;
  80. - else
  81. - afi = &nft_af_ipv6;
  82. -
  83. - ops->pf = afi->family;
  84. - if (afi->hooks[ops->hooknum])
  85. - ops->hook = afi->hooks[ops->hooknum];
  86. + nft_set_pktinfo(&pkt, skb, state);
  87. +
  88. + switch (state->pf) {
  89. + case NFPROTO_IPV4:
  90. + nft_set_pktinfo_ipv4(&pkt, skb);
  91. + break;
  92. + case NFPROTO_IPV6:
  93. + nft_set_pktinfo_ipv6(&pkt, skb);
  94. + break;
  95. + default:
  96. + break;
  97. + }
  98. +
  99. + return nft_do_chain(&pkt, priv);
  100. +}
  101. +
  102. +static unsigned int nft_inet_output(void *priv, struct sk_buff *skb,
  103. + const struct nf_hook_state *state)
  104. +{
  105. + struct nft_pktinfo pkt;
  106. +
  107. + nft_set_pktinfo(&pkt, skb, state);
  108. +
  109. + switch (state->pf) {
  110. + case NFPROTO_IPV4:
  111. + if (unlikely(skb->len < sizeof(struct iphdr) ||
  112. + ip_hdr(skb)->ihl < sizeof(struct iphdr) / 4)) {
  113. + if (net_ratelimit())
  114. + pr_info("ignoring short SOCK_RAW packet\n");
  115. + return NF_ACCEPT;
  116. + }
  117. + nft_set_pktinfo_ipv4(&pkt, skb);
  118. + break;
  119. + case NFPROTO_IPV6:
  120. + if (unlikely(skb->len < sizeof(struct ipv6hdr))) {
  121. + if (net_ratelimit())
  122. + pr_info("ignoring short SOCK_RAW packet\n");
  123. + return NF_ACCEPT;
  124. + }
  125. + nft_set_pktinfo_ipv6(&pkt, skb);
  126. + break;
  127. + default:
  128. + break;
  129. + }
  130. +
  131. + return nft_do_chain(&pkt, priv);
  132. }
  133. static struct nft_af_info nft_af_inet __read_mostly = {
  134. .family = NFPROTO_INET,
  135. .nhooks = NF_INET_NUMHOOKS,
  136. .owner = THIS_MODULE,
  137. - .nops = 2,
  138. - .hook_ops_init = nft_inet_hook_ops_init,
  139. + .nops = 1,
  140. + .hooks = {
  141. + [NF_INET_LOCAL_IN] = nft_do_chain_inet,
  142. + [NF_INET_LOCAL_OUT] = nft_inet_output,
  143. + [NF_INET_FORWARD] = nft_do_chain_inet,
  144. + [NF_INET_PRE_ROUTING] = nft_do_chain_inet,
  145. + [NF_INET_POST_ROUTING] = nft_do_chain_inet,
  146. + },
  147. };
  148. static int __net_init nf_tables_inet_init_net(struct net *net)