Broken (?) Git prereq test

My system:

christopher@eowyn

OS: Guix System a7dbd38859 x86_64 Host: Vostro 230 00 Kernel: 5.4.32-gnu Uptime: 5 days, 1 hour, 57 mins Packages: 57 (guix-system), 86 (guix-user) Shell: bash 5.0.7 Resolution: 1920x1200 DE: GNOME Theme: Adwaita [GTK2/3] Icons: Adwaita [GTK2/3] Terminal: .gnome-terminal CPU: Intel Core 2 Duo E7500 (2) @ 2.596GHz GPU: Intel 4 Series Chipset Memory: 3824MiB / 7929MiB

Attempting to build commit 00f213da7e from lts branch.

Using Guix build environment as follows, based on Guix commit

christopher@eowyn ~/Build/librecmc-lts$ guix describe Generation 15 Apr 17 2020 07:30:36 (current) guix a7dbd38

repository URL: https://git.savannah.gnu.org/git/guix.git
branch: master
commit: a7dbd38859ebb174e5d757645ba80bdc8048bee8

guix environment --pure --ad-hoc gcc-toolchain perl make git coreutils grep sed bash which pkg-config binutils ncurses wget tar patch diffutils unzip bzip2 findutils gawk gengetopt python2 python file util-linux nss-certs gzip

Git install is as follows:

christopher@eowyn ~/Build/librecmc-lts [env]$ git --version git version 2.26.1 christopher@eowyn ~/Build/librecmc-lts [env]$ which git /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/bin/git christopher@eowyn ~/Build/librecmc-lts [env]$ git --exec-path /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core christopher@eowyn ~/Build/librecmc-lts [env]$ ls /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core/git-submodule /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core/git-submodule

PATH environment is as follows:

christopher@eowyn ~/Build/librecmc-lts [env]$ env | grep git GIT_EXEC_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core christopher@eowyn ~/Build/librecmc-lts [env]$ env | grep -i path PKG_CONFIG_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib/pkgconfig BASH_LOADABLES_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib/bash GIT_EXEC_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core PYTHONPATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib/python2.7/site-packages LIBRARY_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib GUIX_LOCPATH=/home/christopher/.guix-profile/lib/locale PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/bin:/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/sbin CPATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/include

First command I run is "make -j1 V=sc menuconfig", which fails on check for git:

''' christopher@eowyn ~/Build/librecmc-lts [env]$ make -j1 V=sc menuconfig Checking 'working-make'... ok. Checking 'case-sensitive-fs'... ok. Checking 'proper-umask'... ok. Checking 'gcc'... ok. Checking 'python'... ok. Checking 'git'... failed. Checking 'file'... ok. Prerequisite check failed. Use FORCE=1 to override. '''

Using FORCE=1 does seem to bypass that check, but leaves open the question of why the check failed. Check code is hard to understand, from include/prereq-build:

''' $(eval $(call SetupHostCommand,git,Please install Git (git-core) >= 1.7.12.2,

git --exec-path | xargs -I % -- grep -q -- --recursive %/git-submodule))

'''

christopher@eowyn ~/Build/librecmc-lts [env]$ git --exec-path | xargs -I % -- grep -q -- --recursive %/git-submodule christopher@eowyn ~/Build/librecmc-lts [env]$ echo $? 123 christopher@eowyn ~/Build/librecmc-lts [env]$ git --exec-path /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core

Delete the check from prereq-build.mk also works. Would suggest different check code but not sure how check is suppose to work or what it is aiming to check for exactly.

My system: christopher@eowyn ----------------- OS: Guix System a7dbd38859ebb174e5d757645ba80bdc8048bee8 x86_64 Host: Vostro 230 00 Kernel: 5.4.32-gnu Uptime: 5 days, 1 hour, 57 mins Packages: 57 (guix-system), 86 (guix-user) Shell: bash 5.0.7 Resolution: 1920x1200 DE: GNOME Theme: Adwaita [GTK2/3] Icons: Adwaita [GTK2/3] Terminal: .gnome-terminal CPU: Intel Core 2 Duo E7500 (2) @ 2.596GHz GPU: Intel 4 Series Chipset Memory: 3824MiB / 7929MiB Attempting to build commit 00f213da7ea5294d5aa967442639e5cd94ee4b9f from lts branch. Using Guix build environment as follows, based on Guix commit christopher@eowyn ~/Build/librecmc-lts$ guix describe Generation 15 Apr 17 2020 07:30:36 (current) guix a7dbd38 repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: a7dbd38859ebb174e5d757645ba80bdc8048bee8 guix environment --pure --ad-hoc gcc-toolchain perl make git coreutils grep sed bash which pkg-config binutils ncurses wget tar patch diffutils unzip bzip2 findutils gawk gengetopt python2 python file util-linux nss-certs gzip Git install is as follows: christopher@eowyn ~/Build/librecmc-lts [env]$ git --version git version 2.26.1 christopher@eowyn ~/Build/librecmc-lts [env]$ which git /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/bin/git christopher@eowyn ~/Build/librecmc-lts [env]$ git --exec-path /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core christopher@eowyn ~/Build/librecmc-lts [env]$ ls /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core/git-submodule /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core/git-submodule PATH environment is as follows: christopher@eowyn ~/Build/librecmc-lts [env]$ env | grep git GIT_EXEC_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core christopher@eowyn ~/Build/librecmc-lts [env]$ env | grep -i path PKG_CONFIG_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib/pkgconfig BASH_LOADABLES_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib/bash GIT_EXEC_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core PYTHONPATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib/python2.7/site-packages LIBRARY_PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/lib GUIX_LOCPATH=/home/christopher/.guix-profile/lib/locale PATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/bin:/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/sbin CPATH=/gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/include First command I run is "make -j1 V=sc menuconfig", which fails on check for git: ''' christopher@eowyn ~/Build/librecmc-lts [env]$ make -j1 V=sc menuconfig Checking 'working-make'... ok. Checking 'case-sensitive-fs'... ok. Checking 'proper-umask'... ok. Checking 'gcc'... ok. <snip> Checking 'python'... ok. Checking 'git'... failed. Checking 'file'... ok. Prerequisite check failed. Use FORCE=1 to override. ''' Using FORCE=1 does seem to bypass that check, but leaves open the question of why the check failed. Check code is hard to understand, from include/prereq-build: ''' $(eval $(call SetupHostCommand,git,Please install Git (git-core) >= 1.7.12.2, \ git --exec-path | xargs -I % -- grep -q -- --recursive %/git-submodule)) ''' christopher@eowyn ~/Build/librecmc-lts [env]$ git --exec-path | xargs -I % -- grep -q -- --recursive %/git-submodule christopher@eowyn ~/Build/librecmc-lts [env]$ echo $? 123 christopher@eowyn ~/Build/librecmc-lts [env]$ git --exec-path /gnu/store/wvaj433hqc2ic2hd34g3g53wqsg5xqzp-profile/libexec/git-core Delete the check from prereq-build.mk also works. Would suggest different check code but not sure how check is suppose to work or what it is aiming to check for exactly.

#125 Broken (?) Git prereq test

christopher@eowyn